[Bug 13646] New: Facets encoding problem with GRS1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13646 Bug ID: 13646 Summary: Facets encoding problem with GRS1 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Searching Assignee: jonathan.druart@biblibre.com Reporter: jonathan.druart@biblibre.com QA Contact: testopia@bugs.koha-community.org Since bug 11944, the facets are not correctly encoded if the indexing mode is GRS1. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13646 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11944 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13646 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13646 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 35634 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35634&action=edit Bug 13646: Fix facets encoding problem for GSR1 Since bug 11944, the facets are not correctly encoded if the indexing mode is GRS1. In MARC::File::USMARC # if utf8 the we encode the string as utf8 if ( $marc->encoding() eq 'UTF-8' ) { $tagdata = marc_to_utf8( $tagdata ); } $marc->encoding return 'MARC8' because the utf8 flag is not set on the marc record. Test plan: On an installation set with GRS1, launch a search and verify you have facets correctly encoded. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13646 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #2 from David Cook <dcook@prosentient.com.au> --- I thought that we'd officially deprecated GRS1 and that it was scheduled for removal? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13646 --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Hello David, I found this bug because we have backported bug 11944 on 3.18.x for a customer. I thought this patch would be useful to someone else, that why I submitted it here. I don't mind if it is not pushed to master, but since it's a fix for bug 11944, it could be helpful to have it, for the record. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13646 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers@biblibre.co | |m --- Comment #4 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- What is the purpose of the line : $mr; ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13646 --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- To assign $mr to $marc_record. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13646 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35634|0 |1 is obsolete| | --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 35880 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35880&action=edit [SIGNED OFF] Bug 13646: Fix facets encoding problem for GSR1 Since bug 11944, the facets are not correctly encoded if the indexing mode is GRS1. In MARC::File::USMARC # if utf8 the we encode the string as utf8 if ( $marc->encoding() eq 'UTF-8' ) { $tagdata = marc_to_utf8( $tagdata ); } $marc->encoding return 'MARC8' because the utf8 flag is not set on the marc record. Test plan: On an installation set with GRS1, launch a search and verify you have facets correctly encoded. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13646 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko@abunchofthings.net --- Comment #7 from Mirko Tietgen <mirko@abunchofthings.net> --- Any reason why this is still listed as »needs signoff«? Tomas: did you just forget to change the status? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13646 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Needs Signoff |Signed Off --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Mirko Tietgen from comment #7)
Any reason why this is still listed as »needs signoff«?
Tomas: did you just forget to change the status?
I did, I'm sorry. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13646 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Signed Off |Failed QA --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Testing this with Jonathan we located another problem with how the links are build - switching this to "Failed QA" waiting for a follow up or new patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13646 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart@biblibre.co |fridolyn.somers@biblibre.co |m |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13646 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Jonathan, is this still needed with the other patches to fix the encoding problems? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13646 Bug 13646 depends on bug 11944, which changed state. Bug 11944 Summary: Cleanup Koha UTF-8 http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org