[Bug 8263] New: Make OPAC stylesheet preferences more consistent
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8263 Priority: P5 - low Change sponsored?: --- Bug ID: 8263 Assignee: m.de.rooy@rijksmuseum.nl Summary: Make OPAC stylesheet preferences more consistent Severity: enhancement Classification: Unclassified OS: All Reporter: m.de.rooy@rijksmuseum.nl Hardware: All Status: ASSIGNED Version: master Component: OPAC Product: Koha opaccolorstylesheet should support remotes, but does not work. opaclayoutstylesheet and opacstylesheet could just be one pref (just as opaccolorstylesheet already advertises) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8263 --- Comment #1 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 10354 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10354&action=edit Patch for 8263 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8263 --- Comment #2 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 10355 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10355&action=edit Database revision for 8263 This patch handles the dbrev for this report. It optionally saves the value of the former opacstylesheet pref into opaclayoutstylesheet. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8263 --- Comment #3 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Test the second (dbrev) patch with: Before applying the patch, put a remote URL in pref opacstylesheet. Apply the patch and run the dbrev (cgi-bin/koha/installer/install.pl?step=3). Check if opaclayoutstylesheet now contains your URL. Test the first (functionality) patch with: 1) Blank opaccolorstylesheet. 2) Put colors.css into opaccolorstylesheet. (By default, this file is empty. But note that it should list now in the opac html page source. Right-click in your browser and find that option in the menu.) 3) Put a full URL (could be your own webserver) starting with http:// into opaccolorstylesheet. Check opac again. 4) Blank opaclayoutstylesheet. Do you have default styles in opac? 5) Put opac.css into opaclayoutstylesheet. No difference? That is expected. 6) Put a full URL into opaclayoutstylesheet. If you have a different stylesheet, put that in with the full http:// prefix. Check your opac. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8263 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8263 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10354|0 |1 is obsolete| | --- Comment #4 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 10379 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10379&action=edit Rebased patch for 8263 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8263 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10355|0 |1 is obsolete| | --- Comment #5 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 10396 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10396&action=edit Rebased dbrev for 8263 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8263 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10396|0 |1 is obsolete| | --- Comment #6 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 10633 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10633&action=edit Rebased dbrev -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8263 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- [% IF (opaclayoutstylesheet.match('^http:|^\/')) %] Should we allow for the possibility of a stylesheet served by https:// ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8263 --- Comment #8 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to comment #7)
Should we allow for the possibility of a stylesheet served by https:// ?
Sure, good point. Will send new version. Thx. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8263 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10379|0 |1 is obsolete| | --- Comment #9 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 10930 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10930&action=edit Patch for 8263 Allows https too for css url. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8263 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10633|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 11035 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11035&action=edit 8263 Make OPAC stylesheet preferences more consistent (dbrev) This patch handles the dbrev for this report. It optionally saves the value of the former opacstylesheet pref into opaclayoutstylesheet. June 21, 2012 & July 4, 2012: Rebased. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8263 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10930|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 11036 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11036&action=edit 8263 Consistent stylesheet prefs This patch makes the use of opaccolorstylesheet and opaclayoutstylesheet more consistent. They may be: 1) just a file name, 2) a complete local path or 3) a full URL starting with http: for a remote css file. This makes the syspref opacstylesheet that was only used for a remote css file obsolete. June 20, 2012 Rebased. July 18, 2012: Regex allows https too (thanks to Owen Leonard). Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8263 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |jonathan.druart@biblibre.co | |m --- Comment #12 from Jonathan Druart <jonathan.druart@biblibre.com> --- Works well It would be great to have the same behaviour for the Intranet systempreference. + Maybe a followup is required to update the description of syspref (support for http AND https) ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8263 --- Comment #13 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to comment #12)
It would be great to have the same behaviour for the Intranet systempreference.
+ Maybe a followup is required to update the description of syspref (support for http AND https) ?
Thanks for signing off on this one. We could start a new report for the Intranet side. Will later send a followup for textual change; I hesitated with adjusting the text because there are much more cases in the pref descriptions where http or https could or should be written. But I already wanted Koha to work with it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8263 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain@biblibre.com Version|master |rel_3_10 QA Contact| |paul.poulain@biblibre.com --- Comment #14 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: * FAUSP leader is happy ;-) * clean code that should gracefully handle existing setups * passes koha-qa.pl -c 2 * grepped opacstylesheet, and I can't see references to this string outside from updatedatabase and translations (it will be removed automatically later, when translation process start) passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8263 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8263 --- Comment #15 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- This report now has its staff client counterpart: bug 10052. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org