http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9115 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Version|unspecified |master Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9115 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 13555 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13555&action=edit Bug 9115 - basket window should close automatically when placing a hold If you choose to place a hold from the Cart pop-up, the entire holds process (possibly including login) takes place in the cart window. Upon completion of the operation you're left with a second window which has lost its context as the Cart. This patch revises the hold process so that when you click the hold link in the cart the operation is moved to the main window and the Cart window closes. Since the holdSel() function doesn't require interaction with template variables I have moved it to basket.js along with the described changes. To test, put items in your Cart and open it. Select items to place on hold and click the "Place hold" link. The cart should close, and the items you selected should appear on the place hold screen in the main window. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9115 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- (In reply to comment #2)

With Chromium version 20.0.1132.47, i am still redirected to the login form, or the holds list if i am already connected, within the cart window.

Talking to Gaetan on IRC we've determined the Firefox problem was a caching problem. I don't have any problem with it in Chrome (or Chromium, or IE, or Opera), so hopefully a follow-up test will confirm. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9115 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13555|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 13585 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13585&action=edit Bug 9115 - basket window should close automatically when placing a hold If you choose to place a hold from the Cart pop-up, the entire holds process (possibly including login) takes place in the cart window. Upon completion of the operation you're left with a second window which has lost its context as the Cart. This patch revises the hold process so that when you click the hold link in the cart the operation is moved to the main window and the Cart window closes. Since the holdSel() function doesn't require interaction with template variables I have moved it to basket.js along with the described changes. To test, put items in your Cart and open it. Select items to place on hold and click the "Place hold" link. The cart should close, and the items you selected should appear on the place hold screen in the main window. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9115 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de QA Contact| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9115 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13585|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 13659 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13659&action=edit [SIGNED-OFF] Bug 9115 - basket window should close automatically when placing a hold If you choose to place a hold from the Cart pop-up, the entire holds process (possibly including login) takes place in the cart window. Upon completion of the operation you're left with a second window which has lost its context as the Cart. This patch revises the hold process so that when you click the hold link in the cart the operation is moved to the main window and the Cart window closes. Since the holdSel() function doesn't require interaction with template variables I have moved it to basket.js along with the described changes. To test, put items in your Cart and open it. Select items to place on hold and click the "Place hold" link. The cart should close, and the items you selected should appear on the place hold screen in the main window. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Checked in Firefox and Chromium in Ubuntu, works nicely. All tests pass. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9115 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.10.x, will be in 3.10.1 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9115 Liz Rea (CatalystIT) <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED CC| |liz@catalyst.net.nz Resolution|--- |FIXED --- Comment #11 from Liz Rea (CatalystIT) <liz@catalyst.net.nz> --- Patches do not apply to 3.6.x, please reopen and submit a patch for 3.6.x if necessary. Thanks! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9115 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.8 |3.6 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9115 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13659|0 |1 is obsolete| | --- Comment #12 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 14003 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14003&action=edit Bug 9115 [3.6.x] basket window should close automatically when placing a hold If you choose to place a hold from the Cart pop-up, the entire holds process (possibly including login) takes place in the cart window. Upon completion of the operation you're left with a second window which has lost its context as the Cart. This patch revises the hold process so that when you click the hold link in the cart the operation is moved to the main window and the Cart window closes. Since the holdSel() function doesn't require interaction with template variables I have moved it to basket.js along with the described changes. To test, put items in your Cart and open it. Select items to place on hold and click the "Place hold" link. The cart should close, and the items you selected should appear on the place hold screen in the main window. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9115 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |paul.poulain@biblibre.com --- Comment #14 from Paul Poulain <paul.poulain@biblibre.com> --- Patch tested with a sandbox, by caroline very-mathieu <caroline.very-mathieu@nimes-ville.fr> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9115 --- Comment #15 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 16260 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16260&action=edit Revert "Merge branch 'bug_9025' into 3.12-master" This reverts commit 081e1ba4c31151db8a3c52a8daa96931a5ac544f, reversing changes made to 7e25faace8d70c2e81272cb3eacd41fa7215719d. Signed-off-by: caroline very-mathieu <caroline.very-mathieu@nimes-ville.fr> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9115 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14003|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9115 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Summary|basket window should close |[3.6.X] basket window |automatically when placing |should close automatically |a hold |when placing a hold -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9115 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14003|0 |1 is obsolete| | --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 17398 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17398&action=edit Bug 9115 [3.6.x] basket window should close automatically when placing a hold If you choose to place a hold from the Cart pop-up, the entire holds process (possibly including login) takes place in the cart window. Upon completion of the operation you're left with a second window which has lost its context as the Cart. This patch revises the hold process so that when you click the hold link in the cart the operation is moved to the main window and the Cart window closes. Since the holdSel() function doesn't require interaction with template variables I have moved it to basket.js along with the described changes. To test, put items in your Cart and open it. Select items to place on hold and click the "Place hold" link. The cart should close, and the items you selected should appear on the place hold screen in the main window. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9115 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #19 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Moving this one to the next queue: Liz, apparently someone wants this in 3.6. -- You are receiving this mail because: You are watching all bug changes.