[Bug 30121] New: Cannot hide non-patron guarantor relationship via BorrowerUnwantedFields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30121 Bug ID: 30121 Summary: Cannot hide non-patron guarantor relationship via BorrowerUnwantedFields Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com The options in the BorrowerUnwantedFields syspref don't include borrowers.relationship, which contains the relationship value for a non-patron guarantor. We should be able to hide this field if desired. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30121 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com, | |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30121 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30121 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 130762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130762&action=edit Bug 30121: Add relationship to borrwers.json This patch addes the realtionship field to borrowers.json and therefore the various borrower related system preferences. - BorrowerUnwantedField - BorrowerMandatoryField - PatronDuplicateMatchingAddFields - PatronQuickAddFields - PatronSelfModificationBorrowerUnwantedField - PatronSelfModificationMandatoryField - PatronSelfRegistrationBorrowerMandatoryField - PatronSelfRegistrationBorrowerUnwantedField To test: 1. Apply patch 2. Test adding and removing the relationship field from the various system preferences listed above, making sure it works correctly for each. Note: I belive for the self registration prefs that contactname, contactfirstname, and relationship should be excluded as choices. If so, I can provide a follow-up to exclude each of them. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30121 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30121 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30121 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130762|0 |1 is obsolete| | --- Comment #2 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 132041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132041&action=edit Bug 30121: Add relationship to borrwers.json This patch addes the realtionship field to borrowers.json and therefore the various borrower related system preferences. - BorrowerUnwantedField - BorrowerMandatoryField - PatronDuplicateMatchingAddFields - PatronQuickAddFields - PatronSelfModificationBorrowerUnwantedField - PatronSelfModificationMandatoryField - PatronSelfRegistrationBorrowerMandatoryField - PatronSelfRegistrationBorrowerUnwantedField To test: 1. Apply patch 2. Test adding and removing the relationship field from the various system preferences listed above, making sure it works correctly for each. Note: I belive for the self registration prefs that contactname, contactfirstname, and relationship should be excluded as choices. If so, I can provide a follow-up to exclude each of them. Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30121 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132041|0 |1 is obsolete| | --- Comment #3 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 132042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132042&action=edit Bug 30121: Add relationship to borrowers.json This patch addes the realtionship field to borrowers.json and therefore the various borrower related system preferences. - BorrowerUnwantedField - BorrowerMandatoryField - PatronDuplicateMatchingAddFields - PatronQuickAddFields - PatronSelfModificationBorrowerUnwantedField - PatronSelfModificationMandatoryField - PatronSelfRegistrationBorrowerMandatoryField - PatronSelfRegistrationBorrowerUnwantedField To test: 1. Apply patch 2. Test adding and removing the relationship field from the various system preferences listed above, making sure it works correctly for each. Note: I belive for the self registration prefs that contactname, contactfirstname, and relationship should be excluded as choices. If so, I can provide a follow-up to exclude each of them. Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30121 Anneli Österman <anneli.osterman@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |anneli.osterman@koha-suomi. | |fi --- Comment #4 from Anneli Österman <anneli.osterman@koha-suomi.fi> --- Relationship option appears in PatronQuickAddFields but unchecking it doesn't work when adding kid or juvenile via Quick add new patron. The Relationship field is still mandatory (required) under the surname field. The relationship filed disappears if I emtpy borrowerRelationship but that is not a good option because then the relationship field disappers from the Patron guarantor also. (Sorry, I didn't know what to choose to the Status) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30121 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30121 --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Anneli Österman from comment #4)
Relationship option appears in PatronQuickAddFields but unchecking it doesn't work when adding kid or juvenile via Quick add new patron. The Relationship field is still mandatory (required) under the surname field.
The relationship filed disappears if I emtpy borrowerRelationship but that is not a good option because then the relationship field disappers from the Patron guarantor also.
(Sorry, I didn't know what to choose to the Status)
Yes, that is a good catch. The field is not called relationship in the quick add field, instead it is called new_guarantor_relationship. So when we check relationship we get two fields new_guarantor_relationship and relationship. I think in this case we want to exclude relation ship for the PatronQuickAddFields pref. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30121 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30121 --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 132378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132378&action=edit Bug 30121: (follow-up) exclude relationship from PatronQuickAddFields -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30121 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #7 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- (In reply to Lucas Gass from comment #5)
(In reply to Anneli Österman from comment #4)
Relationship option appears in PatronQuickAddFields but unchecking it doesn't work when adding kid or juvenile via Quick add new patron. The Relationship field is still mandatory (required) under the surname field.
The relationship filed disappears if I emtpy borrowerRelationship but that is not a good option because then the relationship field disappers from the Patron guarantor also.
(Sorry, I didn't know what to choose to the Status)
Yes, that is a good catch. The field is not called relationship in the quick add field, instead it is called new_guarantor_relationship.
So when we check relationship we get two fields new_guarantor_relationship and relationship.
I think in this case we want to exclude relation ship for the PatronQuickAddFields pref.
I'm still seeing this issue with the follow-up patch applied. "Relationship" shows in the Quick Add fields and is required even though it's not in BorrowerMandatory or PatronQuickAdd system preferences. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30121 --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- This patch must be reworked as the borrowers.json no longer exists in master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30121 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|lucas@bywatersolutions.com |koha-bugs@lists.koha-commun | |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org