[Bug 30437] New: Add an SVG loader to Koha pendingreserves.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30437 Bug ID: 30437 Summary: Add an SVG loader to Koha pendingreserves.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Some pages in Koha can take a long time to load in Koha. One that often can take some time is pendingreserves.pl If a library has a lot of holds this page can take a pretty long time to load and sometimes users don't realize that. It is easy to think the page is broken or not loading properly, causing users to continually click on the pendingreserves.pl link. Clicking over and over again can be problematic as i causes pendingreserves.pl to begin loading again and again. A SVG loader that gives a visual indication that the page is loading/working could help prevent users from clicking the link multiple times while the page is still loading. pendingreserves.pl is one example, so it might be nice to have an SVG loader that can be applied to any link within Koha that takes a long time to load. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30437 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30437 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 132871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132871&action=edit Bug 30437: Add SVG loader to pendingreserves.pl To test: 1. Try to have a bunch of holds in your test system so pendingreserves.pl takes several seconds to load 2. Apply patch 3. Regenerate the staff CSS: https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff... 4. Go to Home > Circulation 5. Click on "Holds to Pull" 6. As the page is loading you should notice some 'Loading page...' text with a spinning SVG loader. 7. Nothing else should change with the functionality of the "Holds to Pull" report This uses a very nice free to use SVG loader from Sam Herbert. https://samherbert.net/svg-loaders/ Credit and link are included in the SVG file -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30437 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30437 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30437 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132871|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 136328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136328&action=edit Bug 30437: Add SVG loader to pendingreserves.pl To test: 1. Try to have a bunch of holds in your test system so pendingreserves.pl takes several seconds to load 2. Apply patch 3. Regenerate the staff CSS: https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff... 4. Go to Home > Circulation 5. Click on "Holds to Pull" 6. As the page is loading you should notice some 'Loading page...' text with a spinning SVG loader. 7. Nothing else should change with the functionality of the "Holds to Pull" report This uses a very nice free to use SVG loader from Sam Herbert. https://samherbert.net/svg-loaders/ Credit and link are included in the SVG file Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30437 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Testing notes (using koha-testing-docker): - Placed about 100 holds by searching for either a and cat, then selecting all and placing about 20 holds at a time for different patrons. - Rebuilding CSS is now a lot easier with KTD: yarn install then yarn build -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30437 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- We do something like this on only two other pages if I recall correctly: The basic and advanced MARC editor pages. Both of them show the loading image after the user has navigated to the page rather than on the page where the user clicked the link. It seems odd to me to use this new technique on only a single page. Is one approach better than the other? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30437 --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Owen Leonard from comment #4)
We do something like this on only two other pages if I recall correctly: The basic and advanced MARC editor pages. Both of them show the loading image after the user has navigated to the page rather than on the page where the user clicked the link.
It seems odd to me to use this new technique on only a single page. Is one approach better than the other?
I am sorry, I should have took some more time to look around for similar functionality already implemented. I will have a look at those pages. At this point I don't know what which method is better but we should only use a single method to do this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30437 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30437 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Lucas Gass from comment #5)
I should have took some more time to look around for similar functionality already implemented
I think it's absolutely worthwhile to look at these two options to have a fresh look at whether we could be doing things better. I'm curious whether there is a usability advantage to one or the other. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30437 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org