[Bug 39775] New: Serials claims table filters aren't working
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39775 Bug ID: 39775 Summary: Serials claims table filters aren't working Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: matt.blenkinsop@openfifth.co.uk QA Contact: testopia@bugs.koha-community.org To reproduce: 1) Navigate to Serials and then Claims (if prompted to create a notice, please do this) 2) If you have no claims listed, return to the serials page and create a new serial (the details of this aren't too important) 3) Return to the serials claims page, try to use one of the filters at the bottom of the table 4) Nothing will happen and the table won't filter -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39775 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |matt.blenkinsop@openfifth.c |ity.org |o.uk -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39775 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |36640 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 [Bug 36640] Upgrade DataTables from 1.13.6 to 2.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39775 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39775 --- Comment #1 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 181666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181666&action=edit Bug 39775: Restore filtering to the serials claims table This patch implements the 'add_filters' argument for kohaTable() to restore filtering to the serials claims table Test plan: 1) Navigate to Serials and then Claims (if prompted to create a notice, please do this) 2) If you have no claims listed, return to the serials page and create a new serial (the details of this aren't too important) 3) Return to the serials claims page, try to use one of the filters at the bottom of the table 4) Nothing will happen and the table won't filter 5) Apply patch 6) Hard refresh the browser 7) The filters will now be at the top of the table and should work -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39775 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39775 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181666|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181668&action=edit Bug 39775: Restore filtering to the serials claims table This patch implements the 'add_filters' argument for kohaTable() to restore filtering to the serials claims table Test plan: 1) Navigate to Serials and then Claims (if prompted to create a notice, please do this) 2) If you have no claims listed, return to the serials page and create a new serial (the details of this aren't too important) 3) Return to the serials claims page, try to use one of the filters at the bottom of the table 4) Nothing will happen and the table won't filter 5) Apply patch 6) Hard refresh the browser 7) The filters will now be at the top of the table and should work Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39775 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181669&action=edit Bug 39775: Remove no-sort def Not needed. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39775 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=39814 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39775 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Keywords| |regression, | |rel_25_05_candidate CC| |jonathan.druart@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39775 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181668|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 181990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181990&action=edit Bug 39775: Restore filtering to the serials claims table This patch implements the 'add_filters' argument for kohaTable() to restore filtering to the serials claims table Test plan: 1) Navigate to Serials and then Claims (if prompted to create a notice, please do this) 2) If you have no claims listed, return to the serials page and create a new serial (the details of this aren't too important) 3) Return to the serials claims page, try to use one of the filters at the bottom of the table 4) Nothing will happen and the table won't filter 5) Apply patch 6) Hard refresh the browser 7) The filters will now be at the top of the table and should work Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39775 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181669|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 181991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181991&action=edit Bug 39775: Remove no-sort def Not needed. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39775 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This restores the table release notes| |filters for serial claims | |search results - they are | |now located at the top of | |the table, and actually | |work. --- Comment #6 from David Nind <david@davidnind.com> --- Adding my sign off, so that Jonathan's can be counted as QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39775 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This restores the table |This restores the table release notes|filters for serial claims |filters for serial claims |search results - they are |search results - they are |now located at the top of |now located at the top of |the table, and actually |the table, and actually |work. |work. This was a | |regression. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39775 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39775 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39775 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39775 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_25_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39775 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=37094 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39775 --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Tried to backport 24.11 but there are a lot of changes, does not work. Maybe Bug 37094 has some impact. If anyone can create a dedicated patch for 24.11.x, this is a bad regression -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39775 --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- How to apply on 24.11.x since it uses dataTable() not kohaTable() ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39775 --- Comment #10 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 188089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188089&action=edit Bug 39775: [24.11] Restore filters -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39775 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable CC| |baptiste.wojtkowski@biblibr | |e.com --- Comment #11 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Backported to 24.11 and pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39775 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.05.00 |25.05.00,24.11.10 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39775 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #12 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Bug appeared with 24.11.00, no need to backport -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39775 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #13 from David Nind <david@davidnind.com> --- Bug fix/regression, no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org