[Bug 30706] New: DateFormat change only takes effect after a restart of searvices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30706 Bug ID: 30706 Summary: DateFormat change only takes effect after a restart of searvices Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org This was found while testing bug 30514. To test: - Edit any patron - Change the date of birth, verify: - Hint: (MM/DD/YYYY) - Adding a date, it displays in this format in the input field - Change Dateformat system prefernce to DD.MM.YYYY - Edit the patron again, Verify: - Hint: (TT.MM.YYYY) - Adding/updating the date it still shows in the previous format - Do a restart_all or equivalent on your test environment - Verify the date now has the correct format when edited A system preference change should take immediate effect. There should be no need to restart anything. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30706 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|DateFormat change only |DateFormat change only |takes effect after a |takes effect after a |restart of searvices |restart of services -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30706 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- There is a bad space there: var dateformat_pref = "[% Koha.Preference('dateformat ') | html %]"; -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30706 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- *** Bug 30711 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30706 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30514 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30514 [Bug 30514] Error in date format check following datepicker removal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30706 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30706 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 134739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134739&action=edit Bug 30706: Fix space in check for dateformat preference This patch fixes the calendar.inc includes in both staff and OPAC in order to remove a typo: An extra space in the check for the "dateformat" system preference. The result of this error is that changes to the dateformat system preference will not be correctly applied to Koha without a restart. To reproduce the problem start the process of creating a new patron. - In the date of birth field, select a date. The format of the date inserted should match your current dateformat system preference. - Go to Administration -> System preferences and update dateformat to something different. - Go back to the patron creation form (refresh it if necessary). - The hint under the Date of birth field will match your updated system preference, but when you pick a date using the calendar widget it will still be formatted according to the old value of dateformat. To test the fix, apply the patch and run through the same steps above. A change the dateformat preference should be immediately reflected in the functionality of the calendar widget. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30706 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30706 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134739|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 134752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134752&action=edit Bug 30706: Fix space in check for dateformat preference This patch fixes the calendar.inc includes in both staff and OPAC in order to remove a typo: An extra space in the check for the "dateformat" system preference. The result of this error is that changes to the dateformat system preference will not be correctly applied to Koha without a restart. To reproduce the problem start the process of creating a new patron. - In the date of birth field, select a date. The format of the date inserted should match your current dateformat system preference. - Go to Administration -> System preferences and update dateformat to something different. - Go back to the patron creation form (refresh it if necessary). - The hint under the Date of birth field will match your updated system preference, but when you pick a date using the calendar widget it will still be formatted according to the old value of dateformat. To test the fix, apply the patch and run through the same steps above. A change the dateformat preference should be immediately reflected in the functionality of the calendar widget. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30706 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134752|0 |1 is obsolete| | --- Comment #5 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 134770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134770&action=edit Bug 30706: Fix space in check for dateformat preference This patch fixes the calendar.inc includes in both staff and OPAC in order to remove a typo: An extra space in the check for the "dateformat" system preference. The result of this error is that changes to the dateformat system preference will not be correctly applied to Koha without a restart. To reproduce the problem start the process of creating a new patron. - In the date of birth field, select a date. The format of the date inserted should match your current dateformat system preference. - Go to Administration -> System preferences and update dateformat to something different. - Go back to the patron creation form (refresh it if necessary). - The hint under the Date of birth field will match your updated system preference, but when you pick a date using the calendar widget it will still be formatted according to the old value of dateformat. To test the fix, apply the patch and run through the same steps above. A change the dateformat preference should be immediately reflected in the functionality of the calendar widget. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30706 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |victor@tuxayo.net --- Comment #6 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Works, qa script happy, code looks good, passing QA :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30706 Mengu Yazicioglu <mengu@devinim.com.tr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mengu@devinim.com.tr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30706 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30706 --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org