https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34859 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |dcook@prosentient.com.au |ity.org | --- Comment #1 from David Cook <dcook@prosentient.com.au> --- I've removed the unnecessary system preference template parameters and I've tidied the code. This script is pretty much the smallest controller you can make in Koha presently. (If we were using Mojolicious like in bug 31380, this script would actually be at most a small function within a greater controller module.) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34859 --- Comment #2 from David Cook <dcook@prosentient.com.au> --- Created attachment 155965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155965&action=edit Bug 34859: Remove unnecessary params from reports-home.pl This change removes unnecessary syspref template parameters and tidies the code. Test plan: 0. Apply the patch and koha-plack --reload kohadev 1. Go to /cgi-bin/koha/admin/preferences.pl?op=search&searchfield=IntranetNav 2. Add the following and save: <li><a href="#">Awesome</a></li> 3. Go to /cgi-bin/koha/admin/preferences.pl?op=search&searchfield=intranetstylesheet 4. Add the following and save: http://bad 5. Go to /cgi-bin/koha/admin/preferences.pl?op=search&searchfield=intranetcolorstylesheet 6. Add the following and save: http://bad2 7. Go to /cgi-bin/koha/reports/reports-home.pl 8. Note the "Awesome" link in the top navbar 9. Note in the console that there are two errors where http://bad and http://bad2 can't be resolved -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34859 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155965|0 |1 is obsolete| | --- Comment #3 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 156238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156238&action=edit Bug 34859: Remove unnecessary params from reports-home.pl This change removes unnecessary syspref template parameters and tidies the code. Test plan: 0. Apply the patch and koha-plack --reload kohadev 1. Go to /cgi-bin/koha/admin/preferences.pl?op=search&searchfield=IntranetNav 2. Add the following and save: <li><a href="#">Awesome</a></li> 3. Go to /cgi-bin/koha/admin/preferences.pl?op=search&searchfield=intranetstylesheet 4. Add the following and save: http://bad 5. Go to /cgi-bin/koha/admin/preferences.pl?op=search&searchfield=intranetcolorstylesheet 6. Add the following and save: http://bad2 7. Go to /cgi-bin/koha/reports/reports-home.pl 8. Note the "Awesome" link in the top navbar 9. Note in the console that there are two errors where http://bad and http://bad2 can't be resolved Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34859 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156238|0 |1 is obsolete| | --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 156284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156284&action=edit Bug 34859: Remove unnecessary params from reports-home.pl This change removes unnecessary syspref template parameters and tidies the code. Test plan: 0. Apply the patch and koha-plack --reload kohadev 1. Go to /cgi-bin/koha/admin/preferences.pl?op=search&searchfield=IntranetNav 2. Add the following and save: <li><a href="#">Awesome</a></li> 3. Go to /cgi-bin/koha/admin/preferences.pl?op=search&searchfield=intranetstylesheet 4. Add the following and save: http://bad 5. Go to /cgi-bin/koha/admin/preferences.pl?op=search&searchfield=intranetcolorstylesheet 6. Add the following and save: http://bad2 7. Go to /cgi-bin/koha/reports/reports-home.pl 8. Note the "Awesome" link in the top navbar 9. Note in the console that there are two errors where http://bad and http://bad2 can't be resolved Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34859 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34859 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.11.00,23.05.05 |23.11.00,23.05.05,22.11.11 released in| | -- You are receiving this mail because: You are watching all bug changes.