https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34833 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34833 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155911|0 |1 is obsolete| | --- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 155914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155914&action=edit Bug 34833: Make "order number" in acq modal translatable The 'order number' was not translatable when editing the estimated delivery date or notes from basket summary or when editing the estimated delivery date from late orders. To get there: 0. Make sure you have budgets and vendors set up 1. Create a basket (skip this if you already have an open basket) 1.1. Go to acquisitions 1.2. Search for a vendor 1.3. Click New > basket 1.4. Enter a name for the basket 1.5. To make the tests easier, choose to create items when : cataloging the record 1.6. Click save 2. Add an order 2.1. Click add to basket > From a new (empty) record 2.2. Fill out the form, minimally - Enter a title - Enter a quantity - Choose a fund - Enter a vendor price 2.3. Click Save 3. Next to the order line, click Edit under Estimated delivery date 4. Verify that the 'order number <ordernumber>' shows on top of the modal 5. Edit internal/vendor note, verify it shows there as well 6. Close basket 7. Go to late orders 8. Edit estimated delivery date, text should show there as well 9. Apply patch 10. Run translation update script 11. Verify the string now appears in po files 12. Translate it 13. Install translation 14. Verify it shows nicely translated in all 3 mentioned spots Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34833 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155914|0 |1 is obsolete| | --- Comment #3 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 156143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156143&action=edit Bug 34833: Make "order number" in acq modal translatable The 'order number' was not translatable when editing the estimated delivery date or notes from basket summary or when editing the estimated delivery date from late orders. To get there: 0. Make sure you have budgets and vendors set up 1. Create a basket (skip this if you already have an open basket) 1.1. Go to acquisitions 1.2. Search for a vendor 1.3. Click New > basket 1.4. Enter a name for the basket 1.5. To make the tests easier, choose to create items when : cataloging the record 1.6. Click save 2. Add an order 2.1. Click add to basket > From a new (empty) record 2.2. Fill out the form, minimally - Enter a title - Enter a quantity - Choose a fund - Enter a vendor price 2.3. Click Save 3. Next to the order line, click Edit under Estimated delivery date 4. Verify that the 'order number <ordernumber>' shows on top of the modal 5. Edit internal/vendor note, verify it shows there as well 6. Close basket 7. Go to late orders 8. Edit estimated delivery date, text should show there as well 9. Apply patch 10. Run translation update script 11. Verify the string now appears in po files 12. Translate it 13. Install translation 14. Verify it shows nicely translated in all 3 mentioned spots Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34833 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Status|Signed Off |Failed QA QA Contact|testopia@bugs.koha-communit |victor@tuxayo.net |y.org | --- Comment #5 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Everything looks good I'm just suspicious about the space at the start there: « (order number» The concatenation to make $modalTitle already adds one space. So the HTML ends up with two. It seems to come from this change: https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139839&action=diff Which didn't have two steps to make the string so the space before «(order number» was necessary. I tried without the additional space on the 3 places of this ticket and rendering looks good and HTML has only one space. Proposal follow-up attached. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34833 --- Comment #7 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I tried before and after the follow-up and did not see a difference in the interface. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34833 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Caroline Cyr La Rose from comment #8)

to be precise, I meant that I only saw one space before the parenthesis (I checked by highlighting the text), with and without the follow-up patch...

Maybe I'm misunderstanding what is being discussed...

I think the browser collapses 2 into 1, but it's cleaner not to add them twice and the space at the beginning of a string might be problematic for translations too. I don't think this needs to be Failed QA? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34833 --- Comment #11 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 156193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156193&action=edit Bug 34833: (follow-up): remove redundant spaces -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34833 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #12 from Victor Grousset/tuxayo <victor@tuxayo.net> --- (In reply to Katrin Fischer from comment #6)

You are right about the follow-up. I did intend to "move" the space outside of translations, but forgot to remove it from the string.

Good, I just needed a confirmation about this then, Works, makes sense, QA script happy, code looks good, passing QA :) --- (In reply to Katrin Fischer from comment #9)

I think the browser collapses 2 into 1

It indeed looks like that :)

I don't think this needs to be Failed QA?

At first I was really not sure to have really found a mistake with the space thing. Hence the "maybe follow-up" and didn't know which status to use. Then I saw it seemed to come from Bug 15348 and got almost sure it was a mistake so Failed QA seemed to fit enough. But still needed a confirmation. Maybe "in discussion" fit better? --- (In reply to Caroline Cyr La Rose from comment #10)

I think Victor maybe wanted some feedback on the follow-up since it's called "MAYBE FOLLOW UP ..."

Yeah, either case it would have been able to move on after settling the space question.

Which is why I tried to test it with and without the follow up patch. I don't see any difference in the .po file either.

Thanks for retesting.

If it's only a clean code thing, it's fine since it doesn't change the behaviour. If it's meant to change the string, it's (maybe?) not working.

In either case, the translatable string was without a leading space. Nice that it can avoid duplication of strings :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34833 --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34833 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.11.00,23.05.05 |23.11.00,23.05.05,22.11.11 released in| | -- You are receiving this mail because: You are watching all bug changes.