[Bug 25136] New: PatronSelfRegistrationLibraryList controls both self-reg and self-modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25136 Bug ID: 25136 Summary: PatronSelfRegistrationLibraryList controls both self-reg and self-modification Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org The syspref PatronSelfRegistrationLibraryList describes itself as being about self-registration, but also limits the libraries available for patron self-modification. This presents a problem for libraries that want to corral their self-reg patrons into one library but allow full patrons to move between libraries. I've only confirmed this on 19.05. Master is currently doing something else weird on this syspref, which I'll file a bug for separately. This is part of a larger muddling of selfreg and selfmod that it'd be helpful to get untangled. See also bug 13188 for separating out the mandatory fields for the two pages. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25136 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25136 --- Comment #1 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Bug around this syspref in master: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25137 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25136 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25136 --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 103042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103042&action=edit Bug 25136: Make PatronSelfRegistrationLibraryList only effect new registration This patch makes it so PatronSelfRegistrationLibraryList will only effect the registration from and not the modification form. TO TEST: 1. Turn on self reg and add some libaries to PatronSelfRegistrationLibraryList. 2. Notice that the libaries that display in the borrower_branchcode dropdown are the ones you selected on both the new registration from and the modification form. 3. Apply patch. 4. Now only the new registration from should show libaries on PatronSelfRegistrationLibraryList. 5. The modifciation dropdown should still show all libraries. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25136 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25136 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |25137 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25137 [Bug 25137] PatronSelfRegistrationLibraryList results in empty branch list on opac-memberentry.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25136 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25136 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103042|0 |1 is obsolete| | --- Comment #3 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 103056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103056&action=edit Bug 25136: Make PatronSelfRegistrationLibraryList only effect new registration This patch makes it so PatronSelfRegistrationLibraryList will only effect the registration from and not the modification form. TO TEST: 1. Turn on self reg and add some libaries to PatronSelfRegistrationLibraryList. 2. Notice that the libaries that display in the borrower_branchcode dropdown are the ones you selected on both the new registration from and the modification form. 3. Apply patch. 4. Now only the new registration from should show libaries on PatronSelfRegistrationLibraryList. 5. The modifciation dropdown should still show all libraries. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25136 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25136 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103056|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 103066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103066&action=edit Bug 25136: Make PatronSelfRegistrationLibraryList only effect new registration This patch makes it so PatronSelfRegistrationLibraryList will only effect the registration from and not the modification form. TO TEST: 1. Turn on self reg and add some libaries to PatronSelfRegistrationLibraryList. 2. Notice that the libaries that display in the borrower_branchcode dropdown are the ones you selected on both the new registration from and the modification form. 3. Apply patch. 4. Now only the new registration from should show libaries on PatronSelfRegistrationLibraryList. 5. The modifciation dropdown should still show all libraries. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25136 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 103067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103067&action=edit Bug 25136: join the 2 ifs Highlight that we only need this for action="new" Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25136 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25136 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25136 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com --- Comment #7 from Joy Nelson <joy@bywatersolutions.com> --- missing dependencies - not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org