[Bug 33237] New: If TranslateNotices is off, use the interface language includes in slips
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 Bug ID: 33237 Summary: If TranslateNotices is off, use the interface language includes in slips Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr Most of our clients use Koha in one language only (French) and their patrons are also all french-speakers. So they don't use TranslateNotices, since they don't need to print slips in different languages. However, if TranslateNotices is off, the translations for "includes" (in my specific example, account types), are not taken into consideration and print in English. Same if TranslateNotices is on, but the patron's language is Default. In those cases, shouldn't it use the interface language rather than just print in English? To replicate: 1. Install the other language (i used fr-CA here) 1.1. gulp po:update fr-CA ./misc/translator/translate install fr-CA 1.2. In Administration > Global system preferences, search for language and check the added language 2. Create a manual invoice in a patron's account and pay it 3. From the Transactions tab, click 'Print' next to the payment line --> On the printed slip, the title is "Payment receipt" (OK) 4. Switch interface to other language 5. Redo step 3 --> On the printed slip, the title is still "Payment receipt" (not ok) 6. In Administration > Global system preferences, enable TranslateNotices 7. Go to Tools > Notices and slips > ACCOUNT_CREDIT and copy the content of the letter into all the languages 8. Redo step 3 (you should still be in the other language interface) --> On the printed slip, the title is still "Payment receipt" (not ok?) 9. Edit the patron's account and change the preferred language to the other language 10. Redo step 3 --> On the printed slip, the title is "Paiement receipt" (OK) On step 3, the account type is in English in the English interface (OK) On step 5, the account type is in English in the other interface, with TranslateNotices off, I feel like the slip should take the interface into account in this case for the include... On step 8, TranslateNotices is on, but the patron's language is Default, I feel like this should also take into account the interface language... On step 10, TranslateNotices is on and patron language is set, these are currently the only settings which allow to have the accounttypes in the other language. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I consider this a bug (especially the one where TranslateNotices is off). If I'm the outlier, then I'd like to propose that we add a default language choice in the patron categories (like we do for messaging preferences) so that we don't have to change the preferred language for each and every new patron. Since "default" is basically "English", unilingual non-english libraries absolutely need to change the patron's preferred language, they can't leave it at default. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 --- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Martin pointed me to the following lines that should be edited https://git.koha-community.org/Koha-community/Koha/src/branch/master/C4/Lett... and https://git.koha-community.org/Koha-community/Koha/src/branch/master/C4/Lett... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, I think the interface language is the best we could do in these cases and should work for our libraries as well. Our OPACs are usually at least English and German, but notices are often German only. The current behavior would therefore give us some trouble, but interface language should work ok. Another alternative might be to use the "first" language in the language selection as default for these cases. You can reorder them and the first in the list is, I think, also the fallback in other cases. So that might also work. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 --- Comment #4 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- So if TranslateNotices is off, use interface language if TranslateNotices is on, use first language as "default" Would that be ok? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 --- Comment #5 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- --> check patron's preferred language --> if patron's preferred language is "default", check interface language --> if no interface (for overdue_notices for example), check first language in "language" system preference No need to check for TranslateNotices since borrowers.lang is always filled no matter what. If the pref is off, all the patrons' preferred languages will be "default". Note that this bug is not for the notice templates. This already works well. It's only for the "includes" included in the templates. In my example, I used ACCOUNT_CREDIT template which uses accounts.inc to print the credit or debit account type. These are all translated in koha-tmpl/intranet-tmpl/prog/{lang}/includes/accounts.inc but only the english file is used in the slips, making all accounttypes (payment, lost item, manual fee, etc.) print in english no matter the language of the template. I added a screenshot of ACCOUNT_CREDIT with the parts that are currently not translated unless TranslateNotices is on and the patron has the correct preferred language in yellow. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 --- Comment #6 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 148281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148281&action=edit Screenshot of ACCOUNT_CREDIT with untranslated parts in yellow -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |hammat.wele@inlibro.com |ity.org | CC| |hammat.wele@inlibro.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 --- Comment #7 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 148785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148785&action=edit Bug 33237: If TranslateNotices is off, use the interface language includes in slips This patch set the language used in slips folloinw this logic: --> uses patron's preferred language --> if patron's preferred language is 'default', use the interface language --> if there is no interface (for overdue_notices for example), use the first language in 'language' system preference To Test: 1. Install the other language (i used fr-CA here) 1.1. gulp po:update fr-CA ./misc/translator/translate install fr-CA 1.2. In Administration > Global system preferences, search for language and check the added language 2. Create a manual invoice in a patron's account and pay it 3. From the Transactions tab, click 'Print' next to the payment line --> On the printed slip, there's the word 'Payment' in English (OK) 4. Switch interface to other language 5. Redo step 3 --> On the printed slip, the word 'Payment' is still in English (not ok) 6. In Administration > Global system preferences, enable TranslateNotices 7. Go to Tools > Notices and slips > ACCOUNT_CREDIT and copy the content of the letter into all the languages 8. Redo step 3 (you should still be in the other language interface) --> On the printed slip, the word 'Payment' is still in English (not ok) 9. Edit the patron's account and change the preferred language to the other language 10. Redo step 3 --> On the printed slip, the word 'Payment' is in the other language (Paiement) (OK) 11. Apply the patch 12. Reset config 12.1. Edit the patron's account and change back the preferred language to 'default' 12.2. In Administration > Global system preferences, disable TranslateNotices 13. Redo step 3 (you should still be in the other language interface) --> On the printed slip, the word 'Payment' is in the other language (Paiement) 14. Switch interface to the english language 15. Redo step 3 --> On the printed slip, the word 'Payment' is in English 16. In Administration > Global system preferences, enable TranslateNotices 17. Edit the patron's account and change the preferred language to the other language 18. Redo step 3 --> On the printed slip, the word 'Payment' is in the other language (Paiement) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |christian.stelzenmueller@bs | |z-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philippe.blouin@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Sorry, can we get some unit tests here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148785|0 |1 is obsolete| | --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 163952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163952&action=edit Bug 33237: If TranslateNotices is off, use the interface language includes in slips This patch set the language used in slips folloinw this logic: --> uses patron's preferred language --> if patron's preferred language is 'default', use the interface language --> if there is no interface (for overdue_notices for example), use the first language in 'language' system preference To Test: 1. Install the other language (i used fr-CA here) 1.1. gulp po:update fr-CA ./misc/translator/translate install fr-CA 1.2. In Administration > Global system preferences, search for language and check the added language 2. Create a manual invoice in a patron's account and pay it 3. From the Transactions tab, click 'Print' next to the payment line --> On the printed slip, there's the word 'Payment' in English (OK) 4. Switch interface to other language 5. Redo step 3 --> On the printed slip, the word 'Payment' is still in English (not ok) 6. In Administration > Global system preferences, enable TranslateNotices 7. Go to Tools > Notices and slips > ACCOUNT_CREDIT and copy the content of the letter into all the languages 8. Redo step 3 (you should still be in the other language interface) --> On the printed slip, the word 'Payment' is still in English (not ok) 9. Edit the patron's account and change the preferred language to the other language 10. Redo step 3 --> On the printed slip, the word 'Payment' is in the other language (Paiement) (OK) 11. Apply the patch 12. Reset config 12.1. Edit the patron's account and change back the preferred language to 'default' 12.2. In Administration > Global system preferences, disable TranslateNotices 13. Redo step 3 (you should still be in the other language interface) --> On the printed slip, the word 'Payment' is in the other language (Paiement) 14. Switch interface to the english language 15. Redo step 3 --> On the printed slip, the word 'Payment' is in English 16. In Administration > Global system preferences, enable TranslateNotices 17. Edit the patron's account and change the preferred language to the other language 18. Redo step 3 --> On the printed slip, the word 'Payment' is in the other language (Paiement) Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 163953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163953&action=edit Bug 33237: (follow-up) Tidy Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Martin Renvoize from comment #8)
Sorry, can we get some unit tests here.
Signed off as test plan works, but Martin is correct, unit tests would be useful -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 --- Comment #12 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 164521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164521&action=edit Bug 33237: (follow-up) Unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for adding the unit test Hammut... but I'm afraid I can't seem to get it to pass on ktd.. I'll investigate a little but I have a feeling it's got something to do with installed languages in that environment.. we don't install any by default but this would require we do.. or at least we install the translated notice for those particular test cases. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com --- Comment #14 from Jonathan Druart <jonathan.druart@gmail.com> --- Yes, I would move this logic in a dedicated subroutine. It will isolate it and make it easier to test ("sub effective_language_for_notices"?) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 --- Comment #15 from Jonathan Druart <jonathan.druart@gmail.com> --- my $lang = 'en'; This is also not needed and confusing as you are actually removing the fallback to "en". I would re-add it, after the if/else block, add `$lang //= 'en';` -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- OK, now that I've dug through the test I'm a lot less sure this bug makes sense. You are setting the language to low down in my opinion.. we should be setting it from GetPreparedLetter.. otherwise you're going to end up with mixed language notices aren't you? Surely it's about picking the right notice template in the first place rather than just the processing step... in the current iteration you could end up with an English notice with includes that come out in french.. that feels strange to me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Right... I see.. it's about what 'default' means.. right? Either way, we need a clear and correct test and that's not the case here as it stands. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165382&action=edit Bug 33237: TMP Fix for Budget test failing in main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165383&action=edit Bug 33237: (follow-up) Restore final fallback This restores the final fallback to 'en' as mentioned by Jonathan -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165384&action=edit Bug 33237: (QA follow-up) Clarify tests This patch tries to clarify the tests a little and expand their coverage. I've added notes where I think we still need a little work, especially in regards to having them pass in the jenkins runs as we don't have translations installed there and thus at the moment the tests will fail without manual intervention to install the translated includes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 --- Comment #21 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- My conclusion here is that we shouldn't be using interface language at all.. we can't reliably tell that 'interface' and 'default' are written in matching languages. I think we have to assume that 'default' matches 'first in list of translated languages'. I think we should be doing the language code manipulation inside GetPreparredLetter and passing that along to the tt processor for includes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165382|0 |1 is obsolete| | --- Comment #22 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165404&action=edit Bug 33237: TMP Fix for Budget test failing in main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165383|0 |1 is obsolete| | --- Comment #23 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165405&action=edit Bug 33237: (follow-up) Restore final fallback This restores the final fallback to 'en' as mentioned by Jonathan -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 --- Comment #24 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165406&action=edit Bug 33237: (QA follow-up) Clarify tests and Mock This patch tries to clarify the tests a little and expand their coverage whilst also adding some defualt translated includes to the test area and mocking the config to allow the tests to run without installing translations. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165384|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 --- Comment #25 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Right.. we can drop the TMP fix patch once those have been corrected upstream in main. I also think the Restore final fallback isn't really required but I did it whilst I was in here as Jonathan mentioned it. The final patch is the important one as it brings us a step closer to the end goal by getting the tests working without having to manually install a translation. However, I'm now strongly of the opinion we should not be doing the interface level check and instead use the highest priority language in the system preferences as the 'default'. My understanding of how 'default' is used is that the 'default' notice is generally written in the primary language of the system and so it would match the top pick for interface language selection and possible not match the selected interface language of the moment. Use cases: 1) US English only. Default == English + Includes should be English 2) Single translation only (French Canadian). Default == French Canadian + Includes should also be French Canadian. 3) Multiple languages. Default template written in French Canadian, the Include should also use French Canadian (even if the staff user clicking to print has switched to Italian) otherwise we have the main notice in French Candian with the Include parts in Itelian. Right now. case 3 fails. I also think we could re-arrange the tests a bit to clean up.. I think we could/should be testing Template selection _+ include selection in the same places.. i.e each time we check the 'title' we would also check the 'content' to ensure they match consistently.. rather than the current check of template selection followed by a section for include selection checking. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 --- Comment #26 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Can I get some real-life users to comment on my thoughts regarding point three in the above comment -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de, | |laurence.rault@biblibre.com | |, michaela.sieber@kit.edu, | |philip.orr@lmscloud.de --- Comment #27 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I CC'd a couple of people who I know use/support Koha in other languages. I will also send an email to the French mailing list to get their opinions. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165404|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 --- Comment #28 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- For bonus points I'm tempted to display a 'Expected language' field for the default notices in the editor to show the output of the highest priority language when more than one is installed. This clarifying to staff what language we're expecting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 --- Comment #29 from Philip Orr <philip.orr@lmscloud.de> ---
From my experience with German public libraries, the user would assume the 'Default' contents of a notice will be written in German. TBH our libraries generally haven't been using TranslateNotices, maybe my feedback is not so important. :) But if they were to activate the syspref, I would expect the 'default' template (for instance for overdues) to be in German and the includes to be in German as well. Martin, for your case 3 I agree with you. The used language for includes and for the 'default' notice content should match. But a display of 'effective language' would really be the best thing for the user as you said. Or: add a checkbox to syspref "Languages" for "Default language for notices". :)
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163952|0 |1 is obsolete| | --- Comment #30 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165455&action=edit Bug 33237: If TranslateNotices is off, use the interface language includes in slips This patch set the language used in slips folloinw this logic: --> uses patron's preferred language --> if patron's preferred language is 'default', use the interface language --> if there is no interface (for overdue_notices for example), use the first language in 'language' system preference To Test: 1. Install the other language (i used fr-CA here) 1.1. gulp po:update fr-CA ./misc/translator/translate install fr-CA 1.2. In Administration > Global system preferences, search for language and check the added language 2. Create a manual invoice in a patron's account and pay it 3. From the Transactions tab, click 'Print' next to the payment line --> On the printed slip, there's the word 'Payment' in English (OK) 4. Switch interface to other language 5. Redo step 3 --> On the printed slip, the word 'Payment' is still in English (not ok) 6. In Administration > Global system preferences, enable TranslateNotices 7. Go to Tools > Notices and slips > ACCOUNT_CREDIT and copy the content of the letter into all the languages 8. Redo step 3 (you should still be in the other language interface) --> On the printed slip, the word 'Payment' is still in English (not ok) 9. Edit the patron's account and change the preferred language to the other language 10. Redo step 3 --> On the printed slip, the word 'Payment' is in the other language (Paiement) (OK) 11. Apply the patch 12. Reset config 12.1. Edit the patron's account and change back the preferred language to 'default' 12.2. In Administration > Global system preferences, disable TranslateNotices 13. Redo step 3 (you should still be in the other language interface) --> On the printed slip, the word 'Payment' is in the other language (Paiement) 14. Switch interface to the english language 15. Redo step 3 --> On the printed slip, the word 'Payment' is in English 16. In Administration > Global system preferences, enable TranslateNotices 17. Edit the patron's account and change the preferred language to the other language 18. Redo step 3 --> On the printed slip, the word 'Payment' is in the other language (Paiement) Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163953|0 |1 is obsolete| | --- Comment #31 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165456&action=edit Bug 33237: (follow-up) Tidy Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164521|0 |1 is obsolete| | --- Comment #32 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165457&action=edit Bug 33237: (follow-up) Unit tests Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165405|0 |1 is obsolete| | --- Comment #33 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165458&action=edit Bug 33237: (follow-up) Restore final fallback This restores the final fallback to 'en' as mentioned by Jonathan -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165406|0 |1 is obsolete| | --- Comment #34 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165459&action=edit Bug 33237: (QA follow-up) Clarify tests and Mock This patch tries to clarify the tests a little and expand their coverage whilst also adding some defualt translated includes to the test area and mocking the config to allow the tests to run without installing translations. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 --- Comment #35 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165460&action=edit Bug 33237: Add display of which language default language is expected This patch adds the display of 'Default language' to the 'Default' language in the notices editor tool. This is so that librarians know which language they are expected to be writing the notice in so we can remain consistent in both template and include language used. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 --- Comment #36 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I've added the display of which language the system is expecting the default to be written in to allow consistency between template and include language. I still think point three is valid and would like to tidy up the tests and remove the interface clause. However, Magnus raised that perhaps these 'Default' templates may actually be deliberately bilingual.. in which case these patches will cause even more confusion and harm when using INCLUDES. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165455|0 |1 is obsolete| | --- Comment #37 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165473&action=edit Bug 33237: If TranslateNotices is off, use the interface language includes in slips This patch set the language used in slips folloinw this logic: --> uses patron's preferred language --> if patron's preferred language is 'default', use the interface language --> if there is no interface (for overdue_notices for example), use the first language in 'language' system preference To Test: 1. Install the other language (i used fr-CA here) 1.1. gulp po:update fr-CA ./misc/translator/translate install fr-CA 1.2. In Administration > Global system preferences, search for language and check the added language 2. Create a manual invoice in a patron's account and pay it 3. From the Transactions tab, click 'Print' next to the payment line --> On the printed slip, there's the word 'Payment' in English (OK) 4. Switch interface to other language 5. Redo step 3 --> On the printed slip, the word 'Payment' is still in English (not ok) 6. In Administration > Global system preferences, enable TranslateNotices 7. Go to Tools > Notices and slips > ACCOUNT_CREDIT and copy the content of the letter into all the languages 8. Redo step 3 (you should still be in the other language interface) --> On the printed slip, the word 'Payment' is still in English (not ok) 9. Edit the patron's account and change the preferred language to the other language 10. Redo step 3 --> On the printed slip, the word 'Payment' is in the other language (Paiement) (OK) 11. Apply the patch 12. Reset config 12.1. Edit the patron's account and change back the preferred language to 'default' 12.2. In Administration > Global system preferences, disable TranslateNotices 13. Redo step 3 (you should still be in the other language interface) --> On the printed slip, the word 'Payment' is in the other language (Paiement) 14. Switch interface to the english language 15. Redo step 3 --> On the printed slip, the word 'Payment' is in English 16. In Administration > Global system preferences, enable TranslateNotices 17. Edit the patron's account and change the preferred language to the other language 18. Redo step 3 --> On the printed slip, the word 'Payment' is in the other language (Paiement) Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165456|0 |1 is obsolete| | --- Comment #38 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165474&action=edit Bug 33237: (follow-up) Tidy Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165457|0 |1 is obsolete| | --- Comment #39 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165475&action=edit Bug 33237: (follow-up) Unit tests Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165458|0 |1 is obsolete| | --- Comment #40 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165476&action=edit Bug 33237: (follow-up) Restore final fallback This restores the final fallback to 'en' as mentioned by Jonathan Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165459|0 |1 is obsolete| | --- Comment #41 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165477&action=edit Bug 33237: (QA follow-up) Clarify tests and Mock This patch tries to clarify the tests a little and expand their coverage whilst also adding some defualt translated includes to the test area and mocking the config to allow the tests to run without installing translations. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165460|0 |1 is obsolete| | --- Comment #42 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165478&action=edit Bug 33237: Add display of which language default language is expected This patch adds the display of 'Default language' to the 'Default' language in the notices editor tool. This is so that librarians know which language they are expected to be writing the notice in so we can remain consistent in both template and include language used. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 --- Comment #43 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165479&action=edit Bug 33237: Rearrange unit tests and ensure consistency This patch re-arranges the unit tests and sets them to ensure we consistently return the notice and notice includes in the same language. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 --- Comment #44 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165480&action=edit Bug 33237: Move and simplify langauge selection logic This patch moves the language selection into GetPreparedLetter, drops the interface check step and ensures the default template always uses the default include language as per the OPACLanguages settings. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #45 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I'm comfortable with this all now.. we have: * Strong test coverage and don't require installation of translations * Consistent behaviour across use cases - 'Default' = 'Top priority OPACLanguage' regardless of the interface used to trigger the notice or whether it's a fallback to the default notice because a localised version doesn't exist or TranslateNotices is disabled. * Display of which language the default notice is expected to be written in. Unit tests pass, QA scripts are happy and discussions have all reached conclusion on Mattermost and here. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|If TranslateNotices is off, |If TranslateNotices is off, |use the interface language |us the default language |includes in slips |includes in slips -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 --- Comment #46 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I just wanted to ponder the change a bit since we had also had some trouble here. I will be back for this soon! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed, | |release-notes-needed --- Comment #47 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch made quite a u-turn from "use the interface language" in the second patch to dropping it totally out of the equation. As we don't have an adjusted test plan - could you please explain/summarize the behavior in the release notes? Some thoughts on this for (much?) later: * We now rely on the language sequence being changed. This sequence defined, if I am not mistaken, which is the fallback language for missing templates, the display order, ... and? It might be worth adding a note/documentation about this to the system preference description at least. We never changed these settings, we will have to start doing so now. * With the move from "hardcoded" notice templates to the nice configurable notices we had a slight regression for some libraries: Until then it was possible to print the slip in any installed language by switching the staff interface language. Now this no longer works. We rely on the settings in the patron record or the default sequence. It makes sense, but it's a change and there is no way to "simulate" the old behavior. Maybe it would be nice to have another way of selecting the language for printing something in from the GUI. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 --- Comment #48 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36732 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36732 [Bug 36732] Add detail to the language selection system preferences to highlight the important of ordering -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36733 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36733 [Bug 36733] It would be good to have a 'Print/Message in language' option in the UI -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 --- Comment #49 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Follow-up bugs reported and linked to this one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 --- Comment #50 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Martin Renvoize from comment #49)
Follow-up bugs reported and linked to this one.
Thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #51 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- + t::lib::Mocks::mock_config( 'intrahtdocs', '/kohadevbox/koha/t/mock_templates/intranet-tmpl' ); This should not have passed QA. Hardcoded kohadevbox paths. Will submit follow-up. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 --- Comment #52 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 166860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166860&action=edit Bug 33237: (QA follow-up) Remove hardcoded kohadevbox path Test plan: Run Letters.t (outside kohadevbox :) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36520 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 --- Comment #53 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Picked QA follow-up for main. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 --- Comment #54 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #55 from Fridolin Somers <fridolin.somers@biblibre.com> --- Not backported to 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch set cleans up release notes| |the way languages are | |chosen and used in includes | |when printing slips. | |Previously, if the system | |preference | |'TranslateNotices' was | |turned off (meaning the | |patron had their language | |set to 'Default'), the | |includes texts would be in | |English, even if the | |library had written their | |notices in a different | |language e.g. French. | | | |With | |this patch set, the | |language used for includes | |will always match the | |language used for creating | |the notice itself, | |regardless of whether | |'TranslateNotices' is | |turned on or off. | | | |This | |patch set also makes | |important changes to the | |logic used to set the | |language. With this patch, | |the notice will: | |1. use | |patron's preferred language | |2. if patron's preferred | |language is 'default', use | |the first language in | |'language' system | |preference. | | | |This patch set | |also adds the display of | |'Default language' to the | |language that will be | |marked as 'Default' in the | |notices editor tool so that | |the librarian writing a | |notice will know exactly | |which language will be used | |when printing slips. | | | |Please note that due to | |these changes it is no | |longer possible to print | |the slip in any installed | |language simply by | |switching the staff | |interface language before | |printing! Bug 36733 has | |been added as a follow-up | |for restoring this | |functionality. Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|If TranslateNotices is off, |If TranslateNotices is off, |us the default language |use the default language |includes in slips |includes in slips -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed |rel_23_11_candidate --- Comment #56 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Can we have a backport for this please? I know that 22.11 is affected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 --- Comment #57 from Fridolin Somers <fridolin.somers@biblibre.com> --- OK I have a look -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00 |24.05.00,23.11.07 released in| | Status|Pushed to main |Pushed to stable --- Comment #58 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.07 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36815 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36815 [Bug 36815] Add the option to 'Reset to default' in the notices editor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #59 from wainuiwitikapark@catalyst.net.nz --- not backporting to 23.05.x unless requested -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #60 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 unless requested -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org