https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |aleisha@catalyst.net.nz |ity.org | Depends on| |19532 Change sponsored?|--- |Sponsored Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 [Bug 19532] Recalls for Koha -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 --- Comment #2 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 139443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139443&action=edit Issue 1: Implement RecallsInterface on OPAC (cherry picked from commit 75eb449b369255c3288bdc55ed274e38bf29c5c2) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 --- Comment #4 from Aleisha Amohia <aleisha@catalyst.net.nz> --- This is a work in progress and is not ready for testing -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 --- Comment #7 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 139643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139643&action=edit Bug 31391: Recalled authorised value for hold cancellation -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 --- Comment #9 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 139645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139645&action=edit Bug 31391: Request recalls and convert reserves on staff interface This enhancement adds the ability to place recalls via the staff interface by introducing a system preference, RecallsInterface, to configure where recalls can be placed. Recalls can either be placed via the OPAC, or the staff interface, or both. This is set to OPAC by default to be consistent with current behaviour. This enhancement also adds the ability to convert existing reserves to recalls easily via the staff interface. The reserve will be cancelled and a recall placed using the reserve's information. To test: 1) Update database and restart services 2) Enable UseRecalls and set the relevant recalls circulation rules 3) View the new RecallsInterface system preference. Confirm it is set to OPAC only by default 4) Check out Item A to Patron B. 5) Log into the OPAC as Patron A. Confirm you can place, view and cancel recalls as normal. 6) In the staff interface, set RecallsInterface to Staff interface only. 7) In the OPAC, confirm you can still view and cancel recalls, but can no longer place recalls. 8) In the staff interface, search for Item A and go to the Reserves tab. Place a reserve for Patron C. 9) Under the Priority column, select the dropdown and choose the recall option next to your reserve. 10) Click Update holds. Confirm when the page refreshes that your reserve has disappeared. 11) Go to the recalls tab. Confirm your reserve has been converted to a recall, and details like the patron, expiration, and pickup location have carried across to the recall. 12) On this recalls page, use the patron search to find Patron D. Test placing a record-level recall by keeping the 'recall next available item' checkbox. 13) When the page refreshes, confirm the recall was successfully placed with the correct details stored. 14) Repeat steps 12 and 13 with Patron E, this time place an item-level recall by choosing an item in the 'place a recall on a specific item' table. When selecting one of these items, the 'recall next available item' checkbox should de-select. 15) Set RecallsInterface back to OPAC only. Go back to the record and view the Recalls tab. 16) Confirm you cannot search for a patron to place a recall, but can still view and cancel recalls. Confirm you also cannot convert reserves to recalls. 17) Set RecallsInterface to both staff interface and OPAC. Confirm you can place recalls on both interfaces. 18) On the staff interface, test placing recalls that your circulation rules do not allow. For example, if 'recalls per record' is 1, ensure you're blocked from placing a second recall on a record for a patron. 19) Place a reserve for one of the patron's that already has a recall. Once complete, try to convert this reserve into a recall. Confirm you are blocked and shown a message that the hold cannot be converted to a recall. 20) Ensure tests pass t/db_dependent/Holds.t Sponsored-by: Auckland University of Technology -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31415 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31415 [Bug 31415] Script to automate converting reserves to recalls -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement adds the |This enhancement adds the release notes|ability to place recalls |ability to place recalls |via the staff interface by |via the staff interface by |introducing a system |introducing a system |preference, |preference, |RecallsInterface, to |RecallsInterface, to |configure where recalls can |configure where recalls can |be placed. Recalls can |be placed. Recalls can |either be placed via the |either be placed via the |OPAC, or the staff |OPAC, or the staff |interface, or both. This is |interface, or both. This is |set to OPAC by default to |set to OPAC by default to |be consistent with current |be consistent with current |behaviour. |behaviour. | | |This |This |enhancement also adds the |enhancement also adds the |ability to convert existing |ability to convert existing |reserves to recalls easily |holds to recalls easily via |via the staff interface. |the staff interface. The |The reserve will be |hold will be cancelled and |cancelled and a recall |a recall placed using the |placed using the reserve's |hold's information. |information. | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #10 from David Nind <david@davidnind.com> --- Patch no longer applies 8-(.. Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 31391: RecallsInterface system preference Applying: Bug 31391: Recalled authorised value for hold cancellation Applying: Bug 31391: Implement RecallsInterface on OPAC Applying: Bug 31391: Request recalls and convert reserves on staff interface Using index info to reconstruct a base tree... M Koha/Item.pm M koha-tmpl/intranet-tmpl/prog/en/modules/recalls/request.tt M koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt M reserve/request.pl Falling back to patching base and 3-way merge... Auto-merging reserve/request.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/recalls/request.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/recalls/request.tt Auto-merging Koha/Item.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 31391: Request recalls and convert reserves on staff interface -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139645|0 |1 is obsolete| | --- Comment #11 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 141474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141474&action=edit Bug 31391: Request recalls and convert reserves on staff interface This enhancement adds the ability to place recalls via the staff interface by introducing a system preference, RecallsInterface, to configure where recalls can be placed. Recalls can either be placed via the OPAC, or the staff interface, or both. This is set to OPAC by default to be consistent with current behaviour. This enhancement also adds the ability to convert existing reserves to recalls easily via the staff interface. The reserve will be cancelled and a recall placed using the reserve's information. To test: 1) Update database and restart services 2) Enable UseRecalls and set the relevant recalls circulation rules 3) View the new RecallsInterface system preference. Confirm it is set to OPAC only by default 4) Check out Item A to Patron B. 5) Log into the OPAC as Patron A. Confirm you can place, view and cancel recalls as normal. 6) In the staff interface, set RecallsInterface to Staff interface only. 7) In the OPAC, confirm you can still view and cancel recalls, but can no longer place recalls. 8) In the staff interface, search for Item A and go to the Reserves tab. Place a reserve for Patron C. 9) Under the Priority column, select the dropdown and choose the recall option next to your reserve. 10) Click Update holds. Confirm when the page refreshes that your reserve has disappeared. 11) Go to the recalls tab. Confirm your reserve has been converted to a recall, and details like the patron, expiration, and pickup location have carried across to the recall. 12) On this recalls page, use the patron search to find Patron D. Test placing a record-level recall by keeping the 'recall next available item' checkbox. 13) When the page refreshes, confirm the recall was successfully placed with the correct details stored. 14) Repeat steps 12 and 13 with Patron E, this time place an item-level recall by choosing an item in the 'place a recall on a specific item' table. When selecting one of these items, the 'recall next available item' checkbox should de-select. 15) Set RecallsInterface back to OPAC only. Go back to the record and view the Recalls tab. 16) Confirm you cannot search for a patron to place a recall, but can still view and cancel recalls. Confirm you also cannot convert reserves to recalls. 17) Set RecallsInterface to both staff interface and OPAC. Confirm you can place recalls on both interfaces. 18) On the staff interface, test placing recalls that your circulation rules do not allow. For example, if 'recalls per record' is 1, ensure you're blocked from placing a second recall on a record for a patron. 19) Place a reserve for one of the patron's that already has a recall. Once complete, try to convert this reserve into a recall. Confirm you are blocked and shown a message that the hold cannot be converted to a recall. 20) Ensure tests pass t/db_dependent/Holds.t Sponsored-by: Auckland University of Technology -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #14 from David Nind <david@davidnind.com> --- Hi Aleisha. Apologies for Failing QA on this again! The previous issue reported is fixed (step 7 - can't cancel a recall from OPAC when RecallsInterface = staff interface only). I've identified a new issue with step 5 - cancelling a recall from the recalls section for a record - record doesn't exist after cancelling a recall using the 'Cancel selected recalls' button and selecting the normal section. To replicate: 1. Place a recall 2. Go to the recalls section for the record on the staff interface 3. Using Actions > Cancel works as expected 4. Repeat steps 1 and 2. 5. Cancel the recall by ticking the box next to the item and then selecting 'Cancel selected recalls' button doesn't work as expected: . The recall is cancelled . URL = http://127.0.0.1:8081/cgi-bin/koha/recalls/request.pl . Breadcrumb = Home > Catalog > No title > Place a recall . Click on the normal section: message = The record you requested does not exist (). URL = http://127.0.0.1:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber= I'm not sure if I tested this last time. I'm also sure I've seen this when testing something else a while ago, but can't remember or find what bug it was. Also, for step 13 it is possible to have more than one recall for a record or item. Whose recall takes priority, and what is the workflow libraries would use to address this? - If a recall is already on the record (from the previous step), there are now two recalls (a record level one, and an item level one) - On the record page is shows "recalled by X on [date]" - for X it shows the person who made the latest recall, not the first person who place a recall. - Is this an edge case to be resolved in a separate bug, or a non-issue? - It seems logical that multiple patrons could make a recall request for the same record. What would the workflow be for libraries if they were in this situation, and how do they resolve this? David -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 --- Comment #15 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 143155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143155&action=edit Bug 31391: (follow-up) Fix cancel recalls using checkbox -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142594|0 |1 is obsolete| | --- Comment #18 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 144104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144104&action=edit Bug 31391: Request recalls and convert reserves on staff interface This enhancement adds the ability to place recalls via the staff interface by introducing a system preference, RecallsInterface, to configure where recalls can be placed. Recalls can either be placed via the OPAC, or the staff interface, or both. This is set to OPAC by default to be consistent with current behaviour. This enhancement also adds the ability to convert existing reserves to recalls easily via the staff interface. The reserve will be cancelled and a recall placed using the reserve's information. To test: 1) Update database and restart services 2) Enable UseRecalls and set the relevant recalls circulation rules 3) View the new RecallsInterface system preference. Confirm it is set to OPAC only by default 4) Check out Item A to Patron B. 5) Log into the OPAC as Patron A. Confirm you can place, view and cancel recalls as normal. 6) In the staff interface, set RecallsInterface to Staff interface only. 7) In the OPAC, confirm you can still view and cancel recalls, but can no longer place recalls. 8) In the staff interface, search for Item A and go to the Reserves tab. Place a reserve for Patron C. 9) Under the Priority column, select the dropdown and choose the recall option next to your reserve. 10) Click Update holds. Confirm when the page refreshes that your reserve has disappeared. 11) Go to the recalls tab. Confirm your reserve has been converted to a recall, and details like the patron, expiration, and pickup location have carried across to the recall. 12) On this recalls page, use the patron search to find Patron D. Test placing a record-level recall by keeping the 'recall next available item' checkbox. 13) When the page refreshes, confirm the recall was successfully placed with the correct details stored. 14) Repeat steps 12 and 13 with Patron E, this time place an item-level recall by choosing an item in the 'place a recall on a specific item' table. When selecting one of these items, the 'recall next available item' checkbox should de-select. 15) Set RecallsInterface back to OPAC only. Go back to the record and view the Recalls tab. 16) Confirm you cannot search for a patron to place a recall, but can still view and cancel recalls. Confirm you also cannot convert reserves to recalls. 17) Set RecallsInterface to both staff interface and OPAC. Confirm you can place recalls on both interfaces. 18) On the staff interface, test placing recalls that your circulation rules do not allow. For example, if 'recalls per record' is 1, ensure you're blocked from placing a second recall on a record for a patron. 19) Place a reserve for one of the patron's that already has a recall. Once complete, try to convert this reserve into a recall. Confirm you are blocked and shown a message that the hold cannot be converted to a recall. 20) Ensure tests pass t/db_dependent/Holds.t Sponsored-by: Auckland University of Technology -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 --- Comment #20 from Aleisha Amohia <aleisha@catalyst.net.nz> --- (In reply to David Nind from comment #17)

This is still not working for me and doesn't appear to be fixed.

If it helps, there is an entry in /var/log/koha/kohadev/plack-intranet-error.log: [2022/11/04 06:36:44] [WARN] Use of uninitialized value $biblionumber in concatenation (.) or string at /kohadevbox/koha/recalls/request.pl line 49.

Everything else continues to work as per the test plan.

Sorry you were right - amended in most recent patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139643|0 |1 is obsolete| | --- Comment #22 from David Nind <david@davidnind.com> --- Created attachment 144132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144132&action=edit Bug 31391: Recalled authorised value for hold cancellation Signed-off-by: David <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144104|0 |1 is obsolete| | --- Comment #24 from David Nind <david@davidnind.com> --- Created attachment 144134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144134&action=edit Bug 31391: Request recalls and convert reserves on staff interface This enhancement adds the ability to place recalls via the staff interface by introducing a system preference, RecallsInterface, to configure where recalls can be placed. Recalls can either be placed via the OPAC, or the staff interface, or both. This is set to OPAC by default to be consistent with current behaviour. This enhancement also adds the ability to convert existing reserves to recalls easily via the staff interface. The reserve will be cancelled and a recall placed using the reserve's information. To test: 1) Update database and restart services 2) Enable UseRecalls and set the relevant recalls circulation rules 3) View the new RecallsInterface system preference. Confirm it is set to OPAC only by default 4) Check out Item A to Patron B. 5) Log into the OPAC as Patron A. Confirm you can place, view and cancel recalls as normal. 6) In the staff interface, set RecallsInterface to Staff interface only. 7) In the OPAC, confirm you can still view and cancel recalls, but can no longer place recalls. 8) In the staff interface, search for Item A and go to the Reserves tab. Place a reserve for Patron C. 9) Under the Priority column, select the dropdown and choose the recall option next to your reserve. 10) Click Update holds. Confirm when the page refreshes that your reserve has disappeared. 11) Go to the recalls tab. Confirm your reserve has been converted to a recall, and details like the patron, expiration, and pickup location have carried across to the recall. 12) On this recalls page, use the patron search to find Patron D. Test placing a record-level recall by keeping the 'recall next available item' checkbox. 13) When the page refreshes, confirm the recall was successfully placed with the correct details stored. 14) Repeat steps 12 and 13 with Patron E, this time place an item-level recall by choosing an item in the 'place a recall on a specific item' table. When selecting one of these items, the 'recall next available item' checkbox should de-select. 15) Set RecallsInterface back to OPAC only. Go back to the record and view the Recalls tab. 16) Confirm you cannot search for a patron to place a recall, but can still view and cancel recalls. Confirm you also cannot convert reserves to recalls. 17) Set RecallsInterface to both staff interface and OPAC. Confirm you can place recalls on both interfaces. 18) On the staff interface, test placing recalls that your circulation rules do not allow. For example, if 'recalls per record' is 1, ensure you're blocked from placing a second recall on a record for a patron. 19) Place a reserve for one of the patron's that already has a recall. Once complete, try to convert this reserve into a recall. Confirm you are blocked and shown a message that the hold cannot be converted to a recall. 20) Ensure tests pass t/db_dependent/Holds.t Sponsored-by: Auckland University of Technology Signed-off-by: David <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 --- Comment #26 from David Nind <david@davidnind.com> --- Created attachment 144136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144136&action=edit Bug 31391: (follow-up) Fix number of tests and terminology Fixed two items: - Number of tests: changed to 77 (from 76), tests now pass - Terminology: changed message when attempting to place recalls from the staff interface when RecallsInterface in set to the OPAC only (staff client should be staff interface) Signed-off-by: David <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 --- Comment #28 from Aleisha Amohia <aleisha@catalyst.net.nz> --- (In reply to David Nind from comment #27)

Thanks Aleisha - now signed off!

I added a follow-up to change the number of tests so that tests pass, and change staff client to staff interface.

David

Good catch! Thank you for your awesome testing. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147581|0 |1 is obsolete| | --- Comment #31 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 147582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147582&action=edit Bug 31391: Interface and wording fixes This patch includes the following fixes: - Making the atomic updates executable - Preventing warns when running tests - Updating db updates - Fixing terminology - Make 'cancel selected recalls' button yellow - Fix HTML makeup of recalls request page - Show a warning when placing a recall if there is already a record-level hold by this patron - Show a link to mark a hold for conversion which selects the recall option on holds page -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144132|0 |1 is obsolete| | --- Comment #33 from David Nind <david@davidnind.com> --- Created attachment 150486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150486&action=edit Bug 31391: Recalled authorised value for hold cancellation Signed-off-by: David <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144134|0 |1 is obsolete| | --- Comment #35 from David Nind <david@davidnind.com> --- Created attachment 150488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150488&action=edit Bug 31391: Request recalls and convert reserves on staff interface This enhancement adds the ability to place recalls via the staff interface by introducing a system preference, RecallsInterface, to configure where recalls can be placed. Recalls can either be placed via the OPAC, or the staff interface, or both. This is set to OPAC by default to be consistent with current behaviour. This enhancement also adds the ability to convert existing reserves to recalls easily via the staff interface. The reserve will be cancelled and a recall placed using the reserve's information. To test: 1) Update database and restart services 2) Enable UseRecalls and set the relevant recalls circulation rules 3) View the new RecallsInterface system preference. Confirm it is set to OPAC only by default 4) Check out Item A to Patron B. 5) Log into the OPAC as Patron A. Confirm you can place, view and cancel recalls as normal. 6) In the staff interface, set RecallsInterface to Staff interface only. 7) In the OPAC, confirm you can still view and cancel recalls, but can no longer place recalls. 8) In the staff interface, search for Item A and go to the Reserves tab. Place a reserve for Patron C. 9) Under the Priority column, select the dropdown and choose the recall option next to your reserve. 10) Click Update holds. Confirm when the page refreshes that your reserve has disappeared. 11) Go to the recalls tab. Confirm your reserve has been converted to a recall, and details like the patron, expiration, and pickup location have carried across to the recall. 12) On this recalls page, use the patron search to find Patron D. Test placing a record-level recall by keeping the 'recall next available item' checkbox. 13) When the page refreshes, confirm the recall was successfully placed with the correct details stored. 14) Repeat steps 12 and 13 with Patron E, this time place an item-level recall by choosing an item in the 'place a recall on a specific item' table. When selecting one of these items, the 'recall next available item' checkbox should de-select. 15) Set RecallsInterface back to OPAC only. Go back to the record and view the Recalls tab. 16) Confirm you cannot search for a patron to place a recall, but can still view and cancel recalls. Confirm you also cannot convert reserves to recalls. 17) Set RecallsInterface to both staff interface and OPAC. Confirm you can place recalls on both interfaces. 18) On the staff interface, test placing recalls that your circulation rules do not allow. For example, if 'recalls per record' is 1, ensure you're blocked from placing a second recall on a record for a patron. 19) Place a reserve for one of the patron's that already has a recall. Once complete, try to convert this reserve into a recall. Confirm you are blocked and shown a message that the hold cannot be converted to a recall. 20) Ensure tests pass t/db_dependent/Holds.t Sponsored-by: Auckland University of Technology Signed-off-by: David <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144136|0 |1 is obsolete| | --- Comment #37 from David Nind <david@davidnind.com> --- Created attachment 150490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150490&action=edit Bug 31391: (follow-up) Fix number of tests and terminology Fixed two items: - Number of tests: changed to 77 (from 76), tests now pass - Terminology: changed message when attempting to place recalls from the staff interface when RecallsInterface in set to the OPAC only (staff client should be staff interface) Signed-off-by: David <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 --- Comment #39 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- IMO we are too far in the release cycle to push this one for 23.05. Additionally there are several bugs opened for the OPAC part that are still waiting to be fixed. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150486|0 |1 is obsolete| | --- Comment #42 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 156996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156996&action=edit Bug 31391: Recalled authorised value for hold cancellation Signed-off-by: David <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150488|0 |1 is obsolete| | --- Comment #44 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 156998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156998&action=edit Bug 31391: Request recalls and convert reserves on staff interface This enhancement adds the ability to place recalls via the staff interface by introducing a system preference, RecallsInterface, to configure where recalls can be placed. Recalls can either be placed via the OPAC, or the staff interface, or both. This is set to OPAC by default to be consistent with current behaviour. This enhancement also adds the ability to convert existing reserves to recalls easily via the staff interface. The reserve will be cancelled and a recall placed using the reserve's information. To test: 1) Update database and restart services 2) Enable UseRecalls and set the relevant recalls circulation rules 3) View the new RecallsInterface system preference. Confirm it is set to OPAC only by default 4) Check out Item A to Patron B. 5) Log into the OPAC as Patron A. Confirm you can place, view and cancel recalls as normal. 6) In the staff interface, set RecallsInterface to Staff interface only. 7) In the OPAC, confirm you can still view and cancel recalls, but can no longer place recalls. 8) In the staff interface, search for Item A and go to the Reserves tab. Place a reserve for Patron C. 9) Under the Priority column, select the dropdown and choose the recall option next to your reserve. 10) Click Update holds. Confirm when the page refreshes that your reserve has disappeared. 11) Go to the recalls tab. Confirm your reserve has been converted to a recall, and details like the patron, expiration, and pickup location have carried across to the recall. 12) On this recalls page, use the patron search to find Patron D. Test placing a record-level recall by keeping the 'recall next available item' checkbox. 13) When the page refreshes, confirm the recall was successfully placed with the correct details stored. 14) Repeat steps 12 and 13 with Patron E, this time place an item-level recall by choosing an item in the 'place a recall on a specific item' table. When selecting one of these items, the 'recall next available item' checkbox should de-select. 15) Set RecallsInterface back to OPAC only. Go back to the record and view the Recalls tab. 16) Confirm you cannot search for a patron to place a recall, but can still view and cancel recalls. Confirm you also cannot convert reserves to recalls. 17) Set RecallsInterface to both staff interface and OPAC. Confirm you can place recalls on both interfaces. 18) On the staff interface, test placing recalls that your circulation rules do not allow. For example, if 'recalls per record' is 1, ensure you're blocked from placing a second recall on a record for a patron. 19) Place a reserve for one of the patron's that already has a recall. Once complete, try to convert this reserve into a recall. Confirm you are blocked and shown a message that the hold cannot be converted to a recall. 20) Ensure tests pass t/db_dependent/Holds.t Sponsored-by: Auckland University of Technology Signed-off-by: David <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150490|0 |1 is obsolete| | --- Comment #46 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 157000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157000&action=edit Bug 31391: (follow-up) Fix number of tests and terminology Fixed two items: - Number of tests: changed to 77 (from 76), tests now pass - Terminology: changed message when attempting to place recalls from the staff interface when RecallsInterface in set to the OPAC only (staff client should be staff interface) Signed-off-by: David <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 --- Comment #48 from David Nind <david@davidnind.com> --- Everything still works, however the tests are failing for me: prove t/db_dependent/Holds.t t/db_dependent/Holds.t .. 68/74 Use of uninitialized value in numeric le (<=) at /kohadevbox/koha/C4/Circulation.pm line 3002. Use of uninitialized value in numeric le (<=) at /kohadevbox/koha/C4/Circulation.pm line 3002. Use of uninitialized value in numeric le (<=) at /kohadevbox/koha/C4/Circulation.pm line 3002. t/db_dependent/Holds.t .. 73/74 # No tests run! # Failed test 'No tests run for subtest "ModReserve to convert a hold to a recall"' # at t/db_dependent/Holds.t line 1902. Can't call method "categorycode" on unblessed reference at /kohadevbox/koha/C4/Circulation.pm line 3830. # Looks like your test exited with 11 just after 74. t/db_dependent/Holds.t .. Dubious, test returned 11 (wstat 2816, 0xb00) Failed 1/74 subtests Test Summary Report ------------------- t/db_dependent/Holds.t (Wstat: 2816 Tests: 74 Failed: 1) Failed test: 74 Non-zero exit status: 11 Files=1, Tests=74, 7 wallclock secs ( 0.04 usr 0.01 sys + 3.62 cusr 1.28 csys = 4.95 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer@bsz-bw.de |testopia@bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156998|0 |1 is obsolete| | --- Comment #49 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 158691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158691&action=edit Bug 31391: Request recalls and convert reserves on staff interface This enhancement adds the ability to place recalls via the staff interface by introducing a system preference, RecallsInterface, to configure where recalls can be placed. Recalls can either be placed via the OPAC, or the staff interface, or both. This is set to OPAC by default to be consistent with current behaviour. This enhancement also adds the ability to convert existing reserves to recalls easily via the staff interface. The reserve will be cancelled and a recall placed using the reserve's information. To test: 1) Update database and restart services 2) Enable UseRecalls and set the relevant recalls circulation rules 3) View the new RecallsInterface system preference. Confirm it is set to OPAC only by default 4) Check out Item A to Patron B. 5) Log into the OPAC as Patron A. Confirm you can place, view and cancel recalls as normal. 6) In the staff interface, set RecallsInterface to Staff interface only. 7) In the OPAC, confirm you can still view and cancel recalls, but can no longer place recalls. 8) In the staff interface, search for Item A and go to the Reserves tab. Place a reserve for Patron C. 9) Under the Priority column, select the dropdown and choose the recall option next to your reserve. 10) Click Update holds. Confirm when the page refreshes that your reserve has disappeared. 11) Go to the recalls tab. Confirm your reserve has been converted to a recall, and details like the patron, expiration, and pickup location have carried across to the recall. 12) On this recalls page, use the patron search to find Patron D. Test placing a record-level recall by keeping the 'recall next available item' checkbox. 13) When the page refreshes, confirm the recall was successfully placed with the correct details stored. 14) Repeat steps 12 and 13 with Patron E, this time place an item-level recall by choosing an item in the 'place a recall on a specific item' table. When selecting one of these items, the 'recall next available item' checkbox should de-select. 15) Set RecallsInterface back to OPAC only. Go back to the record and view the Recalls tab. 16) Confirm you cannot search for a patron to place a recall, but can still view and cancel recalls. Confirm you also cannot convert reserves to recalls. 17) Set RecallsInterface to both staff interface and OPAC. Confirm you can place recalls on both interfaces. 18) On the staff interface, test placing recalls that your circulation rules do not allow. For example, if 'recalls per record' is 1, ensure you're blocked from placing a second recall on a record for a patron. 19) Place a reserve for one of the patron's that already has a recall. Once complete, try to convert this reserve into a recall. Confirm you are blocked and shown a message that the hold cannot be converted to a recall. 20) Ensure tests pass t/db_dependent/Holds.t Sponsored-by: Auckland University of Technology Signed-off-by: David <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157000|0 |1 is obsolete| | --- Comment #51 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 158693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158693&action=edit Bug 31391: (follow-up) Fix number of tests and terminology Fixed two items: - Number of tests: changed to 77 (from 76), tests now pass - Terminology: changed message when attempting to place recalls from the staff interface when RecallsInterface in set to the OPAC only (staff client should be staff interface) Signed-off-by: David <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 --- Comment #53 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 158695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158695&action=edit Bug 31391: Test fixes -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156995|0 |1 is obsolete| | --- Comment #54 from David Nind <david@davidnind.com> --- Created attachment 158825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158825&action=edit Bug 31391: RecallsInterface system preference Signed-off-by: David <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156997|0 |1 is obsolete| | --- Comment #56 from David Nind <david@davidnind.com> --- Created attachment 158827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158827&action=edit Bug 31391: Implement RecallsInterface on OPAC Signed-off-by: David <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158692|0 |1 is obsolete| | --- Comment #58 from David Nind <david@davidnind.com> --- Created attachment 158829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158829&action=edit Bug 31391: (follow-up) Fix cancel recalls using checkbox Signed-off-by: David <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158694|0 |1 is obsolete| | --- Comment #60 from David Nind <david@davidnind.com> --- Created attachment 158831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158831&action=edit Bug 31391: Interface and wording fixes This patch includes the following fixes: - Making the atomic updates executable - Preventing warns when running tests - Updating db updates - Fixing terminology - Make 'cancel selected recalls' button yellow - Fix HTML makeup of recalls request page - Show a warning when placing a recall if there is already a record-level hold by this patron - Show a link to mark a hold for conversion which selects the recall option on holds page - Include changes to patron search dropdown - add 'mark hold for conversion to recall' column to columns settings Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 --- Comment #62 from David Nind <david@davidnind.com> --- Thanks Aleisha! The tests now pass, and everything seems to be working as expected. David -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com, | |pedro.amorim@ptfs-europe.co | |m --- Comment #63 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Test plan works as described and qa script seems happy, but I don't feel comfortable passing or failing QA here, so I'll leave that to someone else and provide some observations instead: Instead of adding RecallsInterface, should we consider updating UseRecalls sys pref to: 0 - Don't use 1 - Use on OPAC only 2 - Use on staff interface only 3 - Use on both OPAC and staff interface This would address the use-cases being covered here and not be YASP. I understand it's more work but it seems partially redundant to have both UseRecalls and RecallsInterface. I believe using the values I suggest above would ease the work, since the current UseRecalls = 1 is equivalent to the would be RecallsInterface = 'opac', although some current checks for truthy UseRecalls would also now encompass '2' and '3', maybe not critical but just something to consider. -------------- Some improvements to error messaging could be considered: Attempt to place a recall on an item not checked out, you get: "Unable to place a recall. Check your circulation rules." When you should get something like: "Unable to place a recall on an item not checked out." Attempt to place a recall on the same patron that the item is checked out to, you get: "Unable to place a recall. Check your circulation rules." When you should get something like "Unable to place recall. Item is already checked out to user X" -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED --- Comment #65 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Thanks all I agree with your suggestions and am working on implementing these. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Circulation| |recalls function| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158826|0 |1 is obsolete| | --- Comment #67 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 172167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172167&action=edit Bug 31391: Recalled authorised value for hold cancellation Signed-off-by: David <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158828|0 |1 is obsolete| | --- Comment #69 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 172169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172169&action=edit Bug 31391: Request recalls and convert reserves on staff interface This enhancement adds the ability to place recalls via the staff interface by introducing a system preference, RecallsInterface, to configure where recalls can be placed. Recalls can either be placed via the OPAC, or the staff interface, or both. This is set to OPAC by default to be consistent with current behaviour. This enhancement also adds the ability to convert existing reserves to recalls easily via the staff interface. The reserve will be cancelled and a recall placed using the reserve's information. To test: 1) Update database and restart services 2) Enable UseRecalls and set the relevant recalls circulation rules 3) View the new RecallsInterface system preference. Confirm it is set to OPAC only by default 4) Check out Item A to Patron B. 5) Log into the OPAC as Patron A. Confirm you can place, view and cancel recalls as normal. 6) In the staff interface, set RecallsInterface to Staff interface only. 7) In the OPAC, confirm you can still view and cancel recalls, but can no longer place recalls. 8) In the staff interface, search for Item A and go to the Reserves tab. Place a reserve for Patron C. 9) Under the Priority column, select the dropdown and choose the recall option next to your reserve. 10) Click Update holds. Confirm when the page refreshes that your reserve has disappeared. 11) Go to the recalls tab. Confirm your reserve has been converted to a recall, and details like the patron, expiration, and pickup location have carried across to the recall. 12) On this recalls page, use the patron search to find Patron D. Test placing a record-level recall by keeping the 'recall next available item' checkbox. 13) When the page refreshes, confirm the recall was successfully placed with the correct details stored. 14) Repeat steps 12 and 13 with Patron E, this time place an item-level recall by choosing an item in the 'place a recall on a specific item' table. When selecting one of these items, the 'recall next available item' checkbox should de-select. 15) Set RecallsInterface back to OPAC only. Go back to the record and view the Recalls tab. 16) Confirm you cannot search for a patron to place a recall, but can still view and cancel recalls. Confirm you also cannot convert reserves to recalls. 17) Set RecallsInterface to both staff interface and OPAC. Confirm you can place recalls on both interfaces. 18) On the staff interface, test placing recalls that your circulation rules do not allow. For example, if 'recalls per record' is 1, ensure you're blocked from placing a second recall on a record for a patron. 19) Place a reserve for one of the patron's that already has a recall. Once complete, try to convert this reserve into a recall. Confirm you are blocked and shown a message that the hold cannot be converted to a recall. 20) Ensure tests pass t/db_dependent/Holds.t Sponsored-by: Auckland University of Technology Signed-off-by: David <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158830|0 |1 is obsolete| | --- Comment #71 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 172171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172171&action=edit Bug 31391: (follow-up) Fix number of tests and terminology Fixed two items: - Number of tests: changed to 77 (from 76), tests now pass - Terminology: changed message when attempting to place recalls from the staff interface when RecallsInterface in set to the OPAC only (staff client should be staff interface) Signed-off-by: David <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158832|0 |1 is obsolete| | --- Comment #73 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 172173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172173&action=edit Bug 31391: Test fixes Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 --- Comment #75 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 172175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172175&action=edit Bug 31391: [WIP] Better recalls error messages -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 --- Comment #77 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am not sure I can help much with the questions on development side, but please let me know once this is ready for testing again and happy to help with that. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Patch doesn't apply --- Comment #78 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Hi Aleisha, providing my input here. Patch doesn't apply (sorry!). I'll try to come back faster next you're available to rebase. I've taken a look at the WIP patch. At first glance, it looks good, but it also looks like it may be a bit out of scope of the original intent here, which is to provide staff-side recalls, so I don't think it should be reason enough to block the whole thing because of it. Your call if you think we should tackle it here or perhaps better on a follow-up bug. Having said that, I'll look again once it applies again. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172167|0 |1 is obsolete| | --- Comment #81 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 173840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173840&action=edit Bug 31391: Recalled authorised value for hold cancellation Signed-off-by: David <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172169|0 |1 is obsolete| | --- Comment #83 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 173842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173842&action=edit Bug 31391: Request recalls and convert reserves on staff interface This enhancement adds the ability to place recalls via the staff interface by introducing a system preference, RecallsInterface, to configure where recalls can be placed. Recalls can either be placed via the OPAC, or the staff interface, or both. This is set to OPAC by default to be consistent with current behaviour. This enhancement also adds the ability to convert existing reserves to recalls easily via the staff interface. The reserve will be cancelled and a recall placed using the reserve's information. To test: 1) Update database and restart services 2) Enable UseRecalls and set the relevant recalls circulation rules 3) View the new RecallsInterface system preference. Confirm it is set to OPAC only by default 4) Check out Item A to Patron B. 5) Log into the OPAC as Patron A. Confirm you can place, view and cancel recalls as normal. 6) In the staff interface, set RecallsInterface to Staff interface only. 7) In the OPAC, confirm you can still view and cancel recalls, but can no longer place recalls. 8) In the staff interface, search for Item A and go to the Reserves tab. Place a reserve for Patron C. 9) Under the Priority column, select the dropdown and choose the recall option next to your reserve. 10) Click Update holds. Confirm when the page refreshes that your reserve has disappeared. 11) Go to the recalls tab. Confirm your reserve has been converted to a recall, and details like the patron, expiration, and pickup location have carried across to the recall. 12) On this recalls page, use the patron search to find Patron D. Test placing a record-level recall by keeping the 'recall next available item' checkbox. 13) When the page refreshes, confirm the recall was successfully placed with the correct details stored. 14) Repeat steps 12 and 13 with Patron E, this time place an item-level recall by choosing an item in the 'place a recall on a specific item' table. When selecting one of these items, the 'recall next available item' checkbox should de-select. 15) Set RecallsInterface back to OPAC only. Go back to the record and view the Recalls tab. 16) Confirm you cannot search for a patron to place a recall, but can still view and cancel recalls. Confirm you also cannot convert reserves to recalls. 17) Set RecallsInterface to both staff interface and OPAC. Confirm you can place recalls on both interfaces. 18) On the staff interface, test placing recalls that your circulation rules do not allow. For example, if 'recalls per record' is 1, ensure you're blocked from placing a second recall on a record for a patron. 19) Place a reserve for one of the patron's that already has a recall. Once complete, try to convert this reserve into a recall. Confirm you are blocked and shown a message that the hold cannot be converted to a recall. 20) Ensure tests pass t/db_dependent/Holds.t Sponsored-by: Auckland University of Technology Signed-off-by: David <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172171|0 |1 is obsolete| | --- Comment #85 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 173844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173844&action=edit Bug 31391: (follow-up) Fix number of tests and terminology Fixed two items: - Number of tests: changed to 77 (from 76), tests now pass - Terminology: changed message when attempting to place recalls from the staff interface when RecallsInterface in set to the OPAC only (staff client should be staff interface) Signed-off-by: David <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172173|0 |1 is obsolete| | --- Comment #87 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 173846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173846&action=edit Bug 31391: Test fixes Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 --- Comment #89 from Aleisha Amohia <aleisha@catalyst.net.nz> --- I've rebased patches and hopefully improved the styling of the error message, but I would like to work on improving the content of the error message in a follow-up bug. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #90 from David Nind <david@davidnind.com> --- (In reply to Aleisha Amohia from comment #89)

I've rebased patches and hopefully improved the styling of the error message, but I would like to work on improving the content of the error message in a follow-up bug.

Hi Aleisha. Thanks for rebasing! I've changed the status to Failed QA as: 1. I can't place a recall using the staff interface (with staff interface or both selected for placing recalls): 1.1 Patron search box doesn't work as expected, so can't select a patron to place a recall for: autocomplete doesn't work, search brings you to an empty record, browse by last name does nothing (the autocomplete still works on the holds section). 1.2 Couldn't test steps 12-14, 17-19. Testing notes (using KTD): 1. Test plan: with follow-up patches, there is now only one system preference UseRecalls, you can select which interfaces to allow recalls to be placed from Other notes: 1. With recalls allowed from the staff interface only and an existing recall: 1.1 In the OPAC, the status for the record as a "Recall" in a button, under "Checked out". 1.2 If you click "Recall" you get "Recalls have not been enabled. Please contact your library." on the account's "Recalls history" section. 1.3 Not sure if that is what is expected or not. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 --- Comment #91 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 174396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174396&action=edit Bug 31391: (follow-up) Include changed requirements of patron autocomplete, datatable -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173840|0 |1 is obsolete| | --- Comment #94 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 174823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174823&action=edit Bug 31391: Recalled authorised value for hold cancellation Signed-off-by: David <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173842|0 |1 is obsolete| | --- Comment #96 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 174825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174825&action=edit Bug 31391: Request recalls and convert reserves on staff interface This enhancement adds the ability to place recalls via the staff interface by introducing a system preference, RecallsInterface, to configure where recalls can be placed. Recalls can either be placed via the OPAC, or the staff interface, or both. This is set to OPAC by default to be consistent with current behaviour. This enhancement also adds the ability to convert existing reserves to recalls easily via the staff interface. The reserve will be cancelled and a recall placed using the reserve's information. To test: 1) Update database and restart services 2) Enable UseRecalls and set the relevant recalls circulation rules 3) View the new RecallsInterface system preference. Confirm it is set to OPAC only by default 4) Check out Item A to Patron B. 5) Log into the OPAC as Patron A. Confirm you can place, view and cancel recalls as normal. 6) In the staff interface, set RecallsInterface to Staff interface only. 7) In the OPAC, confirm you can still view and cancel recalls, but can no longer place recalls. 8) In the staff interface, search for Item A and go to the Reserves tab. Place a reserve for Patron C. 9) Under the Priority column, select the dropdown and choose the recall option next to your reserve. 10) Click Update holds. Confirm when the page refreshes that your reserve has disappeared. 11) Go to the recalls tab. Confirm your reserve has been converted to a recall, and details like the patron, expiration, and pickup location have carried across to the recall. 12) On this recalls page, use the patron search to find Patron D. Test placing a record-level recall by keeping the 'recall next available item' checkbox. 13) When the page refreshes, confirm the recall was successfully placed with the correct details stored. 14) Repeat steps 12 and 13 with Patron E, this time place an item-level recall by choosing an item in the 'place a recall on a specific item' table. When selecting one of these items, the 'recall next available item' checkbox should de-select. 15) Set RecallsInterface back to OPAC only. Go back to the record and view the Recalls tab. 16) Confirm you cannot search for a patron to place a recall, but can still view and cancel recalls. Confirm you also cannot convert reserves to recalls. 17) Set RecallsInterface to both staff interface and OPAC. Confirm you can place recalls on both interfaces. 18) On the staff interface, test placing recalls that your circulation rules do not allow. For example, if 'recalls per record' is 1, ensure you're blocked from placing a second recall on a record for a patron. 19) Place a reserve for one of the patron's that already has a recall. Once complete, try to convert this reserve into a recall. Confirm you are blocked and shown a message that the hold cannot be converted to a recall. 20) Ensure tests pass t/db_dependent/Holds.t Sponsored-by: Auckland University of Technology Signed-off-by: David <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173844|0 |1 is obsolete| | --- Comment #98 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 174827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174827&action=edit Bug 31391: (follow-up) Fix number of tests and terminology Fixed two items: - Number of tests: changed to 77 (from 76), tests now pass - Terminology: changed message when attempting to place recalls from the staff interface when RecallsInterface in set to the OPAC only (staff client should be staff interface) Signed-off-by: David <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173846|0 |1 is obsolete| | --- Comment #100 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 174829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174829&action=edit Bug 31391: Test fixes Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174396|0 |1 is obsolete| | --- Comment #102 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 174831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174831&action=edit Bug 31391: (follow-up) Include changed requirements of patron autocomplete, datatable Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_25_05_candidate -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|martin.renvoize@ptfs-europe |testopia@bugs.koha-communit |.com |y.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 --- Comment #105 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 177902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177902&action=edit Bug 31391: Recalled authorised value for hold cancellation Signed-off-by: David <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 --- Comment #107 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 177904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177904&action=edit Bug 31391: Request recalls and convert reserves on staff interface This enhancement adds the ability to place recalls via the staff interface by introducing a system preference, RecallsInterface, to configure where recalls can be placed. Recalls can either be placed via the OPAC, or the staff interface, or both. This is set to OPAC by default to be consistent with current behaviour. This enhancement also adds the ability to convert existing reserves to recalls easily via the staff interface. The reserve will be cancelled and a recall placed using the reserve's information. To test: 1) Update database and restart services 2) Enable UseRecalls and set the relevant recalls circulation rules 3) View the new RecallsInterface system preference. Confirm it is set to OPAC only by default 4) Check out Item A to Patron B. 5) Log into the OPAC as Patron A. Confirm you can place, view and cancel recalls as normal. 6) In the staff interface, set RecallsInterface to Staff interface only. 7) In the OPAC, confirm you can still view and cancel recalls, but can no longer place recalls. 8) In the staff interface, search for Item A and go to the Reserves tab. Place a reserve for Patron C. 9) Under the Priority column, select the dropdown and choose the recall option next to your reserve. 10) Click Update holds. Confirm when the page refreshes that your reserve has disappeared. 11) Go to the recalls tab. Confirm your reserve has been converted to a recall, and details like the patron, expiration, and pickup location have carried across to the recall. 12) On this recalls page, use the patron search to find Patron D. Test placing a record-level recall by keeping the 'recall next available item' checkbox. 13) When the page refreshes, confirm the recall was successfully placed with the correct details stored. 14) Repeat steps 12 and 13 with Patron E, this time place an item-level recall by choosing an item in the 'place a recall on a specific item' table. When selecting one of these items, the 'recall next available item' checkbox should de-select. 15) Set RecallsInterface back to OPAC only. Go back to the record and view the Recalls tab. 16) Confirm you cannot search for a patron to place a recall, but can still view and cancel recalls. Confirm you also cannot convert reserves to recalls. 17) Set RecallsInterface to both staff interface and OPAC. Confirm you can place recalls on both interfaces. 18) On the staff interface, test placing recalls that your circulation rules do not allow. For example, if 'recalls per record' is 1, ensure you're blocked from placing a second recall on a record for a patron. 19) Place a reserve for one of the patron's that already has a recall. Once complete, try to convert this reserve into a recall. Confirm you are blocked and shown a message that the hold cannot be converted to a recall. 20) Ensure tests pass t/db_dependent/Holds.t Sponsored-by: Auckland University of Technology Signed-off-by: David <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 --- Comment #109 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 177906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177906&action=edit Bug 31391: (follow-up) Fix number of tests and terminology Fixed two items: - Number of tests: changed to 77 (from 76), tests now pass - Terminology: changed message when attempting to place recalls from the staff interface when RecallsInterface in set to the OPAC only (staff client should be staff interface) Signed-off-by: David <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 --- Comment #111 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 177908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177908&action=edit Bug 31391: Test fixes Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 --- Comment #113 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 177910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177910&action=edit Bug 31391: (follow-up) Include changed requirements of patron autocomplete, datatable Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_25_05_candidate, | |RM_priority | --- Comment #115 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Would have loved to see this. Maybe next cycle we can work together to make it happen. I'll hopefully have a little more time on my hands. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177901|0 |1 is obsolete| | --- Comment #116 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 185180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185180&action=edit Bug 31391: RecallsInterface system preference Signed-off-by: David <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177903|0 |1 is obsolete| | --- Comment #118 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 185182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185182&action=edit Bug 31391: Implement RecallsInterface on OPAC Signed-off-by: David <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177905|0 |1 is obsolete| | --- Comment #120 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 185184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185184&action=edit Bug 31391: (follow-up) Fix cancel recalls using checkbox Signed-off-by: David <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177907|0 |1 is obsolete| | --- Comment #122 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 185186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185186&action=edit Bug 31391: Interface and wording fixes This patch includes the following fixes: - Making the atomic updates executable - Preventing warns when running tests - Updating db updates - Fixing terminology - Make 'cancel selected recalls' button yellow - Fix HTML makeup of recalls request page - Show a warning when placing a recall if there is already a record-level hold by this patron - Show a link to mark a hold for conversion which selects the recall option on holds page - Include changes to patron search dropdown - add 'mark hold for conversion to recall' column to columns settings Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177909|0 |1 is obsolete| | --- Comment #124 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 185188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185188&action=edit Bug 31391: Update the UseRecalls system preference to have choices Options are: * off * opac * staff * opac_and_staff This patch implements this all over the place. All recalls things should still work including the above test plan. Tests should pass: * t/db_dependent/Circulation.t * t/db_dependent/Circulation/transferbook.t * t/db_dependent/Holds.t * t/db_dependent/Koha/Biblio.t * t/db_dependent/Koha/Item.t * t/db_dependent/SIP/Transaction.t * t/db_dependent/Search.t * t/db_dependent/XSLT.t Sponsored-by: Auckland University of Technology Sponsored-by: Catalyst IT Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED --- Comment #126 from Aleisha Amohia <aleisha@catalyst.net.nz> --- (In reply to Pedro Amorim from comment #103)

Have signed-off as the observations I'm listing below are minor and quickly fixable (adding the ones from comment #92 here to have them all in a single comment):

1) In koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt

We have IF Koha.Preference('UseRecalls') != "off"

Should it not be IF Koha.Preference('UseRecalls').match('opac)

i.e. do we want to show this on this template if UseRecalls = 'staff'?

Thanks for checking, yes we still want it there to show recalls on their account that were requested via the staff interface, even if the user couldn't request it themselves via the OPAC.

2) In opac-recall.pl: Shouldn't the check for if($op eq 'cud-cancel) be inside the if ( C4::Context->preference('UseRecalls') =~ m/opac/ ) check?

Similar to the above response - the cud-cancel being outside the UseRecalls check means they can still cancel recalls that were requested on their behalf via the staff interface. So this is intentional also.

3) Occurrences of: <input type="submit" class="btn btn-default" value="Place recall"> Should be using .btn-primary

Thanks, will address in a follow-up

4) I believe occurrences of: div class="dialog alert" Should be div class="alert alert-warning"

Thanks, will address in a follow-up

5) At first it seems recalls_per_record was buggy as I had it configured as 5 but was placing 10 recalls on a biblio record. I then realized 'record' in recalls_per_record refers to the patron record (?) and is consistent with the other circulation rules.

Yes that's right, the rule limits how many recalls a patron may request on one record, and does look to be working as intended.

6) Bug 23269 should be rebased on this or vice-versa. I believe recalls API endpoints will be needed for bug 23269.

I think that would be handled separately - this bug report is building upon existing recalls functionality to enable recalls requested via the staff interface, so new endpoints would be out of scope. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 --- Comment #127 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 185190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185190&action=edit Bug 31391: (follow-up) Fix button and alert HTML classes -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #128 from David Nind <david@davidnind.com> --- The patch no longer applies 8-(... Applying: Bug 31391: RecallsInterface system preference Using index info to reconstruct a base tree... M installer/data/mysql/mandatory/sysprefs.sql M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref Auto-merging installer/data/mysql/mandatory/sysprefs.sql error: Failed to merge in the changes. Patch failed at 0001 Bug 31391: RecallsInterface system preference -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185180|0 |1 is obsolete| | --- Comment #130 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 189452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189452&action=edit Bug 31391: RecallsInterface system preference Signed-off-by: David <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185182|0 |1 is obsolete| | --- Comment #132 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 189454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189454&action=edit Bug 31391: Implement RecallsInterface on OPAC Signed-off-by: David <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185184|0 |1 is obsolete| | --- Comment #134 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 189456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189456&action=edit Bug 31391: (follow-up) Fix cancel recalls using checkbox Signed-off-by: David <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185186|0 |1 is obsolete| | --- Comment #136 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 189458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189458&action=edit Bug 31391: Interface and wording fixes This patch includes the following fixes: - Making the atomic updates executable - Preventing warns when running tests - Updating db updates - Fixing terminology - Make 'cancel selected recalls' button yellow - Fix HTML makeup of recalls request page - Show a warning when placing a recall if there is already a record-level hold by this patron - Show a link to mark a hold for conversion which selects the recall option on holds page - Include changes to patron search dropdown - add 'mark hold for conversion to recall' column to columns settings Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185188|0 |1 is obsolete| | --- Comment #138 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 189460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189460&action=edit Bug 31391: Update the UseRecalls system preference to have choices Options are: * off * opac * staff * opac_and_staff This patch implements this all over the place. All recalls things should still work including the above test plan. Tests should pass: * t/db_dependent/Circulation.t * t/db_dependent/Circulation/transferbook.t * t/db_dependent/Holds.t * t/db_dependent/Koha/Biblio.t * t/db_dependent/Koha/Item.t * t/db_dependent/SIP/Transaction.t * t/db_dependent/Search.t * t/db_dependent/XSLT.t Sponsored-by: Auckland University of Technology Sponsored-by: Catalyst IT Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185190|0 |1 is obsolete| | --- Comment #140 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 189462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189462&action=edit Bug 31391: (follow-up) Fix button and alert HTML classes -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff CC| |alexbuckley@catalyst.net.nz --- Comment #142 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Rebased these patches against upstream main. Also added a sponsored follow-up patch to correctly display the 'Return recalled item' and 'Recall awaiting pickup' notices in the member messaging form (as per bug 23781 ) when the UseRecalls syspref is set to: opac, staff or opac_and_staff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 --- Comment #144 from Alex Buckley <alexbuckley@catalyst.net.nz> --- (In reply to David Nind from comment #143)

I'm getting this error when running the database update:

updatedatabase String found where operator expected at /kohadevbox/koha/installer/data/mysql/atomicupdate/bug_31391_- _add_RecallsInterface_syspref.pl line 1, near "rm 'installer/data/mysql/atomicupdate/bug_31391_-_add_RecallsInterface_syspref. pl'" (Do you need to predeclare rm?) DEV atomic update /kohadevbox/koha/installer/data/mysql/atomicupdate/bug_31391_- _add_HOLD_CANCELLATION-RECALLED_authorised_value.pl [03:40:12]: Bug 31391 - Staff-side recalls Added RECALLED value to HOLD_CANCELLATION authorised value category DEV atomic update /kohadevbox/koha/installer/data/mysql/atomicupdate/bug_31391_- _update_UseRecalls_syspref.pl [03:40:12]: Bug 31391 - Staff-side recalls Updated system preference 'UseRecalls' to include interface choices DEV atomic update /kohadevbox/koha/installer/data/mysql/atomicupdate/bug_31391_- _add_RecallsInterface_syspref.pl [03:40:12] ERROR: {UNKNOWN}: Can't use an undefined value as a subroutine reference at /kohadevbox/koha/C4/Installer.pm line 823. at /kohadevbox/koha/C4/Installer.pm line 825

Thanks for testing David! Taking a look -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 --- Comment #146 from Alex Buckley <alexbuckley@catalyst.net.nz> --- (In reply to David Nind from comment #143)

I'm getting this error when running the database update:

updatedatabase String found where operator expected at /kohadevbox/koha/installer/data/mysql/atomicupdate/bug_31391_- _add_RecallsInterface_syspref.pl line 1, near "rm 'installer/data/mysql/atomicupdate/bug_31391_-_add_RecallsInterface_syspref. pl'" (Do you need to predeclare rm?) DEV atomic update /kohadevbox/koha/installer/data/mysql/atomicupdate/bug_31391_- _add_HOLD_CANCELLATION-RECALLED_authorised_value.pl [03:40:12]: Bug 31391 - Staff-side recalls Added RECALLED value to HOLD_CANCELLATION authorised value category DEV atomic update /kohadevbox/koha/installer/data/mysql/atomicupdate/bug_31391_- _update_UseRecalls_syspref.pl [03:40:12]: Bug 31391 - Staff-side recalls Updated system preference 'UseRecalls' to include interface choices DEV atomic update /kohadevbox/koha/installer/data/mysql/atomicupdate/bug_31391_- _add_RecallsInterface_syspref.pl [03:40:12] ERROR: {UNKNOWN}: Can't use an undefined value as a subroutine reference at /kohadevbox/koha/C4/Installer.pm line 823. at /kohadevbox/koha/C4/Installer.pm line 825

Hi David, I have just attached a follow-up fix. Could you please let me know if that resolves this above error for you? Thanks, Alex -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 --- Comment #148 from Alex Buckley <alexbuckley@catalyst.net.nz> --- (In reply to David Nind from comment #147)

(In reply to Alex Buckley from comment #146)

...

(In reply to David Nind from comment #143)

...

I'm getting this error when running the database update:

updatedatabase String found where operator expected at /kohadevbox/koha/installer/data/mysql/atomicupdate/bug_31391_- _add_RecallsInterface_syspref.pl line 1, near "rm 'installer/data/mysql/atomicupdate/bug_31391_-_add_RecallsInterface_syspref. pl'" (Do you need to predeclare rm?) DEV atomic update /kohadevbox/koha/installer/data/mysql/atomicupdate/bug_31391_- _add_HOLD_CANCELLATION-RECALLED_authorised_value.pl [03:40:12]: Bug 31391 - Staff-side recalls Added RECALLED value to HOLD_CANCELLATION authorised value category DEV atomic update /kohadevbox/koha/installer/data/mysql/atomicupdate/bug_31391_- _update_UseRecalls_syspref.pl [03:40:12]: Bug 31391 - Staff-side recalls Updated system preference 'UseRecalls' to include interface choices DEV atomic update /kohadevbox/koha/installer/data/mysql/atomicupdate/bug_31391_- _add_RecallsInterface_syspref.pl [03:40:12] ERROR: {UNKNOWN}: Can't use an undefined value as a subroutine reference at /kohadevbox/koha/C4/Installer.pm line 823. at /kohadevbox/koha/C4/Installer.pm line 825

Hi David,

I have just attached a follow-up fix. Could you please let me know if that resolves this above error for you?

Thanks, Alex

Thanks Alex! It does resolve the error:

updatedatabase DEV atomic update /kohadevbox/koha/installer/data/mysql/atomicupdate/bug_31391_- _add_HOLD_CANCELLATION-RECALLED_authorised_value.pl [05:01:20]: Bug 31391 - Staff-side recalls Added RECALLED value to HOLD_CANCELLATION authorised value category DEV atomic update /kohadevbox/koha/installer/data/mysql/atomicupdate/bug_31391_- _update_UseRecalls_syspref.pl [05:01:20]: Bug 31391 - Staff-side recalls Updated system preference 'UseRecalls' to include interface choices

I'll try to run through the test plans again this evening and signoff.

David

Many thanks David! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 --- Comment #150 from David Nind <david@davidnind.com> --- Hi Alex. Once error encounter so far in retesting. If UseRecalls is not enabled (or if it is enabled with any of the options), if I go to place a hold on an item using the staff interface (doesn't matter if it is checked out or not), I get this error: Template process failed: file error - parse error - holds_table.inc line 82: unexpected end of directive [% IF ( Koha.Preference('UseRecalls').match('staff') %] at /kohadevbox/koha/C4/Templates.pm line 146 in C4::Templates::output at /kohadevbox/koha/C4/Templates.pm line 146 143: 144: my $data; 145: binmode( STDOUT, ":encoding(UTF-8)" ); 146: $template->process( $self->filename, $vars, \$data ) 147: || die "Template process failed: ", $template->error(); 148: return $data; 149: } Show function arguments So far placing and cancelling recalls when only OPAC allowed, when only staff interface allowed, and when both allowed seems to work okay (not fully tested yet). David -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 --- Comment #152 from Alex Buckley <alexbuckley@catalyst.net.nz> --- (In reply to David Nind from comment #150)

Hi Alex.

Once error encounter so far in retesting.

If UseRecalls is not enabled (or if it is enabled with any of the options), if I go to place a hold on an item using the staff interface (doesn't matter if it is checked out or not), I get this error:

Template process failed: file error - parse error - holds_table.inc line 82: unexpected end of directive [% IF ( Koha.Preference('UseRecalls').match('staff') %] at /kohadevbox/koha/C4/Templates.pm line 146 in C4::Templates::output at /kohadevbox/koha/C4/Templates.pm line 146 143: 144: my $data; 145: binmode( STDOUT, ":encoding(UTF-8)" ); 146: $template->process( $self->filename, $vars, \$data ) 147: || die "Template process failed: ", $template->error(); 148: return $data; 149: } Show function arguments

So far placing and cancelling recalls when only OPAC allowed, when only staff interface allowed, and when both allowed seems to work okay (not fully tested yet).

David

Thanks David. I'll aim to have a fix attached to this bug report by the end of tomorrow. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189461|0 |1 is obsolete| | --- Comment #154 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 190877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190877&action=edit Bug 31391: (follow-up) Include changed requirements of patron autocomplete, datatable Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189463|0 |1 is obsolete| | --- Comment #156 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 190879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190879&action=edit Bug 31391: (follow-up) Only skip displaying recalls in messaging preference is UseRecalls syspref is off This patch includes a fix to display the two recalls notices (PICKUP_RECALLED_ITEM and RETURN_RECALLED_ITEM) added to the members messaging preferences table by bug 23781 Now those two recalls notices are always displayed in the messaging preference form, when UseRecalls is set to: opac, staff or opac_and_staff Test plan: 1. Set the UseRecalls system preference to opac, staff or opac_and_staff 2. Confirm that the 'Return recalled item' and 'Recall awaiting pickup' rows DO NOT appear in the Member (User) messaging preferences on a patron account or when editing a category 3. Apply this patch 4. Confirm that the 'Return recalled item' and 'Recall awaiting pickup' rows DO now appear in the Member (User) messaging preferences on a patron account or when editing a category Sponsored-by: Auckland University of Technology -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 --- Comment #158 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 190881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190881&action=edit Bug 31391: (follow-up) Missing closing bracket -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 --- Comment #160 from David Nind <david@davidnind.com> --- Thanks Aleisha. I've tested, and everything in the OPAC and staff interface seems to be working fine for me. Out of curiosity, I ran the qa script: - there are some fails for tidiness, missing new line at the end of files and a couple of others - the t/db_dependent/Circulation.t tests fail -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189454|0 |1 is obsolete| | --- Comment #162 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 190967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190967&action=edit Bug 31391: Implement RecallsInterface on OPAC Signed-off-by: David <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189456|0 |1 is obsolete| | --- Comment #164 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 190969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190969&action=edit Bug 31391: (follow-up) Fix cancel recalls using checkbox Signed-off-by: David <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189458|0 |1 is obsolete| | --- Comment #166 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 190971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190971&action=edit Bug 31391: Interface and wording fixes This patch includes the following fixes: - Making the atomic updates executable - Preventing warns when running tests - Updating db updates - Fixing terminology - Make 'cancel selected recalls' button yellow - Fix HTML makeup of recalls request page - Show a warning when placing a recall if there is already a record-level hold by this patron - Show a link to mark a hold for conversion which selects the recall option on holds page - Include changes to patron search dropdown - add 'mark hold for conversion to recall' column to columns settings Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190876|0 |1 is obsolete| | --- Comment #168 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 190973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190973&action=edit Bug 31391: Update the UseRecalls system preference to have choices Options are: * off * opac * staff * opac_and_staff This patch implements this all over the place. All recalls things should still work including the above test plan. Tests should pass: * t/db_dependent/Circulation.t * t/db_dependent/Circulation/transferbook.t * t/db_dependent/Holds.t * t/db_dependent/Koha/Biblio.t * t/db_dependent/Koha/Item.t * t/db_dependent/SIP/Transaction.t * t/db_dependent/Search.t * t/db_dependent/XSLT.t Sponsored-by: Auckland University of Technology Sponsored-by: Catalyst IT Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190878|0 |1 is obsolete| | --- Comment #170 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 190975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190975&action=edit Bug 31391: (follow-up) Fix button and alert HTML classes -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190881|0 |1 is obsolete| | --- Comment #172 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 190977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190977&action=edit Bug 31391: (follow-up) Missing closing bracket -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #174 from Aleisha Amohia <aleisha@catalyst.net.nz> --- (In reply to David Nind from comment #160)

Thanks Aleisha.

I've tested, and everything in the OPAC and staff interface seems to be working fine for me.

Out of curiosity, I ran the qa script: - there are some fails for tidiness, missing new line at the end of files and a couple of others - the t/db_dependent/Circulation.t tests fail

Thanks David. I've fixed the QQA test tools failures, but still need to fix the Circulation.t test failure. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 --- Comment #176 from David Nind <david@davidnind.com> --- Thanks Aleisha! I've quickly run through the test plan again - everything looks good. Sign-off on the way. David -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190880|0 |1 is obsolete| | Attachment #190966|0 |1 is obsolete| | Attachment #190967|0 |1 is obsolete| | Attachment #190968|0 |1 is obsolete| | Attachment #190969|0 |1 is obsolete| | Attachment #190970|0 |1 is obsolete| | Attachment #190971|0 |1 is obsolete| | Attachment #190972|0 |1 is obsolete| | Attachment #190973|0 |1 is obsolete| | Attachment #190974|0 |1 is obsolete| | Attachment #190975|0 |1 is obsolete| | Attachment #190976|0 |1 is obsolete| | Attachment #190977|0 |1 is obsolete| | Attachment #190978|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.