https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 --- Comment #216 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 0) Why? After talking to a lot of academic libraries I believe that this patch set will be key to make the feature useful for many more libraries. A major blocker for these libraries is that they want staff to do the recalls, which is currently impossible, and not allow patrons in the OPAC to do so. It also includes a feature to turn a hold into a recall. All tested OK, added a small GUI follow-up. Passing QA. @RM please have a look at the follow-up and the database updates (merging/try-catch). 1) QA tests All pass OK now. This POD failure is not relevant for the patch set: [FAIL] C4/Search.pm FAIL pod_coverage sub _build_stemmed_operand has no pod coverage. sub _build_weighted_query has no pod coverage. sub _detect_truncation has no pod coverage. sub _get_facets_from_records has no pod coverage. 2) Code review A few notes about some things I spent a little more time on: a) Database updates - Atomic database updates could be combined. - I am not sure about the try/catch - we had the idea for some time to do this but I think we concluded they would not work as expected given the way we run them. b) OK UseRecalls now has 3 possible settings instead of being boolean: off, opac, staff, opac_and_staff - All occurences and checks on UseRecalls appear to have been updated. 3) Testing a) Detail page: I missed at first that you can place a recall through the tab on the left, I kept staring at the toolbar. I suggest adding a "Place recall" link there too when placing recalls in staff is allowed. --> FOLLOW-UP PATCH ADDED 4) Unrelated or small things to be adjusted separately: a) Improve messages when there are no recalls - Circulation > Recalls queue: Don't show "The following recalls could be fulfilled by available items." when there are no recalls, but just the blue alert like on the other pages. - Circulation > Old recalls: is the only page where the "no recalls" alert has a white background. - Patron account > Recalls history: also has the white background b) Staff detail page - The page title of /cgi-bin/koha/recalls/request.pl was changed from "Existing recalls" to "Place a recall", both are true sometimes. It would be nice to also check for the UseRecalls setting here. -- You are receiving this mail because: You are watching all bug changes.