https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22104 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 83815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83815&action=edit Bug 22104: Clean up patron API keys template This patch makes two corrections to the patron API key template: Convert to Bootstrap grid and correct class on "new key" button. To test, apply the patch and enable the RESTOAuth2ClientCredentials preference. - Open a patron record in the staff client and choose More -> Manage API keys. - On the API keys page, confirm that the page adjusts well at various page widths. - Confirm that the size of the "Generate new client id/key pair" button matches the buttons in the toolbar. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22104 helene <hickeyhe@wgc.school.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hickeyhe@wgc.school.nz --- Comment #2 from helene <hickeyhe@wgc.school.nz> --- Created attachment 84159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84159&action=edit API Keys page API keys page after apply the patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22104 Jack <jke0429@stacmail.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22104 Jack <jke0429@stacmail.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jke0429@stacmail.net Attachment #84160|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22104 Jack <jke0429@stacmail.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #5 from Jack <jke0429@stacmail.net> --- Accidental Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22104 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 84173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84173&action=edit Screenshot showing an added key -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22104 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #9 from David Nind <david@davidnind.com> --- My testing matches your screenshots in comment #6 and #7. However, there is some inconsistency in how the different account screens display. I can post some screenshots if you would like. When you narrow the screen width down most of the account screens leave the account information on the top left (name, address, etc), the menu items under this (Check out, Details, etc), and then content for the screen to the right. Th API key screen along with the Holds history and Modification log behave in a more responsive manner. These have the particular screen first, the account information, then the menu items. If this is what you intended (the results matching your screenshots) then I am happy to sign-off on that basis. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22104 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22104 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84232|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 84234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84234&action=edit Bug 22104: Clean up patron API keys template This patch makes two corrections to the patron API key template: Convert to Bootstrap grid and correct class on "new key" button. To test, apply the patch and enable the RESTOAuth2ClientCredentials preference. - Open a patron record in the staff client and choose More -> Manage API keys. - On the API keys page, confirm that the page adjusts well at various page widths. - Confirm that the size of the "Generate new client id/key pair" button matches the buttons in the toolbar. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22104 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement will not be backported to 18.11.x -- You are receiving this mail because: You are watching all bug changes.