[Bug 21945] New: Clean up stock rotation template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21945 Bug ID: 21945 Summary: Clean up stock rotation template Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Blocks: 14546 There are some minor markup issues with the stock rotation template under tools, including needing a Bootstrap grid upgrade. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14546 [Bug 14546] Make staff client templates responsive -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21945 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21945 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 82849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82849&action=edit Bug 21945: Clean up stock rotation template This patch makes some minor markup upgrades to the stock rotation template: Replace some YUI markup with Bootstrap; Add some missing <tr> tags; Remove invalid "type" attribute from <script> tag. To test, apply the patch and go to Tools -> Stock rotation. Confirm that the page looks correct and adjusts well at various browser widths. Test with various views: New rota, edit rota, manage stages, manage items. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21945 José-Mario Monteiro-Santos <jose-mario.monteiro-santos@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82849|0 |1 is obsolete| | --- Comment #2 from José-Mario Monteiro-Santos <jose-mario.monteiro-santos@inlibro.com> --- Created attachment 84220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84220&action=edit Bug 21945: Clean up stock rotation template This patch makes some minor markup upgrades to the stock rotation template: Replace some YUI markup with Bootstrap; Add some missing <tr> tags; Remove invalid "type" attribute from <script> tag. To test, apply the patch and go to Tools -> Stock rotation. Confirm that the page looks correct and adjusts well at various browser widths. Test with various views: New rota, edit rota, manage stages, manage items. Signed-off-by: Jose-Mario Monteiro-Santos <jose-mario.monteiro-santos@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21945 José-Mario Monteiro-Santos <jose-mario.monteiro-santos@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jose-mario.monteiro-santos@ | |inlibro.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21945 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21945 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84220|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 84235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84235&action=edit Bug 21945: Clean up stock rotation template This patch makes some minor markup upgrades to the stock rotation template: Replace some YUI markup with Bootstrap; Add some missing <tr> tags; Remove invalid "type" attribute from <script> tag. To test, apply the patch and go to Tools -> Stock rotation. Confirm that the page looks correct and adjusts well at various browser widths. Test with various views: New rota, edit rota, manage stages, manage items. Signed-off-by: Jose-Mario Monteiro-Santos <jose-mario.monteiro-santos@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21945 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21945 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for tidying this Owen :) -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org