[Bug 28796] New: wrong number of parameters in new_from_xml call
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28796 Bug ID: 28796 Summary: wrong number of parameters in new_from_xml call Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: MARC Bibliographic record staging/import Assignee: koha-bugs@lists.koha-community.org Reporter: didier.gautheron@biblibre.com QA Contact: testopia@bugs.koha-community.org Hi, It seems to me that C4/ImportBatch.pm: my $old_marc = MARC::Record->new_from_xml(StripNonXmlChars($oldxml), 'UTF-8', $rowref->{'encoding'}, $marc_type); Is calling MARC::Record->new_from_xml with the wrong number of parameters and $marc_type is ignored it should be either: MARC::Record->new_from_xml(StripNonXmlChars($oldxml), 'UTF-8', $marc_type); or: MARC::Record->new_from_xml(StripNonXmlChars($oldxml),$rowref->{'encoding'} , $marc_type); -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28796 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Yes, that's wrong, it must be $rowref->{'encoding'} , $marc_type -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28796 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|20.11 |unspecified -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28796 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #2 from Julian Maurice <julian.maurice@biblibre.com> --- I tried to import a MARCXML file encoded in ISO-8859-1. I set the correct encoding in the form but no records were imported and I have this message in logfile: bib-1.iso88591.marcxml: :15: parser error : Input is not proper UTF-8, indicate encoding ! Bytes: 0xE0 0x20 0x6D 0x6F <subfield code="a">�</subfield> The error is located in C4::ImportBatch::RecordsFromMARCXMLFile MARC::File::XML::decode seems to ignore the encoding passed in parameters. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org