https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #384 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to David Gustafsson from comment #383)

...

...

6. How does it interface with the marc modification templates when batch editing bibliographic records?

Investigating.. I have a feeling his patchset predates it and I missed this case ! :(

Sorry, never got around to have a look at this yesterday, but now did. From what I can gather from the code I'm pretty sure that if no rules have been defined for the batchmod context, the incoming record simply overwrites the existing record. If there are rules, these are applied on the record after the record has been modified using the specified template. So if the modification template modifies some protected field for example, these changes will not be applied. This is expected behavior as far as I can tell?

Tested right now: - Protect 500 - Edit bibliographic record, add new 500 field => Change not saved (OK) - Use the batch record modification tool (previously created a MARC modification template that add a 500$a => The preview show the 500$a (KO) - Save => The new field is created (KO) -- You are receiving this mail because: You are watching all bug changes.