[Bug 29856] New: Make the ES config more flexible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29856 Bug ID: 29856 Summary: Make the ES config more flexible Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: jonathan.druart+koha@gmail.com Reporter: jonathan.druart+koha@gmail.com I need to add a 'request_timeout' entry to the ES configuration to fix some timeout problems on the sandboxes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29856 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29856 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 129327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129327&action=edit Bug 29856: Make the ES config more flexible I need to add a 'request_timeout' entry to the ES configuration to fix some timeout problems on the sandboxes. Instead of hard coding this new option it seems preferable to be flexible and allow different options to be passed from the config file. Test plan: Add to the $KOHA_CONF, inside the elasticsearch section <request_timeout>60</request_timeout> Rebuild the ES index koha-elasticsearch --rebuild kohadev Change the value of the timeout to 1 Rebuild the index It should fail (with a quite bad error 'Bad response received when submitting request to Elasticsearch') -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29856 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m, tomascohen@gmail.com --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Can I get this patch pushed quickly please? It will help to fix the BibLibre's sandboxes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29856 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129327|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 129328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129328&action=edit Bug 29856: Make the ES config more flexible I need to add a 'request_timeout' entry to the ES configuration to fix some timeout problems on the sandboxes. Instead of hard coding this new option it seems preferable to be flexible and allow different options to be passed from the config file. Test plan: Add to the $KOHA_CONF, inside the elasticsearch section <request_timeout>60</request_timeout> Rebuild the ES index koha-elasticsearch --rebuild kohadev Change the value of the timeout to 1 Rebuild the index It should fail (with a quite bad error 'Bad response received when submitting request to Elasticsearch') -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29856 --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- *** Bug 29854 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29856 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129328|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 129347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129347&action=edit Bug 29856: Make the ES config more flexible I need to add a 'request_timeout' entry to the ES configuration to fix some timeout problems on the sandboxes. Instead of hard coding this new option it seems preferable to be flexible and allow different options to be passed from the config file. Test plan: Add to the $KOHA_CONF, inside the elasticsearch section <request_timeout>60</request_timeout> Rebuild the ES index koha-elasticsearch --rebuild kohadev Change the value of the timeout to 1 Rebuild the index It should fail (with a quite bad error 'Bad response received when submitting request to Elasticsearch') Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29856 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Needs Signoff |Signed Off --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This is nice and works as described. Signing off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29856 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29856 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29856 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129347|0 |1 is obsolete| | --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 129349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129349&action=edit Bug 29856: Make the ES config more flexible I need to add a 'request_timeout' entry to the ES configuration to fix some timeout problems on the sandboxes. Instead of hard coding this new option it seems preferable to be flexible and allow different options to be passed from the config file. Test plan: Add to the $KOHA_CONF, inside the elasticsearch section <request_timeout>60</request_timeout> Rebuild the ES index koha-elasticsearch --rebuild kohadev Change the value of the timeout to 1 Rebuild the index It should fail (with a quite bad error 'Bad response received when submitting request to Elasticsearch') Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29856 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- FTR: It seems Search::Elasticsearch doesn't break on weird/invalid configurations passed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29856 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29856 --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29856 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org