[Bug 29491] New: Improve display of notices in patron details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29491 Bug ID: 29491 Summary: Improve display of notices in patron details Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org The display of notices in a patrons record could be improved.. the display box seems to be unnecessarily narrow and I can't tell if HTML formatting is being fully applied. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29491 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson@bedfordtx.g | |ov --- Comment #1 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- Increasing the width of the display box would be helpful. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29491 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29491 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29491 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 127740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127740&action=edit Bug 29491: Improve display of notices in patron details This patch updates the patron notices list so that notices are shown in a modal dialog instead of inline in the table. The "Resend" button is shown in the modal window controls. To test, apply the patch and locate a patron in the staff interface with multiple sent notices. - View the patron's "Notices" tab. - In the table of notices, click one of the notice titles. - A modal window should appear with the notice subject as the header and the notice content in the main body of the modal. - If the message has any other status than 'pending' there should be a "Resend" button in the modal footer. Confirm that it submits the form and resends the correct message. - Try viewing multiple notices to confirm that the contents of the modal are correctly updated for each message. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29491 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Sorry Owen.. I get sha1 issues trying to apply this patch :( -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29491 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127740|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 127741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127741&action=edit Bug 29491: (preparatory step) Reindent template Step 1: Replace tabs with spaces and reindent. This patch should include only whitespace changes. If you view the diff while ignoring whitespace there should be no changes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29491 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 127742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127742&action=edit Bug 29491: Improve display of notices in patron details This patch updates the patron notices list so that notices are shown in a modal dialog instead of inline in the table. The "Resend" button is shown in the modal window controls. To test, apply the patch and locate a patron in the staff interface with multiple sent notices. - View the patron's "Notices" tab. - In the table of notices, click one of the notice titles. - A modal window should appear with the notice subject as the header and the notice content in the main body of the modal. - If the message has any other status than 'pending' there should be a "Resend" button in the modal footer. Confirm that it submits the form and resends the correct message. - Try viewing multiple notices to confirm that the contents of the modal are correctly updated for each message. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29491 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127741|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127775&action=edit Bug 29491: (preparatory step) Reindent template Step 1: Replace tabs with spaces and reindent. This patch should include only whitespace changes. If you view the diff while ignoring whitespace there should be no changes. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29491 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127742|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127776&action=edit Bug 29491: Improve display of notices in patron details This patch updates the patron notices list so that notices are shown in a modal dialog instead of inline in the table. The "Resend" button is shown in the modal window controls. To test, apply the patch and locate a patron in the staff interface with multiple sent notices. - View the patron's "Notices" tab. - In the table of notices, click one of the notice titles. - A modal window should appear with the notice subject as the header and the notice content in the main body of the modal. - If the message has any other status than 'pending' there should be a "Resend" button in the modal footer. Confirm that it submits the form and resends the correct message. - Try viewing multiple notices to confirm that the contents of the modal are correctly updated for each message. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29491 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This is an excellent improvement, thanks Owen! Signing off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29491 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29491 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127775|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 128468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128468&action=edit Bug 29491: (preparatory step) Reindent template Step 1: Replace tabs with spaces and reindent. This patch should include only whitespace changes. If you view the diff while ignoring whitespace there should be no changes. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29491 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127776|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 128469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128469&action=edit Bug 29491: Improve display of notices in patron details This patch updates the patron notices list so that notices are shown in a modal dialog instead of inline in the table. The "Resend" button is shown in the modal window controls. To test, apply the patch and locate a patron in the staff interface with multiple sent notices. - View the patron's "Notices" tab. - In the table of notices, click one of the notice titles. - A modal window should appear with the notice subject as the header and the notice content in the main body of the modal. - If the message has any other status than 'pending' there should be a "Resend" button in the modal footer. Confirm that it submits the form and resends the correct message. - Try viewing multiple notices to confirm that the contents of the modal are correctly updated for each message. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29491 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29491 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | Text to go in the| |In patron notices table, release notes| |notices are now shown in a | |modal dialog instead of | |inline in the table. | |The | |"Resend" button is shown in | |the modal window controls. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29491 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29491 --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29491 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |kyle@bywatersolutions.com Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org