https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17208 --- Comment #1 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Hit enter too early. At the moment, you can attempt to create sources and filing rules using codes that already exist, and you receive a message saying that the new source or filing rule was created, however it isn't actually added to the database (as the codes must be unique), so it doesn't work. There should be some kind of check upon submission of the form that checks if the code already exists (like the check of a barcode before creating a new item). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17208 --- Comment #2 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 57878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57878&action=edit Bug 17208: Checking if classification source or filing rule already exists before adding To test: 1) Go to Admin -> Classification sources 2) Attempt to reproduce bug before applying patch. Notice the message saying the add was successful, but was not added to the table 3) Apply patch and refresh page (restart plack if necessary) 4) Add new classification source with same code as existing one. Notice you are now told that the add failed. 5) Confirm adding new classification source with unique code works 6) Add new classification filing rule with same code as existing one. Notice you are told that add failed. 7) Confirm adding new classification filing rule with unique code works Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17208 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17208 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17208 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58237|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 58315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58315&action=edit Bug 17208: Checking if classification source or filing rule already exists before adding To test: 1) Go to Admin -> Classification sources 2) Attempt to reproduce bug before applying patch. Notice the message saying the add was successful, but was not added to the table 3) Apply patch and refresh page (restart plack if necessary) 4) Add new classification source with same code as existing one. Notice you are now told that the add failed. 5) Confirm adding new classification source with unique code works 6) Add new classification filing rule with same code as existing one. Notice you are told that add failed. 7) Confirm adding new classification filing rule with unique code works Sponsored-by: Catalyst IT Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> This is not the way to go, we should use an eval instead. But since we do not have RaiseError set, it will not work. This module will need to be moved to Koha::Objects to be implemented correctly. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17208 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |katrin.fischer@bsz-bw.de Status|Pushed to Master |RESOLVED --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes.