[Bug 17398] New: Enhance circulation message UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17398 Bug ID: 17398 Summary: Enhance circulation message UI Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: josef.moravec@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17398 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |josef.moravec@gmail.com |ity.org | Depends on| |17397 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17397 [Bug 17397] Show name of librarian who created circulation message -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17398 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17398 --- Comment #1 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 56031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56031&action=edit Bug 17398: Enhance circulation messages UI Test plan: 1) Apply patch 2) Add same circulation messages, note that both buttons are in bootstrap style and the whole form is a bit cleaner 3) Confirm that adding works as expected 4) Try to delete some of your messages, note the delete link is also button now 5) Confirm that deleting works as expected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17398 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56031|0 |1 is obsolete| | --- Comment #2 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 56047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56047&action=edit Bug 17398: Enhance circulation messages UI Test plan: 1) Apply patch 2) Add same circulation messages, note that both buttons are in bootstrap style and the whole form is a bit cleaner 3) Confirm that adding works as expected 4) Try to delete some of your messages, note the delete link is also button now 5) Confirm that deleting works as expected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17398 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56047|0 |1 is obsolete| | --- Comment #3 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 56050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56050&action=edit Bug 17398: Enhance circulation messages UI Test plan: 1) Apply patch 2) Add same circulation messages, note that both buttons are in bootstrap style and the whole form is a bit cleaner 3) Confirm that adding works as expected 4) Try to delete some of your messages, note the delete link is also button now 5) Confirm that deleting works as expected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17398 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- I get this error on the circulation page after applying this patch: DBIx::Class::ResultSource::_resolve_join(): No such relationship manager on Message at kohaclone/Koha/Objects.pm line 168 Have I missed a step in the test plan? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17398 --- Comment #5 from Josef Moravec <josef.moravec@gmail.com> --- You will need to apply 17397 first and also update db structure and update dbix class files. Sorry to not mention it here... I'll add a schema change to 17397... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17398 Radek Šiman (R-Bit Technology, s.r.o.) <rbit@rbit.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rbit@rbit.cz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17398 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56050|0 |1 is obsolete| | --- Comment #6 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 57216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57216&action=edit Bug 17398: Enhance circulation messages UI Test plan: 1) Apply patch 2) Add same circulation messages, note that both buttons are in bootstrap style and the whole form is a bit cleaner 3) Confirm that adding works as expected 4) Try to delete some of your messages, note the delete link is also button now 5) Confirm that deleting works as expected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17398 --- Comment #7 from Josef Moravec <josef.moravec@gmail.com> --- Bug 17397 is in master now I've rebased on master (especially because Bug 17365) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17398 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Bug 17397 introduced a stray closing bracket to the markup on line 859 of circulation.tt: + [% END %]> I wonder if this patch should include the fix? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17398 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57216|0 |1 is obsolete| | --- Comment #9 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 57391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57391&action=edit Bug 17398: Enhance circulation messages UI Test plan: 1) Apply patch 2) Add same circulation messages, note that both buttons are in bootstrap style and the whole form is a bit cleaner 3) Confirm that adding works as expected 4) Try to delete some of your messages, note the delete link is also button now 5) Confirm that deleting works as expected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17398 --- Comment #10 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Owen Leonard from comment #8)
Bug 17397 introduced a stray closing bracket to the markup on line 859 of circulation.tt:
+ [% END %]>
I wonder if this patch should include the fix?
Good catch, thanks. I've fixed it and updated the patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17398 --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- I like that this patch simplifies the modal view. I disagree that the "Delete" link should be converted to a button. It doesn't occur very often in the interface, but I think the more common pattern is to use links for actions which are "inline," or part of a line of text. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17398 --- Comment #12 from Josef Moravec <josef.moravec@gmail.com> --- Thanks for testing! I just followed the changes which were made on pay links in circulation by bug 16810, but as I see, it was a bit by accident... I have no strong opinion to make delete link a button... But I don't like the link to be in square brackets... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17398 --- Comment #13 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Josef Moravec from comment #12)
I have no strong opinion to make delete link a button... But I don't like the link to be in square brackets...
I agree. The brackets were more necessary before the link had an icon associated with it. We should look into adapting the btn-link class (after Bug 16239 probably) to work in instances like this so that the icon and link text don't wrap separately. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17398 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57391|0 |1 is obsolete| | --- Comment #14 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 57408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57408&action=edit Bug 17398: Enhance circulation messages UI Test plan: 1) Apply patch 2) Add same circulation messages, note that both buttons are in bootstrap style and the whole form is a bit cleaner 3) Confirm that adding works as expected 4) Try to delete some of your messages, note the delete link is also button now 5) Confirm that deleting works as expected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17398 --- Comment #15 from Josef Moravec <josef.moravec@gmail.com> --- I did just remove btn class from delete link and make it a bit larger to size btn-small... this approach is taken from advanced search toolbar, as it will be changed to btn-link by 16239 (as it does with the links in advanced search toolbar) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17398 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57408|0 |1 is obsolete| | --- Comment #16 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 57409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57409&action=edit Bug 17398: Enhance circulation messages UI Test plan: 1) Apply patch 2) Add same circulation messages, note that both buttons are in bootstrap style and the whole form is a bit cleaner 3) Confirm that adding works as expected 4) Try to delete some of your messages, note the delete link is also button now 5) Confirm that deleting works as expected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17398 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16239 CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17398 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57409|0 |1 is obsolete| | --- Comment #17 from Marc Véron <veron@veron.ch> --- Created attachment 58240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58240&action=edit Bug 17398: Enhance circulation messages UI Test plan: 1) Apply patch 2) Add same circulation messages, note that both buttons are in bootstrap style and the whole form is a bit cleaner 3) Confirm that adding works as expected 4) Try to delete some of your messages, note the delete link is also button now 5) Confirm that deleting works as expected Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17398 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17398 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17398 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58240|0 |1 is obsolete| | --- Comment #18 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 58306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58306&action=edit Bug 17398: Enhance circulation messages UI Test plan: 1) Apply patch 2) Add same circulation messages, note that both buttons are in bootstrap style and the whole form is a bit cleaner 3) Confirm that adding works as expected 4) Try to delete some of your messages, note the delete link is also button now 5) Confirm that deleting works as expected Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17398 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #19 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Josef! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17398 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org