[Bug 37623] New: t/db_dependent/Letters.t tests fail to consider EmailFieldPrimary syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37623 Bug ID: 37623 Summary: t/db_dependent/Letters.t tests fail to consider EmailFieldPrimary syspref Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: aleisha@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org The tests in t/db_dependent/Letters.t fail if EmailFieldPrimary is set to anything OTHER than: * primary email * first valid email address -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37623 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33192 Change sponsored?|--- |Sponsored Assignee|chris@bigballofwax.co.nz |aleisha@catalyst.net.nz Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33192 [Bug 33192] We should rename 'AutoEmailPrimaryAddress' to 'EmailFieldPrimary' for clarification -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37623 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37623 --- Comment #1 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 170251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170251&action=edit Bug 37623: Make t/db_dependent/Letters.t idempotent The tests should be unaffected by system preference settings, such as EmailFieldPrimary. To test: 1. Log into the staff interface 2. Go to Koha Administration -> Global system preferences, and search for EmailFieldPrimary 3. Change the EmailFieldPrimary preference to something other than 'primary email' and 'first valid email address', i.e. any of the following: * alternate email * card number * secondary email * selected addresses 4. Run tests t/db_dependent/Letters.t and notice they fail 5. Apply the patch 6. Run the tests again t/db_dependent/Letters.t with different settings of EmailFieldPrimary. The tests should always pass. Sponsored-by: Pymble Ladies' College -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37623 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37598 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37598 [Bug 37598] Ability to use the BCC field for sending notices to multiple addresses, rather than the To field -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37623 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37623 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170251|0 |1 is obsolete| | --- Comment #2 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 170410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170410&action=edit Bug 37623: Make t/db_dependent/Letters.t idempotent The tests should be unaffected by system preference settings, such as EmailFieldPrimary. To test: 1. Log into the staff interface 2. Go to Koha Administration -> Global system preferences, and search for EmailFieldPrimary 3. Change the EmailFieldPrimary preference to something other than 'primary email' and 'first valid email address', i.e. any of the following: * alternate email * card number * secondary email * selected addresses 4. Run tests t/db_dependent/Letters.t and notice they fail 5. Apply the patch 6. Run the tests again t/db_dependent/Letters.t with different settings of EmailFieldPrimary. The tests should always pass. Sponsored-by: Pymble Ladies' College Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37623 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37623 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170410|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 170423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170423&action=edit Bug 37623: Make t/db_dependent/Letters.t idempotent The tests should be unaffected by system preference settings, such as EmailFieldPrimary. To test: 1. Log into the staff interface 2. Go to Koha Administration -> Global system preferences, and search for EmailFieldPrimary 3. Change the EmailFieldPrimary preference to something other than 'primary email' and 'first valid email address', i.e. any of the following: * alternate email * card number * secondary email * selected addresses 4. Run tests t/db_dependent/Letters.t and notice they fail 5. Apply the patch 6. Run the tests again t/db_dependent/Letters.t with different settings of EmailFieldPrimary. The tests should always pass. Sponsored-by: Pymble Ladies' College Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37623 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37623 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|t/db_dependent/Letters.t |t/db_dependent/Letters.t |tests fail to consider |tests fails to consider |EmailFieldPrimary syspref |EmailFieldPrimary system | |preference -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37623 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37623 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37623 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable CC| |lucas@bywatersolutions.com Version(s)|24.11.00 |24.11.00,24.05.04 released in| | --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37623 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|24.11.00,24.05.04 |24.11.00,24.05.04,23.11.10 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37623 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #7 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 23.05.x unless requested -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37623 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #8 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org