[Bug 17704] New: OAI-PMH compatiblity with Ubuntu Xenial and Debian Stretch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 Bug ID: 17704 Summary: OAI-PMH compatiblity with Ubuntu Xenial and Debian Stretch Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Web services Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org Actually OAI-PMH in Koha uses HTTP::OAI lib from version in Jessie 3.27. This module is not compatible with version 4.03 which is in Ubuntu Xenial and Debian Stretch. You get the error : Can't call method "start_element" on an undefined value at /usr/share/perl5/HTTP/OAI/Response.pm line 114 This is because the method HTTP::OAI::Response::generate() has changed, it needs an argument $driver. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 --- Comment #1 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- See https://packages.debian.org/search?searchon=names&keywords=libhttp-oai-perl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko@abunchofthings.net --- Comment #2 from Mirko Tietgen <mirko@abunchofthings.net> --- Related: https://lists.katipo.co.nz/public/koha/2016-April/045226.html https://rt.cpan.org/Public/Bug/Display.html?id=102010#txn-1569001 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 --- Comment #3 from Josef Moravec <josef.moravec@gmail.com> --- *** Bug 19732 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|OAI-PMH compatiblity with |Fix OAI breakage when using |Ubuntu Xenial and Debian |HTTP::OAI 4.03+ |Stretch | CC| |tomascohen@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- [Koha-devel] State of HTTP::OAI versions http://lists.koha-community.org/pipermail/koha-devel/2018-February/044302.ht... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://github.com/LibreCat | |/perl-oai-lib/issues/4 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 --- Comment #5 from Mirko Tietgen <mirko@abunchofthings.net> --- I have uploaded libhttp-oai-perl_4.06-1~koha1_all.deb to the unstable repository. Does that help? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Mirko Tietgen from comment #5)
I have uploaded libhttp-oai-perl_4.06-1~koha1_all.deb to the unstable repository. Does that help?
Better wait we solve some issues. I'm in talks with the maintainer to fix some standing issues. The fix for xslt is oh their repo but there hasn't been a release yet. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 --- Comment #7 from Mirko Tietgen <mirko@abunchofthings.net> --- Ok, I have removed the file again. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20437 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ere.maijala@helsinki.fi -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 75331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75331&action=edit Bug 17704: Adapt Koha::OAI::* to the new HTTP::OAI api This is my attempt to adapt the existing implementation to the new version of the HTTP::OAI lib. Currently 4.06 is released, but 4.07 should be used once released, as it contains the fix for the ->xslt method missing. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 --- Comment #9 from Mirko Tietgen <mirko@abunchofthings.net> --- 1. Is this backwards compatible to 3.27? 2. Does it obsolete Bug 20437? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Mirko Tietgen from comment #9)
1. Is this backwards compatible to 3.27?
No.
2. Does it obsolete Bug 20437?
Absolutely not. This is WIP and is not functional. I just dropped the code for other to take over. If we make it work, we will still need a new version of HTTP::OAI released (with the fixes for xslt and maybe others) and package it for older distros. So no. This is not production ready at all. And 18.05 should use 3.27, and I'd say supported stable releases of Koha too, to support Stretch and newer Ubuntus. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20800 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 Narcis Garcia <informatica@actiu.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |informatica@actiu.net -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 --- Comment #11 from Ere Maijala <ere.maijala@helsinki.fi> --- Looks like HTTP::OAI 4.07 is now released. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #12 from David Cook <dcook@prosentient.com.au> --- (In reply to Ere Maijala (away 13Jul-30Aug) from comment #11)
Looks like HTTP::OAI 4.07 is now released.
I tried 4.10 today and it still doesn't work. #NOTE: I think this one is related to a customization I did so maybe ignore it /cgi-bin/koha/oai.pl?verb=Identify Can't locate object method "requestURL" via package "Koha::OAI::Server::Identify" at .../lib/Koha/OAI/Server/Repository.pm line 170 This one should be relevant though: Can't call method "processing_instruction" on an undefined value at /usr/local/share/perl/5.28.1/HTTP/OAI/Response.pm line 115 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 --- Comment #13 from David Cook <dcook@prosentient.com.au> --- As Tomas mentioned in https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704#c8, we have to update our usage of HTTP::OAI in Koha in order to use newer versions, and when we do use a newer version, it'll need to be > 4.07. Note: It's not enough to just use 4.07. I can prove that Koha master will fail with 4.10 in koha-testing-docker: 1) cpanm HTTP::OAI This should install 4.10 2) restart_all 3) Enable OAI-PMH at http://localhost:8081/cgi-bin/koha/admin/preferences.pl 4) Go to http://localhost:8080/cgi-bin/koha/oai.pl 5) Note "Internal Server Error" in the browser 6) Note "Can't call method "processing_instruction" on an undefined value at /usr/local/share/perl/5.24.1/HTTP/OAI/Response.pm line 115." in plack-error.log -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 --- Comment #14 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #12)
Can't call method "processing_instruction" on an undefined value at /usr/local/share/perl/5.28.1/HTTP/OAI/Response.pm line 115
HTTP::OAI::Response::generate() used in Koha/OAI/Server/Repository.pm requires a $driver argument in 4.10 (and 4.07)... So some type of patch is needed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 --- Comment #15 from David Cook <dcook@prosentient.com.au> --- (In reply to Tomás Cohen Arazi from comment #10)
This is WIP and is not functional. I just dropped the code for other to take over.
Ok, I'll make a note to myself to take a look at this again. It looks like you're probably nearly there? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 --- Comment #16 from David Cook <dcook@prosentient.com.au> --- Created attachment 107214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107214&action=edit Bug 17704: Enable ->xslt method (must use HTTP::OAI >= 4.07) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75331|0 |1 is obsolete| | --- Comment #17 from David Cook <dcook@prosentient.com.au> --- Created attachment 107215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107215&action=edit Bug 17704: Adapt Koha::OAI::* to the new HTTP::OAI api This is my attempt to adapt the existing implementation to the new version of the HTTP::OAI lib. Currently 4.06 is released, but 4.07 should be used once released, as it contains the fix for the ->xslt method missing. Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107214|0 |1 is obsolete| | --- Comment #18 from David Cook <dcook@prosentient.com.au> --- Created attachment 107216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107216&action=edit Bug 17704: Enable ->xslt method (must use HTTP::OAI >= 4.07) Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #19 from David Cook <dcook@prosentient.com.au> --- Putting this one to "In Discussion" instead of "Signed off" for the moment, since we need to handle the HTTP::OAI dependency first before we make changes to this code... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 --- Comment #20 from David Cook <dcook@prosentient.com.au> --- Comment on attachment 75331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75331 Bug 17704: Adapt Koha::OAI::* to the new HTTP::OAI api Review of attachment 75331: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17704&attachment=75331) ----------------------------------------------------------------- ::: Koha/OAI/Server/Repository.pm @@ +152,5 @@
+ Handler => my $builder = XML::LibXML::SAX::Builder->new() + ); + + $self->{ driver } = $driver; + $self->{ builder } = $builder;
Tomas, did you put driver and builder here for a specific purpose? I'm guessing for testing purposes? I don't see any functional reason otherwise? @@ +156,5 @@
+ $self->{ builder } = $builder; + + $driver->start_oai_pmh(); + + $response->set_handler($w);
I don't understand the purpose of this, but I noticed it in the HTTP::OAI::Repository example, so I imagine it must be necessary. I find HTTP::OAI to be an unnecessarily arcane library, and since it's just a couple lines here, it's probably not worth taking the time to interrogate it too closely... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 Londhe A <iamalon1434@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major CC| |iamalon1434@gmail.com Priority|P5 - low |P3 --- Comment #21 from Londhe A <iamalon1434@gmail.com> --- (In reply to David Cook from comment #18)
Created attachment 107216 [details] [review] Bug 17704: Enable ->xslt method (must use HTTP::OAI >= 4.07)
Signed-off-by: David Cook <dcook@prosentient.com.au>
I am getting same error, <pre>Can't call method "processing_instruction" on an undefined value at /usr/local/share/perl/5.30.0/HTTP/OAI/Response.pm line 115. koha version 20.11.12 HTTP::OAI 4.11 to add this patch in my file there is no lines like this : $response->set_handler($w); #$response->xslt( "/opac-tmpl/xslt/OAI.xslt" ); $response->generate($driver); lines in my file (Koha/OAI/Server/Repository.pm): $response->set_handler( XML::SAX::Writer->new( Output => *STDOUT ) ); $response->xslt( "/opac-tmpl/xslt/OAI.xslt" ); $response->generate; bless $self, $class; return $self; -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 --- Comment #22 from David Cook <dcook@prosentient.com.au> --- We should probably do a patch for this at some point so that we don't have to package the older HTTP::OAI modules. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 --- Comment #23 from Mason James <mtj@kohaaloha.com> --- Created attachment 141762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141762&action=edit Bug 17704: Fix OAI breakage when using HTTP::OAI 4.03+ bump version in cpanfile, and remove from debian/list-deps (no test plan) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 --- Comment #24 from Mason James <mtj@kohaaloha.com> --- (In reply to David Cook from comment #22)
We should probably do a patch for this at some point so that we don't have to package the older HTTP::OAI modules.
patch is tested as working for me using HTTP::OAI 4.11 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 --- Comment #25 from Mason James <mtj@kohaaloha.com> --- Created attachment 141763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141763&action=edit pic -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141762|0 |1 is obsolete| | --- Comment #26 from Mason James <mtj@kohaaloha.com> --- Created attachment 141764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141764&action=edit Bug 17704: Enable ->xslt method (must use HTTP::OAI >= 4.07) Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: Mason James <mtj@kohaaloha.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 --- Comment #27 from Mason James <mtj@kohaaloha.com> --- Created attachment 141765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141765&action=edit Bug 17704: Bump version in cpanfile -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107215|0 |1 is obsolete| | Attachment #107216|0 |1 is obsolete| | --- Comment #28 from Mason James <mtj@kohaaloha.com> --- Created attachment 141766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141766&action=edit Bug 17704: Adapt Koha::OAI::* to the new HTTP::OAI api This is my attempt to adapt the existing implementation to the new version of the HTTP::OAI lib. Currently 4.06 is released, but 4.07 should be used once released, as it contains the fix for the ->xslt method missing. Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: Mason James <mtj@kohaaloha.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |dcook@prosentient.com.au |ity.org | --- Comment #29 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 3 patches, 3 different authors, picking first. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #30 from Kyle M Hall <kyle@bywatersolutions.com> --- Applying: Bug 17704: Enable ->xslt method (must use HTTP::OAI >= 4.07) error: sha1 information is lacking or useless (Koha/OAI/Server/Repository.pm). error: could not build fake ancestor Patch failed at 0001 Bug 17704: Enable ->xslt method (must use HTTP::OAI >= 4.07) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 --- Comment #31 from Mason James <mtj@kohaaloha.com> --- Created attachment 146457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146457&action=edit Bug 17704: Adapt Koha::OAI::* to the new HTTP::OAI api This is my attempt to adapt the existing implementation to the new version of the HTTP::OAI lib. Currently 4.06 is released, but 4.07 should be used once released, as it contains the fix for the ->xslt method missing. Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: Mason James <mtj@kohaaloha.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141764|0 |1 is obsolete| | --- Comment #32 from Mason James <mtj@kohaaloha.com> --- Created attachment 146458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146458&action=edit Bug 17704: Enable ->xslt method (must use HTTP::OAI >= 4.07) Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: Mason James <mtj@kohaaloha.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141765|0 |1 is obsolete| | --- Comment #33 from Mason James <mtj@kohaaloha.com> --- Created attachment 146459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146459&action=edit Bug 17704: Bump version in cpanfile Signed-off-by: Mason James <mtj@kohaaloha.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141766|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 --- Comment #34 from Mason James <mtj@kohaaloha.com> --- (In reply to Kyle M Hall from comment #30)
Applying: Bug 17704: Enable ->xslt method (must use HTTP::OAI >= 4.07) error: sha1 information is lacking or useless (Koha/OAI/Server/Repository.pm). error: could not build fake ancestor Patch failed at 0001 Bug 17704: Enable ->xslt method (must use HTTP::OAI >= 4.07)
oops, the order of the 3 patches got mixed up i've uploaded them again in the correct order ----------------------------------------- mason@xen1:~/g/k/m$ git log | head -1 commit 6ac569453b4b66dac7e221a4244869ca3cee3268 mason@xen1:~/g/k/m$ git gz apply -s 17704 fatal: Resolve operation not in progress, we are not resuming. fatal: No rebase in progress? Bug 17704 - Fix OAI breakage when using HTTP::OAI 4.03+ 146457 - Bug 17704: Adapt Koha::OAI::* to the new HTTP::OAI api 146458 - Bug 17704: Enable ->xslt method (must use HTTP::OAI >= 4.07) 146459 - Bug 17704: Bump version in cpanfile Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 17704: Adapt Koha::OAI::* to the new HTTP::OAI api Applying: Bug 17704: Enable ->xslt method (must use HTTP::OAI >= 4.07) Applying: Bug 17704: Bump version in cpanfile -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 --- Comment #35 from Mason James <mtj@kohaaloha.com> ---
----------------------------------------- mason@xen1:~/g/k/m$ git log | head -1 commit 6ac569453b4b66dac7e221a4244869ca3cee3268
oops, typo thats... mason@xen1:~/g/k/m$ git log | head -1 commit 32258f82b5dd6a2bef3faedf06211eaf674f674c -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #36 from Kyle M Hall <kyle@bywatersolutions.com> --- Unit test failures. Please let me know if it just that I'm doing something wrong. I install HTTP::OAI 4.12 before running the tests. t/db_dependent/OAI/Server.t ... 13/34 # Failed test 'ListMetadataFormats' # at t/db_dependent/OAI/Server.t line 184. # Comparing hash keys of $data # Missing: 'request' # PARAM:--- # verb: ListMetadataFormats # EXPECTED:--- # ListMetadataFormats: # metadataFormat: # - metadataNamespace: http://www.openarchives.org/OAI/2.0/oai_dc/ # metadataPrefix: oai_dc # schema: http://www.openarchives.org/OAI/2.0/oai_dc.xsd # - metadataNamespace: http://www.loc.gov/MARC21/slim http://www.loc.gov/standards/marcxml/schema/MARC21slim # metadataPrefix: marc21 # schema: http://www.loc.gov/standards/marcxml/schema/MARC21slim.xsd # - metadataNamespace: http://www.loc.gov/MARC21/slim http://www.loc.gov/standards/marcxml/schema/MARC21slim # metadataPrefix: marcxml # schema: http://www.loc.gov/standards/marcxml/schema/MARC21slim.xsd # request: http://localhost # xmlns: http://www.openarchives.org/OAI/2.0/ # xmlns:xsi: http://www.w3.org/2001/XMLSchema-instance # xsi:schemaLocation: http://www.openarchives.org/OAI/2.0/ http://www.openarchives.org/OAI/2.0/OAI-PMH.xsd # RESPONSE:--- # ListMetadataFormats: # metadataFormat: # - metadataNamespace: http://www.openarchives.org/OAI/2.0/oai_dc/ # metadataPrefix: oai_dc # schema: http://www.openarchives.org/OAI/2.0/oai_dc.xsd # - metadataNamespace: http://www.loc.gov/MARC21/slim http://www.loc.gov/standards/marcxml/schema/MARC21slim # metadataPrefix: marc21 # schema: http://www.loc.gov/standards/marcxml/schema/MARC21slim.xsd # - metadataNamespace: http://www.loc.gov/MARC21/slim http://www.loc.gov/standards/marcxml/schema/MARC21slim # metadataPrefix: marcxml # schema: http://www.loc.gov/standards/marcxml/schema/MARC21slim.xsd # xmlns: http://www.openarchives.org/OAI/2.0/ # xmlns:xsi: http://www.w3.org/2001/XMLSchema-instance # xsi:schemaLocation: http://www.openarchives.org/OAI/2.0/ http://www.openarchives.org/OAI/2.0/OAI-PMH.xsd # Failed test 'ListIdentifiers without metadataPrefix' # at t/db_dependent/OAI/Server.t line 184. # Comparing hash keys of $data # Missing: 'error', 'request' # PARAM:--- # verb: ListIdentifiers # EXPECTED:--- # error: # code: badArgument # content: Required argument 'metadataPrefix' was undefined # request: http://localhost # xmlns: http://www.openarchives.org/OAI/2.0/ # xmlns:xsi: http://www.w3.org/2001/XMLSchema-instance # xsi:schemaLocation: http://www.openarchives.org/OAI/2.0/ http://www.openarchives.org/OAI/2.0/OAI-PMH.xsd # RESPONSE:--- # xmlns: http://www.openarchives.org/OAI/2.0/ # xmlns:xsi: http://www.w3.org/2001/XMLSchema-instance # xsi:schemaLocation: http://www.openarchives.org/OAI/2.0/ http://www.openarchives.org/OAI/2.0/OAI-PMH.xsd # Failed test 'ListIdentifiers' # at t/db_dependent/OAI/Server.t line 184. # Comparing hash keys of $data # Missing: 'request' # PARAM:--- # metadataPrefix: marcxml # verb: ListIdentifiers # EXPECTED:--- # ListIdentifiers: # header: # - datestamp: 2023-03-10T13:04:26Z # identifier: TEST:483 # - datestamp: 2023-03-10T13:04:26Z # identifier: TEST:484 # - datestamp: 2023-03-10T13:04:26Z # identifier: TEST:485 # resumptionToken: # content: !!perl/hash:Test::Deep::Regexp # val: !!perl/regexp (?^u:^marcxml/3////0/0/\d+$) # cursor: 3 # request: http://localhost # xmlns: http://www.openarchives.org/OAI/2.0/ # xmlns:xsi: http://www.w3.org/2001/XMLSchema-instance # xsi:schemaLocation: http://www.openarchives.org/OAI/2.0/ http://www.openarchives.org/OAI/2.0/OAI-PMH.xsd # RESPONSE:--- # ListIdentifiers: # header: # - datestamp: 2023-03-10T13:04:26Z # identifier: TEST:483 # - datestamp: 2023-03-10T13:04:26Z # identifier: TEST:484 # - datestamp: 2023-03-10T13:04:26Z # identifier: TEST:485 # resumptionToken: # content: marcxml/3////0/0/486 # cursor: '3' # xmlns: http://www.openarchives.org/OAI/2.0/ # xmlns:xsi: http://www.w3.org/2001/XMLSchema-instance # xsi:schemaLocation: http://www.openarchives.org/OAI/2.0/ http://www.openarchives.org/OAI/2.0/OAI-PMH.xsd # Failed test 'ListIdentifiers' # at t/db_dependent/OAI/Server.t line 184. # Comparing hash keys of $data # Missing: 'request' # PARAM:--- # metadataPrefix: marcxml # verb: ListIdentifiers # EXPECTED:--- # ListIdentifiers: # header: # - datestamp: 2023-03-10T13:04:26Z # identifier: TEST:483 # - datestamp: 2023-03-10T13:04:26Z # identifier: TEST:484 # - datestamp: 2023-03-10T13:04:26Z # identifier: TEST:485 # resumptionToken: # content: !!perl/hash:Test::Deep::Regexp # val: !!perl/regexp (?^u:^marcxml/3////0/0/\d+$) # cursor: 3 # request: http://localhost # xmlns: http://www.openarchives.org/OAI/2.0/ # xmlns:xsi: http://www.w3.org/2001/XMLSchema-instance # xsi:schemaLocation: http://www.openarchives.org/OAI/2.0/ http://www.openarchives.org/OAI/2.0/OAI-PMH.xsd # RESPONSE:--- # ListIdentifiers: # header: # - datestamp: 2023-03-10T13:04:26Z # identifier: TEST:483 # - datestamp: 2023-03-10T13:04:26Z # identifier: TEST:484 # - datestamp: 2023-03-10T13:04:26Z # identifier: TEST:485 # resumptionToken: # content: marcxml/3////0/0/486 # cursor: '3' # xmlns: http://www.openarchives.org/OAI/2.0/ # xmlns:xsi: http://www.w3.org/2001/XMLSchema-instance # xsi:schemaLocation: http://www.openarchives.org/OAI/2.0/ http://www.openarchives.org/OAI/2.0/OAI-PMH.xsd # Failed test 'ListIdentifiers with resumptionToken 1' # at t/db_dependent/OAI/Server.t line 184. # Comparing hash keys of $data # Missing: 'request' # PARAM:--- # resumptionToken: marcxml/3/1970-01-01T00:00:00Z/2023-03-10T23:59:59Z//0/0/486 # verb: ListIdentifiers # EXPECTED:--- # ListIdentifiers: # header: # - datestamp: 2023-03-10T13:04:26Z # identifier: TEST:486 # - datestamp: 2023-03-10T13:04:26Z # identifier: TEST:487 # - datestamp: 2023-03-10T13:04:26Z # identifier: TEST:488 # resumptionToken: # content: !!perl/hash:Test::Deep::Regexp # val: !!perl/regexp (?^u:^marcxml/6/1970-01-01T00:00:00Z/2023-03-10T23:59:59Z//0/0/\d+$) # cursor: 6 # request: http://localhost # xmlns: http://www.openarchives.org/OAI/2.0/ # xmlns:xsi: http://www.w3.org/2001/XMLSchema-instance # xsi:schemaLocation: http://www.openarchives.org/OAI/2.0/ http://www.openarchives.org/OAI/2.0/OAI-PMH.xsd # RESPONSE:--- # ListIdentifiers: # header: # - datestamp: 2023-03-10T13:04:26Z # identifier: TEST:486 # - datestamp: 2023-03-10T13:04:26Z # identifier: TEST:487 # - datestamp: 2023-03-10T13:04:26Z # identifier: TEST:488 # resumptionToken: # content: marcxml/6/1970-01-01T00:00:00Z/2023-03-10T23:59:59Z//0/0/489 # cursor: '6' # xmlns: http://www.openarchives.org/OAI/2.0/ # xmlns:xsi: http://www.w3.org/2001/XMLSchema-instance # xsi:schemaLocation: http://www.openarchives.org/OAI/2.0/ http://www.openarchives.org/OAI/2.0/OAI-PMH.xsd # Failed test 'ListIdentifiers with resumptionToken 2' # at t/db_dependent/OAI/Server.t line 184. # Comparing hash keys of $data # Missing: 'request' # PARAM:--- # resumptionToken: marcxml/6/1970-01-01T00:00:00Z/2023-03-10T23:59:59Z//0/0/489 # verb: ListIdentifiers # EXPECTED:--- # ListIdentifiers: # header: # - datestamp: 2023-03-10T13:04:26Z # identifier: TEST:489 # - datestamp: 2023-03-10T13:04:26Z # identifier: TEST:490 # - datestamp: 2023-03-10T13:04:26Z # identifier: TEST:491 # resumptionToken: # content: !!perl/hash:Test::Deep::Regexp # val: !!perl/regexp (?^u:^marcxml/9/1970-01-01T00:00:00Z/2023-03-10T23:59:59Z//0/0/\d+$) # cursor: 9 # request: http://localhost # xmlns: http://www.openarchives.org/OAI/2.0/ # xmlns:xsi: http://www.w3.org/2001/XMLSchema-instance # xsi:schemaLocation: http://www.openarchives.org/OAI/2.0/ http://www.openarchives.org/OAI/2.0/OAI-PMH.xsd # RESPONSE:--- # ListIdentifiers: # header: # - datestamp: 2023-03-10T13:04:26Z # identifier: TEST:489 # - datestamp: 2023-03-10T13:04:26Z # identifier: TEST:490 # - datestamp: 2023-03-10T13:04:26Z # identifier: TEST:491 # resumptionToken: # content: marcxml/9/1970-01-01T00:00:00Z/2023-03-10T23:59:59Z//0/0/492 # cursor: '9' # xmlns: http://www.openarchives.org/OAI/2.0/ # xmlns:xsi: http://www.w3.org/2001/XMLSchema-instance # xsi:schemaLocation: http://www.openarchives.org/OAI/2.0/ http://www.openarchives.org/OAI/2.0/OAI-PMH.xsd Can't locate object method "generate" via package "marcxml/9/1970-01-01T00:00:00Z/2023-03-10T23:59:59Z//0/0/492" (perhaps you forgot to load "marcxml/9/1970-01-01T00:00:00Z/2023-03-10T23:59:59Z//0/0/492"?) at /usr/local/share/perl/5.32.1/HTTP/OAI/PartialList.pm line 30. # Looks like your test exited with 11 just after 18. t/db_dependent/OAI/Server.t ... Dubious, test returned 11 (wstat 2816, 0xb00) Failed 22/34 subtests t/db_dependent/OAI/Sets.t ..... ok Test Summary Report ------------------- t/db_dependent/OAI/Server.t (Wstat: 2816 Tests: 18 Failed: 6) Failed tests: 13-18 Non-zero exit status: 11 Parse errors: Bad plan. You planned 34 tests but ran 18. Files=3, Tests=175, 3 wallclock secs ( 0.02 usr 0.00 sys + 2.44 cusr 0.21 csys = 2.67 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion --- Comment #37 from Mason James <mtj@kohaaloha.com> --- (In reply to Kyle M Hall from comment #36)
Unit test failures. Please let me know if it just that I'm doing something wrong. I install HTTP::OAI 4.12 before running the tests.
hi Kyle oops, i forgot to run 'prove' after testing this it seems the newer version of HTTP::OAI has changed its behavior somewhat the tests look to some 'updating' before they will pass on 4.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 --- Comment #38 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Should this be failed QA? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 Mengu Yazicioglu <mengu@devinim.com.tr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mengu@devinim.com.tr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 Lauren Denny <lauren_denny@sil.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lauren_denny@sil.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Status|In Discussion |Failed QA --- Comment #39 from Victor Grousset/tuxayo <victor@tuxayo.net> --- It seems so. Switching to it so it's clearer that is rescuable and not blocked due to uncertainty about a fix. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #40 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Are we still working on this? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 --- Comment #41 from David Cook <dcook@prosentient.com.au> --- (In reply to Martin Renvoize from comment #40)
Are we still working on this?
I keep meaning to look at this again... but low on the list... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|dcook@prosentient.com.au |koha-bugs@lists.koha-commun | |ity.org --- Comment #42 from David Cook <dcook@prosentient.com.au> --- Resetting assignee on this one as I have no idea where we're at with this anymore -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org