[Bug 30913] New: Show itemtype notforloan with ILS-DI service GetRecords
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30913 Bug ID: 30913 Summary: Show itemtype notforloan with ILS-DI service GetRecords Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: koha-bugs@lists.koha-community.org Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org Discovery services like EBSCO's EDS use the GetRecords ILS-DI service, but the "notforloan" there only includes item-level notforloan and not item-type notforloan. In theory, they should use GetAvailability for availability but I can see why they'd use GetRecords since it has so much more information and that way they can do 1 API call instead of 2. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30913 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30636 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30913 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- Locally, in GetRecords, I check if the item is notforloan. If it has a 0 value, I then check to see if it's notforloan at the itemtype level. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30913 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30913 mathieu saby <mathsabypro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30913 --- Comment #2 from David Cook <dcook@prosentient.com.au> --- I thought I'd attached a patch for this. Looks like I hadn't... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30913 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Assignee|koha-bugs@lists.koha-commun |dcook@prosentient.com.au |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30913 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30913 --- Comment #3 from David Cook <dcook@prosentient.com.au> --- Created attachment 154401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154401&action=edit Bug 30913: Show notforloan from itemtype for ILS-DI GetRecords This patch sets notforloan for an item if its itemtype is set to notforloan, when creating the ILS-DI GetRecords response. To test: 0. Apply the patch 1. koha-plack --restart kohadev 2. Go to http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=ILS-DI 3. Enable the ILS-DI API 4. Go to http://localhost:8080/cgi-bin/koha/ilsdi.pl?service=GetRecords&id=29 5. Note the "notforloan" is 0 6. Go to http://localhost:8081/cgi-bin/koha/admin/itemtypes.pl?op=add_form&itemtype=BK 7. Checkbox the "Not for loan" and save 8. Go to http://localhost:8080/cgi-bin/koha/ilsdi.pl?service=GetRecords&id=29 9. Note the "notforloan" is 1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30913 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30913 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154401|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 154861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154861&action=edit Bug 30913: Show notforloan from itemtype for ILS-DI GetRecords This patch sets notforloan for an item if its itemtype is set to notforloan, when creating the ILS-DI GetRecords response. To test: 0. Apply the patch 1. koha-plack --restart kohadev 2. Go to http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=ILS-DI 3. Enable the ILS-DI API 4. Go to http://localhost:8080/cgi-bin/koha/ilsdi.pl?service=GetRecords&id=29 5. Note the "notforloan" is 0 6. Go to http://localhost:8081/cgi-bin/koha/admin/itemtypes.pl?op=add_form&itemtype=BK 7. Checkbox the "Not for loan" and save 8. Go to http://localhost:8080/cgi-bin/koha/ilsdi.pl?service=GetRecords&id=29 9. Note the "notforloan" is 1 Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30913 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Discovery services like release notes| |EBSCO's EDS use the | |GetRecords ILS-DI service, | |but the "notforloan" only | |includes item-level | |notforloan and not | |item-type notforloan. | | | |This | |fixes this, so that if the | |item type is set as not for | |loan, ILS-DI GetRecords | |responses will return | |<notforloan>1</notforloan>. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30913 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Signed Off |Failed QA --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Please add a test in t/db_dependent/ILSDI_Services.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30913 --- Comment #6 from David Cook <dcook@prosentient.com.au> --- I should look at this one again... -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org