[Bug 42490] New: Allow configuration of LocalHoldsPriority to apply only at checkin, not when building holds queue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42490 Bug ID: 42490 Summary: Allow configuration of LocalHoldsPriority to apply only at checkin, not when building holds queue Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, lisette@bywatersolutions.com, tomascohen@gmail.com Some libraries would like LocalHoldsPriority to impact only the choice of which hold should be filled when an on-loan item is returned, without impacting how the holds queue is built. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42490 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=41410 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42490 --- Comment #1 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 198467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198467&action=edit Bug 42490: Add system preference LocalHoldsPriorityScope Patch from commit c683dab -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42490 --- Comment #2 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 198468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198468&action=edit Bug 42490: Implement LocalHoldsPriorityScope To test: 1 - Set LocalHoldsPriority to "Don't give", set HoldsQueueOptimizeBranch to "home library" 2 - have a bib with two items: both items available, Item 1 home and holdingbranch Centerville, Item 2 home and holdingbranch Fairfield 3 - place a hold (Hold 1) on the bib for a patron from Centerville , for pickup at Fairfield 4 - place a hold (Hold 2) on the bib for a patron from Fairfield, for pickup at Centerville Establish behavior without LocalHoldsPriority 5 - build holds queue 6 - confirm the queue targets the FPL item for Hold 1 and the CPL item for Hold 2 7 - check both items out to a third patron (not one of your patrons with holds) 8 - check in Item 2, confirm it tries to fill Hold 1, click Ignore 9 - check in Item 1, confirm it also tries to fill Holds 1, click Ignore 10 - reset item locations: UPDATE items SET holdingbranch=homebranch; Establish behavior with LocalHoldsPriority 11 - Set LocalHoldsPriority to "Give library", LocalHoldsPriorityPatronControl to "home library", LocalHoldsPriorityItemControl to "home library" 12 - build holds queue 13 - confirm the queue targets the CPL item for Hold 1 and the FPL item for Hold 2 14 - check both items out to a third patron (not one of your patrons with holds) 15 - build holds queue, confirm it has no targets 16 - check in Item 2, confirm it tries to fill Hold 2, click Ignore 17 - check in Item 1, confirm it tries to fill Holds 1, click Ignore 18 - reset item locations: UPDATE items SET holdingbranch=homebranch; Apply patch, updatedatabase, restart_all 19 - confirm new system preference LocalHoldsPriorityScope, set to "checking items in and building the holds queue" 20 - repeat steps 11 - 18, no change in behavior 21 - set LocalHoldsPriorityScope to "checking items in" 22 - build holds queue 23 - confirm the queue targets the FPL item for Hold 1 and the CPL item for Hold 2 24 - check both items out to a third patron (not one of your patrons with holds) 25 - build holds queue, confirm it has no targets 26 - check in Item 2, confirm it tries to fill Hold 2 27 - check in Item 1, confirm it tries to fill Holds 1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42490 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |andrew@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42490 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42490 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198467|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42490 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198468|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42490 --- Comment #3 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 198476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198476&action=edit Bug 42490: Add system preference LocalHoldsPriorityScope Patch from commit c683dab -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42490 --- Comment #4 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 198477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198477&action=edit Bug 42490: Implement LocalHoldsPriorityScope To test: 1 - Set LocalHoldsPriority to "Don't give", set HoldsQueueOptimizeBranch to "home library" 2 - have a bib with two items: both items available, Item 1 home and holdingbranch Centerville, Item 2 home and holdingbranch Fairfield 3 - place a hold (Hold 1) on the bib for a patron from Centerville , for pickup at Fairfield 4 - place a hold (Hold 2) on the bib for a patron from Fairfield, for pickup at Centerville Establish behavior without LocalHoldsPriority 5 - build holds queue 6 - confirm the queue targets the FPL item for Hold 1 and the CPL item for Hold 2 7 - check both items out to a third patron (not one of your patrons with holds) 8 - check in Item 2, confirm it tries to fill Hold 1, click Ignore 9 - check in Item 1, confirm it also tries to fill Holds 1, click Ignore 10 - reset item locations: UPDATE items SET holdingbranch=homebranch; Establish behavior with LocalHoldsPriority 11 - Set LocalHoldsPriority to "Give library", LocalHoldsPriorityPatronControl to "home library", LocalHoldsPriorityItemControl to "home library" 12 - build holds queue 13 - confirm the queue targets the CPL item for Hold 1 and the FPL item for Hold 2 14 - check both items out to a third patron (not one of your patrons with holds) 15 - build holds queue, confirm it has no targets 16 - check in Item 2, confirm it tries to fill Hold 2, click Ignore 17 - check in Item 1, confirm it tries to fill Holds 1, click Ignore 18 - reset item locations: UPDATE items SET holdingbranch=homebranch; Apply patch, updatedatabase, restart_all 19 - confirm new system preference LocalHoldsPriorityScope, set to "checking items in and building the holds queue" 20 - repeat steps 11 - 18, no change in behavior 21 - set LocalHoldsPriorityScope to "checking items in" 22 - build holds queue 23 - confirm the queue targets the FPL item for Hold 1 and the CPL item for Hold 2 24 - check both items out to a third patron (not one of your patrons with holds) 25 - build holds queue, confirm it has no targets 26 - check in Item 2, confirm it tries to fill Hold 2 27 - check in Item 1, confirm it tries to fill Holds 1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42490 --- Comment #5 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 198478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198478&action=edit Bug 42490: Update unit tests Prove t/db_dependent/HoldsQueue.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42490 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198476|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42490 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198477|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42490 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198478|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42490 --- Comment #6 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 198494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198494&action=edit Bug 42490: Add system preference LocalHoldsPriorityScope Patch from commit 1aba1a1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42490 --- Comment #7 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 198495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198495&action=edit Bug 42490: Implement LocalHoldsPriorityScope To test: 1 - Set LocalHoldsPriority to "Don't give", set HoldsQueueOptimizeBranch to "home library" 2 - have a bib with two items: both items available, Item 1 home and holdingbranch Centerville, Item 2 home and holdingbranch Fairfield 3 - place a hold (Hold 1) on the bib for a patron from Centerville , for pickup at Fairfield 4 - place a hold (Hold 2) on the bib for a patron from Fairfield, for pickup at Centerville Establish behavior without LocalHoldsPriority 5 - build holds queue 6 - confirm the queue targets the FPL item for Hold 1 and the CPL item for Hold 2 7 - check both items out to a third patron (not one of your patrons with holds) 8 - check in Item 2, confirm it tries to fill Hold 1, click Ignore 9 - check in Item 1, confirm it also tries to fill Holds 1, click Ignore 10 - reset item locations: UPDATE items SET holdingbranch=homebranch; Establish behavior with LocalHoldsPriority 11 - Set LocalHoldsPriority to "Give library", LocalHoldsPriorityPatronControl to "home library", LocalHoldsPriorityItemControl to "home library" 12 - build holds queue 13 - confirm the queue targets the CPL item for Hold 1 and the FPL item for Hold 2 14 - check both items out to a third patron (not one of your patrons with holds) 15 - build holds queue, confirm it has no targets 16 - check in Item 2, confirm it tries to fill Hold 2, click Ignore 17 - check in Item 1, confirm it tries to fill Holds 1, click Ignore 18 - reset item locations: UPDATE items SET holdingbranch=homebranch; Apply patch, updatedatabase, restart_all 19 - confirm new system preference LocalHoldsPriorityScope, set to "checking items in and building the holds queue" 20 - repeat steps 11 - 18, no change in behavior 21 - set LocalHoldsPriorityScope to "checking items in" 22 - build holds queue 23 - confirm the queue targets the FPL item for Hold 1 and the CPL item for Hold 2 24 - check both items out to a third patron (not one of your patrons with holds) 25 - build holds queue, confirm it has no targets 26 - check in Item 2, confirm it tries to fill Hold 2 27 - check in Item 1, confirm it tries to fill Holds 1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42490 --- Comment #8 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 198496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198496&action=edit Bug 42490: Update unit tests Prove t/db_dependent/HoldsQueue.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42490 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Sponsorship status|--- |Sponsored Comma delimited| |The Main Library Alliance list of Sponsors| |<https://www.mainlib.org/> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42490 --- Comment #9 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- I'm just realizing my test plan says "HoldsQueueOptimizeBranch" when the syspref is actually "HoldsQueuePrioritizeBranch." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42490 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42490 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198494|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42490 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198495|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42490 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198496|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42490 --- Comment #10 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 199398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199398&action=edit Bug 42490: Add system preference LocalHoldsPriorityScope Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42490 --- Comment #11 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 199399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199399&action=edit Bug 42490: Implement LocalHoldsPriorityScope To test: 1 - Set LocalHoldsPriority to "Don't give", set HoldsQueueOptimizeBranch to "home library" 2 - have a bib with two items: both items available, Item 1 home and holdingbranch Centerville, Item 2 home and holdingbranch Fairfield 3 - place a hold (Hold 1) on the bib for a patron from Centerville , for pickup at Fairfield 4 - place a hold (Hold 2) on the bib for a patron from Fairfield, for pickup at Centerville Establish behavior without LocalHoldsPriority 5 - build holds queue 6 - confirm the queue targets the FPL item for Hold 1 and the CPL item for Hold 2 7 - check both items out to a third patron (not one of your patrons with holds) 8 - check in Item 2, confirm it tries to fill Hold 1, click Ignore 9 - check in Item 1, confirm it also tries to fill Holds 1, click Ignore 10 - reset item locations: UPDATE items SET holdingbranch=homebranch; Establish behavior with LocalHoldsPriority 11 - Set LocalHoldsPriority to "Give library", LocalHoldsPriorityPatronControl to "home library", LocalHoldsPriorityItemControl to "home library" 12 - build holds queue 13 - confirm the queue targets the CPL item for Hold 1 and the FPL item for Hold 2 14 - check both items out to a third patron (not one of your patrons with holds) 15 - build holds queue, confirm it has no targets 16 - check in Item 2, confirm it tries to fill Hold 2, click Ignore 17 - check in Item 1, confirm it tries to fill Holds 1, click Ignore 18 - reset item locations: UPDATE items SET holdingbranch=homebranch; Apply patch, updatedatabase, restart_all 19 - confirm new system preference LocalHoldsPriorityScope, set to "checking items in and building the holds queue" 20 - repeat steps 11 - 18, no change in behavior 21 - set LocalHoldsPriorityScope to "checking items in" 22 - build holds queue 23 - confirm the queue targets the FPL item for Hold 1 and the CPL item for Hold 2 24 - check both items out to a third patron (not one of your patrons with holds) 25 - build holds queue, confirm it has no targets 26 - check in Item 2, confirm it tries to fill Hold 2 27 - check in Item 1, confirm it tries to fill Holds 1 Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42490 --- Comment #12 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 199400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199400&action=edit Bug 42490: Update unit tests Prove t/db_dependent/HoldsQueue.t Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42490 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@openfifth.c |y.org |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42490 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42490 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199398|0 |1 is obsolete| | Attachment #199399|0 |1 is obsolete| | Attachment #199400|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42490 --- Comment #13 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 204772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204772&action=edit Bug 42490: Add system preference LocalHoldsPriorityScope Sponsored-by: The Main Library Alliance <https://www.mainlib.org/> Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42490 --- Comment #14 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 204773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204773&action=edit Bug 42490: Implement LocalHoldsPriorityScope To test: 1 - Set LocalHoldsPriority to "Don't give", set HoldsQueueOptimizeBranch to "home library" 2 - have a bib with two items: both items available, Item 1 home and holdingbranch Centerville, Item 2 home and holdingbranch Fairfield 3 - place a hold (Hold 1) on the bib for a patron from Centerville , for pickup at Fairfield 4 - place a hold (Hold 2) on the bib for a patron from Fairfield, for pickup at Centerville Establish behavior without LocalHoldsPriority 5 - build holds queue 6 - confirm the queue targets the FPL item for Hold 1 and the CPL item for Hold 2 7 - check both items out to a third patron (not one of your patrons with holds) 8 - check in Item 2, confirm it tries to fill Hold 1, click Ignore 9 - check in Item 1, confirm it also tries to fill Holds 1, click Ignore 10 - reset item locations: UPDATE items SET holdingbranch=homebranch; Establish behavior with LocalHoldsPriority 11 - Set LocalHoldsPriority to "Give library", LocalHoldsPriorityPatronControl to "home library", LocalHoldsPriorityItemControl to "home library" 12 - build holds queue 13 - confirm the queue targets the CPL item for Hold 1 and the FPL item for Hold 2 14 - check both items out to a third patron (not one of your patrons with holds) 15 - build holds queue, confirm it has no targets 16 - check in Item 2, confirm it tries to fill Hold 2, click Ignore 17 - check in Item 1, confirm it tries to fill Holds 1, click Ignore 18 - reset item locations: UPDATE items SET holdingbranch=homebranch; Apply patch, updatedatabase, restart_all 19 - confirm new system preference LocalHoldsPriorityScope, set to "checking items in and building the holds queue" 20 - repeat steps 11 - 18, no change in behavior 21 - set LocalHoldsPriorityScope to "checking items in" 22 - build holds queue 23 - confirm the queue targets the FPL item for Hold 1 and the CPL item for Hold 2 24 - check both items out to a third patron (not one of your patrons with holds) 25 - build holds queue, confirm it has no targets 26 - check in Item 2, confirm it tries to fill Hold 2 27 - check in Item 1, confirm it tries to fill Holds 1 Sponsored-by: The Main Library Alliance <https://www.mainlib.org/> Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42490 --- Comment #15 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 204774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204774&action=edit Bug 42490: Update unit tests Prove t/db_dependent/HoldsQueue.t Sponsored-by: The Main Library Alliance <https://www.mainlib.org/> Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42490 --- Comment #16 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 204775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204775&action=edit Bug 42490: (QA follow-up) Address QA review comments - Remove leftover skeleton boilerplate comments in the atomicupdate ("Do you stuffs here", "# sysprefs") - Fix typo in atomicupdate description ("preferene" -> "preference") - Update POD on MapItemsToHoldRequests to mention the new LocalHoldsPriorityScope gate - Explicitly mock LocalHoldsPriorityScope in the existing Local Holds Priority subtests that exercise CreateQueue/MapItemsToHoldRequests, instead of relying on it falling through to the real DB default Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42490 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Initiative type|--- |Feature -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42490 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_26_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42490 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@openfifth.co.u | |k Status|Passed QA |Failed QA --- Comment #17 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Blocker: After updatedatabase: prove t/db_dependent/check_sysprefs.t t/db_dependent/check_sysprefs.t .. # Failed test 'LocalHoldsPriorityScope has 'explanation' set in DB, must be NULL!' # at t/db_dependent/check_sysprefs.t line 115. # Failed test 'LocalHoldsPriorityScope has 'type' set in DB, must be NULL!' # at t/db_dependent/check_sysprefs.t line 118. # Looks like you failed 2 tests of 1804. t/db_dependent/check_sysprefs.t .. 1/3 Non-blockers but nice to haves: - 'checking items in' undersells it. CheckReserves (and so LocalHoldsPriority) also runs at checkout, transfers, hold cancel/move and SIP, so checkin_only really means "everywhere except the holds queue". Please make the label (and ideally the value) say so, if that is indeed the case. - Commit message: HoldsQueueOptimizeBranch should be HoldsQueuePrioritizeBranch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42490 --- Comment #18 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- (In reply to Pedro Amorim (ammopt) from comment #17)
- 'checking items in' undersells it. CheckReserves (and so LocalHoldsPriority) also runs at checkout, transfers, hold cancel/move and SIP, so checkin_only really means "everywhere except the holds queue". Please make the label (and ideally the value) say so, if that is indeed the case. - Commit message: HoldsQueueOptimizeBranch should be HoldsQueuePrioritizeBranch.
How do we feel about "when capturing an item for a hold" instead of "when checking items in?" It's accurately broad. I'm on the fence about whether or not it's sufficiently clear to users. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42490 --- Comment #19 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- (In reply to Andrew Fuerste-Henry from comment #18)
(In reply to Pedro Amorim (ammopt) from comment #17)
- 'checking items in' undersells it. CheckReserves (and so LocalHoldsPriority) also runs at checkout, transfers, hold cancel/move and SIP, so checkin_only really means "everywhere except the holds queue". Please make the label (and ideally the value) say so, if that is indeed the case. - Commit message: HoldsQueueOptimizeBranch should be HoldsQueuePrioritizeBranch.
How do we feel about "when capturing an item for a hold" instead of "when checking items in?" It's accurately broad. I'm on the fence about whether or not it's sufficiently clear to users.
Alternatively, this could be phrased as a separate sentence: "Do/Do not apply these settings when building the holds queue." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42490 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42490 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #204772|0 |1 is obsolete| | Attachment #204773|0 |1 is obsolete| | Attachment #204774|0 |1 is obsolete| | Attachment #204775|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42490 --- Comment #20 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 206898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206898&action=edit Bug 42490: Add system preference LocalHoldsPriorityScope Sponsored-by: The Main Library Alliance <https://www.mainlib.org/> Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42490 --- Comment #21 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 206899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206899&action=edit Bug 42490: Implement LocalHoldsPriorityScope To test: 1 - Set LocalHoldsPriority to "Don't give", set HoldsQueuePrioritizeBranch to "home library" 2 - have a bib with two items: both items available, Item 1 home and holdingbranch Centerville, Item 2 home and holdingbranch Fairfield 3 - place a hold (Hold 1) on the bib for a patron from Centerville , for pickup at Fairfield 4 - place a hold (Hold 2) on the bib for a patron from Fairfield, for pickup at Centerville Establish behavior without LocalHoldsPriority 5 - build holds queue 6 - confirm the queue targets the FPL item for Hold 1 and the CPL item for Hold 2 7 - check both items out to a third patron (not one of your patrons with holds) 8 - check in Item 2, confirm it tries to fill Hold 1, click Ignore 9 - check in Item 1, confirm it also tries to fill Holds 1, click Ignore 10 - reset item locations: UPDATE items SET holdingbranch=homebranch; Establish behavior with LocalHoldsPriority 11 - Set LocalHoldsPriority to "Give library", LocalHoldsPriorityPatronControl to "home library", LocalHoldsPriorityItemControl to "home library" 12 - build holds queue 13 - confirm the queue targets the CPL item for Hold 1 and the FPL item for Hold 2 14 - check both items out to a third patron (not one of your patrons with holds) 15 - build holds queue, confirm it has no targets 16 - check in Item 2, confirm it tries to fill Hold 2, click Ignore 17 - check in Item 1, confirm it tries to fill Holds 1, click Ignore 18 - reset item locations: UPDATE items SET holdingbranch=homebranch; Apply patch, updatedatabase, restart_all 19 - confirm new system preference LocalHoldsPriorityScope, set to "checking items in and building the holds queue" 20 - repeat steps 11 - 18, no change in behavior 21 - set LocalHoldsPriorityScope to "checking items in" 22 - build holds queue 23 - confirm the queue targets the FPL item for Hold 1 and the CPL item for Hold 2 24 - check both items out to a third patron (not one of your patrons with holds) 25 - build holds queue, confirm it has no targets 26 - check in Item 2, confirm it tries to fill Hold 2 27 - check in Item 1, confirm it tries to fill Holds 1 Sponsored-by: The Main Library Alliance <https://www.mainlib.org/> Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42490 --- Comment #22 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 206900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206900&action=edit Bug 42490: Update unit tests Prove t/db_dependent/HoldsQueue.t Sponsored-by: The Main Library Alliance <https://www.mainlib.org/> Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42490 --- Comment #23 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 206901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206901&action=edit Bug 42490: (QA follow-up) Address QA review comments - Remove leftover skeleton boilerplate comments in the atomicupdate ("Do you stuffs here", "# sysprefs") - Fix typo in atomicupdate description ("preferene" -> "preference") - Update POD on MapItemsToHoldRequests to mention the new LocalHoldsPriorityScope gate - Explicitly mock LocalHoldsPriorityScope in the existing Local Holds Priority subtests that exercise CreateQueue/MapItemsToHoldRequests, instead of relying on it falling through to the real DB default Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42490 --- Comment #24 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 206902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206902&action=edit Bug 42490: (QA follow-up) Reword syspref description and options -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42490 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42490 --- Comment #25 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42490 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement allows for release notes| |a more narrow application | |of LocalHoldsPriority via | |the system preference | |LocalHoldsPriorityScope. | |Setting | |LocalHoldsPriorityScope to | |capture_and_queue maintains | |the current behavior. When | |LocalHoldsPriorityScope is | |set to capture_only, holds | |queue targets will be | |assigned without the | |influence of | |LocalHoldsPriority but | |LocalHoldsPriority will | |still be used when an item | |that is not already | |targeted by the queue is | |captured for a hold (this | |generally occurs when an | |item has been on loan or | |otherwise unavailable to | |the queue and is then | |checked in or otherwise | |updated to become | |available). Summary|Allow configuration of |Allow configuration of |LocalHoldsPriority to apply |LocalHoldsPriority to apply |only at checkin, not when |only when capturing items |building holds queue |for holds, not when | |building holds queue -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42490 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to main |Needs documenting --- Comment #26 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Enhancement, no 26.05.x backport. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org