[Bug 42490] New: Allow configuration of LocalHoldsPriority to apply only at checkin, not when building holds queue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42490 Bug ID: 42490 Summary: Allow configuration of LocalHoldsPriority to apply only at checkin, not when building holds queue Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, lisette@bywatersolutions.com, tomascohen@gmail.com Some libraries would like LocalHoldsPriority to impact only the choice of which hold should be filled when an on-loan item is returned, without impacting how the holds queue is built. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42490 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=41410 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42490 --- Comment #1 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 198467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198467&action=edit Bug 42490: Add system preference LocalHoldsPriorityScope Patch from commit c683dab -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42490 --- Comment #2 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 198468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198468&action=edit Bug 42490: Implement LocalHoldsPriorityScope To test: 1 - Set LocalHoldsPriority to "Don't give", set HoldsQueueOptimizeBranch to "home library" 2 - have a bib with two items: both items available, Item 1 home and holdingbranch Centerville, Item 2 home and holdingbranch Fairfield 3 - place a hold (Hold 1) on the bib for a patron from Centerville , for pickup at Fairfield 4 - place a hold (Hold 2) on the bib for a patron from Fairfield, for pickup at Centerville Establish behavior without LocalHoldsPriority 5 - build holds queue 6 - confirm the queue targets the FPL item for Hold 1 and the CPL item for Hold 2 7 - check both items out to a third patron (not one of your patrons with holds) 8 - check in Item 2, confirm it tries to fill Hold 1, click Ignore 9 - check in Item 1, confirm it also tries to fill Holds 1, click Ignore 10 - reset item locations: UPDATE items SET holdingbranch=homebranch; Establish behavior with LocalHoldsPriority 11 - Set LocalHoldsPriority to "Give library", LocalHoldsPriorityPatronControl to "home library", LocalHoldsPriorityItemControl to "home library" 12 - build holds queue 13 - confirm the queue targets the CPL item for Hold 1 and the FPL item for Hold 2 14 - check both items out to a third patron (not one of your patrons with holds) 15 - build holds queue, confirm it has no targets 16 - check in Item 2, confirm it tries to fill Hold 2, click Ignore 17 - check in Item 1, confirm it tries to fill Holds 1, click Ignore 18 - reset item locations: UPDATE items SET holdingbranch=homebranch; Apply patch, updatedatabase, restart_all 19 - confirm new system preference LocalHoldsPriorityScope, set to "checking items in and building the holds queue" 20 - repeat steps 11 - 18, no change in behavior 21 - set LocalHoldsPriorityScope to "checking items in" 22 - build holds queue 23 - confirm the queue targets the FPL item for Hold 1 and the CPL item for Hold 2 24 - check both items out to a third patron (not one of your patrons with holds) 25 - build holds queue, confirm it has no targets 26 - check in Item 2, confirm it tries to fill Hold 2 27 - check in Item 1, confirm it tries to fill Holds 1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42490 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |andrew@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42490 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42490 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198467|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42490 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198468|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42490 --- Comment #3 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 198476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198476&action=edit Bug 42490: Add system preference LocalHoldsPriorityScope Patch from commit c683dab -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42490 --- Comment #4 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 198477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198477&action=edit Bug 42490: Implement LocalHoldsPriorityScope To test: 1 - Set LocalHoldsPriority to "Don't give", set HoldsQueueOptimizeBranch to "home library" 2 - have a bib with two items: both items available, Item 1 home and holdingbranch Centerville, Item 2 home and holdingbranch Fairfield 3 - place a hold (Hold 1) on the bib for a patron from Centerville , for pickup at Fairfield 4 - place a hold (Hold 2) on the bib for a patron from Fairfield, for pickup at Centerville Establish behavior without LocalHoldsPriority 5 - build holds queue 6 - confirm the queue targets the FPL item for Hold 1 and the CPL item for Hold 2 7 - check both items out to a third patron (not one of your patrons with holds) 8 - check in Item 2, confirm it tries to fill Hold 1, click Ignore 9 - check in Item 1, confirm it also tries to fill Holds 1, click Ignore 10 - reset item locations: UPDATE items SET holdingbranch=homebranch; Establish behavior with LocalHoldsPriority 11 - Set LocalHoldsPriority to "Give library", LocalHoldsPriorityPatronControl to "home library", LocalHoldsPriorityItemControl to "home library" 12 - build holds queue 13 - confirm the queue targets the CPL item for Hold 1 and the FPL item for Hold 2 14 - check both items out to a third patron (not one of your patrons with holds) 15 - build holds queue, confirm it has no targets 16 - check in Item 2, confirm it tries to fill Hold 2, click Ignore 17 - check in Item 1, confirm it tries to fill Holds 1, click Ignore 18 - reset item locations: UPDATE items SET holdingbranch=homebranch; Apply patch, updatedatabase, restart_all 19 - confirm new system preference LocalHoldsPriorityScope, set to "checking items in and building the holds queue" 20 - repeat steps 11 - 18, no change in behavior 21 - set LocalHoldsPriorityScope to "checking items in" 22 - build holds queue 23 - confirm the queue targets the FPL item for Hold 1 and the CPL item for Hold 2 24 - check both items out to a third patron (not one of your patrons with holds) 25 - build holds queue, confirm it has no targets 26 - check in Item 2, confirm it tries to fill Hold 2 27 - check in Item 1, confirm it tries to fill Holds 1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42490 --- Comment #5 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 198478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198478&action=edit Bug 42490: Update unit tests Prove t/db_dependent/HoldsQueue.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42490 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198476|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42490 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198477|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42490 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198478|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42490 --- Comment #6 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 198494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198494&action=edit Bug 42490: Add system preference LocalHoldsPriorityScope Patch from commit 1aba1a1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42490 --- Comment #7 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 198495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198495&action=edit Bug 42490: Implement LocalHoldsPriorityScope To test: 1 - Set LocalHoldsPriority to "Don't give", set HoldsQueueOptimizeBranch to "home library" 2 - have a bib with two items: both items available, Item 1 home and holdingbranch Centerville, Item 2 home and holdingbranch Fairfield 3 - place a hold (Hold 1) on the bib for a patron from Centerville , for pickup at Fairfield 4 - place a hold (Hold 2) on the bib for a patron from Fairfield, for pickup at Centerville Establish behavior without LocalHoldsPriority 5 - build holds queue 6 - confirm the queue targets the FPL item for Hold 1 and the CPL item for Hold 2 7 - check both items out to a third patron (not one of your patrons with holds) 8 - check in Item 2, confirm it tries to fill Hold 1, click Ignore 9 - check in Item 1, confirm it also tries to fill Holds 1, click Ignore 10 - reset item locations: UPDATE items SET holdingbranch=homebranch; Establish behavior with LocalHoldsPriority 11 - Set LocalHoldsPriority to "Give library", LocalHoldsPriorityPatronControl to "home library", LocalHoldsPriorityItemControl to "home library" 12 - build holds queue 13 - confirm the queue targets the CPL item for Hold 1 and the FPL item for Hold 2 14 - check both items out to a third patron (not one of your patrons with holds) 15 - build holds queue, confirm it has no targets 16 - check in Item 2, confirm it tries to fill Hold 2, click Ignore 17 - check in Item 1, confirm it tries to fill Holds 1, click Ignore 18 - reset item locations: UPDATE items SET holdingbranch=homebranch; Apply patch, updatedatabase, restart_all 19 - confirm new system preference LocalHoldsPriorityScope, set to "checking items in and building the holds queue" 20 - repeat steps 11 - 18, no change in behavior 21 - set LocalHoldsPriorityScope to "checking items in" 22 - build holds queue 23 - confirm the queue targets the FPL item for Hold 1 and the CPL item for Hold 2 24 - check both items out to a third patron (not one of your patrons with holds) 25 - build holds queue, confirm it has no targets 26 - check in Item 2, confirm it tries to fill Hold 2 27 - check in Item 1, confirm it tries to fill Holds 1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42490 --- Comment #8 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 198496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198496&action=edit Bug 42490: Update unit tests Prove t/db_dependent/HoldsQueue.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42490 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Sponsorship status|--- |Sponsored Comma delimited| |The Main Library Alliance list of Sponsors| |<https://www.mainlib.org/> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42490 --- Comment #9 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- I'm just realizing my test plan says "HoldsQueueOptimizeBranch" when the syspref is actually "HoldsQueuePrioritizeBranch." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42490 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42490 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198494|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42490 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198495|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42490 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198496|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42490 --- Comment #10 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 199398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199398&action=edit Bug 42490: Add system preference LocalHoldsPriorityScope Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42490 --- Comment #11 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 199399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199399&action=edit Bug 42490: Implement LocalHoldsPriorityScope To test: 1 - Set LocalHoldsPriority to "Don't give", set HoldsQueueOptimizeBranch to "home library" 2 - have a bib with two items: both items available, Item 1 home and holdingbranch Centerville, Item 2 home and holdingbranch Fairfield 3 - place a hold (Hold 1) on the bib for a patron from Centerville , for pickup at Fairfield 4 - place a hold (Hold 2) on the bib for a patron from Fairfield, for pickup at Centerville Establish behavior without LocalHoldsPriority 5 - build holds queue 6 - confirm the queue targets the FPL item for Hold 1 and the CPL item for Hold 2 7 - check both items out to a third patron (not one of your patrons with holds) 8 - check in Item 2, confirm it tries to fill Hold 1, click Ignore 9 - check in Item 1, confirm it also tries to fill Holds 1, click Ignore 10 - reset item locations: UPDATE items SET holdingbranch=homebranch; Establish behavior with LocalHoldsPriority 11 - Set LocalHoldsPriority to "Give library", LocalHoldsPriorityPatronControl to "home library", LocalHoldsPriorityItemControl to "home library" 12 - build holds queue 13 - confirm the queue targets the CPL item for Hold 1 and the FPL item for Hold 2 14 - check both items out to a third patron (not one of your patrons with holds) 15 - build holds queue, confirm it has no targets 16 - check in Item 2, confirm it tries to fill Hold 2, click Ignore 17 - check in Item 1, confirm it tries to fill Holds 1, click Ignore 18 - reset item locations: UPDATE items SET holdingbranch=homebranch; Apply patch, updatedatabase, restart_all 19 - confirm new system preference LocalHoldsPriorityScope, set to "checking items in and building the holds queue" 20 - repeat steps 11 - 18, no change in behavior 21 - set LocalHoldsPriorityScope to "checking items in" 22 - build holds queue 23 - confirm the queue targets the FPL item for Hold 1 and the CPL item for Hold 2 24 - check both items out to a third patron (not one of your patrons with holds) 25 - build holds queue, confirm it has no targets 26 - check in Item 2, confirm it tries to fill Hold 2 27 - check in Item 1, confirm it tries to fill Holds 1 Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42490 --- Comment #12 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 199400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199400&action=edit Bug 42490: Update unit tests Prove t/db_dependent/HoldsQueue.t Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42490 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@openfifth.c |y.org |o.uk -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org