https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42489 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |pedro.amorim@openfifth.co.u |ity.org |k CC| |martin.renvoize@openfifth.c | |o.uk -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42489 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|pedro.amorim@openfifth.co.u |tomascohen@gmail.com |k | Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42489 --- Comment #2 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 198498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198498&action=edit Bug 42489: Pass unallocated mode to real-time holds queue When RealTimeHoldsQueueUnallocated is enabled, the background job passes unallocated => 1 and delete => 0 to update_queue_for_biblio. This skips deleting existing queue entries and only processes holds not already allocated, matching the --unallocated behavior of build_holds_queue.pl. Test plan: 1. Apply patches 2. Run: $ ktd --shell k$ prove t/db_dependent/Koha/BackgroundJob/BatchUpdateBiblioHoldsQueue.t => SUCCESS: Tests pass! 3. Tests verify: - delete => 1 and no unallocated when pref is off - delete => 0 and unallocated => 1 when pref is on 4. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42489 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This development allows the release notes| |RealTimeHoldsQueue to use | |the 'unallocated' option | |available in | |build_holds_queue.pl. This | |option prevents deletion of | |current queue and only | |deals with holds not | |currently in the queue. --- Comment #3 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- To test the functionality in the staff interface: 1 - apply patch, updatedatabase, restart_all 2 - enable RealTimeHoldsQueue, leave RealTimeHoldsQueueUnallocated set to 'rebuild the entire queue for the affected biblio' 3 - have a bib with two items, both with homebranch and holdingbranch of Centerville 4 - place a hold on your biblio, for pickup at Fairfield 5 - confirm your hold has been added to the holds queue, note which item has been targeted 6 - edit the non-targeted item, setting homebranch and holdingbranch to Fairfield 7 - reload the holds queue, observe the queue is now targeting the item at Fairfield 8 - cancel your hold, edit the item back to Centerville 9 - set RealTimeHoldsQueueUnallocated to 'only process unallocated holds' 10 - place a new hold on your biblio, for pickup at Fairfield 11 - confirm your hold has been added to the holds queue, note which item has been targeted 12 - edit the non-targeted item, setting homebranch and holdingbranch to Fairfield 13 - reload the holds queue, observe the queue has not changed its target -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42489 Alex Carver [Acerock7] <alex@rcls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198498|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42489 Alex Carver [Acerock7] <alex@rcls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42489 Alex Carver [Acerock7] <alex@rcls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199055|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42489 --- Comment #6 from Alex Carver [Acerock7] <alex@rcls.org> --- Created attachment 199057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199057&action=edit Bug 42489: Pass unallocated mode to real-time holds queue When RealTimeHoldsQueueUnallocated is enabled, the background job passes unallocated => 1 and delete => 0 to update_queue_for_biblio. This skips deleting existing queue entries and only processes holds not already allocated, matching the --unallocated behavior of build_holds_queue.pl. Test plan: 1. Apply patches 2. Run: $ ktd --shell k$ prove t/db_dependent/Koha/BackgroundJob/BatchUpdateBiblioHoldsQueue.t => SUCCESS: Tests pass! 3. Tests verify: - delete => 1 and no unallocated when pref is off - delete => 0 and unallocated => 1 when pref is on 4. Sign off :-D Signed-off-by: Alex Carver [Acerock7] <alex@rcls.org> Sponsored-by: The Main Library Alliance <https://www.mainlib.org/> Signed-off-by: Alex Carver [Acerock7] <alex@rcls.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42489 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|andrew@bywatersolutions.com |testopia@bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42489 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42489 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199057|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42489 --- Comment #8 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 199156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199156&action=edit Bug 42489: Pass unallocated mode to real-time holds queue When RealTimeHoldsQueueUnallocated is enabled, the background job passes unallocated => 1 and delete => 0 to update_queue_for_biblio. This skips deleting existing queue entries and only processes holds not already allocated, matching the --unallocated behavior of build_holds_queue.pl. Test plan: 1. Apply patches 2. Run: $ ktd --shell k$ prove t/db_dependent/Koha/BackgroundJob/BatchUpdateBiblioHoldsQueue.t => SUCCESS: Tests pass! 3. Tests verify: - delete => 1 and no unallocated when pref is off - delete => 0 and unallocated => 1 when pref is on 4. Sign off :-D Signed-off-by: Alex Carver [Acerock7] <alex@rcls.org> Sponsored-by: The Main Library Alliance <https://www.mainlib.org/> Signed-off-by: Alex Carver [Acerock7] <alex@rcls.org> Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42489 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #9 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Apply patch, updatedatabase: prove /kohadevbox/koha/t/db_dependent/check_sysprefs.t /kohadevbox/koha/t/db_dependent/check_sysprefs.t .. # Failed test 'RealTimeHoldsQueueUnallocated has 'explanation' set in DB, must be NULL!' # at /kohadevbox/koha/t/db_dependent/check_sysprefs.t line 115. # Failed test 'RealTimeHoldsQueueUnallocated has 'type' set in DB, must be NULL!' # at /kohadevbox/koha/t/db_dependent/check_sysprefs.t line 118. # Looks like you failed 2 tests of 1784. /kohadevbox/koha/t/db_dependent/check_sysprefs.t .. 1/3 # Failed test 'Compare database with sysprefs.sql file' # at /kohadevbox/koha/t/db_dependent/check_sysprefs.t line 51. # Looks like you failed 1 test of 3. /kohadevbox/koha/t/db_dependent/check_sysprefs.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/3 subtests Test Summary Report ------------------- /kohadevbox/koha/t/db_dependent/check_sysprefs.t (Wstat: 256 (exited 1) Tests: 3 Failed: 1) Failed test: 1 Non-zero exit status: 1 Files=1, Tests=3, 1 wallclock secs ( 0.05 usr 0.01 sys + 1.07 cusr 0.12 csys = 1.25 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42489 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199155|0 |1 is obsolete| | Attachment #199156|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42489 --- Comment #11 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 200789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200789&action=edit Bug 42489: Pass unallocated mode to real-time holds queue When RealTimeHoldsQueueUnallocated is enabled, the background job passes unallocated => 1 and delete => 0 to update_queue_for_biblio. This skips deleting existing queue entries and only processes holds not already allocated, matching the --unallocated behavior of build_holds_queue.pl. Test plan: 1. Apply patches 2. Run: $ ktd --shell k$ prove t/db_dependent/Koha/BackgroundJob/BatchUpdateBiblioHoldsQueue.t => SUCCESS: Tests pass! 3. Tests verify: - delete => 1 and no unallocated when pref is off - delete => 0 and unallocated => 1 when pref is on 4. Sign off :-D Signed-off-by: Alex Carver [Acerock7] <alex@rcls.org> Sponsored-by: The Main Library Alliance <https://www.mainlib.org/> Signed-off-by: Alex Carver [Acerock7] <alex@rcls.org> Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.