[Bug 12720] New: Turn off Authority logging when running "bulkmarcimport.pl"
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12720 Bug ID: 12720 Summary: Turn off Authority logging when running "bulkmarcimport.pl" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt@gmail.com Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org Currently, there is no provision to disable logging when running "bulkmarcimport.pl" in authority mode. There is for bibliographic mode, and it seems to presumably be for performance reasons. (I would think both in terms of the import and in terms of querying the action_logs table, as that could get quite cumbersome if you import 600,000 authorities.) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12720 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12720 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- Created attachment 30550 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30550&action=edit Bug 12720 - Turn off Authority logging when running "bulkmarcimport.pl" This patch turns off the AuthoritiesLogging syspref when running the bulkmarcimport.pl script. It also temporarily disables the syspref caching which will have been making the CataloguingLogging handling ineffectual. (That is, updating the CataloguingLogging syspref in the script wouldn't have an effect as the original cached value would be used anyway.) _TEST PLAN_ 0) Turn on "AuthoritiesLogging" syspref 1) Load an authority record using bulkmarcimport.pl 2) Note a new Authorities entry in action_logs 3) Apply the patch 4) Repeat Step 1 5) Note that no new entry is made in action_logs (Bonus points: Do the same thing with CataloguingLogging and a bibliographic record.) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12720 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12720 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30550|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 30560 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30560&action=edit [SIGNED-OFF] Bug 12720 - Turn off Authority logging when running "bulkmarcimport.pl" This patch turns off the AuthoritiesLogging syspref when running the bulkmarcimport.pl script. It also temporarily disables the syspref caching which will have been making the CataloguingLogging handling ineffectual. (That is, updating the CataloguingLogging syspref in the script wouldn't have an effect as the original cached value would be used anyway.) _TEST PLAN_ 0) Turn on "AuthoritiesLogging" syspref 1) Load an authority record using bulkmarcimport.pl 2) Note a new Authorities entry in action_logs 3) Apply the patch 4) Repeat Step 1 5) Note that no new entry is made in action_logs (Bonus points: Do the same thing with CataloguingLogging and a bibliographic record.) Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Tested with biblio and auth imports. Work as described, no koha-qa errors. Note: If you begin to load a big file and get impatient and hit ^C, seems that current syspref value is lost... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12720 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12720 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12720 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30560|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 30956 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30956&action=edit [PASSED QA] Bug 12720 - Turn off Authority logging when running "bulkmarcimport.pl" This patch turns off the AuthoritiesLogging syspref when running the bulkmarcimport.pl script. It also temporarily disables the syspref caching which will have been making the CataloguingLogging handling ineffectual. (That is, updating the CataloguingLogging syspref in the script wouldn't have an effect as the original cached value would be used anyway.) _TEST PLAN_ 0) Turn on "AuthoritiesLogging" syspref 1) Load an authority record using bulkmarcimport.pl 2) Note a new Authorities entry in action_logs 3) Apply the patch 4) Repeat Step 1 5) Note that no new entry is made in action_logs (Bonus points: Do the same thing with CataloguingLogging and a bibliographic record.) Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Tested with biblio and auth imports. Work as described, no koha-qa errors. Note: If you begin to load a big file and get impatient and hit ^C, seems that current syspref value is lost... Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes tests and QA script. Patch copies what was already done for the CatalougingLog, no problems found. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12720 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 31127 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31127&action=edit Bug 12720: (QA followup) use API instead of plain SQL Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12720 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks David! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org