[Bug 12744] New: Set language in staff client should have 'Cancel' link
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12744 Bug ID: 12744 Summary: Set language in staff client should have 'Cancel' link Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12744 --- Comment #1 from Marc Véron <veron@veron.ch> --- Created attachment 30691 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30691&action=edit Bug 12744 - Set language in staff client should have 'Cancel' link Test plan Without patch: Click on Library name in head of any staff client page anc choose 'Set library' Result: Form 'Set library' with no 'Cancel' near 'Submit' button With patch: Form displays 'Cancel' link. This link closes the form and takes you back to the page where you came from. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12744 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch Assignee|koha-bugs@lists.koha-commun |veron@veron.ch |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12744 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- This works great for me, but I have one minor issue: The "Cancel" link should not have an empty "onclick" attribute. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12744 --- Comment #3 from Marc Véron <veron@veron.ch> --- I followed a pattern from an other place with 'Cancel' Would the following be better? <a class="cancel" id="cancel_set_library" href="[% referer or '/cgi-bin/koha/circ/circulation.pl' %]">Cancel</a> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12744 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Marc Véron from comment #3)
Would the following be better?
<a class="cancel" id="cancel_set_library" href="[% referer or '/cgi-bin/koha/circ/circulation.pl' %]">Cancel</a>
Yes. If you found instances where there is an empty onclick attribute the onclick should be removed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12744 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30691|0 |1 is obsolete| | --- Comment #5 from Marc Véron <veron@veron.ch> --- Created attachment 30704 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30704&action=edit Bug 12744 - Set language in staff client should have 'Cancel' link Test plan Without patch: Click on Library name in head of any staff client page anc choose 'Set library' Result: Form 'Set library' with no 'Cancel' near 'Submit' button With patch: Form displays 'Cancel' link. This link closes the form and takes you back to the page where you came from. New patch without empty "onclick" attribute. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12744 --- Comment #6 from Marc Véron <veron@veron.ch> --- Mistaked with git add. New patch follows. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12744 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30704|0 |1 is obsolete| | --- Comment #7 from Marc Véron <veron@veron.ch> --- Created attachment 30707 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30707&action=edit Bug 12744 - Set language in staff client should have 'Cancel' link Test plan Without patch: Click on Library name in head of any staff client page anc choose 'Set library' Result: Form 'Set library' with no 'Cancel' near 'Submit' button With patch: Form displays 'Cancel' link. This link closes the form and takes you back to the page where you came from. New patch without empty "onclick" attribute. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12744 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12744 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30707|0 |1 is obsolete| | --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 30746 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30746&action=edit [SIGNED-OFF] Bug 12744 - Set language in staff client should have 'Cancel' link Test plan Without patch: Click on Library name in head of any staff client page anc choose 'Set library' Result: Form 'Set library' with no 'Cancel' near 'Submit' button With patch: Form displays 'Cancel' link. This link closes the form and takes you back to the page where you came from. New patch without empty "onclick" attribute. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12744 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Summary|Set language in staff |Set library in staff client |client should have 'Cancel' |should have 'Cancel' link |link | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12744 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12744 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30746|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 30876 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30876&action=edit [PASSED QA] Bug 12744 - Set language in staff client should have 'Cancel' link Test plan Without patch: Click on Library name in head of any staff client page anc choose 'Set library' Result: Form 'Set library' with no 'Cancel' near 'Submit' button With patch: Form displays 'Cancel' link. This link closes the form and takes you back to the page where you came from. New patch without empty "onclick" attribute. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Nice patch, no problems found. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12744 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12744 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Marc! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org