[Bug 36789] New: Transform a booking into checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 Bug ID: 36789 Summary: Transform a booking into checkout Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: thibaud.guillot@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Hello, Linked to the booking feeture you can now transform a booking into a checkout directly from the booking list view. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |36271 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36271 [Bug 36271] Bookings should respect circulation rules for max loan periods -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |thibaud.guillot@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 --- Comment #1 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 166213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166213&action=edit Bug 36789: Transform a booking into checkout Directly from the bookings list, you can perform a checkout with booked item. Test plan: 1) Got an item booked :) 2) Click on transform to checkout 3) Normally you will be redirected to circulation.pl checkout view with form infos from booking (due date is calculated from today + booking length period - new circulation rule - see bug 36271) 4) If issue is confirmed, the booking will be deleted. Sponsored by: Association de Gestion des Œuvres Sociales d'Inria (AGOS) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 Marie <marie.hedbom@musikverket.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marie.hedbom@musikverket.se -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 --- Comment #2 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 167191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167191&action=edit Bug 36789: Fix format when hours or minutes contain only one digit -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166213|0 |1 is obsolete| | Attachment #167191|0 |1 is obsolete| | --- Comment #3 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 167242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167242&action=edit Bug 36789: Transform a booking into checkout Directly from the bookings list, you can perform a checkout with booked item. Test plan: 1) Got an item booked :) 2) Click on transform to checkout 3) Normally you will be redirected to circulation.pl checkout view with form infos from booking (due date is calculated from today + booking length period - new circulation rule - see bug 36271) 4) If issue is confirmed, the booking will be deleted. Sponsored by: Association de Gestion des Œuvres Sociales d'Inria (AGOS) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167242|0 |1 is obsolete| | --- Comment #4 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 167246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167246&action=edit Bug 36789: Transform a booking into checkout Directly from the bookings list, you can perform a checkout with booked item. Test plan: 1) Got an item booked :) 2) Click on transform to checkout 3) Normally you will be redirected to circulation.pl checkout view with form infos from booking (due date is calculated from today + booking length period - new circulation rule - see bug 36271) 4) If issue is confirmed, the booking will be deleted. Sponsored by: Association de Gestion des Œuvres Sociales d'Inria (AGOS) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 --- Comment #5 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 167268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167268&action=edit Bug 36789: Pass param to prevent notification on checkout transformation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |36915 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 [Bug 36915] Send email notification when a booking is cancelled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167246|0 |1 is obsolete| | Attachment #167268|0 |1 is obsolete| | --- Comment #6 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 167307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167307&action=edit Bug 36789: Transform a booking into checkout Directly from the bookings list, you can perform a checkout with booked item. Test plan: 1) Got an item booked :) 2) Click on transform to checkout 3) Normally you will be redirected to circulation.pl checkout view with form infos from booking. 4) If issue is confirmed, the booking will be deleted. Sponsored by: Association de Gestion des Œuvres Sociales d'Inria (AGOS) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167307|0 |1 is obsolete| | --- Comment #7 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 167309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167309&action=edit Bug 36789: Transform a booking into checkout Directly from the bookings list, you can perform a checkout with booked item. Test plan: 1) Got an item booked :) 2) Click on transform to checkout 3) Normally you will be redirected to circulation.pl checkout view with form infos from booking. 4) If issue is confirmed, the booking will be deleted. Sponsored by: Association de Gestion des Œuvres Sociales d'Inria (AGOS) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167309|0 |1 is obsolete| | --- Comment #8 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 167311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167311&action=edit Bug 36789: Transform a booking into checkout Directly from the bookings list, you can perform a checkout with booked item. Test plan: 1) Got an item booked :) 2) Click on transform to checkout 3) Normally you will be redirected to circulation.pl checkout view with form infos from booking. 4) If issue is confirmed, the booking will be deleted. Sponsored by: Association de Gestion des Œuvres Sociales d'Inria (AGOS) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #9 from David Nind <david@davidnind.com> --- Something in one of the dependencies cases bug 36915 to not apply (although 36915 applies OK by itself). Will re-test once dependencies fixed. git bz apply 36789 Bug 36789 Depends on bug 36271 (Needs Signoff) Follow? [(y)es, (n)o] y Bug 36271 Depends on bug 35906 (Signed Off) Follow? [(y)es, (n)o] y Bug 35906 - Add bookable option on itemtypes 166866 - Bug 35906: Add bookable option on itemtype 166867 - Bug 35906: Add unit test 166868 - Bug 35906: Remove preference and add override handling 166869 - Bug 35906: Schema dump 166870 - Bug 35906: (QA follow-up) Fix item-type schema 166871 - Bug 35906: (follow-up) rebased it Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 35906: Add bookable option on itemtype Applying: Bug 35906: Add unit test Applying: Bug 35906: Remove preference and add override handling Applying: Bug 35906: Schema dump Applying: Bug 35906: (QA follow-up) Fix item-type schema Applying: Bug 35906: (follow-up) rebased it Bug 36271 - Bookings should respect circulation rules for max loan periods 166962 - Bug 36271: Add circulation rules for booking Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 36271: Add circulation rules for booking Bug 36789 Depends on bug 36915 (Failed QA) Follow? [(y)es, (n)o] y Bug 36915 - Send email notification when a booking is cancelled 167013 - Bug 36915: Send email notification when a booking is cancelled Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 36915: Send email notification when a booking is cancelled Using index info to reconstruct a base tree... M Koha/Booking.pm Falling back to patching base and 3-way merge... Auto-merging Koha/Booking.pm CONFLICT (content): Merge conflict in Koha/Booking.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 36915: Send email notification when a booking is cancelled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167311|0 |1 is obsolete| | --- Comment #10 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 167368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167368&action=edit Bug 36789: Transform a booking into checkout Directly from the bookings list, you can perform a checkout with booked item. Test plan: 1) Got an item booked :) 2) Click on transform to checkout 3) Normally you will be redirected to circulation.pl checkout view with form infos from booking. 4) If issue is confirmed, the booking will be deleted. Sponsored by: Association de Gestion des Œuvres Sociales d'Inria (AGOS) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|36271 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36271 [Bug 36271] Bookings should respect circulation rules for max loan periods -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167368|0 |1 is obsolete| | --- Comment #11 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 167369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167369&action=edit Bug 36789: Transform a booking into checkout Directly from the bookings list, you can perform a checkout with booked item. Test plan: 1) Got an item booked :) 2) Click on transform to checkout 3) Normally you will be redirected to circulation.pl checkout view with form infos from booking. 4) If issue is confirmed, the booking will be deleted. Sponsored by: Association de Gestion des Œuvres Sociales d'Inria (AGOS) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 --- Comment #12 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- (In reply to David Nind from comment #9)
Something in one of the dependencies cases bug 36915 to not apply (although 36915 applies OK by itself).
Will re-test once dependencies fixed.
git bz apply 36789
Bug 36789 Depends on bug 36271 (Needs Signoff) Follow? [(y)es, (n)o] y
Bug 36271 Depends on bug 35906 (Signed Off) Follow? [(y)es, (n)o] y
Bug 35906 - Add bookable option on itemtypes
166866 - Bug 35906: Add bookable option on itemtype 166867 - Bug 35906: Add unit test 166868 - Bug 35906: Remove preference and add override handling 166869 - Bug 35906: Schema dump 166870 - Bug 35906: (QA follow-up) Fix item-type schema 166871 - Bug 35906: (follow-up) rebased it
Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 35906: Add bookable option on itemtype Applying: Bug 35906: Add unit test Applying: Bug 35906: Remove preference and add override handling Applying: Bug 35906: Schema dump Applying: Bug 35906: (QA follow-up) Fix item-type schema Applying: Bug 35906: (follow-up) rebased it
Bug 36271 - Bookings should respect circulation rules for max loan periods
166962 - Bug 36271: Add circulation rules for booking
Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 36271: Add circulation rules for booking
Bug 36789 Depends on bug 36915 (Failed QA) Follow? [(y)es, (n)o] y
Bug 36915 - Send email notification when a booking is cancelled
167013 - Bug 36915: Send email notification when a booking is cancelled
Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 36915: Send email notification when a booking is cancelled Using index info to reconstruct a base tree... M Koha/Booking.pm Falling back to patching base and 3-way merge... Auto-merging Koha/Booking.pm CONFLICT (content): Merge conflict in Koha/Booking.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 36915: Send email notification when a booking is cancelled
Hi David, Thanks for your feedback.. I fixed it (after changes there is only one dependency :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #13 from David Nind <david@davidnind.com> --- I get a 403 error after clicking on "Transform to checkout": An error has occurred! Error 403 Programming error - No CSRF token passed for POST http://127.0.0.1:8081/intranet/circ/circulation.pl?borrowernumber=49 (referer: http://127.0.0.1:8081/cgi-bin/koha/bookings/list.pl?biblionumber=126&searchid=scs_1717528289710) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 --- Comment #14 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 167602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167602&action=edit Bug 36789: (follow-up) Fix CSRF Token missing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 --- Comment #15 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- (In reply to David Nind from comment #13)
I get a 403 error after clicking on "Transform to checkout":
An error has occurred! Error 403 Programming error - No CSRF token passed for POST http://127.0.0.1:8081/intranet/circ/circulation.pl?borrowernumber=49 (referer: http://127.0.0.1:8081/cgi-bin/koha/bookings/list. pl?biblionumber=126&searchid=scs_1717528289710)
Hello David, Thanks for your feedback, It seems fixed now -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 Sylvain Def. <s.deflache@ville-caluire.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |s.deflache@ville-caluire.fr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167369|0 |1 is obsolete| | --- Comment #16 from David Nind <david@davidnind.com> --- Created attachment 167906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167906&action=edit Bug 36789: Transform a booking into checkout Directly from the bookings list, you can perform a checkout with booked item. Test plan: 1) Got an item booked :) 2) Click on transform to checkout 3) Normally you will be redirected to circulation.pl checkout view with form infos from booking. 4) If issue is confirmed, the booking will be deleted. Sponsored by: Association de Gestion des Œuvres Sociales d'Inria (AGOS) Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167602|0 |1 is obsolete| | --- Comment #17 from David Nind <david@davidnind.com> --- Created attachment 167907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167907&action=edit Bug 36789: (follow-up) Fix CSRF Token missing Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 --- Comment #18 from David Nind <david@davidnind.com> --- Thanks Thibaud! Can confirm that the patches now apply and works as expected. Have added my sign-off as well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This is the sort of workflow I was alluding to when I said in bug 36915 that perhaps we don't want to tie the cancellation notice to the delete method but rather introduce a cancel method instead. I'm also not really sure about removing bookings at fulfilment time.. I can see people wanting to report on those fulfilled and unfulfilled bookings down the line. I was considering instead, adding a status field to bookings to flag that a booking is in various states... waiting, fulfilled, overdue for pickup, cancelled.. etc. Then, adding to cleanup_database to ensure we don't have a runaway table of data. Thoughts? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kkrueger@cuyahogalibrary.or | |g -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37201 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37201 [Bug 37201] Add a syspref to allow or not a checkout if a expired booking exists for the same patron -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #20 from David Nind <david@davidnind.com> --- The patches no longer apply 8-(... git bz apply 36789 Bug 36789 Depends on bug 36915 (Needs Signoff) Follow? [(y)es, (n)o] y Bug 36915 - Send email notification when a booking is cancelled 168149 - Bug 36915: Send email notification when a booking is cancelled 168150 - Bug 36915: (follow-up) Pass object to GetPreparedLetter 168155 - Bug 36915: (follow-up) Basic sample notice Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 36915: Send email notification when a booking is cancelled Applying: Bug 36915: (follow-up) Pass object to GetPreparedLetter Applying: Bug 36915: (follow-up) Basic sample notice Bug 36789 - Transform a booking into checkout 167906 - Bug 36789: Transform a booking into checkout 167907 - Bug 36789: (follow-up) Fix CSRF Token missing Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 36789: Transform a booking into checkout Using index info to reconstruct a base tree... M C4/Circulation.pm M Koha/Booking.pm M koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt Auto-merging Koha/Booking.pm CONFLICT (content): Merge conflict in Koha/Booking.pm Auto-merging C4/Circulation.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 36789: Transform a booking into checkout -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 --- Comment #21 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 170198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170198&action=edit Bug 36789: (follow-up) rebase after using object directly in letter -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 --- Comment #22 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- (In reply to Martin Renvoize from comment #19)
This is the sort of workflow I was alluding to when I said in bug 36915 that perhaps we don't want to tie the cancellation notice to the delete method but rather introduce a cancel method instead.
I'm also not really sure about removing bookings at fulfilment time.. I can see people wanting to report on those fulfilled and unfulfilled bookings down the line.
I was considering instead, adding a status field to bookings to flag that a booking is in various states... waiting, fulfilled, overdue for pickup, cancelled.. etc. Then, adding to cleanup_database to ensure we don't have a runaway table of data.
Thoughts?
Hello Yes, it might be useful to create a cancel method to mark them with a "status". Maybe we can also move bookings to "old_bookings" like holds/old_holds I mean.... For now I'll just quickly rebase the patch if anyone wants to test it and make up their own mind :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.derscheid@lmscloud.de --- Comment #23 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Concerning the status from comment #22: There's bug 37601, where we want to do exactly that. Then we want to move the logic within delete into a cancel method in a follow-up to 37601 and 39615. This will require rebases on the children of this bug again, so let's get the root through first would be my recommendation. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 --- Comment #24 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Sorry meant bug 36915 in comment #23. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Circulation| |bookings function| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #25 from David Nind <david@davidnind.com> --- The patch no longer applies 8-(... git bz apply 36789 Bug 36789 - Transform a booking into checkout 167906 - Bug 36789: Transform a booking into checkout 167907 - Bug 36789: (follow-up) Fix CSRF Token missing 170198 - Bug 36789: (follow-up) rebase after using object directly in letter Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 36789: Transform a booking into checkout Using index info to reconstruct a base tree... M C4/Circulation.pm M Koha/Booking.pm M circ/circulation.pl M koha-tmpl/intranet-tmpl/prog/en/modules/bookings/list.tt M koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/bookings/list.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/bookings/list.tt Auto-merging circ/circulation.pl Auto-merging Koha/Booking.pm CONFLICT (content): Merge conflict in Koha/Booking.pm Auto-merging C4/Circulation.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 36789: Transform a booking into checkout -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167906|0 |1 is obsolete| | --- Comment #26 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 171553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171553&action=edit Bug 36789: Transform a booking into checkout Directly from the bookings list, you can perform a checkout with booked item. Test plan: 1) Got an item booked :) 2) Click on transform to checkout 3) Normally you will be redirected to circulation.pl checkout view with form infos from booking. 4) If issue is confirmed, the booking will be deleted. Sponsored by: Association de Gestion des Œuvres Sociales d'Inria (AGOS) Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167907|0 |1 is obsolete| | --- Comment #27 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 171554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171554&action=edit Bug 36789: (follow-up) Fix CSRF Token missing Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170198|0 |1 is obsolete| | --- Comment #28 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 171555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171555&action=edit Bug 36789: (follow-up) rebase after using object directly in letter -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 Olivier Vezina <ovezina@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171553|0 |1 is obsolete| | --- Comment #29 from Olivier Vezina <ovezina@inlibro.com> --- Created attachment 172058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172058&action=edit Bug 36789: Transform a booking into checkout Directly from the bookings list, you can perform a checkout with booked item. Test plan: 1) Got an item booked :) 2) Click on transform to checkout 3) Normally you will be redirected to circulation.pl checkout view with form infos from booking. 4) If issue is confirmed, the booking will be deleted. Sponsored by: Association de Gestion des Œuvres Sociales d'Inria (AGOS) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Olivier V <olivier.vezina@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 Olivier Vezina <ovezina@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171554|0 |1 is obsolete| | --- Comment #30 from Olivier Vezina <ovezina@inlibro.com> --- Created attachment 172059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172059&action=edit Bug 36789: (follow-up) Fix CSRF Token missing Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Olivier V <olivier.vezina@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 Olivier Vezina <ovezina@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171555|0 |1 is obsolete| | --- Comment #31 from Olivier Vezina <ovezina@inlibro.com> --- Created attachment 172060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172060&action=edit Bug 36789: (follow-up) rebase after using object directly in letter Signed-off-by: Olivier V <olivier.vezina@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 Olivier Vezina <ovezina@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ovezina@inlibro.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 Koha collecto <koha@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha@collecto.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA QA Contact|testopia@bugs.koha-communit |lisette@bywatersolutions.co |y.org |m CC| |lisette@bywatersolutions.co | |m --- Comment #32 from Lisette Scheer <lisette@bywatersolutions.com> --- Please rebase and then I'll qa ASAP. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172058|0 |1 is obsolete| | Attachment #172059|0 |1 is obsolete| | Attachment #172060|0 |1 is obsolete| | --- Comment #33 from Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> --- Created attachment 176452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176452&action=edit Bug 36789: Transform a booking into checkout Directly from the bookings list, you can perform a checkout with booked item. Test plan: 1) Got an item booked :) 2) Click on transform to checkout 3) Normally you will be redirected to circulation.pl checkout view with form infos from booking. 4) If issue is confirmed, the booking will be deleted. Sponsored by: Association de Gestion des Œuvres Sociales d'Inria (AGOS) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Olivier V <olivier.vezina@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 --- Comment #34 from Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> --- Created attachment 176453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176453&action=edit Bug 36789: (follow-up) Fix CSRF Token missing Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Olivier V <olivier.vezina@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 --- Comment #35 from Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> --- Hello :) Rebased and removal delete overload method due to implementation of _send_notices method. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #36 from Lisette Scheer <lisette@bywatersolutions.com> --- FAIL koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt FAIL filters missing_filter at line 1074 ( var booking_id = [% booking_id.json %];) In order to prevent XSS vulnerabilities all the variables displayed in the templates must be escaped using an appropriate filter. See Bug 13618 for more information. Not all of them are concerned by the vulnerability but to be on the safe side we are going to escape them all. Usually you will want to use the filters provided by TT: html, uri, url, etc. And sometimes we will want to display the variable as it is, i.e. you will want to make the browser interpret the content (HTML or JavaScript), in that case you will explicitly use the raw filter, that does nothing. https://wiki.koha-community.org/wiki/Coding_Guidelines#HTML9:_Filter_all_tem... There's also 2 tidy warnings, one line each in C4/Circulation.pm & circ/circulation.pl It worked great, and once you add the filter I'm happy to pqa. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 --- Comment #37 from Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> --- Created attachment 176489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176489&action=edit Bug 36789: (follow-up) add JSON filter -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 --- Comment #38 from Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> --- Thanks Lisette for your time, I fixed this, sorry for missing ^^ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com Status|Signed Off |Failed QA --- Comment #39 from Jonathan Druart <jonathan.druart@gmail.com> --- 1. +++ b/bookings/list.pl +use Koha::Biblios; +use Koha::Bookings; +use Koha::Patrons; +use Koha::Items; +use Koha::CirculationRules; Hum? -my $biblio = Koha::Biblios->find($biblionumber); +my $biblio = Koha::Biblios->find( { biblionumber => $biblionumber } ); Hum?? 2. Change in pm not covered by tests 3. 393 result += `<form name="checkout-transform" method="post" action="/cgi-bin/koha/circ/circulation.pl?borrowernumber=${row.patron_id}"><input type="hidden" name="op" value="cud-checkout"/><input type="hidden" name="borrowernumber" value="${row.patron_id}"/><input type="hidden" name="barcode" value="${row.item.external_id}"/><input type="hidden" name="duedatespec" value="${row.end_date}"/><input type="hidden" name="booking_id" value="${row.booking_id}"/><input type="hidden" name="csrf_token" value="${csrf_token}"/><button id="checkout_action" class="btn btn-default btn-xs" type="submit">${_("Transform to checkout")}</button></form>`; This line is 660 chars long, it's not readable. Additionally, all variables from the REST API must be escaped (using escape_str) I also think you will gain in readability using .format() and bind parameters. 4. JS error on circulation.pl Uncaught SyntaxError: expected expression, got ';' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=40296 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |DUPLICATE --- Comment #40 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- *** This bug has been marked as a duplicate of bug 40296 *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|DUPLICATE |--- Status|RESOLVED |REOPENED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |40296 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40296 [Bug 40296] Bookings that are checked out do not have status updated to completed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 --- Comment #41 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Hi there, I have tested this and it seems all changes in this patch are superseded by Bug 40296 except for the actual button in bookings/list.tt. I already tried out to transform just keeping the button change and it seemed to behave as expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |40656 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40656 [Bug 40656] bookings/list.tt needs to be refactored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176452|0 |1 is obsolete| | Attachment #176489|0 |1 is obsolete| | --- Comment #42 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 185472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185472&action=edit Bug 36789: Transform a booking into checkout Directly from the bookings list, you can perform a checkout with booked item. Test plan: 1) Got an item booked :) 2) Click on transform to checkout 3) Normally you will be redirected to circulation.pl checkout view with form infos from booking. 4) If issue is confirmed, the booking will be deleted. Sponsored by: Association de Gestion des Œuvres Sociales d'Inria (AGOS) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Olivier V <olivier.vezina@inLibro.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176453|0 |1 is obsolete| | --- Comment #43 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 185473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185473&action=edit Bug 36789: (follow-up) Fix CSRF Token missing Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Olivier V <olivier.vezina@inLibro.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 --- Comment #44 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 185474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185474&action=edit Bug 36789: (follow-up) Adjust bookings/list.tt to handle bookings completed status - Add fa-check-circle as an icon to "Transform to checkout" button - Remove unncessary booking_id input, placeholder and value in format call. - Include completed in - editable property of vis-timeline - filters array of additional filters include - init call to AdditionalFilters lib - onChange handler of AdditionalFilters lib - condition for rendering actions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|40296 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40296 [Bug 40296] Bookings that are checked out do not have status updated to completed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185472|0 |1 is obsolete| | --- Comment #45 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 185878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185878&action=edit Bug 36789: Transform a booking into checkout Directly from the bookings list, you can perform a checkout with booked item. Test plan: 1) Got an item booked :) 2) Click on transform to checkout 3) Normally you will be redirected to circulation.pl checkout view with form infos from booking. 4) If issue is confirmed, the booking will be completed. Sponsored-by: Association de Gestion des Œuvres Sociales d'Inria (AGOS) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Olivier V <olivier.vezina@inLibro.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185473|0 |1 is obsolete| | --- Comment #46 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 185879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185879&action=edit Bug 36789: (follow-up) Fix CSRF Token missing Sponsored-by: LMS Cloud <https://www.lmscloud.de/> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Olivier V <olivier.vezina@inLibro.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185474|0 |1 is obsolete| | --- Comment #47 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 185880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185880&action=edit Bug 36789: (follow-up) Adjust bookings/list.tt to handle bookings completed status - Add fa-check-circle as an icon to "Transform to checkout" button - Remove unncessary booking_id input, placeholder and value in format call. - Include completed in - editable property of vis-timeline - filters array of additional filters include - init call to AdditionalFilters lib - onChange handler of AdditionalFilters lib - condition for rendering actions Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|lisette@bywatersolutions.co |martin.renvoize@openfifth.c |m |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 --- Comment #48 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.11.00 |25.11.00,25.05.04 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 --- Comment #49 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #50 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 24.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 Bug 36789 depends on bug 40656, which changed state. Bug 40656 Summary: bookings/list.tt needs to be refactored https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40656 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 Bug 36789 depends on bug 36915, which changed state. Bug 36915 Summary: Send email notification when a booking is cancelled https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41898 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41898 [Bug 41898] Expired bookings do not display when expired filter is used in patron record -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org