https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002 --- Comment #2 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Because users can go through the web installer and onboarding tool then get straight to work cataloguing items (which is likely to be the first thing they do) I suggest that the acquisition onboarding functionality (required by this bug report) be placed as a independent onboarding tool when the user first goes into the acquisition area to help the user to create a budget, fund, vendor and basket. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002 --- Comment #3 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 59910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59910&action=edit Bug 18002 - Added in modal box and message (outside of modal box) for when users first visit Acquisitions. These messages are in place of the unclear yellow warning messages. Test plan: 1. Drop and recreate your database 2. Go through the web installer without installing any optional data values 3. Visit Acquisitions you should see two large yellow warning message boxes telling you to specify a currency and a budget 4. Apply this patch 5. Refresh the Acquisitions page. Instead of the two yellow warning messages you will see a message sentence telling you to create a currency (providing you with a link). As well as a modal box fading in specifying (with links) the steps you need to do to set up Acquisitions, in the following order: create budget, fund, vendor and basket -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002 --- Comment #7 from Alex Buckley <alexbuckley@catalyst.net.nz> --- (in reply to M.Tompsett in comment 5) An interesting feature I have just noticed is that loop_budget is always returned as null so that the acquisitionsModal div is always displayed even if the user has created a budget. On my system this is not specific to bug 18002, I also get it when testing on my master branch, as the warning telling the user to define a budget is displayed even if there are multiple budgets. Do you also find the message appears even when you have created a budget? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002 --- Comment #8 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Please disregard comment 7 as I was logging in as the database administrator and so the acquisitions message was being displayed constantly as I was not tied to a particular branch. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #10 from Alex Buckley <alexbuckley@catalyst.net.nz> --- (in reply to M.Tompsett in comment 5) In the most recent commit patch I have attached to this bug I removed the inline styling into an internal style sheet at the top of the acqui-home.tt file. Additionally I removed the errant warn from the acqui-home.pl script. Test plan: 1. From the main page of the staff client click go to More->Acquisitions (making sure there is no currency and budget and fund in the Koha database. Also make sure you are logged in as a superlibrarian user not the database administrator). 2. Notice the yellow warning messages: One telling the user to create a currency and the other informing the user to create a budget it doesn't say you have to create a fund as well which could be confusing for new users after they have created the budget). 3. Apply this bug. 4. Refresh the Acquisitions page and you will see a message telling the user to specify a currency outside a div box, whilst the other is in a div box (with the Koha staff client light grey/blue background colour). The message inside the coloured div box contains numbered links clearly showing what the user must do to set up acquisitions. Each link opens in a new tab, saving the user from having to go back to the main acquisitions page constantly. 5. Create a currency 6. Refresh the main Acquisitions page and notice that the currency notice has disappeared. 7. Click the two links to create a budget and fund then refresh the main acquisitions page and the coloured div message box has disappeared because the user has set up the Acquisitions successfully. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Installation and upgrade |Acquisitions |(web-based installer) | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Clarify the initial setup |Make onboarding tool |of Acquisitions with |include framework to be |onboarding message when |embedded in Acquisitions to |user arrives in |help the users set up |Acquisitions without |Acquisitions for the first |currency, budget and fund |time -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002 --- Comment #12 from Alex Buckley <alexbuckley@catalyst.net.nz> --- To clarify how the patches for this bug report are going to help the users set up their acquisitions area below is a description of how the developing onboarding tool include will work: I am developing the acquisitions onboarding tool as an include displayed by the the acqui-home.tt file. So it will appear to users as a div box on the acquisitions home page. If the user is exploring Koha for the first time and visits the acquisition home page for the first time this onboarding tool box will appear but if the user does not want to set up Acquisitions yet they can simply use the Koha global navigation to navigate to a new page, they are not forced to use the acquisitions onboarding tool. The acquisitions onboarding tool box will be displayed everytime the user visits the acquisitions home page until they use it to set up their acquisitions. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002 --- Comment #14 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 60677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60677&action=edit Bug 18002 - Added add fund form to the onboardinginclude.inc file to be displayed after users have created a budget in the add budget form also in the onboardinginclude.inc -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002 --- Comment #16 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 60679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60679&action=edit Bug 18002 - Successful insertion of budget and fund in the acquisitions onboarding tool followed by the acquisition home page being displayed. Also the order of the form display in the acquisition onboarding tool is now correct with the budget being displayed first then fund. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60680|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59911|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60676|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60678|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002 --- Comment #18 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 60681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60681&action=edit Bug 18002 - Added a new include (onboardinginclude.inc) which displays a form for the user to create a budget. Bug 18002 - Added in modal box and message (outside of modal box) for when users first visit Acquisitions. These messages are in place of the unclear yellow warning messages. Test plan: 1. Drop and recreate your database 2. Go through the web installer without installing any optional data values 3. Visit Acquisitions you should see two large yellow warning message boxes telling you to specify a currency and a budget 4. Apply this patch 5. Refresh the Acquisitions page. Instead of the two yellow warning messages you will see a message sentence telling you to create a currency (providing you with a link). As well as a modal box fading in specifying (with links) the steps you need to do to set up Acquisitions, in the following order: create budget, fund, vendor and basket Bug 18002 - Removed the Javascript preventing the display of currency and acquisition setup messages at the same time Bug 18002 - Removed errant warn and inline styling into an internal style sheet -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60681|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002 --- Comment #20 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 60683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60683&action=edit Bug 18002 - Created a budget creation onboarding form to be displayed when the user first visits the acquisition area -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60683|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002 --- Comment #22 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 60685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60685&action=edit Bug 18002 - Created a budget creation onboarding form to be displayed when the user first visits the acquisition area -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002 --- Comment #24 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 60687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60687&action=edit Bug 18002 - Created two includes onboardinginclude.inc and onboardinginclude2.inc which contain the budget and fund creation forms respectively Both these forms successfully insert records into the database -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #26 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Test plan: 1. Drop and recreate your database 2. Restart memcached: sudo service memcached restart 3. Go through the web installer 4. Go to More->acquisitions 5. Notice the warnings telling you that you need to create a budget 6. Create a budget and return to the acqui-home.pl page 7. Notice the warning to create a budget is still being displayed 8. Apply the patches in this bug: git bz apply 18002 9. Redo steps 1,2,3,4 10. Notice there is a box containing a simplified form for you to create a budget is displayed on acqui-home.pl (no warning message being displayed) 11. Create a budget using this form and submit the form 12. Notice a simplified form containing a simplified form for you to create a fund is displayed on acqui-home.pl 13. Create a fund using this form and submit it 14. Notice the fund you have created is displayed in a table in the subsequent acqui-home.pl screen 15. Click on Budgets->Add fund 16. Create and save a fund 17.Notice how this fund form in aqbudgets.pl redirects you back to aqbudgets.pl after you have saved the fund form -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002 --- Comment #27 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 61987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61987&action=edit Bug 18002 - Implemented currency creation form which is the first file to be displayed if the user did not install sample currencies during installation. Implemented new colour scheme to match the blue/grey Koha staff interface colours. Implemented text about what is happening in all forms, in addition to a hidden 'Next steps' help text on the acqui-home.tt page which will appear when the user hits the button clearly visible on the same page. This Next steps text tells the user how to create a vendor (link supplied), basket and order I have defaulted the budget active checkbox and currency active checkboxes to be ticked. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002 --- Comment #29 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Test plan: 1. Restart memcached: sudo service memcached restart 2. Drop and recreate the database 3. Go through the web installer selecting all data values (except the basic currencies) 4. After the web installer is finished log into the staff interface using database admin credentials 5. Create a patron and assign superlibrarian permissions to them 6. Log out of staff interface and log back in as the new user you just created 7. Go to More->Acquisitions 8. Notice yellow/orange warning message telling you to create a budget 9. Apply the patches attached to this bug report 10. Repeat steps 1,2,3,4,5,6,7 11. Notice instead of warning messages a currency creation form appears along with explanation of what a currency is and why the user is being asked to fill this form out. Fill out and submit this form. Notice active checkbox is ticked by default 12. A budget creation form is displayed along with an explanation of budgets above it. Fill this form out and submit it. Notice active checkbox is ticked by default. 13. A fund creation form appears (again with explanation text above it), fill it out and submit it 14. The coloured acquisition onboard box disappears and a table of created funds is displayed and should show the fund you just created 15. On the left of the screen below the text 'Administration' click on 'Funds' and delete the fund you just created 16. Click on More->Acquisitions and observe how the funds form is displayed rather than the currency or budget forms (because we already have a currency and budget in the database). Fill out the fund form and submit it. 17. Again you'll notice the fund table is displayed 18. On the left of the screen click on 'Budget' and delete your budget 19. Navigate to More->Acquisitions and observe how this time the budget form is displayed. Fill out this form and submit it. You should be redirected to the Budget Information page (aqbudgetperiods.pl) where you can click Actions->Add fund to add a fund. 20. Repeat steps 1,2,3,4,5,6,7 but making sure to install all sample data in the web installer including the basic currencies 21. Notice this time because you have installed basic currencies the first form to appear is the budget creation form -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002 --- Comment #31 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Patches eyeball well on first glance otherwise! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60686|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60688|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61988|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63150|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #34 from Marc Véron <veron@veron.ch> --- Works nicely. QA tools still have something to complain about: FAIL koha-tmpl/intranet-tmpl/prog/en/includes/onboardinginclude3.inc FAIL valid_template : filter not found FAIL koha-tmpl/intranet-tmpl/prog/en/modules/acqui/acqui-home.tt FAIL spelling seperate ==> separate -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002 --- Comment #35 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 63380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63380&action=edit Bug 18002 - Created a budget creation onboarding form to be displayed when the user first visits the acquisition area -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63380|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002 --- Comment #38 from Alex Buckley <alexbuckley@catalyst.net.nz> --- I have fixed up the spelling mistake that was causing a qa error in acqui-home.tt and I have implemented [% USE Price %] at the top of the onboardinginclude3.inc file (thanks to Marc Veron for the suggestion), so both errors should now be fixed. The two qa errors were not being thrown on my machine before making these changes and so I cannot guarantee that this patch has fixed the two errors. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63456|0 |1 is obsolete| | Attachment #63456|1 |0 is patch| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002 --- Comment #41 from Marc Véron <veron@veron.ch> --- Created attachment 64746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64746&action=edit Can not scroll down Acquisition onboarding wizard If the browser window is not high enough for the Acquisition onboarding wizard, you can not scroll down to make visible the whole modal dialog. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=4078 --- Comment #43 from Marc Véron <veron@veron.ch> --- (In reply to Marc Véron from comment #42)

The active currency must have an exchange rate of 1. However, the wizard allows to enter a different value.

I think - the checkbox "Active" should be checked and read-only (maybe hidden?) - the exchange rate should be set to 1 and read-only (maybe hidden?) BTW I'm not sure, should not the currency be already defined in the onboarding process immediately after installing? - Since the active currency is important not only for acquisition, but should / will be used for fines etc. as well (at least the symbol), see Bug 4078. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002 --- Comment #45 from Marc Véron <veron@veron.ch> --- (In reply to Alex Buckley from comment #44)

Thanks for testing and the feedback Marc

At present the currency is not set in the onboarding process and will only be set if the user chooses to install currencies in the web installer.

However the creation of a currency in the onboarding too could be a good enhancement to the onboarding tool I will make a bug report for that if you like?

+1 :-) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64732|0 |1 is obsolete| | --- Comment #46 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 64765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64765&action=edit Bug 18002 - Created an acquisition onboarding tool to be displayed when no currency, budget, or fund exists Implemented scrolling for acquisition onboarding tool. Hidden the active checkbox for currencies and budget, and made exchange rate readonly (displayed). Same test plan as comment 29. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002 --- Comment #48 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 64947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64947&action=edit Bug 18002: Made rate hidden and removed the overflow attribute of onboardingModal -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002 --- Comment #50 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 66301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66301&action=edit Bug 18002: Followup - Changes based on test feedback In this patch the following changes have been made based on test feedback: * Added POD to GetHighestBudgetPeriod * Removed unconditional warns in Budgets.pm * Fixed typos and uncommented hint and date field * Changed manual link Made the acquisition onboarding tool less visible in the right hand side of the screen rather than in the middle obscuring the rest of the acquisition home page Implemented conditional so this tool is only displayed when the user is superlibrarian Test plan: 1. Restart memcached: sudo service memcached restart 2. Drop and recreate the database 3. Go through the web installer selecting all data values (except the basic currencies) 4. After the web installer is finished log into the staff interface using database admin credentials 5. Create a patron and assign superlibrarian permissions to them 6. Log out of staff interface and log back in as the new user you just created 7. Go to More->Acquisitions 8. Notice yellow/orange warning message telling you to create a budget 9. Apply the patches attached to this bug report 10. Repeat steps 1,2,3,4,5,6,7 11. Notice instead of warning messages a currency creation form appears on the right hand side of the page along with explanation of what a currency is and why the user is being asked to fill this form out. Fill out and submit this form. 12. A budget creation form is displayed along with an explanation of budgets above it. Fill this form out and submit it. 13. A fund creation form appears (again with explanation text above it), fill it out and submit it 14. The acquisition onboard tool disappears from the right of the screen and a table of created funds is displayed and should show the fund you just created 15. On the left of the screen below the text 'Administration' click on 'Funds' and delete the fund you just created 16. Click on More->Acquisitions and observe how the funds form is displayed rather than the currency or budget forms (because we already have a currency and budget in the database). Fill out the fund form and submit it. 17. Again you'll notice the fund table is displayed 18. On the left of the screen click on 'Budget' and delete your budget 19. Navigate to More->Acquisitions and observe how this time the budget form is displayed. Fill out this form and submit it. You should be redirected to the Budget Information page (aqbudgetperiods.pl) where you can click Actions->Add fund to add a fund. 20. Repeat steps 1,2,3,4,5,6,7 but making sure to install all sample data in the web installer including the basic currencies 21. Notice this time because you have installed basic currencies the first form to appear is the budget creation form 22. Repeat step 15 and then create a patron that does not have the superlibrarian permissions and log out and log back in. 23. Go to the Acquisitions module and notice that the yellow message telling you that your administrator must define a budget is displayed Sponsored by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002 --- Comment #52 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Alex, I was not aware that it only showed up for superlibrarians, that makes it 'less invasive' already :) Maybe we can leave it like that for now. About the other error I am not sure - maybe check with some of the other devs on IRC? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002 David Bourgault <david.bourgault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64765|0 |1 is obsolete| | --- Comment #54 from David Bourgault <david.bourgault@inlibro.com> --- Created attachment 67649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67649&action=edit Bug 18002 - Created an acquisition onboarding tool to be displayed when no currency, budget, or fund exists Implemented scrolling for acquisition onboarding tool. Hidden the active checkbox for currencies and budget, and made exchange rate readonly (displayed). Same test plan as comment 29. Signed-off-by: David Bourgault <david.bourgault@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002 David Bourgault <david.bourgault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66301|0 |1 is obsolete| | --- Comment #56 from David Bourgault <david.bourgault@inlibro.com> --- Created attachment 67651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67651&action=edit Bug 18002: Followup - Changes based on test feedback In this patch the following changes have been made based on test feedback: * Added POD to GetHighestBudgetPeriod * Removed unconditional warns in Budgets.pm * Fixed typos and uncommented hint and date field * Changed manual link Made the acquisition onboarding tool less visible in the right hand side of the screen rather than in the middle obscuring the rest of the acquisition home page Implemented conditional so this tool is only displayed when the user is superlibrarian Test plan: 1. Restart memcached: sudo service memcached restart 2. Drop and recreate the database 3. Go through the web installer selecting all data values (except the basic currencies) 4. After the web installer is finished log into the staff interface using database admin credentials 5. Create a patron and assign superlibrarian permissions to them 6. Log out of staff interface and log back in as the new user you just created 7. Go to More->Acquisitions 8. Notice yellow/orange warning message telling you to create a budget 9. Apply the patches attached to this bug report 10. Repeat steps 1,2,3,4,5,6,7 11. Notice instead of warning messages a currency creation form appears on the right hand side of the page along with explanation of what a currency is and why the user is being asked to fill this form out. Fill out and submit this form. 12. A budget creation form is displayed along with an explanation of budgets above it. Fill this form out and submit it. 13. A fund creation form appears (again with explanation text above it), fill it out and submit it 14. The acquisition onboard tool disappears from the right of the screen and a table of created funds is displayed and should show the fund you just created 15. On the left of the screen below the text 'Administration' click on 'Funds' and delete the fund you just created 16. Click on More->Acquisitions and observe how the funds form is displayed rather than the currency or budget forms (because we already have a currency and budget in the database). Fill out the fund form and submit it. 17. Again you'll notice the fund table is displayed 18. On the left of the screen click on 'Budget' and delete your budget 19. Navigate to More->Acquisitions and observe how this time the budget form is displayed. Fill out this form and submit it. You should be redirected to the Budget Information page (aqbudgetperiods.pl) where you can click Actions->Add fund to add a fund. 20. Repeat steps 1,2,3,4,5,6,7 but making sure to install all sample data in the web installer including the basic currencies 21. Notice this time because you have installed basic currencies the first form to appear is the budget creation form 22. Repeat step 15 and then create a patron that does not have the superlibrarian permissions and log out and log back in. 23. Go to the Acquisitions module and notice that the yellow message telling you that your administrator must define a budget is displayed Sponsored by: Catalyst IT Signed-off-by: David Bourgault <david.bourgault@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67649|0 |1 is obsolete| | --- Comment #58 from Charles Farmer <charles.farmer@inlibro.com> --- Created attachment 68108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68108&action=edit Bug 18002 - Created an acquisition onboarding tool to be displayed when no currency, budget, or fund exists Implemented scrolling for acquisition onboarding tool. Hidden the active checkbox for currencies and budget, and made exchange rate readonly (displayed). Same test plan as comment 29. Signed-off-by: David Bourgault <david.bourgault@inlibro.com> Signed-off-by: Charles Farmer <charles.farmer@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67651|0 |1 is obsolete| | --- Comment #60 from Charles Farmer <charles.farmer@inlibro.com> --- Created attachment 68110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68110&action=edit Bug 18002: Followup - Changes based on test feedback In this patch the following changes have been made based on test feedback: * Added POD to GetHighestBudgetPeriod * Removed unconditional warns in Budgets.pm * Fixed typos and uncommented hint and date field * Changed manual link Made the acquisition onboarding tool less visible in the right hand side of the screen rather than in the middle obscuring the rest of the acquisition home page Implemented conditional so this tool is only displayed when the user is superlibrarian Test plan: 1. Restart memcached: sudo service memcached restart 2. Drop and recreate the database 3. Go through the web installer selecting all data values (except the basic currencies) 4. After the web installer is finished log into the staff interface using database admin credentials 5. Create a patron and assign superlibrarian permissions to them 6. Log out of staff interface and log back in as the new user you just created 7. Go to More->Acquisitions 8. Notice yellow/orange warning message telling you to create a budget 9. Apply the patches attached to this bug report 10. Repeat steps 1,2,3,4,5,6,7 11. Notice instead of warning messages a currency creation form appears on the right hand side of the page along with explanation of what a currency is and why the user is being asked to fill this form out. Fill out and submit this form. 12. A budget creation form is displayed along with an explanation of budgets above it. Fill this form out and submit it. 13. A fund creation form appears (again with explanation text above it), fill it out and submit it 14. The acquisition onboard tool disappears from the right of the screen and a table of created funds is displayed and should show the fund you just created 15. On the left of the screen below the text 'Administration' click on 'Funds' and delete the fund you just created 16. Click on More->Acquisitions and observe how the funds form is displayed rather than the currency or budget forms (because we already have a currency and budget in the database). Fill out the fund form and submit it. 17. Again you'll notice the fund table is displayed 18. On the left of the screen click on 'Budget' and delete your budget 19. Navigate to More->Acquisitions and observe how this time the budget form is displayed. Fill out this form and submit it. You should be redirected to the Budget Information page (aqbudgetperiods.pl) where you can click Actions->Add fund to add a fund. 20. Repeat steps 1,2,3,4,5,6,7 but making sure to install all sample data in the web installer including the basic currencies 21. Notice this time because you have installed basic currencies the first form to appear is the budget creation form 22. Repeat step 15 and then create a patron that does not have the superlibrarian permissions and log out and log back in. 23. Go to the Acquisitions module and notice that the yellow message telling you that your administrator must define a budget is displayed Sponsored by: Catalyst IT Signed-off-by: David Bourgault <david.bourgault@inlibro.com> Signed-off-by: Charles Farmer <charles.farmer@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|alexbuckley@catalyst.net.nz |thibaud.guillot@biblibre.co | |m CC| |thibaud.guillot@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.