http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #1 from Chris Cormack <chris@bigballofwax.co.nz> 2011-08-08 08:34:43 UTC --- Created attachment 4883 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4883 Bug 6679 : Fixing a style error to pass Perl::Critic, plus silencing a warn -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> 2011-08-08 09:01:09 UTC --- Created attachment 4885 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4885 Bug 6679: More style errors, plus fixing a security issue -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff Severity|enhancement |minor -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> 2011-08-08 09:43:04 UTC --- Created attachment 4888 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4888 Bug 6679 : scripts under admin style fixed Contrary to common belief, subroutine prototypes do not enable compile-time checks for proper arguments. Don't use them. Defining a named sub within another sub, does not prevent that subroutine being global -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #8 from Frédéric Demians <frederic@tamil.fr> 2011-09-17 06:17:01 UTC --- Created attachment 5446 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5446 Followup patch for acqui/histsearch.pl -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent |P5 Patch Status|Needs Signoff |--- --- Comment #10 from Chris Cormack <chris@bigballofwax.co.nz> 2011-09-21 03:00:17 UTC --- Patches pushed, leaving bug open to catch more Now passing for 130 files -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5483|0 |1 is patch| | Attachment #5483|0 |1 is obsolete| | Attachment #5483|application/octet-stream |text/plain mime type| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ian.walls@bywatersolutions. | |com Patch Status|Needs Signoff |Passed QA --- Comment #12 from Ian Walls <ian.walls@bywatersolutions.com> 2011-09-22 12:06:03 UTC --- Passing latest patch through QA (also consider this my sign off) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent |P5 Patch Status|Passed QA |--- --- Comment #13 from Chris Cormack <chris@bigballofwax.co.nz> 2011-09-23 02:19:55 UTC --- All pushed, leaving open for me -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #16 from Chris Cormack <chris@bigballofwax.co.nz> 2011-10-31 08:18:42 UTC --- Created attachment 6123 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6123 Bug 6679 : cataloguing/ now passing critic tests Declare variables outside of conditionals Don't use prototypes http://www.modernperlbooks.com/mt/2009/08/the-problem-with-prototypes.html Use ":encoding(UTF-8)" to get strict validation. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #17 from Chris Cormack <chris@bigballofwax.co.nz> 2011-11-02 03:02:32 UTC --- Created attachment 6139 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6139 Bug 6679 : Adding license statement and stopping declaring variables in a conditional -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #19 from Chris Cormack <chris@bigballofwax.co.nz> 2011-11-02 03:14:18 UTC --- Created attachment 6141 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6141 Bug 6679 : Don't declare variables in conditionals Don't change $_ in a list context http://search.cpan.org/~elliotjs/Perl-Critic-1.116/lib/Perl/Critic/Policy/Co... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #21 from Chris Cormack <chris@bigballofwax.co.nz> 2011-11-02 03:24:43 UTC --- Created attachment 6143 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6143 Bug 6679 : Don't declare variables in conditionals -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |paul.poulain@biblibre.com AssignedTo|gmcharlt@gmail.com |chris@bigballofwax.co.nz --- Comment #23 from Paul Poulain <paul.poulain@biblibre.com> 2011-11-06 17:04:15 UTC --- The 2nd patch does not work well I think (it also does not apply, but it's easily fixed) in showmarc.pl, before your patch, my biblio with diacritic look like : 200 1 _aMassacre (The) éô ï (éô ï is what i'm expecting) After the patch, it looks like : 200 1 _aMassacre (The) éô ï which is the sign of a double encoded biblio record. Marking "failed QA" for now. The 3rd patch, that updates perlcritic.tt does not apply after that (i've not tested further, I suspect they will conflict because catalogue has not been added Once the showmarc issue is solved, i'll test & push those usefull code cleaning patches as fast as possible -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6143|0 |1 is obsolete| | --- Comment #25 from Paul Poulain <paul.poulain@biblibre.com> 2011-11-06 17:20:38 UTC --- Comment on attachment 6143 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6143 Bug 6679 : Don't declare variables in conditionals this patch has been pushed -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6141|0 |1 is obsolete| | --- Comment #27 from Paul Poulain <paul.poulain@biblibre.com> 2011-11-06 17:21:17 UTC --- Comment on attachment 6141 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6141 Bug 6679 : Don't declare variables in conditionals Don't change $_ in a list context http://search.cpan.org/~elliotjs/Perl-Critic-1.116/lib/Perl/Critic/Policy/Co... this patch has been pushed -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6121|0 |1 is obsolete| | --- Comment #29 from Paul Poulain <paul.poulain@biblibre.com> 2011-11-06 17:30:21 UTC --- Comment on attachment 6121 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6121 Bug 6679: Fixing admin/aqplain :encoding(UTF-8) gives strict validation this patch has been pushed -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #31 from Chris Nighswonger <cnighswonger@foundations.edu> 2011-11-09 20:50:57 UTC --- Created attachment 6271 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6271 Fixing critic complaint: Don't change $_ in a list context -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6122|0 |1 is obsolete| | --- Comment #33 from Paul Poulain <paul.poulain@biblibre.com> 2011-12-08 09:32:38 UTC --- Comment on attachment 6122 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6122 Bug 6679: catalogue/ now passing perl critic tests patch pushed -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6139|0 |1 is obsolete| | --- Comment #35 from Paul Poulain <paul.poulain@biblibre.com> 2011-12-08 09:34:24 UTC --- Comment on attachment 6139 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6139 Bug 6679 : Adding license statement and stopping declaring variables in a conditional patch pushed -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6663|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6271|0 |1 is obsolete| | --- Comment #38 from Paul Poulain <paul.poulain@biblibre.com> 2011-12-08 09:38:20 UTC --- Comment on attachment 6271 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6271 Fixing critic complaint: Don't change $_ in a list context patch already applied (bug 7207) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #40 from Paul Poulain <paul.poulain@biblibre.com> 2011-12-08 16:14:24 UTC --- Created attachment 6670 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6670 Bug 6697: fix missing use strict The 3 files had use strict missing. The patch add the use strict and modify what's needed to work with it 4XX.pl also has some perlcritic fixes: Variable declared in conditional statement at line XXX, column 9. Declare variables outside of the condition. (Severity: 5) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6670|0 |1 is obsolete| | --- Comment #42 from Chris Cormack <chris@bigballofwax.co.nz> 2011-12-08 18:04:41 UTC --- Created attachment 6675 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6675 Bug 6679: fix missing use strict The 3 files had use strict missing. The patch add the use strict and modify what's needed to work with it 4XX.pl also has some perlcritic fixes: Variable declared in conditional statement at line XXX, column 9. Declare variables outside of the condition. (Severity: 5) Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #43 from Chris Nighswonger <cnighswonger@foundations.edu> 2011-12-08 19:14:15 UTC --- (In reply to comment #41)

Which patches chris_n .. they have been marked obsolete and I have lost track of them,

If you list the ones you need ill rebase them.

Here are the commit ids: 4a14e7dbe69db0517d1d333a644c4abeb0a42cb8 a047dea5e46338d3d664935451764fffe56e6d9e dc6e1031f8c2aa36e88ca39a70c5b7d9fd63065d -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #45 from Chris Cormack <chris@bigballofwax.co.nz> 2011-12-08 19:26:46 UTC --- Created attachment 6677 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6677 [3.6.x] Bug 6679 : cataloguing/ now passing critic tests Declare variables outside of conditionals Don't use prototypes http://www.modernperlbooks.com/mt/2009/08/the-problem-with-prototypes.html Use ":encoding(UTF-8)" to get strict validation. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6675|0 |1 is obsolete| | --- Comment #47 from Paul Poulain <paul.poulain@biblibre.com> 2011-12-09 08:52:12 UTC --- Comment on attachment 6675 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6675 Bug 6679: fix missing use strict patch pushed -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent |P1 - high --- Comment #49 from Chris Nighswonger <cnighswonger@foundations.edu> 2011-12-13 14:26:30 UTC --- These patches were applied to 3.6.x last week. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6677|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #50 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 8542 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8542&action=edit Bug 6679 : Fixing perlcritic violation -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #53 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 8897 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8897&action=edit Bug 6679 : Fixing perlcritic violation in authorities/ysearch.pl -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #54 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 8898 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8898&action=edit Bug 6679 members dir now passes perlcritic tests -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8898|0 |1 is obsolete| | --- Comment #56 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 8950 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8950&action=edit Bug 6679 :[SIGNED-OFF] members dir now passes perlcritic tests -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8897|0 |1 is obsolete| | --- Comment #58 from Jonathan Druart <jonathan.druart@biblibre.com> --- Comment on attachment 8897 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8897 Bug 6679 : Fixing perlcritic violation in authorities/ysearch.pl I signed off the same patch (from Colin) today. (Bug 7816) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8950|0 |1 is obsolete| | --- Comment #60 from Paul Poulain <paul.poulain@biblibre.com> --- Comment on attachment 8950 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8950 Bug 6679 :[SIGNED-OFF] members dir now passes perlcritic tests This patch has been pushed -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff CC| |mtj@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #64 from Mason James <mtj@kohaaloha.com> --- Created attachment 9748 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9748&action=edit Fixing 5 perlcritic violations in opac/* 1 more to go... :) opac/changelanguage.pl: Code before strictures are enabled at line 24, column 1. See page 429 of PBP. (Severity: 5) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #66 from Mason James <mtj@kohaaloha.com> --- Created attachment 9750 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9750&action=edit Fixing 13 perlcritic violations in C4/Barcodes.pm Subroutine prototypes used at line XXX, column 1. See page 194 of PBP. (Severity: 5) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9746|0 |1 is obsolete| | Attachment #9747|0 |1 is obsolete| | Attachment #9748|0 |1 is obsolete| | Attachment #9749|0 |1 is obsolete| | Attachment #9750|0 |1 is obsolete| | --- Comment #68 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 10050 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10050&action=edit Bug 6679: Fixing 26 perlcritic violations in C4/Tags.pm Subroutine prototypes used at line XXX, column 1. See page 194 of PBP. (Severity: 5) Note: Rebased on master 06/09/2012 by jcamins -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #70 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 10052 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10052&action=edit Bug 6679: Fixing 5 perlcritic violations in opac/* 1 more to go... :) opac/changelanguage.pl: Code before strictures are enabled at line 24, column 1. See page 429 of PBP. (Severity: 5) Note: Rebased on master 06/09/2012 by jcamins -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #72 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 10054 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10054&action=edit Bug 6679: Fixing 13 perlcritic violations in C4/Barcodes.pm Subroutine prototypes used at line XXX, column 1. See page 194 of PBP. (Severity: 5) Note: Rebased on master 06/09/2012 by jcamins -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10054|0 |1 is obsolete| | --- Comment #74 from Joy Nelson <joy@bywatersolutions.com> --- Created attachment 10075 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10075&action=edit [SIGNED-OFF] Bug 6679: Fixing 13 perlcritic violations in C4/Barcodes.pm Subroutine prototypes used at line XXX, column 1. See page 194 of PBP. (Severity: 5) Note: Rebased on master 06/09/2012 by jcamins Signed-off-by: Joy Nelson <joy@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10052|0 |1 is obsolete| | --- Comment #76 from Joy Nelson <joy@bywatersolutions.com> --- Created attachment 10077 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10077&action=edit [SIGNED OFF] Bug 6679: Fixing 5 perlcritic violations in opac/* 1 more to go... :) opac/changelanguage.pl: Code before strictures are enabled at line 24, column 1. See page 429 of PBP. (Severity: 5) Note: Rebased on master 06/09/2012 by jcamins Signed-off-by: Joy Nelson <joy@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10050|0 |1 is obsolete| | --- Comment #78 from Joy Nelson <joy@bywatersolutions.com> --- Created attachment 10079 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10079&action=edit [SIGNED OFF] Bug 6679: Fixing 26 perlcritic violations in C4/Tags.pm Subroutine prototypes used at line XXX, column 1. See page 194 of PBP. (Severity: 5) Note: Rebased on master 06/09/2012 by jcamins Signed-off-by: Joy Nelson <joy@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10075|0 |1 is obsolete| | --- Comment #80 from Paul Poulain <paul.poulain@biblibre.com> --- Comment on attachment 10075 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10075 [SIGNED-OFF] Bug 6679: Fixing 13 perlcritic violations in C4/Barcodes.pm OK, this patch fixes error, but there are still some: "return" statement with explicit "undef" at line 57, column 2. See page 199 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 131, column 3. See page 199 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 147, column 22. See page 199 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 152, column 22. See page 199 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 157, column 22. See page 199 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 193, column 3. See page 199 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 197, column 3. See page 199 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 228, column 2. See page 199 of PBP. (Severity: 5) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10077|0 |1 is obsolete| | --- Comment #82 from Paul Poulain <paul.poulain@biblibre.com> --- Comment on attachment 10077 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10077 [SIGNED OFF] Bug 6679: Fixing 5 perlcritic violations in opac/* patch pushed,OPAC almost perlcritic compliant, just one error to solve: opac/ilsdi.pl: Stricture disabled at line 217, column 17. See page 429 of PBP. (Severity: 5) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10078|0 |1 is obsolete| | --- Comment #84 from Paul Poulain <paul.poulain@biblibre.com> --- Comment on attachment 10078 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10078 [SIGNED OFF] Bug 6679: Fixing 23 perlcritic violations in C4/Tags.pm This patch does not apply, replaced by another one -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED --- Comment #86 from Paul Poulain <paul.poulain@biblibre.com> --- (In reply to comment #85)

Comment on attachment 10079 [details] [SIGNED OFF] Bug 6679: Fixing 26 perlcritic violations in C4/Tags.pm

this patch has been pushed

Still a lot of things to update in C4/Tags.pm: "return" statement with explicit "undef" at line 120, column 25. See page 199 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 126, column 27. See page 199 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 148, column 10. See page 199 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 154, column 10. See page 199 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 160, column 10. See page 199 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 166, column 10. See page 199 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 362, column 22. See page 199 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 373, column 22. See page 199 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 387, column 23. See page 199 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 409, column 23. See page 199 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 422, column 23. See page 199 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 429, column 23. See page 199 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 438, column 22. See page 199 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 463, column 23. See page 199 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 464, column 26. See page 199 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 473, column 30. See page 199 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 474, column 30. See page 199 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 487, column 10. See page 199 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 508, column 47. See page 199 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 560, column 30. See page 199 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 561, column 30. See page 199 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 565, column 13. See page 199 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 574, column 3. See page 199 of PBP. (Severity: 5) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #89 from Mason James <mtj@kohaaloha.com> --- Created attachment 10486 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10486&action=edit fix 15 perlcritic violations in C4/ImportExportFramework.pm Bareword file handle opened at line 558, column 17. See pages 202,204 of PBP. (Severity: 5) Two-argument "open" used at line 558, column 17. See page 207 of PBP. (Severity: 5) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #91 from Mason James <mtj@kohaaloha.com> --- Created attachment 10488 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10488&action=edit Bug 6679 - fix 12 perlcritic violations in C4/Auth_with_ldap.pm Subroutine prototypes used at line 73, column 1. See page 194 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 74, column 24. See page 199 of PBP. (Severity: 5) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #93 from Mason James <mtj@kohaaloha.com> --- Created attachment 10491 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10491&action=edit Bug 6679 - fix 11 perlcritic violations in C4/Dates.pm - Subroutine prototypes used at line 82, column 1. See page 194 of PBP. (Severity: 5) - "return" statement with explicit "undef" at line 102, column 28. See page 199 of PBP. (Severity: 5) - Expression form of "eval" at line 108, column 20. See page 161 of PBP. (Severity: 5) - Variable declared in conditional statement at line 126, column 5. Declare variables outside of the condition. (Severity: 5) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #95 from Mason James <mtj@kohaaloha.com> --- Created attachment 10493 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10493&action=edit Bug 6679 - fix 9 perlcritic violations in C4/Koha.pm - Subroutine prototypes used at line 115, column 1. See page 194 of PBP. (Severity: 5) - "return" statement with explicit "undef" at line 1112, column 4. See page 199 of PBP. (Severity: 5) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10488|0 |1 is obsolete| | --- Comment #97 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 10495 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10495&action=edit Bug 6679 - [SIGNED-OFF] fix 12 perlcritic violations in C4/Auth_with_ldap.pm Subroutine prototypes used at line 73, column 1. See page 194 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 74, column 24. See page 199 of PBP. (Severity: 5) Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10484|0 |1 is obsolete| | --- Comment #99 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 10497 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10497&action=edit Bug 6679 - [SIGNED-OFF]fixing 23 '"return" statement with explicit "undef"' violations in C4/Tags.pm Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #100 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #88)

Created attachment 10485 [details] Bug 6679 - fix 19 perlcritic violations from C4::Letters.pm

FAILED QA for this patch, I think the following lines don't have to be modified: - return unless exists $params->{'letter'}; - return unless exists $params->{'borrowernumber'}; - return unless exists $params->{'message_transport_type'}; + return exists $params->{'letter'}; + return exists $params->{'borrowernumber'}; + return exists $params->{'message_transport_type'}; It's unless, not undef :-) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #102 from Mason James <mtj@kohaaloha.com> --- Created attachment 10500 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10500&action=edit Bug 6679 - fix 8 perlcritic violations in C4/Barcodes.pm - "return" statement with explicit "undef" at line 57, column 2. See page 199 of PBP. (Severity: 5) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #104 from Mason James <mtj@kohaaloha.com> --- Created attachment 10502 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10502&action=edit Bug 6679 - fix 6 perlcritic violations in C4/Reports/Guided.pm - Subroutine prototypes used at line 376, column 1. See page 194 of PBP. (Severity: 5) - Bareword file handle opened at line 757, column 2. See pages 202,204 of PBP. (Severity: 5) - Two-argument "open" used at line 757, column 2. See page 207 of PBP. (Severity: 5) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #106 from Mason James <mtj@kohaaloha.com> --- Created attachment 10504 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10504&action=edit Bug 6679 - fix 5 perlcritic violations in C4/VirtualShelves.pm, and comment-out obselete sub() - Subroutine prototypes used at line 224, column 1. See page 194 of PBP. (Severity: 5) - "return" statement with explicit "undef" at line 354, column 22. See page 199 of PBP. (Severity: 5) - Don't modify $_ in list functions at line 664, column 5. See page 114 of PBP. (Severity: 5) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #108 from Mason James <mtj@kohaaloha.com> --- Created attachment 10506 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10506&action=edit Bug 6679 - fix 4 perlcritic violations in C4/ShelfBrowser.pm - Variable declared in conditional statement at line 183, column 5. Declare variables outside of the condition. (Severity: 5) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #110 from Mason James <mtj@kohaaloha.com> --- Created attachment 10508 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10508&action=edit Bug 6679 - fix 4 perlcritic violations in C4/Creators/PDF.pm - "return" statement with explicit "undef" at line 171, column 8. See page 199 of PBP. (Severity: 5) - "return" statement with explicit "undef" at line 201, column 8. See page 199 of PBP. (Severity: 5) - Bareword file handle opened at line 212, column 11. See pages 202,204 of PBP. (Severity: 5) - Two-argument "open" used at line 212, column 11. See page 207 of PBP. (Severity: 5) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #112 from Mason James <mtj@kohaaloha.com> --- Created attachment 10510 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10510&action=edit Bug 6679 - fix 3 perlcritic violations in C4/SQLHelper.pm Subroutine prototypes used at line 251, column 1. See page 194 of PBP. (Severity: 5) Subroutine prototypes used at line 287, column 1. See page 194 of PBP. (Severity: 5) Subroutine prototypes used at line 317, column 1. See page 194 of PBP. (Severity: 5) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #114 from Mason James <mtj@kohaaloha.com> --- Created attachment 10513 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10513&action=edit Bug 6679 - fix 3 perlcritic violations in C4/Output.pm "return" statement with explicit "undef" at line 128, column 74. See page 199 of PBP. (Severity: 5) Subroutine prototypes used at line 270, column 1. See page 194 of PBP. (Severity: 5) Subroutine prototypes used at line 308, column 1. See page 194 of PBP. (Severity: 5) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #116 from Mason James <mtj@kohaaloha.com> --- Created attachment 10515 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10515&action=edit Bug 6679 - fix 3 perlcritic violations in C4/Items.pm "return" statement with explicit "undef" at line 508, column 44. See page 199 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 2267, column 5. See page 199 of PBP. (Severity: 5) Variable declared in conditional statement at line 2642, column 21. Declare variables outside of the condition. (Severity: 5) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #118 from Mason James <mtj@kohaaloha.com> --- Created attachment 10521 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10521&action=edit Bug 6679 - fix 3 perlcritic violations in C4/Auth.pm, and enabled warnings Subroutine prototypes used at line 561, column 1. See page 194 of PBP. (Severity: 5) Bareword file handle opened at line 606, column 5. See pages 202,204 of PBP. (Severity: 5) Two-argument "open" used at line 606, column 5. See page 207 of PBP. (Severity: 5) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #120 from Mason James <mtj@kohaaloha.com> --- Created attachment 10523 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10523&action=edit Bug 6679 - fix 2 perlcritic violations in C4/Print.pm Bareword file handle opened at line 80, column 9. See pages 202,204 of PBP. (Severity: 5) Two-argument "open" used at line 80, column 9. See page 207 of PBP. (Severity: 5) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #122 from Mason James <mtj@kohaaloha.com> --- Created attachment 10525 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10525&action=edit Bug 6679 - fix 2 perlcritic violations in C4/Installer/PerlModules.pm Expression form of "eval" at line 71, column 9. See page 161 of PBP. (Severity: 5) Expression form of "eval" at line 85, column 13. See page 161 of PBP. (Severity: 5) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #124 from Mason James <mtj@kohaaloha.com> --- Created attachment 10527 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10527&action=edit Bug 6679 - fix 2 perlcritic violations in C4/AuthoritiesMarc.pm "return" statement with explicit "undef" at line 853, column 5. See page 199 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 1191, column 3. See page 199 of PBP. (Severity: 5) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10486|0 |1 is obsolete| | --- Comment #125 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 10935 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10935&action=edit Bug 6679 - [SIGNED-OFF] fix 15 perlcritic violations in C4/ImportExportFramework.pm Bareword file handle opened at line 558, column 17. See pages 202,204 of PBP. (Severity: 5) Two-argument "open" used at line 558, column 17. See page 207 of PBP. (Severity: 5) http://bugs.koha-community.org/show_bug.cgi?id=6679 Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10492|0 |1 is obsolete| | --- Comment #127 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 10938 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10938&action=edit Bug 6679 - [SIGNED-OFF] fix 9 perlcritic violations in C4/TmplTokenType.pm - Subroutine prototypes used at line 86, column 1. See page 194 of PBP. (Severity: 5) Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10499|0 |1 is obsolete| | --- Comment #129 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 10944 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10944&action=edit Bug 6679 - [SIGNED-OFF] fix 8 perlcritic violations in C4/Circulation.pm -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10944|0 |1 is obsolete| | --- Comment #131 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 10946 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10946&action=edit Bug 6679 - [SIGNED-OFF] fix 8 perlcritic violations in C4/Circulation.pm -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10501|0 |1 is obsolete| | --- Comment #133 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 10948 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10948&action=edit Bug 6679 - [SIGNED-OFF] fix 7 perlcritic violations in C4/Biblio.pm -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10503|0 |1 is obsolete| | --- Comment #135 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 10950 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10950&action=edit Bug 6679 - [SIGNED-OFF] fix 6 perlcritic violations in C4/Barcodes/hbyymmincr.pm -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10506|0 |1 is obsolete| | --- Comment #137 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 10953 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10953&action=edit Bug 6679 - [SIGNED-OFF] fix 4 perlcritic violations in C4/ShelfBrowser.pm -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10510|0 |1 is obsolete| | --- Comment #139 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 10957 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10957&action=edit Bug 6679 - [SIGNED-OFF] fix 3 perlcritic violations in C4/SQLHelper.pm -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10513|0 |1 is obsolete| | --- Comment #141 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 10959 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10959&action=edit Bug 6679 - [SIGNED-OFF] fix 3 perlcritic violations in C4/Output.pm -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10515|0 |1 is obsolete| | --- Comment #143 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 10961 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10961&action=edit Bug 6679 - [SIGNED-OFF] fix 3 perlcritic violations in C4/Items.pm -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10522|0 |1 is obsolete| | --- Comment #145 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 10963 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10963&action=edit Bug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in C4/Utils.pm -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10525|0 |1 is obsolete| | --- Comment #147 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 10965 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10965&action=edit Bug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in C4/Installer/PerlModules.pm -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10527|0 |1 is obsolete| | --- Comment #149 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 10967 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10967&action=edit Bug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in C4/AuthoritiesMarc.pm -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10507|0 |1 is obsolete| | --- Comment #151 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 10976 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10976&action=edit Bug 6679 - [SIGNED-OFF] fix 4 perlcritic violations in C4/Installer.pm -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10523|0 |1 is obsolete| | --- Comment #153 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 10980 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10980&action=edit Bug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in C4/Print.pm -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10517|Bug-6679---fix-3-perlcritic |[FAILED QA] filename|-violations-in-C4ClassS.pat |Bug-6679---fix-3-perlcritic |ch |-violations-in-C4ClassS.pat | |ch Attachment #10517|1 |0 is obsolete| | --- Comment #154 from Jonathan Druart <jonathan.druart@biblibre.com> --- Comment on attachment 10517 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10517 Bug 6679 - fix 3 perlcritic violations in C4/ClassSortRoutine.pm Failed QA : "Bad name after :: at C4/ClassSortRoutine.pm line 55." -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #156 from Jonathan Druart <jonathan.druart@biblibre.com> --- Comment on attachment 10517 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10517 Bug 6679 - fix 3 perlcritic violations in C4/ClassSortRoutine.pm Failed QA: Bad name after :: at C4/ClassSortRoutine.pm line 55. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED Assignee|chris@bigballofwax.co.nz |mtj@kohaaloha.com --- Comment #157 from Jonathan Druart <jonathan.druart@biblibre.com> --- All seems good except 2 patchs: C4/Letters.pm and C4/ClassSortRoutine.pm Switch to Assigned -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #159 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #158)

Created attachment 12224 [details] Proposed patch

This patch fixes two instances that cause Jemkins builds to fail

Why don't you just remove the "undef" word ? I think if ($@) { return; } is less readable as return if $@; Don't you think ? I can provide a new patch but I don't want to go against what you want. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12363|0 |1 is obsolete| | --- Comment #161 from Paul Poulain <paul.poulain@biblibre.com> --- Comment on attachment 12363 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12363 Proposed patch to calm Jenkins This patch has been pushed -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #162 from Paul Poulain <paul.poulain@biblibre.com> --- patches are signed off, going to this status to have patches in QA team radar ! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10494|0 |1 is obsolete| | --- Comment #164 from Paul Poulain <paul.poulain@biblibre.com> --- Comment on attachment 10494 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10494 Bug 6679 - [SIGNED-OFF]fix 12 perlcritic violations in C4/External/BakerTaylor.pm This patch has been pushed to master -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10496|0 |1 is obsolete| | --- Comment #166 from Paul Poulain <paul.poulain@biblibre.com> --- Comment on attachment 10496 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10496 Bug 6679 -[SIGNED-OFF] fix 12 perlcritic violations in C4/Context.pm This patch has been pushed to master -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #168 from Paul Poulain <paul.poulain@biblibre.com> --- Comment on attachment 10517 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10517 Bug 6679 - [FAILED QA]fix 3 perlcritic violations in C4/ClassSortRoutine.pm This patch has NOT been pushed. After applying it, you get a Perl error -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #170 from Paul Poulain <paul.poulain@biblibre.com> --- Comment on attachment 10936 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10936 Bug 6679 - [SIGNED-OFF] fix 11 perlcritic violations in C4/Dates.pm This patch has NOT been pushed. After applying it you get a perl error -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10940|0 |1 is obsolete| | --- Comment #172 from Paul Poulain <paul.poulain@biblibre.com> --- Comment on attachment 10940 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10940 Bug 6679 - [SIGNED-OFF] fix 9 perlcritic violations in C4/Koha.pm This patch has been pushed to master -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10947|0 |1 is obsolete| | --- Comment #174 from Paul Poulain <paul.poulain@biblibre.com> --- Comment on attachment 10947 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10947 Bug 6679 - [SIGNED-OFF] fix 8 perlcritic violations in C4/Barcodes.pm This patch has been pushed to master -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10950|0 |1 is obsolete| | --- Comment #176 from Paul Poulain <paul.poulain@biblibre.com> --- Comment on attachment 10950 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10950 Bug 6679 - [SIGNED-OFF] fix 6 perlcritic violations in C4/Barcodes/hbyymmincr.pm This patch has been pushed to master -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10953|0 |1 is obsolete| | --- Comment #178 from Paul Poulain <paul.poulain@biblibre.com> --- Comment on attachment 10953 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10953 Bug 6679 - [SIGNED-OFF] fix 4 perlcritic violations in C4/ShelfBrowser.pm This patch has been pushed to master -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10957|0 |1 is obsolete| | --- Comment #180 from Paul Poulain <paul.poulain@biblibre.com> --- Comment on attachment 10957 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10957 Bug 6679 - [SIGNED-OFF] fix 3 perlcritic violations in C4/SQLHelper.pm This patch has been pushed to master -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10960|0 |1 is obsolete| | --- Comment #182 from Paul Poulain <paul.poulain@biblibre.com> --- Comment on attachment 10960 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10960 Bug 6679 - [SIGNED-OFF] fix 3 perlcritic violations in C4/Message.pm This patch has been pushed to master -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10963|0 |1 is obsolete| | --- Comment #184 from Paul Poulain <paul.poulain@biblibre.com> --- Comment on attachment 10963 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10963 Bug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in C4/Utils.pm This patch has been pushed to master -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10965|0 |1 is obsolete| | --- Comment #186 from Paul Poulain <paul.poulain@biblibre.com> --- Comment on attachment 10965 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10965 Bug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in C4/Installer/PerlModules.pm This patch has been pushed to master -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10981|0 |1 is obsolete| | --- Comment #188 from Paul Poulain <paul.poulain@biblibre.com> --- Comment on attachment 10981 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10981 Bug 6679 - [SIGNED-OFF] fix 3 perlcritic violations in C4/Auth.pm, and enabled warnings This patch has been pushed to master -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10979|0 |1 is obsolete| | --- Comment #190 from Paul Poulain <paul.poulain@biblibre.com> --- Comment on attachment 10979 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10979 Bug 6679 - [SIGNED-OFF] fix 4 perlcritic violations in C4/Creators/PDF.pm This patch has been pushed to master -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED --- Comment #192 from Paul Poulain <paul.poulain@biblibre.com> --- Attachment that are still here either: * does not apply anymore * badly break Koha (resulting in a Perl error) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10965|1 |0 is obsolete| | --- Comment #194 from Paul Poulain <paul.poulain@biblibre.com> --- Comment on attachment 10965 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10965 Bug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in C4/Installer/PerlModules.pm This patch has been reverted = jenkins complain: perl t/Installer_pm.t 1..4 ok 1 - use C4::Installer::PerlModules; ok 2 - The object isa C4::Installer::PerlModules ok 3 - returns numeric version not ok 4 - returns correct version # Failed test 'returns correct version' # at t/Installer_pm.t line 23. # Looks like you failed 1 test of 4. After reverting, t/Installer_pm.t is OK Maybe that's the test that must be upgraded, but until it's done, this patch is reverted -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12490|0 |1 is obsolete| | --- Comment #196 from Mason James <mtj@kohaaloha.com> --- Created attachment 12491 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12491&action=edit Bug 6679 - Fixing code so it passes basic Perl:::Critic tests opac/opac-search.pl: "require" statement with library name as string at line 36, column 9. Use a bareword instead. (Severity: 5) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Bug 6679 depends on bug 7119, which changed state. Bug 7119 Summary: general code-cleaning, tidy/whitespace omnibus http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7119 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.