http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6123|0 |1 is obsolete| | --- Comment #34 from Paul Poulain <paul.poulain@biblibre.com> 2011-12-08 09:34:10 UTC --- Comment on attachment 6123 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6123 Bug 6679 : cataloguing/ now passing critic tests patch pushed. trying to prove cataloguing show me some errors in plugins though: prove t/00-testcritic.t t/00-testcritic.t .. 196/246 # Failed test 'Test::Perl::Critic for "cataloguing/value_builder/stocknumber.pl"' # at /usr/share/perl5/Test/Perl/Critic.pm line 110. # # Perl::Critic found these violations in "cataloguing/value_builder/stocknumber.pl": # Code before strictures are enabled at line 30, column 1. See page 429 of PBP. (Severity: 5) t/00-testcritic.t .. 239/246 # Failed test 'Test::Perl::Critic for "cataloguing/value_builder/unimarc_field_210c.pl"' # at /usr/share/perl5/Test/Perl/Critic.pm line 110. # # Perl::Critic found these violations in "cataloguing/value_builder/unimarc_field_210c.pl": # Code before strictures are enabled at line 40, column 1. See page 429 of PBP. (Severity: 5) # Variable declared in conditional statement at line 113, column 9. Declare variables outside of the condition. (Severity: 5) t/00-testcritic.t .. 243/246 # Failed test 'Test::Perl::Critic for "cataloguing/value_builder/unimarc_field_4XX.pl"' # at /usr/share/perl5/Test/Perl/Critic.pm line 110. # # Perl::Critic found these violations in "cataloguing/value_builder/unimarc_field_4XX.pl": # Variable declared in conditional statement at line 272, column 9. Declare variables outside of the condition. (Severity: 5) # Variable declared in conditional statement at line 286, column 9. Declare variables outside of the condition. (Severity: 5) # Variable declared in conditional statement at line 292, column 9. Declare variables outside of the condition. (Severity: 5) # Variable declared in conditional statement at line 377, column 13. Declare variables outside of the condition. (Severity: 5) t/00-testcritic.t .. 245/246 # Looks like you failed 3 tests of 246. I think it's worth activating the test (it's better to have a test showing something is wrong than doing no test and thinking things are OK ;-) ) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.