[Bug 33705] New: Quote of the day: table has configure button even if it's not configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33705 Bug ID: 33705 Summary: Quote of the day: table has configure button even if it's not configurable Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org I'm not sure if bug 31435 was meant as a general fix or if each individual table needs to be fixed... The Quote of the day table has the "Configure" button, and it leads to the column configuration page, but that table is not in the list. To test: - Make sure you have quotes, add at least one, or add the sample quotes during installation, or load the installer/data/mysql/en/optional/sample_quotes.yml file 1. Go to Tools > Quote editor 2. Click "Configure" --> You are brought to the column settings page, but the quote editor table is not there -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33705 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29723, 31435 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29723 [Bug 29723] Add a "Configure table" button for KohaTable tables https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31435 [Bug 31435] "Configure this table" appears for non-configurable tables -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33705 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33066 Keywords| |rel_23_05_candidate Assignee|oleonard@myacpl.org |jonathan.druart+koha@gmail. | |com CC| |jonathan.druart+koha@gmail. | |com Status|NEW |ASSIGNED Severity|enhancement |normal --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Caused by commit 765fd1ced3b9efc4ff6fb71e2fee1a7a227d1cae Bug 33066: Introduce a KohaTable Vue component Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 [Bug 33066] We need a KohaTable Vue component -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33705 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Quote of the day: table has |Tables have configure |configure button even if |button even if it's not |it's not configurable |configurable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33705 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Tables have configure |Tables have configure |button even if it's not |button even if they are not |configurable |configurable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33705 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33705 --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 150922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150922&action=edit Bug 33705: (bug 33066 follow-up) Fix 'configure' button for kohaTable The 'configure' button is displayed for any tables, even those that cannot be configured. This is a regression caused by commit 765fd1ced3b9efc4ff6fb71e2fee1a7a227d1cae Bug 33066: Introduce a KohaTable Vue component It's adding a default value for table_settings, but then later we are testing if table_settings is true: 699 let table_settings = params.table_settings || {}; ... 798 if ( table_settings && CAN_user_parameters_manage_column_config ) { This patch is reverting the default value, so the test will be corrected. Test plan: 1. Go to Tools > Quote editor 2. Click "Configure" => Without this patch you are brought to the column settings page, but the quote editor table is not there => With this patch the button is not present 3. Go to the cities page (admin/cities.pl) 4. Click "Configure" => You are brought to the column settings page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33705 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33705 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150922|0 |1 is obsolete| | --- Comment #3 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 151000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151000&action=edit Bug 33705: (bug 33066 follow-up) Fix 'configure' button for kohaTable The 'configure' button is displayed for any tables, even those that cannot be configured. This is a regression caused by commit 765fd1ced3b9efc4ff6fb71e2fee1a7a227d1cae Bug 33066: Introduce a KohaTable Vue component It's adding a default value for table_settings, but then later we are testing if table_settings is true: 699 let table_settings = params.table_settings || {}; ... 798 if ( table_settings && CAN_user_parameters_manage_column_config ) { This patch is reverting the default value, so the test will be corrected. Test plan: 1. Go to Tools > Quote editor 2. Click "Configure" => Without this patch you are brought to the column settings page, but the quote editor table is not there => With this patch the button is not present 3. Go to the cities page (admin/cities.pl) 4. Click "Configure" => You are brought to the column settings page Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33705 Bug 33705 depends on bug 33066, which changed state. Bug 33066 Summary: We need a KohaTable Vue component https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33705 Bug 33705 depends on bug 33066, which changed state. Bug 33066 Summary: We need a KohaTable Vue component https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33705 Bug 33705 depends on bug 33066, which changed state. Bug 33066 Summary: We need a KohaTable Vue component https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33705 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151000|0 |1 is obsolete| | --- Comment #4 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 151232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151232&action=edit Bug 33705: (bug 33066 follow-up) Fix 'configure' button for kohaTable The 'configure' button is displayed for any tables, even those that cannot be configured. This is a regression caused by commit 765fd1ced3b9efc4ff6fb71e2fee1a7a227d1cae Bug 33066: Introduce a KohaTable Vue component It's adding a default value for table_settings, but then later we are testing if table_settings is true: 699 let table_settings = params.table_settings || {}; ... 798 if ( table_settings && CAN_user_parameters_manage_column_config ) { This patch is reverting the default value, so the test will be corrected. Test plan: 1. Go to Tools > Quote editor 2. Click "Configure" => Without this patch you are brought to the column settings page, but the quote editor table is not there => With this patch the button is not present 3. Go to the cities page (admin/cities.pl) 4. Click "Configure" => You are brought to the column settings page Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33705 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |victor@tuxayo.net --- Comment #5 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Works, makes sense, QA script happy, code looks good, passing QA :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33705 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_23_05_candidate | Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 23.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33705 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.07 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33705 --- Comment #7 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Nice work everyone! Pushed to 22.11.x for next release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org