[Bug 33733] New: Move t/XSLT.t to db_dependent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33733 Bug ID: 33733 Summary: Move t/XSLT.t to db_dependent Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org This test is not database independent after all, reading various sysprefs from database. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33733 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33733 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 151185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151185&action=edit Bug 33733: Remove need for Test::DBIx::Class Test plan: Run t/XSLT.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33733 --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 151186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151186&action=edit Bug 33733: Fix indentation in subtest Test plan: git diff -w HEAD~1.. t/XSLT.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33733 --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 151187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151187&action=edit Bug 33733: Move to db_dependent The subtest is added to the existing db_dependent test. Test plan: Run t/db_dependent/XSLT.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33733 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris@bigballofwax.co.nz |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33733 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33733 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33733 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151185|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 151240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151240&action=edit Bug 33733: Remove need for Test::DBIx::Class Test plan: Run t/XSLT.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33733 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151186|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 151241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151241&action=edit Bug 33733: Fix indentation in subtest Test plan: git diff -w HEAD~1.. t/XSLT.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33733 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151187|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 151242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151242&action=edit Bug 33733: Move to db_dependent The subtest is added to the existing db_dependent test. Test plan: Run t/db_dependent/XSLT.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33733 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #7 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. Ran prove t/db_dependent/XSLT.t - tests pass (no longer any t/XSLT.t). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33733 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33733 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151240|0 |1 is obsolete| | Attachment #151241|0 |1 is obsolete| | Attachment #151242|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 151265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151265&action=edit Bug 33733: Remove need for Test::DBIx::Class Test plan: Run t/XSLT.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33733 --- Comment #9 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 151266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151266&action=edit Bug 33733: Fix indentation in subtest Test plan: git diff -w HEAD~1.. t/XSLT.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33733 --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 151267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151267&action=edit Bug 33733: Move to db_dependent The subtest is added to the existing db_dependent test. Test plan: Run t/db_dependent/XSLT.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33733 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | CC| |jonathan.druart+koha@gmail. | |com Status|Passed QA |Pushed to master --- Comment #11 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Patches pushed for 23.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33733 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@ptfs-europe.co | |m Status|Pushed to master |RESOLVED Resolution|--- |FIXED --- Comment #12 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Does not apply in 22.11.x because bug 33567 was not pushed. Not pushing. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org