https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8214 --- Comment #167 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- (In reply to Katrin Fischer from comment #166)

2) CODE REVIEW

a) Check for system preference in code (question) It looks like we don't always check for the system preference. I am not sure if this is an issue, but wanted to raise it for consideration.

I'll double check this

b) Templates (question) Surprised by the non-standard HTML tags here:

+[% IF Koha.Preference('EnableBoundWithItems') %] + <bound-with-modal biblionumber="[% biblionumber | html %]" can-manage="[% CAN_user_editcatalogue_manage_item_biblio_links ? 1 : 0 | html %]"></bound-with-modal> +[% END %] +

These are the custom elements we can create with Vue islands

c) Authorised value ITEM_BIBLIO_LINK_TYPE (no blocker)

I am a bit confused by this. It looks like the AV is currently not used and if that is a thought for a future enhancement, maybe moving analytics? The code comment says it's for handling display, but I don't see any reference to it in the templates. Maybe missing something?

If for later use, I think it would have been cleaner to add it later, but it's not a blocker for me.

This came from the spec I worked from - I believe it is for future use and customisation but will need fleshing out as use cases arise

3) TESTING

a) Configuration (not blocker)

The system preference reads: Note that a full search engine reindex is required after enabling this feature and creating links, so that availability appears on all linked records.

Is the index really required after turning on the feature if you haven't added any links yet (which you can't before enabling the feature?)

Good question, that comment might be from before I linked the indexing into the feature

e) Small stuff and questions (for later)

Display: There are some more pages where displaying the information about the bound with would be nice: * Staff: Holds list in patron account * Staff: Holds list in catalog/record detail * List of checkouts in staff/OPAC

Notices: I wonder if we can print the "right" title in the notices. Might need a little extra work/mark-up.

Happy to look at some of these in follow-ups for next cycle -- You are receiving this mail because: You are watching all bug changes.