[Bug 43121] New: Vue: Don't pattern match on translatable strings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43121 Bug ID: 43121 Summary: Vue: Don't pattern match on translatable strings Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: jonathan.druart@gmail.com, matt.blenkinsop@openfifth.co.uk, me@paulderscheid.xyz Target Milestone: --- I think we've discovered a bad design pattern here, that crept into the Vue work: We sometimes match untranslatable strings on translatable strings, so they won't match in an installation that is not English. Example: koha-tmpl/intranet-tmpl/prog/js/vue/components/Vendors/VendorResource.vue: { name: "Ordering information", pane: 2 }, koha-tmpl/intranet-tmpl/prog/js/vue/components/Vendors/VendorResource.vue: group: $__("Ordering information"), koha-tmpl/intranet-tmpl/prog/js/vue/components/Vendors/VendorResource.vue: group: $__("Ordering information"), koha-tmpl/intranet-tmpl/prog/js/vue/components/Vendors/VendorResource.vue: group: $__("Ordering information"), koha-tmpl/intranet-tmpl/prog/js/vue/components/Vendors/VendorResource.vue: group: $__("Ordering information"), koha-tmpl/intranet-tmpl/prog/js/vue/components/Vendors/VendorResource.vue: group: $__("Ordering information"), koha-tmpl/intranet-tmpl/prog/js/vue/components/Vendors/VendorResource.vue: group: $__("Ordering information"), koha-tmpl/intranet-tmpl/prog/js/vue/components/Vendors/VendorResource.vue: group: $__("Ordering information"), koha-tmpl/intranet-tmpl/prog/js/vue/components/Vendors/VendorResource.vue: group: $__("Ordering information"), koha-tmpl/intranet-tmpl/prog/js/vue/components/Vendors/VendorResource.vue: group: $__("Ordering information"), koha-tmpl/intranet-tmpl/prog/js/vue/components/Vendors/VendorResource.vue: group: $__("Ordering information"), koha-tmpl/intranet-tmpl/prog/js/vue/components/Vendors/VendorResource.vue: group: $__("Ordering information"), I believe there are more occurences for this and we maybe need a coding guideline. In other cases we seem to have both translatable, which probably works, but still seems like a less than ideal pattern. We should be matching on things, that don't change between languages. Note: the problems in the vendor detail Vue is visible as a display bug (sequence of sections) in 26.05. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43121 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43121 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |clemens.tubach@kit.edu, | |michaela.sieber@kit.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43121 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@openfifth.c | |o.uk, | |pedro.amorim@openfifth.co.u | |k -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43121 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jan.kissig@th-wildau.de, | |lisette@bywatersolutions.co | |m See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=40942 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43121 --- Comment #1 from Michaela Sieber <michaela.sieber@kit.edu> --- Created attachment 202209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202209&action=edit Screenshot_Display-Vendor-Details-German-Interface -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43121 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |38201 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38201 [Bug 38201] VueJS architecture rethink -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43121 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43121 --- Comment #2 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Upping this to major from the development meeting. Needs to be addressed at the VueJS framework level. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43121 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43121 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43121 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43121 --- Comment #3 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 202243 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202243&action=edit Bug 43121: Use an explicit label for group and tab names rather than a translated string Patch from commit 53b72fd -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43121 --- Comment #4 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 202244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202244&action=edit Bug 43121: Convert all groups to use explicit labels Test plan: 1) Install another language 2) Navigate to a vendor record 3) The group names should translate correctly and display in the split screen view -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43121 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |matt.blenkinsop@openfifth.c |ity.org |o.uk -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43121 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #202243|0 |1 is obsolete| | Attachment #202244|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43121 --- Comment #5 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 202340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202340&action=edit Bug 43121: Use an explicit label for group and tab names rather than a translated string Signed-off-by: Michaela <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43121 --- Comment #6 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 202341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202341&action=edit Bug 43121: Convert all groups to use explicit labels Test plan: 1) Install another language 2) Navigate to a vendor record 3) The group names should translate correctly and display in the split screen view Signed-off-by: Michaela <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43121 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43121 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43121 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #202340|0 |1 is obsolete| | Attachment #202341|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43121 --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 202346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202346&action=edit Bug 43121: Use an explicit label for group and tab names rather than a translated string Signed-off-by: Michaela <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43121 --- Comment #8 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 202347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202347&action=edit Bug 43121: Convert all groups to use explicit labels Test plan: 1) Install another language 2) Navigate to a vendor record 3) The group names should translate correctly and display in the split screen view Signed-off-by: Michaela <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43121 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_26_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43121 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43121 --- Comment #9 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43121 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.11.00 |26.11.00,26.05.03 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43121 --- Comment #10 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to 26.05.x for the upcoming 26.05.03 release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43121 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_26_05_candidate | CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org