[Bug 17869] New: Don' t show pick-up library for holds in OPAC account when there is only one branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17869 Bug ID: 17869 Summary: Don't show pick-up library for holds in OPAC account when there is only one branch Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org When there is only one branch in an installation, it makes no sense to show a pick-up library column in the holds list in the patron account in OPAC. We should remove it from display, as we do in other spots. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17869 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17869 Grace <gracesmythh@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17869 --- Comment #1 from Grace <gracesmythh@gmail.com> --- Created attachment 70541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70541&action=edit Bug 17869 Holds location removal Test Plan [1.] Type in browser http://localhost:8080/ (If you aren't logged in then log in) [2.] Then search for anything and click on the link 'Place hold' which is directly underneath the stars for an item [3.] Notice that there is a pick up location with only one location [4.] Load the patch and now notice that there is no location (as it is not necessary with only one location) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17869 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Assignee|oleonard@myacpl.org |gracesmythh@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17869 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes@biblibre.com Status|Needs Signoff |Signed Off --- Comment #2 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by claude <claude.brayer@cea.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17869 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70541|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17869 --- Comment #3 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 72763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72763&action=edit Bug 17869 Holds location removal Test Plan [1.] Type in browser http://localhost:8080/ (If you aren't logged in then log in) [2.] Then search for anything and click on the link 'Place hold' which is directly underneath the stars for an item [3.] Notice that there is a pick up location with only one location [4.] Load the patch and now notice that there is no location (as it is not necessary with only one location) Signed-off-by: claude <claude.brayer@cea.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17869 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17869 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 72805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72805&action=edit Bug 17869: Don't show pick up location on OPAC holds if only one library exists Test Plan [1.] Type in browser http://localhost:8080/ (If you aren't logged in then log in) [2.] Then search for anything and click on the link 'Place hold' which is directly underneath the stars for an item [3.] Notice that there is a pick up location with only one location [4.] Load the patch and now notice that there is no location (as it is not necessary with only one location) Signed-off-by: claude <claude.brayer@cea.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17869 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17869 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72763|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17869 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I do not recreate the bug on master, can you confirm it is still valid? The singleBranchMode test should do this job. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17869 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Don't show pick-up library |Don't show pick-up library |for holds in OPAC account |for list of holds in OPAC |when there is only one |account when there is only |branch |one branch --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think the original bug was misunderstood and you are right in that the patch is not needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17869 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gracesmythh@gmail.com |oleonard@myacpl.org Status|Failed QA |ASSIGNED --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- What I meant was: - Make sure you only got 1 library in your installation - Place a hold, verify there is no pick-up location to select - Go to the patron account in OPAC - Go to summary - Pick tab holds - Verify you can see a pick-up location column there -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17869 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72805|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17869 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17869 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 76146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76146&action=edit Bug 17869: Don't show pick-up library for list of holds in OPAC account when there is only one branch This patch modifies the user summary page in the OPAC so that the "pick up location" column isn't shown in the table of holds if there is only one library defined. To test, apply the patch and log into the OPAC as a user with one or more holds. - In a system with more than one library defined the "Holds" tab of opac-user.pl should show a "Pick up location" column. - In a system with only one library defined there should be now "Pick up location" column. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17869 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17869 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76146|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 76252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76252&action=edit Bug 17869: Don't show pick-up library for list of holds in OPAC account when there is only one branch This patch modifies the user summary page in the OPAC so that the "pick up location" column isn't shown in the table of holds if there is only one library defined. To test, apply the patch and log into the OPAC as a user with one or more holds. - In a system with more than one library defined the "Holds" tab of opac-user.pl should show a "Pick up location" column. - In a system with only one library defined there should be now "Pick up location" column. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17869 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx, Owen! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17869 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17869 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76252|0 |1 is obsolete| | --- Comment #11 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 76516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76516&action=edit Bug 17869: Don't show pick-up library for list of holds in OPAC account when there is only one branch This patch modifies the user summary page in the OPAC so that the "pick up location" column isn't shown in the table of holds if there is only one library defined. To test, apply the patch and log into the OPAC as a user with one or more holds. - In a system with more than one library defined the "Holds" tab of opac-user.pl should show a "Pick up location" column. - In a system with only one library defined there should be now "Pick up location" column. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17869 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17869 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #12 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17869 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize@ptfs-europe | |.com --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x for 18.05.02, trivial bugfix. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17869 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #14 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.11.x for 17.11.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17869 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org