[Bug 37024] New: Scrolling glitch on holdings table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 Bug ID: 37024 Summary: Scrolling glitch on holdings table Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: Laura.escamilla@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Similar to bug 36291, the holdings table is also glitching during scrolling. I'm seeing the following message in the console log: "This site appears to use a scroll-linked positioning effect. This may not work well with asynchronous panning; see https://firefox-source-docs.mozilla.org/performance/scroll-linked_effects.ht... for further details and to join the discussion on related tools and features!" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- That warning will show up on any page that uses HCSticky as far as I know, and doesn't necessarily indicate an actual problem with the page. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 Benjamin Daeuber <bdaeuber@cityoffargo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bdaeuber@cityoffargo.com --- Comment #2 from Benjamin Daeuber <bdaeuber@cityoffargo.com> --- I think this is still occurring in 24.11, even after the DataTables update. It may a separate issue, but staff have reported it here on long holdings tables. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 carthur@slolibrary.org <carthur@slolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |carthur@slolibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 Jason Robb <jrobb@sekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |Main CC| |jrobb@sekls.org --- Comment #3 from Jason Robb <jrobb@sekls.org> --- I've gotten lots of reports of glitchy scrolling recently, possibly coinciding with 24.11.05. It only happens in Chrome (my current Version 138.0.7204.158). It seems to happen any time a table header wants to stick as you're scrolling down the page. I was able to recreate it on Main in ktd by adding some holds then running the holds queue (10 rows seemed to be a sweet spot that really fired it up). When you try to scroll slowly, it jerks the page back up. If you scroll quickly it can sometimes get over the bump. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 Cindy Murdock Ames <cmurdock@ccfls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cmurdock@ccfls.org --- Comment #4 from Cindy Murdock Ames <cmurdock@ccfls.org> --- Not sure if this is helpful or even the same issue, but we've been experiencing this lately on 24.11 on our staff computers in Chrome (although I've been unable to replicate it myself). Apparently it's been happening for a while so I'm not sure if a recent Chrome update has triggered or worsened it. Anyway, a colleague found while checking things out in Chrome's developer tools that if you disable this (under Styles) the problem disappeared: :root { font-size: var(--bs-root-font-size); } That line is from /usr/share/koha/intranet/htdocs/intranet-tmpl/prog/css/staff-global.css I have no idea how to disable that permaenently or if doing so is the correct thing to do or entirely reckless, but I'm putting it here in case someone in the know finds that this is the correct rabbithole to go down. ;) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 rpalermo@oslri.net changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rpalermo@oslri.net --- Comment #5 from rpalermo@oslri.net --- I'm noticing the same behavior when scrolling on items, checkouts and also holds using the Edge browser. It also seems that the mouse needs to be positioned within the table to experience this issue. When moving the mouse off the table to the left, I don't see the same behavior. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 --- Comment #6 from carthur@slolibrary.org <carthur@slolibrary.org> --- +1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 Rebecca Coert <rcoert@arlingtonva.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert@arlingtonva.us --- Comment #7 from Rebecca Coert <rcoert@arlingtonva.us> --- +1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #8 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- I've tried my hardest to recreate this issue and cannot. I've tried k-t-d and production sites that are reporting the problem. I have tried Ubunutu and Windows. I have tried Chrome and FF. I can't recreate this. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #9 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- I can recreate on a fresh up-to-date KTD in Chrome version 138.0.7204.169 but not in Firefox version 141.0. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 --- Comment #10 from Cindy Murdock Ames <cmurdock@ccfls.org> --- An addendum: I was finally able to replicate it myself on my in-library work computer, which has more similar specs to our other staff computers. This one has an Intel CoffeeLake-S GT2 UHD Graphics 630 graphics card, using the i915 driver, as do probably most of our other staff computers. The one in my home office, where I couldn't replicate it, I think has an Nvidia Quadro 4000. My colleague couldn't replicate it on his laptop on Chrome 138.0.7204.157, but he updated to 138.0.7204.168 and it started happening. If I scroll slowly with the mouse scroll button it jumps all over the place, but if I scroll faster it gets past it. If I use the page up/page down buttons on the keyboard it doesn't do it at all. I'm wondering if it's an unfortunate combination of video hardware &/or driver plus the latest version of Chrome where it's most likely to happen. Also the workaround someone mentioned in Edge where it wouldn't do it if you scrolled off to the left of the table doesn't work on Chrome. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 karie.straube@yavapaiaz.gov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |karie.straube@yavapaiaz.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 Michelle Spinney <mspinney@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mspinney@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 --- Comment #11 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- -This only seems to be reported in Chrome. -An on scroll event is being triggered and reseting the `.dtfh-floatingparent` element to `top: 0`, which creates the flicker. It seems like we can mostly work around the issue by adding the following CSS: .dataTable thead { position: sticky !important; top: 0 !important; } My question, is there anything fixedHeader is doing that cannot be done with CSS position sticky which now has wide browser support? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com --- Comment #12 from Jonathan Druart <jonathan.druart@gmail.com> --- It would be worth trying with a newest version of DataTables. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=36291 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa@montgomeryc | |ountymd.gov --- Comment #13 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- I reproduce this on main and 24.11.02 in Chrome (I'm also on version 138.0.7204.158), and I confirm that Lucas's CSS snippet fixes it for me. (Thanks, Lucas!) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 David Roberts <david.roberts@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david.roberts@openfifth.co. | |uk --- Comment #14 from David Roberts <david.roberts@openfifth.co.uk> --- Some of our customers have reported this in Edge too. The problem happens where the 'banner' reaches the top of the screen and Koha is reluctant to let the scrolling continue. There are a few seconds of juddering before the remainder of the long page flows under the banner that has reached the top of the page. There is often a difference in behaviour between using the mouse wheel, and the arrows at the top and bottom of the scroll bar in the browser. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor@clamsnet.org --- Comment #15 from Brendan Lawlor <blawlor@clamsnet.org> --- Our libraries just reported this in 24.11.06 Thanks for the css fix Lucas! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 Dani Elder <danielle.elder@law.utexas.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |danielle.elder@law.utexas.e | |du -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 --- Comment #16 from Katie Bliss <kebliss@dmpl.org> --- I've seen this in Edge as well, though I went to go test again and can't actually reproduce it anymore. So perhaps no longer an issue in that browser? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 Ray Delahunty <r.delahunty@arts.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |r.delahunty@arts.ac.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@openfifth.c | |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 --- Comment #17 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Any more thoughts on this? We've added the CSS fix from Lucas to our xCSS preferences for a number of our sites now reporting this.. but it would be good to have a core fix -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CONFIRMED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 --- Comment #18 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Martin Renvoize (ashimema) from comment #17)
Any more thoughts on this?
First thing should be to confirm it's not fixed upstream. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 Eric Phetteplace <ephetteplace@cca.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ephetteplace@cca.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 Janet McGowan <janet.mcgowan@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janet.mcgowan@openfifth.co. | |uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 Christine Lee <chlee@pascolibraries.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chlee@pascolibraries.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 --- Comment #19 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #18)
(In reply to Martin Renvoize (ashimema) from comment #17)
Any more thoughts on this?
First thing should be to confirm it's not fixed upstream.
I can confirm this still exists in main. I'm most often seeing it in the circ rules (/cgi-bin/koha/admin/smart-rules.pl). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 --- Comment #20 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- (In reply to Andrew Fuerste-Henry from comment #19)
I can confirm this still exists in main. I'm most often seeing it in the circ rules (/cgi-bin/koha/admin/smart-rules.pl).
In Chrome Version 141.0.7390.123 on a mac. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|CONFIRMED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 --- Comment #21 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 189138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189138&action=edit Bug 37024: Fix dataTable scroll glitch To test: 1. Observe the glitchy scroll behavior describe in this bug report. 2. Apply patch, yarn build 3. The scroll glitch should be gone -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189138|0 |1 is obsolete| | --- Comment #22 from David Nind <david@davidnind.com> --- Created attachment 189140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189140&action=edit Bug 37024: Fix dataTable scroll glitch To test: 1. Observe the glitchy scroll behavior describe in this bug report. 2. Apply patch, yarn build 3. The scroll glitch should be gone Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes scrolling on release notes| |some staff interface pages | |that have "sticky" headers | |for tables (for some | |browsers). For example, | |when scrolling down the | |circulation and fine rules | |page using a Chromium-based | |browser, the main table | |with the sticky header is | |initially difficult to | |scroll past and | |"jumps/flickers" a little | |before letting you scroll | |down the rest of the page. --- Comment #23 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. Tested on an Ubuntu 22.04 desktop, using Chromium, Firefox Developer Edition, and Google Chrome (latest versions), 2. Tested the circulation and fine rules page (Koha administration > Patrons and circulation > Circulation and fine rules). 3. Before the patch: - Chromium: jumps/flickers - Google Chrome: jumps/flickers - Firefox Developer Edition: no issues, scrolls as expected 4. After the patch: - Chromium: now scrolls as expected - Google Chrome: now scrolls as expected - Firefox Developer Edition: no change, scrolls as expected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 --- Comment #24 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Andrew Fuerste-Henry from comment #19)
(In reply to Jonathan Druart from comment #18)
(In reply to Martin Renvoize (ashimema) from comment #17)
Any more thoughts on this?
First thing should be to confirm it's not fixed upstream.
I can confirm this still exists in main. I'm most often seeing it in the circ rules (/cgi-bin/koha/admin/smart-rules.pl).
by upstream I meant in newer DataTable version. Can you try bug 40816 maybe? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 --- Comment #25 from David Nind <david@davidnind.com> --- (In reply to Jonathan Druart from comment #24)
(In reply to Andrew Fuerste-Henry from comment #19)
(In reply to Jonathan Druart from comment #18)
(In reply to Martin Renvoize (ashimema) from comment #17)
Any more thoughts on this?
First thing should be to confirm it's not fixed upstream.
I can confirm this still exists in main. I'm most often seeing it in the circ rules (/cgi-bin/koha/admin/smart-rules.pl).
by upstream I meant in newer DataTable version. Can you try bug 40816 maybe?
I tried bug 40816 (apply patch, yarn build, restart_all) and the issue still exists. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=40816 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #26 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- With this patch and yarn build, I still saw some glitchy behavior when scrolling down slowly from the start of the table with 10 longer rows on the admin/branches page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 --- Comment #27 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #26)
With this patch and yarn build, I still saw some glitchy behavior when scrolling down slowly from the start of the table with 10 longer rows on the admin/branches page.
In Chrome Version 142.0.7444.60 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 --- Comment #28 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Probably we should adjust the title of this report. Since it is a more generic thing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 Daphne Hoolahan <dch@interleaf.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dch@interleaf.ie -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Scrolling glitch on |Scrolling "glitch" for some |holdings table |tables with sticky headers | |(that use DataTables) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #29 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Moving to In discussion. This needs more testing or further changes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #30 from David Cook <dcook@prosentient.com.au> --- (In reply to Lucas Gass (lukeg) from comment #11)
-This only seems to be reported in Chrome. -An on scroll event is being triggered and reseting the `.dtfh-floatingparent` element to `top: 0`, which creates the flicker.
It seems like we can mostly work around the issue by adding the following CSS:
.dataTable thead { position: sticky !important; top: 0 !important; }
My question, is there anything fixedHeader is doing that cannot be done with CSS position sticky which now has wide browser support?
I've tried Lucas's CSS via IntranetUserCSS and while it might not be perfect, it certainly fixes the problem for us. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 Jeremy Evans <jeremy.evans@ukhsa.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jeremy.evans@ukhsa.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|lucas@bywatersolutions.com |koha-bugs@lists.koha-commun | |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA --- Comment #31 from David Cook <dcook@prosentient.com.au> --- I was sad to see Lucas reset Assignee, so I took another look at this, and the patch works well for me even with tables of 12-15 entries. I did have to open my dev tools and force a refresh of the staff-global.css so that it didn't use a cached version. With the version that includes the following CSS, it works well: table.dataTable thead { position: sticky; top: 0 } -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |dcook@prosentient.com.au |y.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #32 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Marcel de Rooy from comment #29)
Moving to In discussion. This needs more testing or further changes.
I don't see that this was resolved or discussed, resetting to 'In discussion'/ Marcel, what further testing/changes are needed? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 --- Comment #33 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Lucas Gass (lukeg) from comment #32)
(In reply to Marcel de Rooy from comment #29)
Moving to In discussion. This needs more testing or further changes.
I don't see that this was resolved or discussed, resetting to 'In discussion'/ Marcel, what further testing/changes are needed?
It didnt work for me.. So further tests could perhaps reveal more. But it didnt move much since then. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 --- Comment #34 from David Nind <david@davidnind.com> --- Created attachment 190946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190946&action=edit Video of scrolling and jumping behavour - Chromium browser Another table to see this on is Administration > Patrons and circulation > Patron categories. Resize the length of your browser window so that you have to scroll to get to the bottom of the table. Try to scroll to the bottom of the table: - if you scroll slowly, you will never get to the bottom, and it keeps jumping and going back to the top of the table - if you scroll very quickly, you will get to the bottom. Only visible in some browsers - see my testing notes on comment #23 After applying the patch, a yarn build is required to regenerate the CSS. Short video attached. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 --- Comment #35 from David Cook <dcook@prosentient.com.au> --- (In reply to Marcel de Rooy from comment #33)
(In reply to Lucas Gass (lukeg) from comment #32)
(In reply to Marcel de Rooy from comment #29)
Moving to In discussion. This needs more testing or further changes.
I don't see that this was resolved or discussed, resetting to 'In discussion'/ Marcel, what further testing/changes are needed?
It didnt work for me.. So further tests could perhaps reveal more. But it didnt move much since then.
Have you confirmed that you're definitely using the patched version and not a cached version of the CSS? The patch has worked for Lucas, David Nind, and David Cook. Note when I first tried it - it didn't work for me but that's because my browser was using a cached version of the CSS. I had to open my F12 dev tools, go to the network tab, ensure "Disable cache" was checked, and then hold shift and do a refresh of the page. It was only after those steps that I was able to load the updated CSS and get the fix working. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #36 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to David Cook from comment #35)
(In reply to Marcel de Rooy from comment #33)
(In reply to Lucas Gass (lukeg) from comment #32)
(In reply to Marcel de Rooy from comment #29)
Moving to In discussion. This needs more testing or further changes.
I don't see that this was resolved or discussed, resetting to 'In discussion'/ Marcel, what further testing/changes are needed?
It didnt work for me.. So further tests could perhaps reveal more. But it didnt move much since then.
Have you confirmed that you're definitely using the patched version and not a cached version of the CSS? The patch has worked for Lucas, David Nind, and David Cook.
Note when I first tried it - it didn't work for me but that's because my browser was using a cached version of the CSS. I had to open my F12 dev tools, go to the network tab, ensure "Disable cache" was checked, and then hold shift and do a refresh of the page. It was only after those steps that I was able to load the updated CSS and get the fix working.
I think maybe we can go with this as is. It is certainly fixing the problem for many. Why it persists for Marcel, I don't know. We've added similar CSS to many sites via IntranetUserCSS ( mentioned in comment #11 ) and no one has complained about adverse side effects. I will mark this back to 'Signed off'. Maybe one of the David's can put a QA stamp here? :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189140|0 |1 is obsolete| | --- Comment #37 from David Cook <dcook@prosentient.com.au> --- Created attachment 191019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191019&action=edit Bug 37024: Fix dataTable scroll glitch To test: 1. Observe the glitchy scroll behavior describe in this bug report. 2. Apply patch, yarn build 3. The scroll glitch should be gone Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #38 from Jonathan Druart <jonathan.druart@gmail.com> --- Sorry, late to the party. The fix looked wrong to me, and I found a bug: With filters on the holdings table: https://snipboard.io/9UTQRi.jpg Certainly coming from: koha-tmpl/intranet-tmpl/prog/js/datatables.js 1146 table_dt.fixedHeader.adjust(); -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 --- Comment #39 from Jonathan Druart <jonathan.druart@gmail.com> --- Sorry, late to the party. The fix looked wrong to me, and I found some bugs: 1. With filters on the holdings table: https://snipboard.io/Ka1UIL.jpg Certainly coming from: koha-tmpl/intranet-tmpl/prog/js/datatables.js 1146 table_dt.fixedHeader.adjust(); 2. Also a problem on the item search where fixedHeader is disabled: https://snipboard.io/TUmv7n.jpg 3. The headers of the pref tables are now sticky, they are not on main: koha-tmpl/intranet-tmpl/prog/js/pages/preferences.js: fixedHeader: false, -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 --- Comment #40 from David Cook <dcook@prosentient.com.au> --- Seems like we're a bit stuck here? Should we be fixing/changing each table one by one? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 Michael Adamyk <michael.adamyk@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michael.adamyk@bywatersolut | |ions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 --- Comment #41 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #40)
Seems like we're a bit stuck here?
Should we be fixing/changing each table one by one?
Any more ideas from anyone? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 --- Comment #42 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to David Cook from comment #41)
(In reply to David Cook from comment #40)
Seems like we're a bit stuck here?
Should we be fixing/changing each table one by one?
Any more ideas from anyone?
Maybe produce a minimal example and ask on DT's forum? https://datatables.net/forums/ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 helm.consortium@nhs.net changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |helm.consortium@nhs.net -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 --- Comment #43 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #42)
(In reply to David Cook from comment #41)
(In reply to David Cook from comment #40)
Seems like we're a bit stuck here?
Should we be fixing/changing each table one by one?
Any more ideas from anyone?
Maybe produce a minimal example and ask on DT's forum? https://datatables.net/forums/
Yeah that's a good idea. I just looked at the Basic Initialisation example on FixedHeader and it works seamlessly. I wonder what we're doing that is making it not work... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 --- Comment #44 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #39)
Certainly coming from: koha-tmpl/intranet-tmpl/prog/js/datatables.js 1146 table_dt.fixedHeader.adjust();
Hmm I commented that line out and it doesn't make a difference in /cgi-bin/koha/admin/smart-rules.pl Interestingly... if I scroll to the far right FixedHeader works perfectly. If I scroll to the far left, FixedHeader has the scrolling bug... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 --- Comment #45 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #44)
(In reply to Jonathan Druart from comment #39)
Certainly coming from: koha-tmpl/intranet-tmpl/prog/js/datatables.js 1146 table_dt.fixedHeader.adjust();
Hmm I commented that line out and it doesn't make a difference in /cgi-bin/koha/admin/smart-rules.pl
Interestingly... if I scroll to the far right FixedHeader works perfectly. If I scroll to the far left, FixedHeader has the scrolling bug...
If I delete the "colgroup" from the HTML, it doesn't have the scrolling bug... But then the "Basic initialisation" example has a colgroup and it's fine... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 --- Comment #46 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #44)
Interestingly... if I scroll to the far right FixedHeader works perfectly. If I scroll to the far left, FixedHeader has the scrolling bug...
Actually that's not quite right... there's a certain sweet spot with the scroll where the headings jump to the left... ugh -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 --- Comment #47 from David Cook <dcook@prosentient.com.au> --- So I get the scrolling glitch on /cgi-bin/koha/admin/smart-rules.pl and /cgi-bin/koha/admin/itemtypes.pl but not /cgi-bin/koha/members/members-home.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 --- Comment #48 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #47)
So I get the scrolling glitch on /cgi-bin/koha/admin/smart-rules.pl and /cgi-bin/koha/admin/itemtypes.pl but not /cgi-bin/koha/members/members-home.pl
I guess because fixedHeader is false on members-home.pl and the "fixed header" we do must be done via an alternate method. Although I see fh-fixedHeader used with div.searchheader... but maybe that's not doing anything there... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 --- Comment #49 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #48)
I guess because fixedHeader is false on members-home.pl and the "fixed header" we do must be done via an alternate method. Although I see fh-fixedHeader used with div.searchheader... but maybe that's not doing anything there...
Yeah nah fh-fixedHeader does nothing there... It's #memberresultst thead { position: sticky; top: 40px } in staff-global.css... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 --- Comment #50 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #47)
So I get the scrolling glitch on /cgi-bin/koha/admin/smart-rules.pl and /cgi-bin/koha/admin/itemtypes.pl but not /cgi-bin/koha/members/members-home.pl
I guess because fixedHeader is false on members-home.pl and the "fixed header" we do must be done via an alternate method. Although I see fh-fixedHeader used with div.searchheader... but maybe that's not doing anything there... /cgi-bin/koha/admin/systempreferences.pl has the glitchy scroll. There's something about fixedHeader that seems weird... It looks like folk have been interested in replacing fixedHeader with position:sticky see issue 98 for DataTables/FixedHeader on github. (I'm refraining from posting too many links so I don't get autobanned...) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 --- Comment #51 from David Cook <dcook@prosentient.com.au> --- We're using FixedHeader 4.0.1 but that looks like it should contain these fixes: "Fix: Bootstrap 5 was showing odd behaviour with scrolling - it was flickering the scroll position during the mode transistion." "Fix: "Jittering" when the table starts to scroll (in certain cases)" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 --- Comment #52 from David Cook <dcook@prosentient.com.au> --- I commented on https://github.com/DataTables/FixedHeader/issues/105 titled "bootstrap 3 fixedheader scrolling down issue" which has a video which looks the same as ours I think... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 Eric Phetteplace <ephetteplace@cca.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|ephetteplace@cca.edu | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 --- Comment #53 from David Cook <dcook@prosentient.com.au> --- I tried rebuilding our datatables.min.js and datatables.min.css using the latest and greatest via the DataTables builder, but the problem still happens. It looks like a lot of attempts have been made at fixes over the past few years. I do wonder if just not using fixedHeader would be a better way to go... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 --- Comment #54 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #42)
Maybe produce a minimal example and ask on DT's forum? https://datatables.net/forums/
Thanks for inspiring me to go to the source, Jonathan! The author Allan wrote a fix for it last night: https://github.com/DataTables/FixedHeader/commit/3defb25dbfe1533dded755f614e... He was really responsive on the Github issue. I've asked when he thinks it will be added in a tagged release. Of course, since we include FixedHeader in the datatables.min.js bundle, we'd have to replace the whole bundle. It would be good to get this fixed though. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 --- Comment #55 from David Cook <dcook@prosentient.com.au> --- Allan the DataTables author says he should have a tagged release ready this week. So that's good! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 --- Comment #56 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to David Cook from comment #55)
Allan the DataTables author says he should have a tagged release ready this week. So that's good!
Very cool! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 --- Comment #57 from Jonathan Druart <jonathan.druart@gmail.com> --- Would be great to push bug 40816 then continue with the latest version that is going to be released? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 --- Comment #58 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #57)
Would be great to push bug 40816 then continue with the latest version that is going to be released?
Good question. I doubt bug 40816 would be backported, but I suppose backports would have to involve a careful bundle regeneration anyway... so for main yeah doing bug 40816 with the latest FixedHeader plugin would probably work? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 --- Comment #59 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #58)
(In reply to Jonathan Druart from comment #57)
Would be great to push bug 40816 then continue with the latest version that is going to be released?
Good question. I doubt bug 40816 would be backported, but I suppose backports would have to involve a careful bundle regeneration anyway... so for main yeah doing bug 40816 with the latest FixedHeader plugin would probably work?
FixedHeader 4.0.6 is now released and I've confirmed the correct version is included in the DataTables bundle builder. And looking at the builder again... I guess we do have to update the entire bundle when we want to upgrade any particular subcomponent... So let's get bug 40816 pushed... and then do this bug report with the latest and greatest which should be fairly close to what's in 40816 anyway... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 --- Comment #60 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to David Cook from comment #59)
And looking at the builder again... I guess we do have to update the entire bundle when we want to upgrade any particular subcomponent...
I can work on that as soon as bug 40816 is pushed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |40816 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 [Bug 40816] Upgrade DataTables from 2.1.8 to >2.3.4 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@gmail.com |ity.org | Status|Failed QA |ASSIGNED --- Comment #61 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #60)
(In reply to David Cook from comment #59)
And looking at the builder again... I guess we do have to update the entire bundle when we want to upgrade any particular subcomponent...
I can work on that as soon as bug 40816 is pushed.
Sounds good. Passed QA on bug 40816. I'll obsolete the patch here in the meantime. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191019|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Circulation |Templates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|ASSIGNED |RESOLVED --- Comment #62 from Jonathan Druart <jonathan.druart@gmail.com> --- Please confirm this is fixed with the new version, see bug 42003. *** This bug has been marked as a duplicate of bug 42003 *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 Bug 37024 depends on bug 40816, which changed state. Bug 40816 Summary: Upgrade DataTables from 2.1.8 to 2.3.4 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org