[Bug 42434] New: Capitalization: Print Slip CSS, Print Notice CSS...
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42434 Bug ID: 42434 Summary: Capitalization: Print Slip CSS, Print Notice CSS... Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Keywords: Academy Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org Depends on: 35267 Found while translating in koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt The template should be reviewed for more capitalization issues. See coding guidelines: https://wiki.koha-community.org/w/index.php?title=Coding_Guidelines#HTML4:_U... Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 [Bug 35267] Clarify CSS options for Notices -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42434 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42434 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Assignee|oleonard@myacpl.org |david@davidnind.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42434 --- Comment #1 from David Nind <david@davidnind.com> --- Created attachment 198070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198070&action=edit Bug 42434: Fix capitalization for notice and slip configuration pages Bug 35267 (Clarify CSS options for notices) added several new sections to notice and slip configuration pages. However, the headings and some sentences use capital case instead of sentence case. This updates the text for the headings and sentences to use sentence case. It also adds full stops to some alert sentences for consistency. Test plan: 1. Go to Tools > Patrons > Notices and slips. 2. Edit a notice or slip. 3. Note that several headings are capitalized, instead of using sentence case. 4. Expand each heading, and notice that some text doesn't use sentence case. 5. Apply the patch. 6. Refresh the notice or slip page. 7. Note that headings and text now use sentence case (and sentences in alerts now have a full stop). Examples - headings in capital case: - Global HTML Notice Styles . All Notice CSS . Email Notice CSS . Print Notice CSS . Print Slip CSS ...and further down the page under "Default language: English" - Local HTML Notice Styles Examples - text in expanded sections in capital case: - CSS to be applied to email notices in addition to that already in "All Notice CSS" Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42434 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes notice and slip release notes| |configuration page headings | |and text so that they use | |sentence | |case. It also adds full | |stops to some alert | |sentences for consistency. | | | |(Related to Bug 35267 - | |Clarify CSS options for | |notices, which added | |several new sections | |to notice and slip | |configuration pages in Koha | |26.05.) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42434 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42434 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198070|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42434 --- Comment #2 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 198234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198234&action=edit Bug 42434: Fix capitalization for notice and slip configuration pages Bug 35267 (Clarify CSS options for notices) added several new sections to notice and slip configuration pages. However, the headings and some sentences use capital case instead of sentence case. This updates the text for the headings and sentences to use sentence case. It also adds full stops to some alert sentences for consistency. Test plan: 1. Go to Tools > Patrons > Notices and slips. 2. Edit a notice or slip. 3. Note that several headings are capitalized, instead of using sentence case. 4. Expand each heading, and notice that some text doesn't use sentence case. 5. Apply the patch. 6. Refresh the notice or slip page. 7. Note that headings and text now use sentence case (and sentences in alerts now have a full stop). Examples - headings in capital case: - Global HTML Notice Styles . All Notice CSS . Email Notice CSS . Print Notice CSS . Print Slip CSS ...and further down the page under "Default language: English" - Local HTML Notice Styles Examples - text in expanded sections in capital case: - CSS to be applied to email notices in addition to that already in "All Notice CSS" Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42434 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baptiste.wojtkowski@biblibr | |e.com --- Comment #3 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Note : this change is made to respect HTML4 coding guideline -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42434 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |baptiste.wojtkowski@biblibr |y.org |e.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42434 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198234|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42434 --- Comment #4 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 198281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198281&action=edit Bug 42434: Fix capitalization for notice and slip configuration pages Bug 35267 (Clarify CSS options for notices) added several new sections to notice and slip configuration pages. However, the headings and some sentences use capital case instead of sentence case. This updates the text for the headings and sentences to use sentence case. It also adds full stops to some alert sentences for consistency. Test plan: 1. Go to Tools > Patrons > Notices and slips. 2. Edit a notice or slip. 3. Note that several headings are capitalized, instead of using sentence case. 4. Expand each heading, and notice that some text doesn't use sentence case. 5. Apply the patch. 6. Refresh the notice or slip page. 7. Note that headings and text now use sentence case (and sentences in alerts now have a full stop). Examples - headings in capital case: - Global HTML Notice Styles . All Notice CSS . Email Notice CSS . Print Notice CSS . Print Slip CSS ...and further down the page under "Default language: English" - Local HTML Notice Styles Examples - text in expanded sections in capital case: - CSS to be applied to email notices in addition to that already in "All Notice CSS" Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42434 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42434 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42434 --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42434 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting --- Comment #6 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- This will not be backported to 25.11.x due to it being deemed an enhancement or a dependancy not being met -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42434 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #7 from David Nind <david@davidnind.com> --- Bug fix, no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org