https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |pedro.amorim@ptfs-europe.co |ity.org |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35073 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35073 [Bug 35073] Serials batch edit deletes unchanged additional fields data -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com, | |julian.maurice@biblibre.com | |, katrin.fischer@bsz-bw.de, | |martin.renvoize@ptfs-europe | |.com, | |michaela.sieber@kit.edu -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 --- Comment #1 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 157324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157324&action=edit Bug 35044: [DONT PUSH] dbic specific -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 --- Comment #3 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 157326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157326&action=edit Bug 35044: Admin: New additional fields 'repeatable' field There is now a new 'repeatable' checkbox when configuring (adding or editing) an additional field for a specific table. It is also displayed in a column in the additional fields panel for a given tablename. MARC fields are not allowed to be repeatable. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 --- Comment #5 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 157328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157328&action=edit Bug 35044: Update: Order baskets Test plan, k-t-d: Preparation: Create additional fields for table 'aqbasket': 2 text fields, one repeatable, one not-repeatable 2 AV fields, one repeatable, one not-repeatable 1) Add a new basket, visit: /cgi-bin/koha/acqui/basketheader.pl?booksellerid=1&op=add_form 2) Fill in name and all additional fields, click the '+New' and 'Clear' links, hit 'Save' 3) Notice the basket screen shows repeated fields separated by comma. 4) Notice that only non-null additional fields labels are shown. 5) Edit the basket. Notice all fields are shown as expected. Additional testing: Having a repeatable field with multiple instances, go back to the additional fields configuration and make the additional field non-repeatable again. Edit the basket again. Notice the multiple text instances are still shown, but the '+New' link no longer shows. You're able to remove existing multiple instances, but unable to add new ones, this is because the field is no longer repeatable. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 --- Comment #7 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 157330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157330&action=edit Bug 35044: Update: Invoices Added fixme comment to invoices.tt, the search works so nothing to do here, but the code is not DRY Test plan, k-t-d: Preparation: Create additional fields for table 'aqinvoices': 2 text fields, one repeatable, one not-repeatable 2 AV fields, one repeatable, one not-repeatable 1) Add a new invoice for an existing vendor, visit: /cgi-bin/koha/acqui/parcels.pl?booksellerid=1 2) Input something in the mandatory "Vendor invoice" field. 3) Fill in all additional fields, click the '+New' and 'Clear' links, hit 'Save' 4) Search for invoices, visit: http://localhost:8081/cgi-bin/koha/acqui/invoices.pl 5) Click "Search" on the left column of the page 6) Click the invoice we just created. Verify all the fields show correctly. 7) Go back to the additional fields configuration, set all additional fields as "searchable" 8) Return to http://localhost:8081/cgi-bin/koha/acqui/invoices.pl 9) Perform some searches using the additional fields values. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 --- Comment #9 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 157332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157332&action=edit Bug 35044: Update: Serial subscriptions batch edit Test plan, k-t-d: Preparation: Create additional fields for table 'subscription', visit: /cgi-bin/koha/admin/additional-fields.pl?tablename=subscription 2 text fields, one repeatable, one not-repeatable 2 AV fields, one repeatable, one not-repeatable 2 MARC fields, one 'get' and one 'set', both non-repeatable, MARC field 942$c Attempt to create a repeatable MARC field (get or set). Notice you're unable to. 1) Add a new serial subscription, visit: /cgi-bin/koha/serials/subscription-add.pl 2) Set the mandatory "Record" input (e.g. '112'). Click the 'Next' and press 'Ok' on the alert box. 3) Fill in all required fields and press "Test prediction pattern" 4) At the bottom, fill in all additional fields, click the '+New' and 'Clear' links, hit 'Save' 5) Notice the fields are shown, repeated fields are comma separated 6) Repeat steps 1-4 to create a second subscription 7) Visit serials home and hit "Search": /cgi-bin/koha/serials/serials-home.pl 8) Check the checkboxes next to the 2 subscriptions and click "Edit selected serials" 9) Input some values in the additional fields section, click the '+New' and 'Clear' links, hit 'Save' 10) Verify that both subscriptions now have the new values form the batch edit. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 --- Comment #11 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 157334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157334&action=edit Bug 35044: Add tests Test plan: prove t/db_dependent/Koha/Object/Mixin/AdditionalFields.t -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35197 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35197 | Depends on| |35197 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35197 [Bug 35197] Expose additional fields through REST API -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157324|0 |1 is obsolete| | --- Comment #13 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 158498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158498&action=edit Bug 35044: [DONT PUSH] dbic specific -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157326|0 |1 is obsolete| | --- Comment #15 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 158500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158500&action=edit Bug 35044: Admin: New additional fields 'repeatable' field There is now a new 'repeatable' checkbox when configuring (adding or editing) an additional field for a specific table. It is also displayed in a column in the additional fields panel for a given tablename. MARC fields are not allowed to be repeatable. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157328|0 |1 is obsolete| | --- Comment #17 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 158502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158502&action=edit Bug 35044: Update: Order baskets Test plan, k-t-d: Preparation: Create additional fields for table 'aqbasket': 2 text fields, one repeatable, one not-repeatable 2 AV fields, one repeatable, one not-repeatable 1) Add a new basket, visit: /cgi-bin/koha/acqui/basketheader.pl?booksellerid=1&op=add_form 2) Fill in name and all additional fields, click the '+New' and 'Clear' links, hit 'Save' 3) Notice the basket screen shows repeated fields separated by comma. 4) Notice that only non-null additional fields labels are shown. 5) Edit the basket. Notice all fields are shown as expected. Additional testing: Having a repeatable field with multiple instances, go back to the additional fields configuration and make the additional field non-repeatable again. Edit the basket again. Notice the multiple text instances are still shown, but the '+New' link no longer shows. You're able to remove existing multiple instances, but unable to add new ones, this is because the field is no longer repeatable. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157330|0 |1 is obsolete| | --- Comment #19 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 158504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158504&action=edit Bug 35044: Update: Invoices Added fixme comment to invoices.tt, the search works so nothing to do here, but the code is not DRY Test plan, k-t-d: Preparation: Create additional fields for table 'aqinvoices': 2 text fields, one repeatable, one not-repeatable 2 AV fields, one repeatable, one not-repeatable 1) Add a new invoice for an existing vendor, visit: /cgi-bin/koha/acqui/parcels.pl?booksellerid=1 2) Input something in the mandatory "Vendor invoice" field. 3) Fill in all additional fields, click the '+New' and 'Clear' links, hit 'Save' 4) Search for invoices, visit: http://localhost:8081/cgi-bin/koha/acqui/invoices.pl 5) Click "Search" on the left column of the page 6) Click the invoice we just created. Verify all the fields show correctly. 7) Go back to the additional fields configuration, set all additional fields as "searchable" 8) Return to http://localhost:8081/cgi-bin/koha/acqui/invoices.pl 9) Perform some searches using the additional fields values. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157332|0 |1 is obsolete| | --- Comment #21 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 158506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158506&action=edit Bug 35044: Update: Serial subscriptions batch edit Test plan, k-t-d: Preparation: Create additional fields for table 'subscription', visit: /cgi-bin/koha/admin/additional-fields.pl?tablename=subscription 2 text fields, one repeatable, one not-repeatable 2 AV fields, one repeatable, one not-repeatable 2 MARC fields, one 'get' and one 'set', both non-repeatable, MARC field 942$c Attempt to create a repeatable MARC field (get or set). Notice you're unable to. 1) Add a new serial subscription, visit: /cgi-bin/koha/serials/subscription-add.pl 2) Set the mandatory "Record" input (e.g. '112'). Click the 'Next' and press 'Ok' on the alert box. 3) Fill in all required fields and press "Test prediction pattern" 4) At the bottom, fill in all additional fields, click the '+New' and 'Clear' links, hit 'Save' 5) Notice the fields are shown, repeated fields are comma separated 6) Repeat steps 1-4 to create a second subscription 7) Visit serials home and hit "Search": /cgi-bin/koha/serials/serials-home.pl 8) Check the checkboxes next to the 2 subscriptions and click "Edit selected serials" 9) Input some values in the additional fields section, click the '+New' and 'Clear' links, hit 'Save' 10) Verify that both subscriptions now have the new values form the batch edit. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157334|0 |1 is obsolete| | --- Comment #23 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 158508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158508&action=edit Bug 35044: Add tests Test plan: prove t/db_dependent/Koha/Object/Mixin/AdditionalFields.t -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 --- Comment #24 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Rebased on top of bug 35190 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158498|0 |1 is obsolete| | --- Comment #25 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 158857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158857&action=edit Bug 35044: [DONT PUSH] dbic specific -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158500|0 |1 is obsolete| | --- Comment #27 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 158859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158859&action=edit Bug 35044: Admin: New additional fields 'repeatable' field There is now a new 'repeatable' checkbox when configuring (adding or editing) an additional field for a specific table. It is also displayed in a column in the additional fields panel for a given tablename. MARC fields are not allowed to be repeatable. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158502|0 |1 is obsolete| | --- Comment #29 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 158861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158861&action=edit Bug 35044: Update: Order baskets Test plan, k-t-d: Preparation: Create additional fields for table 'aqbasket': 2 text fields, one repeatable, one not-repeatable 2 AV fields, one repeatable, one not-repeatable 1) Add a new basket, visit: /cgi-bin/koha/acqui/basketheader.pl?booksellerid=1&op=add_form 2) Fill in name and all additional fields, click the '+New' and 'Clear' links, hit 'Save' 3) Notice the basket screen shows repeated fields separated by comma. 4) Notice that only non-null additional fields labels are shown. 5) Edit the basket. Notice all fields are shown as expected. Additional testing: Having a repeatable field with multiple instances, go back to the additional fields configuration and make the additional field non-repeatable again. Edit the basket again. Notice the multiple text instances are still shown, but the '+New' link no longer shows. You're able to remove existing multiple instances, but unable to add new ones, this is because the field is no longer repeatable. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158504|0 |1 is obsolete| | --- Comment #31 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 158863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158863&action=edit Bug 35044: Update: Invoices Added fixme comment to invoices.tt, the search works so nothing to do here, but the code is not DRY Test plan, k-t-d: Preparation: Create additional fields for table 'aqinvoices': 2 text fields, one repeatable, one not-repeatable 2 AV fields, one repeatable, one not-repeatable 1) Add a new invoice for an existing vendor, visit: /cgi-bin/koha/acqui/parcels.pl?booksellerid=1 2) Input something in the mandatory "Vendor invoice" field. 3) Fill in all additional fields, click the '+New' and 'Clear' links, hit 'Save' 4) Search for invoices, visit: http://localhost:8081/cgi-bin/koha/acqui/invoices.pl 5) Click "Search" on the left column of the page 6) Click the invoice we just created. Verify all the fields show correctly. 7) Go back to the additional fields configuration, set all additional fields as "searchable" 8) Return to http://localhost:8081/cgi-bin/koha/acqui/invoices.pl 9) Perform some searches using the additional fields values. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158506|0 |1 is obsolete| | --- Comment #33 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 158865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158865&action=edit Bug 35044: Update: Serial subscriptions batch edit Test plan, k-t-d: Preparation: Create additional fields for table 'subscription', visit: /cgi-bin/koha/admin/additional-fields.pl?tablename=subscription 2 text fields, one repeatable, one not-repeatable 2 AV fields, one repeatable, one not-repeatable 2 MARC fields, one 'get' and one 'set', both non-repeatable, MARC field 942$c Attempt to create a repeatable MARC field (get or set). Notice you're unable to. 1) Add a new serial subscription, visit: /cgi-bin/koha/serials/subscription-add.pl 2) Set the mandatory "Record" input (e.g. '112'). Click the 'Next' and press 'Ok' on the alert box. 3) Fill in all required fields and press "Test prediction pattern" 4) At the bottom, fill in all additional fields, click the '+New' and 'Clear' links, hit 'Save' 5) Notice the fields are shown, repeated fields are comma separated 6) Repeat steps 1-4 to create a second subscription 7) Visit serials home and hit "Search": /cgi-bin/koha/serials/serials-home.pl 8) Check the checkboxes next to the 2 subscriptions and click "Edit selected serials" 9) Input some values in the additional fields section, click the '+New' and 'Clear' links, hit 'Save' 10) Verify that both subscriptions now have the new values form the batch edit. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158113|0 |1 is obsolete| | --- Comment #35 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 158867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158867&action=edit Bug 35044: Add repetable to REST API spec -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 --- Comment #37 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Rebased on bug 34708 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35451 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35625 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35625 [Bug 35625] Add support for system flag to additional fields -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158858|0 |1 is obsolete| | --- Comment #40 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 160178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160178&action=edit Bug 35044: DB changes + atomicupdate file Add the 'repeatable' column to additional_fields Remove the unique key from additional_field_values as we will now be allowing for repeated instances of the same field_id + record_id Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158860|0 |1 is obsolete| | --- Comment #42 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 160180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160180&action=edit Bug 35044: Preparation: get_additional_field_values_for_template method New method to be utilized for retrieval of additional fields of any class that implements it. This is to be used when additional_fields are needed to be sent to .tt files for renderering. Both for form entries and read-only 'show' pages. Template files: Updated additional-fields-entry.inc: Now considers entry of repeatable fields. Repeatable text fields will have a "+New" link to allow for adding of a new instance of a repeatable field. Repeatable AV fields will be shown as checkboxes instead of a dropdown Update additional-fields-display.inc When displaying non-editable additional-fields, multiple instances for each field are now considered. Label now only shows if field has a non-null value in it. Option to show value_only Option to set if its to be displayed on a table cell Update histsearch.tt and filter-orders.inc Now calls additional-fields-entry.inc with search_form=1 to prevent repetable "+New" controls from showing on search inputs. additional-fields-entry.js New JS asset to be called by template files who require additional-fields-entry.inc for repeatable fields controls. This also handles the need for having the marcfield of type 'get' submitted if it is a disabled dropdown (AV marc field) Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158862|0 |1 is obsolete| | --- Comment #44 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 160182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160182&action=edit Bug 35044: Update: Acquisition orders Test plan, k-t-d: Preparation: Create additional fields for table 'aqorders': 2 text fields, one repeatable, one not-repeatable 2 AV fields, one repeatable, one not-repeatable 2 MARC fields, one 'get' and one 'set', both non-repeatable, MARC field 942$c Attempt to create a repeatable MARC field (get or set). Notice you're unable to. 1) Add a new order for an existing basket, with an existing record, visit: /cgi-bin/koha/acqui/neworderempty.pl?booksellerid=1&basketno=1&biblionumber=76 2) Set the mandatory "Koha item type" for the item. Click the 'Add item' button below. 3) Notice the accounting details now have quantity:1 4) Set the mandatory "Fund" input in accounting details. 5) At the bottom, fill in all additional fields, click the '+New' and 'Clear' links, hit 'Save' 6) In the orders table shown, click "Modify". Notice all the fields are presented correctly in the edit form. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158864|0 |1 is obsolete| | --- Comment #46 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 160184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160184&action=edit Bug 35044: Update: Serial subscriptions Test plan, k-t-d: Preparation: Create additional fields for table 'subscription', visit: /cgi-bin/koha/admin/additional-fields.pl?tablename=subscription 2 text fields, one repeatable, one not-repeatable 2 AV fields, one repeatable, one not-repeatable 2 MARC fields, one 'get' and one 'set', both non-repeatable, MARC field 942$c Attempt to create a repeatable MARC field (get or set). Notice you're unable to. 1) Add a new serial subscription, visit: /cgi-bin/koha/serials/subscription-add.pl 2) Set the mandatory "Record" input (e.g. '112'). Click the 'Next' and press 'Ok' on the alert box. 3) Fill in all required fields and press "Test prediction pattern" 4) At the bottom, fill in all additional fields, click the '+New' and 'Clear' links, hit 'Save' 5) Notice the fields are shown, repeated fields are comma separated 6) Click Edit -> Edit Subscription, repeat steps 4 and 5 7) Go back to subscription additional fields, set all fields as searchable 8) Visit serials-home: /cgi-bin/koha/serials/serials-home.pl 9) Click 'Search' 10) Notice the searchable fields now show in their columns, repeated fields separated by comma 11) Perform a search using a repeatable field, verify it all works as expected. -- Subscription Claims -- Preparation: 1) Define a new claim notice, visit: /cgi-bin/koha/tools/letter.pl?op=add_form&module=claimissues 2) Input code, name, click "Email" set a "Message subject" and put something in the message body. Hit 'Save'. 3) Set a serial as late, visit our original subscription: /cgi-bin/koha/serials/serials-collection.pl?subscriptionid=1 4) Click "Edit serials" and status -> "Late". Hit "Save". 5) Link the original subscription to the existing vendor, visit: /cgi-bin/koha/serials/subscription-add.pl?op=modify&subscriptionid=1 6) Click "Search for a vendor". Hit "Ok". Hit "Choose". Save the subscription. Claims: 7) Visit claims: /cgi-bin/koha/serials/claims.pl 8) Click "Ok" 9) Verify that searchable additional fields all have their respective column. Repeated fields are shown comma separated. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158866|0 |1 is obsolete| | --- Comment #48 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 160186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160186&action=edit Bug 35044: Update: Manual invoices, manual credits and accountlines Test plan, k-t-d: Preparation: Create additional fields for table 'accountlines:credit', visit: /cgi-bin/koha/admin/additional-fields.pl?tablename=accountlines%3Acredit 2 text fields, one repeatable, one not-repeatable 2 AV fields, one repeatable, one not-repeatable 1) Add a new manual credit for admin borrower: /cgi-bin/koha/members/mancredit.pl?borrowernumber=51 2) Set the mandatory "Amount" input (e.g. '5'). Click the 'Next' and press 'Ok' on the alert box. 3) Fill in all additional fields, click the '+New' and 'Clear' links, hit 'Save' 4) On the table, click "Details" for the for account line we just created. 5) Notice the additional fields are there, repeated fields are comma separated. 6) Repeat the above test plan, but for accountlines:debit instead, visit: /cgi-bin/koha/admin/additional-fields.pl?tablename=accountlines%3Adebit 7) To add a manual invoice, visit: /cgi-bin/koha/members/maninvoice.pl?borrowernumber=51 Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158868|0 |1 is obsolete| | --- Comment #50 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 160188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160188&action=edit Bug 35044: Add tests Test plan: prove t/db_dependent/Koha/Object/Mixin/AdditionalFields.t Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #52 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Tested thoroughly and I'm really happy with the results here. There's one caveat, which I've already discussed with Pedro and we came to the conclusion it was a feature rather than a bug. The repeatable implementation is all UI level, there's no check on store to prevent a non-repeatable field being repeated.. this means if you're so inclined you could carefully craft a request to add an additional field value for a field marked non-repeatable. However, given that you can flick between repeatable/non-repeatable in the UI easily (and that doesn't cleanup existing repeated value's as we felt it least destructive to keep the data around) and you can remove existing repeated value's, but not add new ones to a newly marked non-repeatable field this covers the use cases nicely. Signing off. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |david@davidnind.com --- Comment #53 from David Nind <david@davidnind.com> --- Patches no longer apply 8-(.... git bz apply 35044 Bug 35044 Depends on bug 35197 (Signed Off) Follow? [(y)es, (n)o] y Bug 35197 - Expose additional_field definitions through REST API 159648 - Bug 35197: Add additional_fields REST API endpoint 159649 - Bug 35197: Add tests 159650 - Bug 35197: Field name consistency Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 35197: Add additional_fields REST API endpoint Applying: Bug 35197: Add tests Applying: Bug 35197: Field name consistency Bug 35044 - Additional fields: Allow for repeatable fields 160177 - Bug 35044: [DONT PUSH] dbic specific 160178 - Bug 35044: DB changes + atomicupdate file 160179 - Bug 35044: Admin: New additional fields 'repeatable' field 160180 - Bug 35044: Preparation: 160181 - Bug 35044: Update: Order baskets 160182 - Bug 35044: Update: Acquisition orders 160183 - Bug 35044: Update: Invoices 160184 - Bug 35044: Update: Serial subscriptions 160185 - Bug 35044: Update: Serial subscriptions batch edit 160186 - Bug 35044: Update: Manual invoices, manual credits and accountlines 160187 - Bug 35044: Add repetable to REST API spec 160188 - Bug 35044: Add tests 160189 - Bug 35044: (QA Follow-up) Fix atomicupdate Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 35044: [DONT PUSH] dbic specific Applying: Bug 35044: DB changes + atomicupdate file Applying: Bug 35044: Admin: New additional fields 'repeatable' field Applying: Bug 35044: Preparation: Applying: Bug 35044: Update: Order baskets Applying: Bug 35044: Update: Acquisition orders Using index info to reconstruct a base tree... M acqui/addorder.pl M acqui/neworderempty.pl M koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt Auto-merging acqui/neworderempty.pl Auto-merging acqui/addorder.pl CONFLICT (content): Merge conflict in acqui/addorder.pl error: Failed to merge in the changes. Patch failed at 0001 Bug 35044: Update: Acquisition orders -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160178|0 |1 is obsolete| | --- Comment #55 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 164163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164163&action=edit Bug 35044: DB changes + atomicupdate file Add the 'repeatable' column to additional_fields Remove the unique key from additional_field_values as we will now be allowing for repeated instances of the same field_id + record_id Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160180|0 |1 is obsolete| | --- Comment #57 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 164165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164165&action=edit Bug 35044: Preparation: get_additional_field_values_for_template method New method to be utilized for retrieval of additional fields of any class that implements it. This is to be used when additional_fields are needed to be sent to .tt files for renderering. Both for form entries and read-only 'show' pages. Template files: Updated additional-fields-entry.inc: Now considers entry of repeatable fields. Repeatable text fields will have a "+New" link to allow for adding of a new instance of a repeatable field. Repeatable AV fields will be shown as checkboxes instead of a dropdown Update additional-fields-display.inc When displaying non-editable additional-fields, multiple instances for each field are now considered. Label now only shows if field has a non-null value in it. Option to show value_only Option to set if its to be displayed on a table cell Update histsearch.tt and filter-orders.inc Now calls additional-fields-entry.inc with search_form=1 to prevent repetable "+New" controls from showing on search inputs. additional-fields-entry.js New JS asset to be called by template files who require additional-fields-entry.inc for repeatable fields controls. This also handles the need for having the marcfield of type 'get' submitted if it is a disabled dropdown (AV marc field) Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160182|0 |1 is obsolete| | --- Comment #59 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 164167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164167&action=edit Bug 35044: Update: Acquisition orders Test plan, k-t-d: Preparation: Create additional fields for table 'aqorders': 2 text fields, one repeatable, one not-repeatable 2 AV fields, one repeatable, one not-repeatable 2 MARC fields, one 'get' and one 'set', both non-repeatable, MARC field 942$c Attempt to create a repeatable MARC field (get or set). Notice you're unable to. 1) Add a new order for an existing basket, with an existing record, visit: /cgi-bin/koha/acqui/neworderempty.pl?booksellerid=1&basketno=1&biblionumber=76 2) Set the mandatory "Koha item type" for the item. Click the 'Add item' button below. 3) Notice the accounting details now have quantity:1 4) Set the mandatory "Fund" input in accounting details. 5) At the bottom, fill in all additional fields, click the '+New' and 'Clear' links, hit 'Save' 6) In the orders table shown, click "Modify". Notice all the fields are presented correctly in the edit form. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160184|0 |1 is obsolete| | --- Comment #61 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 164169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164169&action=edit Bug 35044: Update: Serial subscriptions Test plan, k-t-d: Preparation: Create additional fields for table 'subscription', visit: /cgi-bin/koha/admin/additional-fields.pl?tablename=subscription 2 text fields, one repeatable, one not-repeatable 2 AV fields, one repeatable, one not-repeatable 2 MARC fields, one 'get' and one 'set', both non-repeatable, MARC field 942$c Attempt to create a repeatable MARC field (get or set). Notice you're unable to. 1) Add a new serial subscription, visit: /cgi-bin/koha/serials/subscription-add.pl 2) Set the mandatory "Record" input (e.g. '112'). Click the 'Next' and press 'Ok' on the alert box. 3) Fill in all required fields and press "Test prediction pattern" 4) At the bottom, fill in all additional fields, click the '+New' and 'Clear' links, hit 'Save' 5) Notice the fields are shown, repeated fields are comma separated 6) Click Edit -> Edit Subscription, repeat steps 4 and 5 7) Go back to subscription additional fields, set all fields as searchable 8) Visit serials-home: /cgi-bin/koha/serials/serials-home.pl 9) Click 'Search' 10) Notice the searchable fields now show in their columns, repeated fields separated by comma 11) Perform a search using a repeatable field, verify it all works as expected. -- Subscription Claims -- Preparation: 1) Define a new claim notice, visit: /cgi-bin/koha/tools/letter.pl?op=add_form&module=claimissues 2) Input code, name, click "Email" set a "Message subject" and put something in the message body. Hit 'Save'. 3) Set a serial as late, visit our original subscription: /cgi-bin/koha/serials/serials-collection.pl?subscriptionid=1 4) Click "Edit serials" and status -> "Late". Hit "Save". 5) Link the original subscription to the existing vendor, visit: /cgi-bin/koha/serials/subscription-add.pl?op=modify&subscriptionid=1 6) Click "Search for a vendor". Hit "Ok". Hit "Choose". Save the subscription. Claims: 7) Visit claims: /cgi-bin/koha/serials/claims.pl 8) Click "Ok" 9) Verify that searchable additional fields all have their respective column. Repeated fields are shown comma separated. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160186|0 |1 is obsolete| | --- Comment #63 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 164171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164171&action=edit Bug 35044: Update: Manual invoices, manual credits and accountlines Test plan, k-t-d: Preparation: Create additional fields for table 'accountlines:credit', visit: /cgi-bin/koha/admin/additional-fields.pl?tablename=accountlines%3Acredit 2 text fields, one repeatable, one not-repeatable 2 AV fields, one repeatable, one not-repeatable 1) Add a new manual credit for admin borrower: /cgi-bin/koha/members/mancredit.pl?borrowernumber=51 2) Set the mandatory "Amount" input (e.g. '5'). Click the 'Next' and press 'Ok' on the alert box. 3) Fill in all additional fields, click the '+New' and 'Clear' links, hit 'Save' 4) On the table, click "Details" for the for account line we just created. 5) Notice the additional fields are there, repeated fields are comma separated. 6) Repeat the above test plan, but for accountlines:debit instead, visit: /cgi-bin/koha/admin/additional-fields.pl?tablename=accountlines%3Adebit 7) To add a manual invoice, visit: /cgi-bin/koha/members/maninvoice.pl?borrowernumber=51 Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160188|0 |1 is obsolete| | --- Comment #65 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 164173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164173&action=edit Bug 35044: Add tests Test plan: prove t/db_dependent/Koha/Object/Mixin/AdditionalFields.t Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 --- Comment #68 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 167690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167690&action=edit Bug 35044: 00-testcritic.t fix Squash to 'Update: Serial subscriptions' -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164174|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164163|0 |1 is obsolete| | --- Comment #70 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 168538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168538&action=edit Bug 35044: DB changes + atomicupdate file Add the 'repeatable' column to additional_fields Remove the unique key from additional_field_values as we will now be allowing for repeated instances of the same field_id + record_id Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164165|0 |1 is obsolete| | --- Comment #72 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 168540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168540&action=edit Bug 35044: Preparation: get_additional_field_values_for_template method New method to be utilized for retrieval of additional fields of any class that implements it. This is to be used when additional_fields are needed to be sent to .tt files for renderering. Both for form entries and read-only 'show' pages. Template files: Updated additional-fields-entry.inc: Now considers entry of repeatable fields. Repeatable text fields will have a "+New" link to allow for adding of a new instance of a repeatable field. Repeatable AV fields will be shown as checkboxes instead of a dropdown Update additional-fields-display.inc When displaying non-editable additional-fields, multiple instances for each field are now considered. Label now only shows if field has a non-null value in it. Option to show value_only Option to set if its to be displayed on a table cell Update histsearch.tt and filter-orders.inc Now calls additional-fields-entry.inc with search_form=1 to prevent repetable "+New" controls from showing on search inputs. additional-fields-entry.js New JS asset to be called by template files who require additional-fields-entry.inc for repeatable fields controls. This also handles the need for having the marcfield of type 'get' submitted if it is a disabled dropdown (AV marc field) Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164167|0 |1 is obsolete| | --- Comment #74 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 168542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168542&action=edit Bug 35044: Update: Acquisition orders Test plan, k-t-d: Preparation: Create additional fields for table 'aqorders': 2 text fields, one repeatable, one not-repeatable 2 AV fields, one repeatable, one not-repeatable 2 MARC fields, one 'get' and one 'set', both non-repeatable, MARC field 942$c Attempt to create a repeatable MARC field (get or set). Notice you're unable to. 1) Add a new order for an existing basket, with an existing record, visit: /cgi-bin/koha/acqui/neworderempty.pl?booksellerid=1&basketno=1&biblionumber=76 2) Set the mandatory "Koha item type" for the item. Click the 'Add item' button below. 3) Notice the accounting details now have quantity:1 4) Set the mandatory "Fund" input in accounting details. 5) At the bottom, fill in all additional fields, click the '+New' and 'Clear' links, hit 'Save' 6) In the orders table shown, click "Modify". Notice all the fields are presented correctly in the edit form. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164169|0 |1 is obsolete| | --- Comment #76 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 168544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168544&action=edit Bug 35044: Update: Serial subscriptions Test plan, k-t-d: Preparation: Create additional fields for table 'subscription', visit: /cgi-bin/koha/admin/additional-fields.pl?tablename=subscription 2 text fields, one repeatable, one not-repeatable 2 AV fields, one repeatable, one not-repeatable 2 MARC fields, one 'get' and one 'set', both non-repeatable, MARC field 942$c Attempt to create a repeatable MARC field (get or set). Notice you're unable to. 1) Add a new serial subscription, visit: /cgi-bin/koha/serials/subscription-add.pl 2) Set the mandatory "Record" input (e.g. '112'). Click the 'Next' and press 'Ok' on the alert box. 3) Fill in all required fields and press "Test prediction pattern" 4) At the bottom, fill in all additional fields, click the '+New' and 'Clear' links, hit 'Save' 5) Notice the fields are shown, repeated fields are comma separated 6) Click Edit -> Edit Subscription, repeat steps 4 and 5 7) Go back to subscription additional fields, set all fields as searchable 8) Visit serials-home: /cgi-bin/koha/serials/serials-home.pl 9) Click 'Search' 10) Notice the searchable fields now show in their columns, repeated fields separated by comma 11) Perform a search using a repeatable field, verify it all works as expected. -- Subscription Claims -- Preparation: 1) Define a new claim notice, visit: /cgi-bin/koha/tools/letter.pl?op=add_form&module=claimissues 2) Input code, name, click "Email" set a "Message subject" and put something in the message body. Hit 'Save'. 3) Set a serial as late, visit our original subscription: /cgi-bin/koha/serials/serials-collection.pl?subscriptionid=1 4) Click "Edit serials" and status -> "Late". Hit "Save". 5) Link the original subscription to the existing vendor, visit: /cgi-bin/koha/serials/subscription-add.pl?op=modify&subscriptionid=1 6) Click "Search for a vendor". Hit "Ok". Hit "Choose". Save the subscription. Claims: 7) Visit claims: /cgi-bin/koha/serials/claims.pl 8) Click "Ok" 9) Verify that searchable additional fields all have their respective column. Repeated fields are shown comma separated. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164171|0 |1 is obsolete| | --- Comment #78 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 168546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168546&action=edit Bug 35044: Update: Manual invoices, manual credits and accountlines Test plan, k-t-d: Preparation: Create additional fields for table 'accountlines:credit', visit: /cgi-bin/koha/admin/additional-fields.pl?tablename=accountlines%3Acredit 2 text fields, one repeatable, one not-repeatable 2 AV fields, one repeatable, one not-repeatable 1) Add a new manual credit for admin borrower: /cgi-bin/koha/members/mancredit.pl?borrowernumber=51 2) Set the mandatory "Amount" input (e.g. '5'). Click the 'Next' and press 'Ok' on the alert box. 3) Fill in all additional fields, click the '+New' and 'Clear' links, hit 'Save' 4) On the table, click "Details" for the for account line we just created. 5) Notice the additional fields are there, repeated fields are comma separated. 6) Repeat the above test plan, but for accountlines:debit instead, visit: /cgi-bin/koha/admin/additional-fields.pl?tablename=accountlines%3Adebit 7) To add a manual invoice, visit: /cgi-bin/koha/members/maninvoice.pl?borrowernumber=51 Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164173|0 |1 is obsolete| | --- Comment #80 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 168548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168548&action=edit Bug 35044: Add tests Test plan: prove t/db_dependent/Koha/Object/Mixin/AdditionalFields.t Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL|https://github.com/PTFS-Eur | |ope/koha/tree/b_35044 | -- You are receiving this mail because: You are watching all bug changes.

Is it feasible to change that term without too much work ? Just in case: it can be done by using format-patch then applying some regexps on the .patch files and re-applying the patches. I can attach the modified

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 --- Comment #83 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to Julian Maurice from comment #82) patches if needed -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 --- Comment #85 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 169546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169546&action=edit Bug 35044: (QA follow-up): Allow for value '0' in additional fields This now allows for value '0' for an additional field (repeatable or not). This still does not allow for an empty '' field in additional fields. This is consistent with borrower patron attributes, i.e. if you submit an empty borrower patron attribute entry, it does not store it as empty. Additionally, if you have a value in a borrower patron attribute but then submit the form with that field as empty, it gets deleted from the database. I agree not being able to save the value '0' is a blocker, but not the empty. For consistency sake I'm keeping this as is, I don't see a use-case where a row with an empty field value is preferred over it not existing. If we allow for '' values of additional fields, the 'clear' button for repeatable fields would have to remove the input instead of clearing the value (or else how would the user remove repeatable fields entries?). If this is done, it's inconsistent with the repeatable fields from patron attribute types, as in that instance the 'clear' button only removes the input contents, not the input element itself. prove t/db_dependent/Koha/Object/Mixin/AdditionalFields.t -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 --- Comment #87 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Julian Maurice from comment #82)

1) In the patches:

...

#FIXME: The above $subscription->{additional_fields} may be redundant. Remove if so. Can it be checked/fixed now ?

2) With the patches it is no longer possible to save a "falsy" value like '' or '0'. That's a regression and it would be nice to add a test for that.

3) I was a bit surprised when I realized that repeatable AV fields are not actually repeatable. There is no "+ New" button like with other repeatable fields. It makes sense in this case to have a list of checkboxes instead of a repeatable dropdown list, but I didn't expect that. So maybe the issue is with the term "repeatable". I think that "multivalued" would fit better. Is it feasible to change that term without too much work ? Can anyone else from QA team or release team give their opinion on this ?

Failing QA for 1 and 2

Thank you very much for your time here, Julian. I believe my 3 latest QA follow-up patches address 1) and 2). Please let me know if you disagree. As for 3) I agree with you, but don't feel strongly either way. I adopted the 'repeatable' naming to be consistent with patron attribute types, even though the 'repeatable' in patron attribute types only works for text fields, not AV fields, with that not being clear from the UI. My long term goal for additional fields + borrower patron attributes is to eventually merge these 2 features (they're essentially the same thing, written twice). But I'm happy to follow-up with the renaming if required. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #89 from Julian Maurice <julian.maurice@biblibre.com> --- About the '' value, I agree that it doesn't make much sense to keep them. But it's a change in behavior, and maybe someone out there uses these empty values in some way. If we decide to not keep the empty value we should at least advertise it in the release notes (and in the commit messages, but you already did that) And I think that the updatedatabase should remove these empty values Other things to fix: 1) add_additional_fields does not allow '0' as a value, so it's not possible to add this value in subscriptions batch edit (the only place where add_additional_fields is used) 2) There is a piece of code that does nothing in koha-tmpl/intranet-tmpl/prog/en/modules/admin/additional-fields.tt: $("#repeatable").prop('checked') == true It's not an "if" condition and it appears on the same line as the end of a block so I assume this must be a copy/paste mistake 3) In koha-tmpl/intranet-tmpl/prog/js/additional-fields-entry.js functions clone_entry and clear_entry are added to the global scope. To avoid that you should wrap the whole script inside a block like this: (function () { // code goes here })(); 4) QA script failure: FAIL installer/data/mysql/kohastructure.sql FAIL tinyint_has_boolean_flag The new column additional_fields.repeatable is using TINYINT(1) as type but is not defined as boolean in the schema file (Koha/Schema/Result/AdditionalField.pm), see the SQL12 coding guideline -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 --- Comment #90 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 169603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169603&action=edit Bug 35044: (QA follow-up): Allow for '0' in serials batch edit This commit also ensures any existing '0' value additional fields are kept if batch editing and submitting the input empty -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 --- Comment #92 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 169605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169605&action=edit Bug 35044: (QA follow-up): Avoid polluting the global scope with function using immediately invoked function expression -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 --- Comment #94 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 169607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169607&action=edit Bug 35044: (QA follow-up): Add removal of empty value entries in additional_field_values to atomicupdate To test: 1) Follow any of the above test plans to add some additional_field_values entries 2) Run the following SQL: update additional_field_values set value = ''; 3) Run updatedatabase twice. Notice the first time it tells you how many entries were removed. The 2nd time it does nothing. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168538|0 |1 is obsolete| | --- Comment #96 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 169644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169644&action=edit Bug 35044: DB changes + atomicupdate file Add the 'repeatable' column to additional_fields Remove the unique key from additional_field_values as we will now be allowing for repeated instances of the same field_id + record_id Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> https://bugs.koha-community.org/show_bug.cgi?id=25044 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168540|0 |1 is obsolete| | --- Comment #98 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 169646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169646&action=edit Bug 35044: Preparation: get_additional_field_values_for_template method New method to be utilized for retrieval of additional fields of any class that implements it. This is to be used when additional_fields are needed to be sent to .tt files for renderering. Both for form entries and read-only 'show' pages. Template files: Updated additional-fields-entry.inc: Now considers entry of repeatable fields. Repeatable text fields will have a "+New" link to allow for adding of a new instance of a repeatable field. Repeatable AV fields will be shown as checkboxes instead of a dropdown Update additional-fields-display.inc When displaying non-editable additional-fields, multiple instances for each field are now considered. Label now only shows if field has a non-null value in it. Option to show value_only Option to set if its to be displayed on a table cell Update histsearch.tt and filter-orders.inc Now calls additional-fields-entry.inc with search_form=1 to prevent repetable "+New" controls from showing on search inputs. additional-fields-entry.js New JS asset to be called by template files who require additional-fields-entry.inc for repeatable fields controls. This also handles the need for having the marcfield of type 'get' submitted if it is a disabled dropdown (AV marc field) Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> https://bugs.koha-community.org/show_bug.cgi?id=25044 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168542|0 |1 is obsolete| | --- Comment #100 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 169648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169648&action=edit Bug 35044: Update: Acquisition orders Test plan, k-t-d: Preparation: Create additional fields for table 'aqorders': 2 text fields, one repeatable, one not-repeatable 2 AV fields, one repeatable, one not-repeatable 2 MARC fields, one 'get' and one 'set', both non-repeatable, MARC field 942$c Attempt to create a repeatable MARC field (get or set). Notice you're unable to. 1) Add a new order for an existing basket, with an existing record, visit: /cgi-bin/koha/acqui/neworderempty.pl?booksellerid=1&basketno=1&biblionumber=76 2) Set the mandatory "Koha item type" for the item. Click the 'Add item' button below. 3) Notice the accounting details now have quantity:1 4) Set the mandatory "Fund" input in accounting details. 5) At the bottom, fill in all additional fields, click the '+New' and 'Clear' links, hit 'Save' 6) In the orders table shown, click "Modify". Notice all the fields are presented correctly in the edit form. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> https://bugs.koha-community.org/show_bug.cgi?id=25044 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168544|0 |1 is obsolete| | --- Comment #102 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 169650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169650&action=edit Bug 35044: Update: Serial subscriptions Test plan, k-t-d: Preparation: Create additional fields for table 'subscription', visit: /cgi-bin/koha/admin/additional-fields.pl?tablename=subscription 2 text fields, one repeatable, one not-repeatable 2 AV fields, one repeatable, one not-repeatable 2 MARC fields, one 'get' and one 'set', both non-repeatable, MARC field 942$c Attempt to create a repeatable MARC field (get or set). Notice you're unable to. 1) Add a new serial subscription, visit: /cgi-bin/koha/serials/subscription-add.pl 2) Set the mandatory "Record" input (e.g. '112'). Click the 'Next' and press 'Ok' on the alert box. 3) Fill in all required fields and press "Test prediction pattern" 4) At the bottom, fill in all additional fields, click the '+New' and 'Clear' links, hit 'Save' 5) Notice the fields are shown, repeated fields are comma separated 6) Click Edit -> Edit Subscription, repeat steps 4 and 5 7) Go back to subscription additional fields, set all fields as searchable 8) Visit serials-home: /cgi-bin/koha/serials/serials-home.pl 9) Click 'Search' 10) Notice the searchable fields now show in their columns, repeated fields separated by comma 11) Perform a search using a repeatable field, verify it all works as expected. -- Subscription Claims -- Preparation: 1) Define a new claim notice, visit: /cgi-bin/koha/tools/letter.pl?op=add_form&module=claimissues 2) Input code, name, click "Email" set a "Message subject" and put something in the message body. Hit 'Save'. 3) Set a serial as late, visit our original subscription: /cgi-bin/koha/serials/serials-collection.pl?subscriptionid=1 4) Click "Edit serials" and status -> "Late". Hit "Save". 5) Link the original subscription to the existing vendor, visit: /cgi-bin/koha/serials/subscription-add.pl?op=modify&subscriptionid=1 6) Click "Search for a vendor". Hit "Ok". Hit "Choose". Save the subscription. Claims: 7) Visit claims: /cgi-bin/koha/serials/claims.pl 8) Click "Ok" 9) Verify that searchable additional fields all have their respective column. Repeated fields are shown comma separated. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> https://bugs.koha-community.org/show_bug.cgi?id=25044 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168546|0 |1 is obsolete| | --- Comment #104 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 169652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169652&action=edit Bug 35044: Update: Manual invoices, manual credits and accountlines Test plan, k-t-d: Preparation: Create additional fields for table 'accountlines:credit', visit: /cgi-bin/koha/admin/additional-fields.pl?tablename=accountlines%3Acredit 2 text fields, one repeatable, one not-repeatable 2 AV fields, one repeatable, one not-repeatable 1) Add a new manual credit for admin borrower: /cgi-bin/koha/members/mancredit.pl?borrowernumber=51 2) Set the mandatory "Amount" input (e.g. '5'). Click the 'Next' and press 'Ok' on the alert box. 3) Fill in all additional fields, click the '+New' and 'Clear' links, hit 'Save' 4) On the table, click "Details" for the for account line we just created. 5) Notice the additional fields are there, repeated fields are comma separated. 6) Repeat the above test plan, but for accountlines:debit instead, visit: /cgi-bin/koha/admin/additional-fields.pl?tablename=accountlines%3Adebit 7) To add a manual invoice, visit: /cgi-bin/koha/members/maninvoice.pl?borrowernumber=51 Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> https://bugs.koha-community.org/show_bug.cgi?id=25044 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168548|0 |1 is obsolete| | --- Comment #106 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 169654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169654&action=edit Bug 35044: Add tests Test plan: prove t/db_dependent/Koha/Object/Mixin/AdditionalFields.t Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> https://bugs.koha-community.org/show_bug.cgi?id=25044 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169546|0 |1 is obsolete| | --- Comment #108 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 169656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169656&action=edit Bug 35044: (QA follow-up): Allow for value '0' in additional fields This now allows for value '0' for an additional field (repeatable or not). This still does not allow for an empty '' field in additional fields. This is consistent with borrower patron attributes, i.e. if you submit an empty borrower patron attribute entry, it does not store it as empty. Additionally, if you have a value in a borrower patron attribute but then submit the form with that field as empty, it gets deleted from the database. I agree not being able to save the value '0' is a blocker, but not the empty. For consistency sake I'm keeping this as is, I don't see a use-case where a row with an empty field value is preferred over it not existing. If we allow for '' values of additional fields, the 'clear' button for repeatable fields would have to remove the input instead of clearing the value (or else how would the user remove repeatable fields entries?). If this is done, it's inconsistent with the repeatable fields from patron attribute types, as in that instance the 'clear' button only removes the input contents, not the input element itself. prove t/db_dependent/Koha/Object/Mixin/AdditionalFields.t Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> https://bugs.koha-community.org/show_bug.cgi?id=25044 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169603|0 |1 is obsolete| | --- Comment #110 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 169658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169658&action=edit Bug 35044: (QA follow-up): Allow for '0' in serials batch edit This commit also ensures any existing '0' value additional fields are kept if batch editing and submitting the input empty Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> https://bugs.koha-community.org/show_bug.cgi?id=25044 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 --- Comment #112 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 169660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169660&action=edit Bug 35044: (QA follow-up): Avoid polluting global scope with functions using immediately invoked function expression Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> https://bugs.koha-community.org/show_bug.cgi?id=25044 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 --- Comment #114 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 169662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169662&action=edit Bug 35044: (QA follow-up): Remove empty additional_field_values entries To test: 1) Follow any of the above test plans to add some additional_field_values entries 2) Run the following SQL: update additional_field_values set value = ''; 3) Run updatedatabase twice. Notice the first time it tells you how many entries were removed. The 2nd time it does nothing. Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> https://bugs.koha-community.org/show_bug.cgi?id=25044 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169605|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169643|0 |1 is obsolete| | --- Comment #116 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 169664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169664&action=edit Bug 35044: [DONT PUSH] dbic specific Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169645|0 |1 is obsolete| | --- Comment #118 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 169666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169666&action=edit Bug 35044: Admin: New additional fields 'repeatable' field There is now a new 'repeatable' checkbox when configuring (adding or editing) an additional field for a specific table. It is also displayed in a column in the additional fields panel for a given tablename. MARC fields are not allowed to be repeatable. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169647|0 |1 is obsolete| | --- Comment #120 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 169668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169668&action=edit Bug 35044: Update: Order baskets Test plan, k-t-d: Preparation: Create additional fields for table 'aqbasket': 2 text fields, one repeatable, one not-repeatable 2 AV fields, one repeatable, one not-repeatable 1) Add a new basket, visit: /cgi-bin/koha/acqui/basketheader.pl?booksellerid=1&op=add_form 2) Fill in name and all additional fields, click the '+New' and 'Clear' links, hit 'Save' 3) Notice the basket screen shows repeated fields separated by comma. 4) Notice that only non-null additional fields labels are shown. 5) Edit the basket. Notice all fields are shown as expected. Additional testing: Having a repeatable field with multiple instances, go back to the additional fields configuration and make the additional field non-repeatable again. Edit the basket again. Notice the multiple text instances are still shown, but the '+New' link no longer shows. You're able to remove existing multiple instances, but unable to add new ones, this is because the field is no longer repeatable. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169649|0 |1 is obsolete| | --- Comment #122 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 169670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169670&action=edit Bug 35044: Update: Invoices Added fixme comment to invoices.tt, the search works so nothing to do here, but the code is not DRY Test plan, k-t-d: Preparation: Create additional fields for table 'aqinvoices': 2 text fields, one repeatable, one not-repeatable 2 AV fields, one repeatable, one not-repeatable 1) Add a new invoice for an existing vendor, visit: /cgi-bin/koha/acqui/parcels.pl?booksellerid=1 2) Input something in the mandatory "Vendor invoice" field. 3) Fill in all additional fields, click the '+New' and 'Clear' links, hit 'Save' 4) Search for invoices, visit: http://localhost:8081/cgi-bin/koha/acqui/invoices.pl 5) Click "Search" on the left column of the page 6) Click the invoice we just created. Verify all the fields show correctly. 7) Go back to the additional fields configuration, set all additional fields as "searchable" 8) Return to http://localhost:8081/cgi-bin/koha/acqui/invoices.pl 9) Perform some searches using the additional fields values. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169651|0 |1 is obsolete| | --- Comment #124 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 169672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169672&action=edit Bug 35044: Update: Serial subscriptions batch edit Test plan, k-t-d: Preparation: Create additional fields for table 'subscription', visit: /cgi-bin/koha/admin/additional-fields.pl?tablename=subscription 2 text fields, one repeatable, one not-repeatable 2 AV fields, one repeatable, one not-repeatable 2 MARC fields, one 'get' and one 'set', both non-repeatable, MARC field 942$c Attempt to create a repeatable MARC field (get or set). Notice you're unable to. 1) Add a new serial subscription, visit: /cgi-bin/koha/serials/subscription-add.pl 2) Set the mandatory "Record" input (e.g. '112'). Click the 'Next' and press 'Ok' on the alert box. 3) Fill in all required fields and press "Test prediction pattern" 4) At the bottom, fill in all additional fields, click the '+New' and 'Clear' links, hit 'Save' 5) Notice the fields are shown, repeated fields are comma separated 6) Repeat steps 1-4 to create a second subscription 7) Visit serials home and hit "Search": /cgi-bin/koha/serials/serials-home.pl 8) Check the checkboxes next to the 2 subscriptions and click "Edit selected serials" 9) Input some values in the additional fields section, click the '+New' and 'Clear' links, hit 'Save' 10) Verify that both subscriptions now have the new values form the batch edit. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169653|0 |1 is obsolete| | --- Comment #126 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 169674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169674&action=edit Bug 35044: Add repetable to REST API spec Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169655|0 |1 is obsolete| | --- Comment #128 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 169676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169676&action=edit Bug 35044: (QA follow-up): DRY code before set_additional_fields Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169657|0 |1 is obsolete| | --- Comment #130 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 169678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169678&action=edit Bug 35044: (QA follow-up): Remove FIXME and redundant code prove t/db_dependent/Koha/Acquisition/Booksellers.t prove t/db_dependent/Serials.t Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169659|0 |1 is obsolete| | --- Comment #132 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 169680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169680&action=edit Bug 35044: (QA follow-up): Remove useless code Most definitely a copy paste error. I've tested and retested this particular JS piece of code, works as intended before and after removing this badly copy pasted code. I'm surprised this wasn't causing a console error. Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169661|0 |1 is obsolete| | --- Comment #134 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 169682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169682&action=edit Bug 35044: (QA follow-up): Fix QA script Error on boolean TINYINT Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169663|0 |1 is obsolete| | --- Comment #136 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 169684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169684&action=edit Bug 35044: (QA follow-up) Delete empty values with a single query Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 --- Comment #138 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 169697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169697&action=edit Bug 35044: (QA follow-up): Fix flaky tests To test, run the following test file a couple times until it fails: prove t/db_dependent/Koha/Object/Mixin/AdditionalFields.t My testing this failed around 50% of the time so it should not take long to reproduce. I believe this is because the order of the array elements may differ. Apply this patch and run the test file again many times. It should never fail. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 --- Comment #140 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 170501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170501&action=edit Bug 35044: (QA follow-up): Add color to atomic update -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 --- Comment #142 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Pedro Amorim from comment #141)

(In reply to Katrin Fischer from comment #139)

...

Applied all patches, removed the "DO NOT PUSH" patch. Did you run dbic? You need the patch or run dbic since those are the schema files. IF that's not it, where/when does the error show up?

I wanted to run dbic after updating the database - otherwise it can't show me the new field. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 --- Comment #144 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- You need to also not apply the patch: Bug 35044: (QA follow-up): Fix QA script Error on boolean TINYINT Because that is fixing the TINYIT boolean database thing for 'repeatable', but if you don't run dbic or apply the schema patch, then the 'repeatable' field does not exist on the schema class. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 --- Comment #146 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Please let me know if something else is a blocker here. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Sandbox |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | CC| |pedro.amorim@ptfs-europe.co | |m Text to go in the| |This enhancement provides release notes| |the "repeatable" option for | |additional fields. For | |repeatable text fields, a | |"Add new" button is added | |to allow for adding a new | |instance of the text field, | |additionally, a "Remove" | |button is also shown to | |allow for removal of a | |repeatable text field | |instance. For repeatable AV | |fields, the UI will present | |the options in checkboxes | |instead of a dropdown, | |enabling multiple | |selections. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 Bug 35044 depends on bug 37262, which changed state. Bug 37262 Summary: api/v1/extended_attribute_types does not filter additional fields for unmapped tablenames https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37262 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 --- Comment #150 from Jonathan Druart <jonathan.druart@gmail.com> --- There is a logic error in additional-fields-entry.inc  15 [% IF field.marcfield && field.marcfield_mode == 'get' %] 16 <select name="additional_field_[% field.id | html %]" id="additional_field_[% field.id | html %]" class="marcfieldget" disabled> 17 [% ELSE %] 18 [% IF !field.repeatable %] 19 <select name="additional_field_[% field.id | html %]" id="additional_field_[% field.id | html %]"> 20 [% END %] 21 [% END %] Then later we unconditionally close 79 </select> Can you have a look please? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 --- Comment #151 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Jonathan Druart from comment #150)

There is a logic error in additional-fields-entry.inc 

15 [% IF field.marcfield && field.marcfield_mode == 'get' %] 16 <select name="additional_field_[% field.id | html %]" id="additional_field_[% field.id | html %]" class="marcfieldget" disabled> 17 [% ELSE %] 18 [% IF !field.repeatable %] 19 <select name="additional_field_[% field.id | html %]" id="additional_field_[% field.id | html %]"> 20 [% END %] 21 [% END %]

Then later we unconditionally close 79 </select>

Can you have a look please?

Opened bug 38738 -- You are receiving this mail because: You are watching all bug changes.