https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37576 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35287 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37576 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart@gmail.com |jake.deery@ptfs-europe.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37576 Andrew Auld <andrew.auld@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|Seeking developer |Sponsored CC| |andrew.auld@ptfs-europe.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37576 --- Comment #1 from Jake Deery <jake.deery@ptfs-europe.com> --- Created attachment 171181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171181&action=edit Bug 37576: Add additional fields for ERM agreements This bug adds support for additional fields in the ERM module's agreements, similar to how Bug 35287 added support for additional fields in the ERM module's licences. To test (k.t.d): a) APPLY PATCH b) Run cypress --spec t/cypress/integration/AdditionalFields_spec.ts 1) Note how the tests pass c) Add new additional fields for 'erm_agreements' 1) Go to /cgi-bin/koha/admin/additional-fields.pl?tablename=erm_agreements 2) Create field one called 'text non-repeatable' 3) Create field two called 'text repeatable', check 'repeatable' 4) Create field three called 'av non-repeatable', pick LANG authorised value 5) Create field four called 'av repeatable', pick LOC authorised value, check repeatable d) Create new agreement 1) Go to /cgi-bin/koha/erm/agreements/add, notice the new additional fields section 2) Complete all mandatory fields for a new licence 3) Experiment with the four different additional field types – it may be useful to watch the Cypress-generated test video for guidance 4) Select some AV options from the AV fields, deselect them, notice the repeatable one allows for multiple selection, the non-repeatable one does not e) Save the agreement, then view it 1) To view the licence, click its name in the table list on /cgi-bin/koha/erm/agreements 2) notice the additional fields on display 3) also notice that the authorised values are in their human-readable form, and not their coded form f) Edit the agreement, then view it again 1) Go to /cgi-bin/koha/erm/agreements/edit/1 2) Play around again with the fields. Save. 3) Repeat step e, have the edits shown up? g) Test searchability 1) Go to /cgi-bin/koha/admin/additional-fields.pl?tablename=erm_agreements 2) Edit one of the fields and make sure searchable is checked (ensure you choose a field that has some data in it) 3) Go to /cgi-bin/koha/erm/agreements 4) Notice that the searchable field(s) are now columns in the table 5) Notice that searchable AV fields contain a drop-down 6) Notice that searchable text fields have an input field 7) Perform a search on the additional field 8) Notice that the searching is working as expected h) SIGN OFF -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37576 Jake Deery <jake.deery@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37577 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37577 [Bug 37577] Add additional fields support to ERM Packages -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37576 Jake Deery <jake.deery@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171181|0 |1 is obsolete| | --- Comment #3 from Jake Deery <jake.deery@ptfs-europe.com> --- Created attachment 171268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171268&action=edit Bug 37576: Add additional fields for ERM agreements This bug adds support for additional fields in the ERM module's agreements, similar to how Bug 35287 added support for additional fields in the ERM module's licences. To test (k.t.d): a) APPLY PATCH b) Run cypress --spec t/cypress/integration/AdditionalFields_spec.ts 1) Note how the tests pass c) Add new additional fields for 'erm_agreements' 1) Go to /cgi-bin/koha/admin/additional-fields.pl?tablename=erm_agreements 2) Create field one called 'text non-repeatable' 3) Create field two called 'text repeatable', check 'repeatable' 4) Create field three called 'av non-repeatable', pick LANG authorised value 5) Create field four called 'av repeatable', pick LOC authorised value, check repeatable d) Create new agreement 1) Go to /cgi-bin/koha/erm/agreements/add, notice the new additional fields section 2) Complete all mandatory fields for a new licence 3) Experiment with the four different additional field types – it may be useful to watch the Cypress-generated test video for guidance 4) Select some AV options from the AV fields, deselect them, notice the repeatable one allows for multiple selection, the non-repeatable one does not e) Save the agreement, then view it 1) To view the licence, click its name in the table list on /cgi-bin/koha/erm/agreements 2) notice the additional fields on display 3) also notice that the authorised values are in their human-readable form, and not their coded form f) Edit the agreement, then view it again 1) Go to /cgi-bin/koha/erm/agreements/edit/1 2) Play around again with the fields. Save. 3) Repeat step e, have the edits shown up? g) Test searchability 1) Go to /cgi-bin/koha/admin/additional-fields.pl?tablename=erm_agreements 2) Edit one of the fields and make sure searchable is checked (ensure you choose a field that has some data in it) 3) Go to /cgi-bin/koha/erm/agreements 4) Notice that the searchable field(s) are now columns in the table 5) Notice that searchable AV fields contain a drop-down 6) Notice that searchable text fields have an input field 7) Perform a search on the additional field 8) Notice that the searching is working as expected h) SIGN OFF -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37576 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171268|0 |1 is obsolete| | --- Comment #5 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 171379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171379&action=edit Bug 37576: Add additional fields for ERM agreements This bug adds support for additional fields in the ERM module's agreements, similar to how Bug 35287 added support for additional fields in the ERM module's licences. To test (k.t.d): a) APPLY PATCH b) Run cypress --spec t/cypress/integration/AdditionalFields_spec.ts 1) Note how the tests pass c) Add new additional fields for 'erm_agreements' 1) Go to /cgi-bin/koha/admin/additional-fields.pl?tablename=erm_agreements 2) Create field one called 'text non-repeatable' 3) Create field two called 'text repeatable', check 'repeatable' 4) Create field three called 'av non-repeatable', pick LANG authorised value 5) Create field four called 'av repeatable', pick LOC authorised value, check repeatable d) Create new agreement 1) Go to /cgi-bin/koha/erm/agreements/add, notice the new additional fields section 2) Complete all mandatory fields for a new licence 3) Experiment with the four different additional field types – it may be useful to watch the Cypress-generated test video for guidance 4) Select some AV options from the AV fields, deselect them, notice the repeatable one allows for multiple selection, the non-repeatable one does not e) Save the agreement, then view it 1) To view the licence, click its name in the table list on /cgi-bin/koha/erm/agreements 2) notice the additional fields on display 3) also notice that the authorised values are in their human-readable form, and not their coded form f) Edit the agreement, then view it again 1) Go to /cgi-bin/koha/erm/agreements/edit/1 2) Play around again with the fields. Save. 3) Repeat step e, have the edits shown up? g) Test searchability 1) Go to /cgi-bin/koha/admin/additional-fields.pl?tablename=erm_agreements 2) Edit one of the fields and make sure searchable is checked (ensure you choose a field that has some data in it) 3) Go to /cgi-bin/koha/erm/agreements 4) Notice that the searchable field(s) are now columns in the table 5) Notice that searchable AV fields contain a drop-down 6) Notice that searchable text fields have an input field 7) Perform a search on the additional field 8) Notice that the searching is working as expected h) SIGN OFF Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37576 --- Comment #7 from Jake Deery <jake.deery@ptfs-europe.com> --- Created attachment 171397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171397&action=edit Bug 37576: (follow-up) fix missed cypress change This patch fixes a single line in our cypress tests which didn't cause the test to fail, but nonetheless should be addressed. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37576 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37576 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171379|0 |1 is obsolete| | Attachment #171397|0 |1 is obsolete| | --- Comment #9 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 173774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173774&action=edit Bug 37576: Add additional fields for ERM agreements This bug adds support for additional fields in the ERM module's agreements, similar to how Bug 35287 added support for additional fields in the ERM module's licences. To test (k.t.d): a) APPLY PATCH b) Run cypress --spec t/cypress/integration/AdditionalFields_spec.ts 1) Note how the tests pass c) Add new additional fields for 'erm_agreements' 1) Go to /cgi-bin/koha/admin/additional-fields.pl?tablename=erm_agreements 2) Create field one called 'text non-repeatable' 3) Create field two called 'text repeatable', check 'repeatable' 4) Create field three called 'av non-repeatable', pick LANG authorised value 5) Create field four called 'av repeatable', pick LOC authorised value, check repeatable d) Create new agreement 1) Go to /cgi-bin/koha/erm/agreements/add, notice the new additional fields section 2) Complete all mandatory fields for a new licence 3) Experiment with the four different additional field types – it may be useful to watch the Cypress-generated test video for guidance 4) Select some AV options from the AV fields, deselect them, notice the repeatable one allows for multiple selection, the non-repeatable one does not e) Save the agreement, then view it 1) To view the licence, click its name in the table list on /cgi-bin/koha/erm/agreements 2) notice the additional fields on display 3) also notice that the authorised values are in their human-readable form, and not their coded form f) Edit the agreement, then view it again 1) Go to /cgi-bin/koha/erm/agreements/edit/1 2) Play around again with the fields. Save. 3) Repeat step e, have the edits shown up? g) Test searchability 1) Go to /cgi-bin/koha/admin/additional-fields.pl?tablename=erm_agreements 2) Edit one of the fields and make sure searchable is checked (ensure you choose a field that has some data in it) 3) Go to /cgi-bin/koha/erm/agreements 4) Notice that the searchable field(s) are now columns in the table 5) Notice that searchable AV fields contain a drop-down 6) Notice that searchable text fields have an input field 7) Perform a search on the additional field 8) Notice that the searching is working as expected h) SIGN OFF Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37576 --- Comment #11 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 173776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173776&action=edit Bug 37576: (QA follow-up) Tidy Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37576 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add additional fields |Add additional fields |support to ERM Agreements |support to ERM agreements -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37576 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37576 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It looks like we have failing Cypress tests, that probably didn't show up before while we fixed other tests. Can you please have provide a follow-up? Show agreement.Agreement CRUD operations Show agreement 0 ms 1 Delete agreement.Agreement CRUD operations Delete agreement 0 ms 1 Show package.Package CRUD operations Show package 0 ms 1 Delete package.Package CRUD operations Delete package 0 ms 1 Add agreement.Add/search user Add agreement -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37576 --- Comment #15 from Jake Deery <jake.deery@ptfs-europe.com> --- Just looking at packages. That also appears to be broken. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37576 --- Comment #17 from Jake Deery <jake.deery@ptfs-europe.com> --- Rebased and expanded follow-up to also fix packages. That appears to be all Cypress tests passing now :-) Jake. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37576 --- Comment #19 from Jake Deery <jake.deery@ptfs-europe.com> --- Created attachment 174532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174532&action=edit Bug 37576: (follow-up) Fix for UserRoles test This patch, although not directly caused by Bug 37576, fixes issues with the UserRoles cypress test due to a change in the data structure brought on by recent ERM bugs. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37576 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | Text to go in the| |This adds the option to add release notes| |additional fields to ERM | |agreements. The fields can | |be either free text or | |linked to an authorized | |value for a pull down list. | |They be set to repeatable | |and made searchable. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37576 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |Caroline Cyr La Rose contact| | CC| |caroline.cyr-la-rose@inlibr | |o.com Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/1097 Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.