[Bug 29887] New: Create system preference IndependentBranchesLoggedInLibrary
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29887 Bug ID: 29887 Summary: Create system preference IndependentBranchesLoggedInLibrary Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Currently if IndependentBranches is turned on it makes it so staff cannot switch branches or 'Set library' unless they are a superlibrarian. Some libraries like this aspect of IndependentBranches but don't want everything else that comes with turning on IndependentBranches. A new system pref 'IndependentBranchesLoggedInLibrary' would allow libraries to utilize this aspect of IndependentBranches without having to turn on everything else that comes with that system preference. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29887 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29887 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29887 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 129517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129517&action=edit Bug 29887: Add system preference IndependentBranchesLoggedInLibrary To test: 1. Have a user who has staff access and circulate privileges but is not a super librarian 2. Apply the patches and run updatedatabase.pl 3. From a superlibrarian account enable IndependentBranches and IndependentBranchesLoggedInLibrary set to Yes. 4. Also turn on the system preference 'CircSidebar' 5. Prepare to login as the non-superlibrarian user. Before logging on notice on auth.tt there is no dropdown allowing you to choose a branch. 6. Log in as the non-superlibrarian. 7. In the top left hand corner notice you are logged in under that users homebranch. 8. Click the dropdown, there is no link for 'Set library'. 9. Go to circulation-home.pl, there is no link for 'Set library' under the heading 'Circulation' 10. With 'CircSidebar' turned on look at the left navigation bar on some of the circulation pages ( Holds queue, Holds to pull, Holds awaiting pickup ). There should be no 'Set library' link on any of these pages. 11. Direct your browser to /cgi-bin/koha/circ/set-library.pl and notice there is no option to change your logged in branch 12. From a superlibrarian account, Turn off IndependentBranches but leave IndependentBranchesLoggedInLibrary set to Yes. 13. Repeat steps 5-11. Nothing should change, the non-superlibrarian should still see no 'Set library' links. 14. From a superlibrarian account, Turn on IndependentBranches and IndependentBranchesLoggedInLibrary set to No 15. Going through steps 5-11 again the non-superlibrarian should see all of the 'Set library' links and be able to successfully switch branches -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29887 --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 129518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129518&action=edit Bug 29887: database update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29887 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29887 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29887 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com Status|Needs Signoff |Failed QA --- Comment #3 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- In step 15, my non-superlibrarian user can access the Set Library feature, but is presented with a dropdown that only offers their current library. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29887 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29887 --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 130452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130452&action=edit Bug 29887: (follow-up) show all branches to non superlibraians -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29887 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29887 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129517|0 |1 is obsolete| | --- Comment #5 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 130674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130674&action=edit Bug 29887: Add system preference IndependentBranchesLoggedInLibrary To test: 1. Have a user who has staff access and circulate privileges but is not a super librarian 2. Apply the patches and run updatedatabase.pl 3. From a superlibrarian account enable IndependentBranches and IndependentBranchesLoggedInLibrary set to Yes. 4. Also turn on the system preference 'CircSidebar' 5. Prepare to login as the non-superlibrarian user. Before logging on notice on auth.tt there is no dropdown allowing you to choose a branch. 6. Log in as the non-superlibrarian. 7. In the top left hand corner notice you are logged in under that users homebranch. 8. Click the dropdown, there is no link for 'Set library'. 9. Go to circulation-home.pl, there is no link for 'Set library' under the heading 'Circulation' 10. With 'CircSidebar' turned on look at the left navigation bar on some of the circulation pages ( Holds queue, Holds to pull, Holds awaiting pickup ). There should be no 'Set library' link on any of these pages. 11. Direct your browser to /cgi-bin/koha/circ/set-library.pl and notice there is no option to change your logged in branch 12. From a superlibrarian account, Turn off IndependentBranches but leave IndependentBranchesLoggedInLibrary set to Yes. 13. Repeat steps 5-11. Nothing should change, the non-superlibrarian should still see no 'Set library' links. 14. From a superlibrarian account, Turn on IndependentBranches and IndependentBranchesLoggedInLibrary set to No 15. Going through steps 5-11 again the non-superlibrarian should see all of the 'Set library' links and be able to successfully switch branches Signed-off-by: Bob Bennhoff <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29887 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129518|0 |1 is obsolete| | --- Comment #6 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 130675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130675&action=edit Bug 29887: database update Signed-off-by: Bob Bennhoff <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29887 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130452|0 |1 is obsolete| | --- Comment #7 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 130676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130676&action=edit Bug 29887: (follow-up) show all branches to non superlibraians Signed-off-by: Bob Bennhoff <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29887 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com, | |katrin.fischer@bsz-bw.de, | |nick@bywatersolutions.com, | |oleonard@myacpl.org --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Isn't the syspref's name misleading? Shouldn't it be more something like "prevent staff to change their logged in library"? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29887 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think the confusing bit could be it having "independentbranches" when it doesn't depend on the pref itself. But we also have IndependentBranchesPatronModifications that doesn't depend on it. So the situation is not really clear. Maybe: AllowStaffChangeLoggedInBranch ? (too long?) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29887 --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #9)
I think the confusing bit could be it having "independentbranches" when it doesn't depend on the pref itself. But we also have IndependentBranchesPatronModifications that doesn't depend on it. So the situation is not really clear.
Maybe: AllowStaffChangeLoggedInBranch ?
(too long?)
The idea with this pref, and IndependentBranchesPatronModifications is that they were once a part of 'IndependentBranches' The goal is to make that preference more granular and allow libraries to set parts of it without others, and keeping them all related with 'IndependentBranches' in the name - possibly it could be a category for the prefs? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29887 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Nick Clemens from comment #10)
(In reply to Katrin Fischer from comment #9)
I think the confusing bit could be it having "independentbranches" when it doesn't depend on the pref itself. But we also have IndependentBranchesPatronModifications that doesn't depend on it. So the situation is not really clear.
Maybe: AllowStaffChangeLoggedInBranch ?
(too long?)
The idea with this pref, and IndependentBranchesPatronModifications is that they were once a part of 'IndependentBranches'
The goal is to make that preference more granular and allow libraries to set parts of it without others, and keeping them all related with 'IndependentBranches' in the name - possibly it could be a category for the prefs?
I like the idea of making it a category and we should maybe note in the description it works independently from Independentbranches? I am ok with the pref name as is. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29887 --- Comment #12 from Lucas Gass <lucas@bywatersolutions.com> ---
I like the idea of making it a category and we should maybe note in the description it works independently from Independentbranches? I am ok with the pref name as is.
Cait, can you explain what is meant by "category"? I don't understand. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29887 --- Comment #13 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 131380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131380&action=edit Bug 29887: (follow-up) Create a system pref category for Independent branches -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29887 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Lucas Gass from comment #13)
Created attachment 131380 [details] [review] Bug 29887: (follow-up) Create a system pref category for Independent branches
Was referring to your comment there :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29887 koha-US bug tracker <bugzilla@koha-us.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla@koha-us.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29887 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30387 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30387 [Bug 30387] IndependentBranches allows users to change libraries when the should not be able to -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29887 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130674|0 |1 is obsolete| | Attachment #130675|0 |1 is obsolete| | Attachment #130676|0 |1 is obsolete| | Attachment #131380|0 |1 is obsolete| | --- Comment #15 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 132353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132353&action=edit Bug 29887: Add system preference IndependentBranchesLoggedInLibrary To test: 1. Have a user who has staff access and circulate privileges but is not a super librarian 2. Apply the patches and run updatedatabase.pl 3. From a superlibrarian account enable IndependentBranches and IndependentBranchesLoggedInLibrary set to Yes. 4. Also turn on the system preference 'CircSidebar' 5. Prepare to login as the non-superlibrarian user. Before logging on notice on auth.tt there is no dropdown allowing you to choose a branch. 6. Log in as the non-superlibrarian. 7. In the top left hand corner notice you are logged in under that users homebranch. 8. Click the dropdown, there is no link for 'Set library'. 9. Go to circulation-home.pl, there is no link for 'Set library' under the heading 'Circulation' 10. With 'CircSidebar' turned on look at the left navigation bar on some of the circulation pages ( Holds queue, Holds to pull, Holds awaiting pickup ). There should be no 'Set library' link on any of these pages. 11. Direct your browser to /cgi-bin/koha/circ/set-library.pl and notice there is no option to change your logged in branch 12. From a superlibrarian account, Turn off IndependentBranches but leave IndependentBranchesLoggedInLibrary set to Yes. 13. Repeat steps 5-11. Nothing should change, the non-superlibrarian should still see no 'Set library' links. 14. From a superlibrarian account, Turn on IndependentBranches and IndependentBranchesLoggedInLibrary set to No 15. Going through steps 5-11 again the non-superlibrarian should see all of the 'Set library' links and be able to successfully switch branches Signed-off-by: Bob Bennhoff <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29887 --- Comment #16 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 132354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132354&action=edit Bug 29887: database update Signed-off-by: Bob Bennhoff <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29887 --- Comment #17 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 132355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132355&action=edit Bug 29887: (follow-up) show all branches to non superlibraians Signed-off-by: Bob Bennhoff <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29887 --- Comment #18 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 132356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132356&action=edit Bug 29887: (follow-up) Create a system pref category for Independent branches -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29887 --- Comment #19 from Lucas Gass <lucas@bywatersolutions.com> --- rebased changes from Bug 30387 on to this patchset -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29887 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This is currently BLOCKED by the depenency requiring sign-off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29887 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30624 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30624 [Bug 30624] Remove IndependentBranchesLoggedInLibrary in favor of a permission -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29887 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29887 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Moving this back to BLOCKED until we have resolved bug 30387. I think both together make a lot of sense and hope to see them moving! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29887 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|BLOCKED |RESOLVED --- Comment #22 from Lucas Gass <lucas@bywatersolutions.com> --- Since we need to move this logic from the system preference IndependentBranchesLoggedInLibrary into a permission, I am resolving this bug and will work on adding the permission in Bug 30624. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29887 Bug 29887 depends on bug 30387, which changed state. Bug 30387 Summary: IndependentBranches allows users to change libraries when they should not be able to https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30387 What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29887 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|30624 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30624 [Bug 30624] Remove IndependentBranchesLoggedInLibrary in favor of a permission -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29887 Rebecca Coert <rcoert@arlingtonva.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org