[Bug 33551] New: Rogue span in Patron restriction types admin page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 Bug ID: 33551 Summary: Rogue span in Patron restriction types admin page Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org To test: 1. Enable PatronRestrictionTypes 2. Go to Administration > Patron restrictions 3. Click 'Edit' next to MANUAL --> The title of the page (in the browser tab) contains <span> </span> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23681 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 [Bug 23681] Make patron restrictions user definable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33077 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 149825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149825&action=edit Bug 33551: Fix HTML title on patron restrictions page To test: 1. Enable PatronRestrictionTypes 2. Go to Administration > Patron restrictions 3. Click 'Edit' next to MANUAL --> The title of the page (in the browser tab) contains <span> </span> 4. Apply patch 5. Look at the title of the page when viewing, editing, and deleteing restrictions to make sure they are correct. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Patch complexity|--- |Trivial patch Assignee|oleonard@myacpl.org |lucas@bywatersolutions.com Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149825|0 |1 is obsolete| | --- Comment #2 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 149836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149836&action=edit Bug 33551: Fix HTML title on patron restrictions page To test: 1. Enable PatronRestrictionTypes 2. Go to Administration > Patron restrictions 3. Click 'Edit' next to MANUAL --> The title of the page (in the browser tab) contains <span> </span> 4. Apply patch 5. Look at the title of the page when viewing, editing, and deleteing restrictions to make sure they are correct. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149836|0 |1 is obsolete| | --- Comment #3 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 149843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149843&action=edit Bug 33551: Fix HTML title on patron restrictions page To test: 1. Enable PatronRestrictionTypes 2. Go to Administration > Patron restrictions 3. Click 'Edit' next to MANUAL --> The title of the page (in the browser tab) contains <span> </span> 4. Apply patch 5. Look at the title of the page when viewing, editing, and deleteing restrictions to make sure they are correct. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32061 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149843|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 149994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149994&action=edit Bug 33551: Fix HTML title on patron restrictions page To test: 1. Enable PatronRestrictionTypes 2. Go to Administration > Patron restrictions 3. Click 'Edit' next to MANUAL --> The title of the page (in the browser tab) contains <span> </span> 4. Apply patch 5. Look at the title of the page when viewing, editing, and deleteing restrictions to make sure they are correct. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 149995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149995&action=edit Bug 33551: (follow-up) Remove spans by using TT filter This allows up to keep the restriction name in the title by removing the span tags with a TT filter. Copied from bug 32061. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The first patch removed not only the spans, but also the restriction type (Manual, etc.) from the title. My follow-up adds them back, but still removes the spans. Maybe we could get another sign-off/QA check? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #6)
The first patch removed not only the spans, but also the restriction type (Manual, etc.) from the title. My follow-up adds them back, but still removes the spans. Maybe we could get another sign-off/QA check?
Probably a good idea. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Rogue span in Patron |Rogue span in patron |restriction types admin |restriction types admin |page |page title -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Lucas Gass from comment #7)
(In reply to Katrin Fischer from comment #6)
The first patch removed not only the spans, but also the restriction type (Manual, etc.) from the title. My follow-up adds them back, but still removes the spans. Maybe we could get another sign-off/QA check?
Probably a good idea.
Lucas, do you want to test? We can sign off each others, if you agree to the change of course. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #9 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- When I try deleting, I have extra quotes. Confirm deletion of restriction 'Manual''') > ... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 150215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150215&action=edit Bug 33551: (follow-up) fix display when deleting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Caroline Cyr La Rose from comment #9)
When I try deleting, I have extra quotes.
Confirm deletion of restriction 'Manual''') > ...
Caroline, I fixed this with a follow-up. Maybe you can try and sign-off since Katrin and I both have patches on this now? I -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149994|0 |1 is obsolete| | --- Comment #12 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 150226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150226&action=edit Bug 33551: Fix HTML title on patron restrictions page To test: 1. Enable PatronRestrictionTypes 2. Go to Administration > Patron restrictions 3. Click 'Edit' next to MANUAL --> The title of the page (in the browser tab) contains <span> </span> 4. Apply patch 5. Look at the title of the page when viewing, editing, and deleteing restrictions to make sure they are correct. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149995|0 |1 is obsolete| | --- Comment #13 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 150227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150227&action=edit Bug 33551: (follow-up) Remove spans by using TT filter This allows up to keep the restriction name in the title by removing the span tags with a TT filter. Copied from bug 32061. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150215|0 |1 is obsolete| | --- Comment #14 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 150228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150228&action=edit Bug 33551: (follow-up) fix display when deleting Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 --- Comment #15 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Thank you both! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33550 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #16 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- the remove span is really not future proof. What if you add an other tag to the include? You need another PROCESS that would return the translated restriction type from a given code. It will be used from the existing include, and from your <title> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #16)
the remove span is really not future proof. What if you add an other tag to the include?
I agree it's not the prettiest fix, but we already use it in another spot. The span in this case was added to aid translations. Maybe we could add a note to the PROCESS for now? I could also file a separate bug for a 'no span' option.
You need another PROCESS that would return the translated restriction type from a given code. It will be used from the existing include, and from your <title>
Sorry, I read it three times, but still not get it :( Can you explain? Happy to file it as a new bug, but it might not be for me right now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 --- Comment #18 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 150565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150565&action=edit [ALTERNATIVE-PATCH] Bug 33551: Remove span from restriction-types.inc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 --- Comment #19 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Why not simply this patch? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Ok, you win - that's a good idea. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150226|0 |1 is obsolete| | Attachment #150227|0 |1 is obsolete| | Attachment #150228|0 |1 is obsolete| | Attachment #150565|0 |1 is obsolete| | --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 150617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150617&action=edit Bug 33551: Remove span from restriction-types.inc Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 150618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150618&action=edit Bug 33551: (QA follow-up) Fix TT filters Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I've tested in the GUI, but also updated the po files to verify that the changes show up as strings and can be translated. Also fixed some TT filters ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 --- Comment #24 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 --- Comment #25 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED --- Comment #26 from Lucas Gass <lucas@bywatersolutions.com> --- Missing dependencies for 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org