[Bug 26985] New: Remove code for "Upcoming events" from codebase as not implemented
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26985 Bug ID: 26985 Summary: Remove code for "Upcoming events" from codebase as not implemented Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org This is a translation find related to the messaging preferences. Will probably need a bit of a better description later. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26985 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26985 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 115113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115113&action=edit Bug 26985: Remove code for "Upcoming events" from codebase as not implemented This patch removes references to an unimplemented feature for "Upcoming events" notices. As far as I can tell the templates are the only files affected. To test, apply the patch and verify that no instances of "Upcoming events" or "Upcoming_events" are found in the codebase. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26985 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26985 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115113|0 |1 is obsolete| | --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 115119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115119&action=edit Bug 26985: Remove code for "Upcoming events" from codebase as not implemented This patch removes references to an unimplemented feature for "Upcoming events" notices. As far as I can tell the templates are the only files affected. To test, apply the patch and verify that no instances of "Upcoming events" or "Upcoming_events" are found in the codebase. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26985 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- applied patch and greped for instances of "Upcoming events" or "Upcoming_events", outside of po files I found none -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26985 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26985 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115119|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 115224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115224&action=edit Bug 26985: Remove code for "Upcoming events" from codebase as not implemented This patch removes references to an unimplemented feature for "Upcoming events" notices. As far as I can tell the templates are the only files affected. To test, apply the patch and verify that no instances of "Upcoming events" or "Upcoming_events" are found in the codebase. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26985 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I recently stumbled on this code too and really glad to see it gone! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26985 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |2434 CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- commit ff62346583d395c83ec05eb183ab55e27786504e bug 2434 remove upcoming events for all languages this patch removed the upcoming events messaging option and the upcoming event message from the system for all languages since it was never implemented and confuses librarians and patrons alike Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2434 [Bug 2434] Remove unimplemented upcoming events message -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26985 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |5889 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- And added back by commit 6282f652b2897ded2319a4f1fce97cac7f45ca62 Bug 5889: Messages name in english for notifications on public interface. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5889 [Bug 5889] Allow message names to be translatable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26985 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26985 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26985 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- I prefer not backport to avoid translation work on 20.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26985 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org