https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27437 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27437 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27437 Mazen Khallaf <mazen.i.khallaf@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115181|0 |1 is obsolete| | --- Comment #2 from Mazen Khallaf <mazen.i.khallaf@gmail.com> --- Created attachment 115251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115251&action=edit Bug 27437: Improve hint labels on library creation form This patch makes a few minor template changes to the form for creating and editing libraries: - <br /><span class="hint"> changed to <div class="hint"> - References to system preferences are linked directly to that preference if the user has permission. - The MARC organization code label has been corrected so that it works now. To test, apply the patch and go to Administration -> Libraries -> New library. - Confirm that the hints for Ill staff email, Reply-to, Return-path, and MARC organization code look correct, including aligning with the input field above them. - Confirm that clicking the "MARC organization code" label moves focus to the correct field. - View the page as a user who both does and does not have permission to access system preferences, confirming that system preferences are linked correctly if the user has the correct permission. Signed-off-by: Mazen Khallaf <mazen.i.khallaf@gamil.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27437 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115251|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 115263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115263&action=edit Bug 27437: Improve hint labels on library creation form This patch makes a few minor template changes to the form for creating and editing libraries: - <br /><span class="hint"> changed to <div class="hint"> - References to system preferences are linked directly to that preference if the user has permission. - The MARC organization code label has been corrected so that it works now. To test, apply the patch and go to Administration -> Libraries -> New library. - Confirm that the hints for Ill staff email, Reply-to, Return-path, and MARC organization code look correct, including aligning with the input field above them. - Confirm that clicking the "MARC organization code" label moves focus to the correct field. - View the page as a user who both does and does not have permission to access system preferences, confirming that system preferences are linked correctly if the user has the correct permission. Signed-off-by: Mazen Khallaf <mazen.i.khallaf@gamil.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27437 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115263|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 115415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115415&action=edit Bug 27437: Improve hint labels on library creation form This patch makes a few minor template changes to the form for creating and editing libraries: - <br /><span class="hint"> changed to <div class="hint"> - References to system preferences are linked directly to that preference if the user has permission. - The MARC organization code label has been corrected so that it works now. To test, apply the patch and go to Administration -> Libraries -> New library. - Confirm that the hints for Ill staff email, Reply-to, Return-path, and MARC organization code look correct, including aligning with the input field above them. - Confirm that clicking the "MARC organization code" label moves focus to the correct field. - View the page as a user who both does and does not have permission to access system preferences, confirming that system preferences are linked correctly if the user has the correct permission. Signed-off-by: Mazen Khallaf <mazen.i.khallaf@gamil.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> JD Amended patch: Add missing space to correctly align input with label -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27437 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27437 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 20.11.x -- You are receiving this mail because: You are watching all bug changes.