[Bug 21188] New: t/db_dependent/Circulation/issue.t is failing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21188 Bug ID: 21188 Summary: t/db_dependent/Circulation/issue.t is failing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Stems from bug 20660 The issue seems to be that $return_date is a string and not a DateTime object - when we call _debar_user_on_return we are expecting a DateTime object -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21188 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Depends on| |20660 Status|NEW |Needs Signoff Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20660 [Bug 20660] AddReturn should use return date override for debarments -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21188 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 77622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77622&action=edit Bug 21188: Convert return_date to a DateTime object -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21188 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Assignee|chris@bigballofwax.co.nz |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21188 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Nick Clemens from comment #1)
Created attachment 77622 [details] [review] Bug 21188: Convert return_date to a DateTime object
To test: 1 - Checkout an item 2 - Make it over due: update issues set date_due='1999-01-01'; 3 - Go to 'Circulation->Check-in' 4 - Specify a return date 5 - Check in the item 6 - Internal server error 7 - Apply patch 8 - Repeat 1-5 9 - Success! 10 - prove t/db_dependent/Circulation/issue.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21188 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21188 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77622|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 77627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77627&action=edit Bug 21188: Convert return_date to a DateTime object Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21188 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Minor fix, moving to PQA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21188 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21188 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize@ptfs-europe | |.com --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x for 18.05.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21188 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21188 Bug 21188 depends on bug 20660, which changed state. Bug 20660 Summary: AddReturn should use return date override for debarments https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20660 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org