[Bug 26262] New: Paging on course reserves tables in OPAC is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26262 Bug ID: 26262 Summary: Paging on course reserves tables in OPAC is broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org The styling on the paging options for the course reserves tables in OPAC is broken. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26262 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|NEW |ASSIGNED Depends on| |25287 Assignee|oleonard@myacpl.org |tomascohen@gmail.com --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Caused by bug 25287. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25287 [Bug 25287] Add columns_settings support to API datatables wrapper -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26262 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #1)
Caused by bug 25287.
How is that? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26262 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I don't know, git bisect. Certainly the changes to datatables.js -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26262 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Ok, I've checked and we don't do pagination in the OPAC, neither on course reserves or items/holds. So this is purely styling issue (i.e. we added the elements but we shouldn't have). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26262 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 109189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109189&action=edit Bug 26262: Remove wrong dom setting in course reserves (OPAC) The current setting required pagination to be displayed. This was hidden probably as a side effect of styling settings. But the docs are clear on the fact that p and l are intended for displaying pagination controls and table rows lenght information [1] As the course reserves datatable is not paginated, this needs to be fixed properly by removing those controls in the configuration. This patch does so. To test: 1. Have some course reserves 2. See them in the OPAC => FAIL: Some funky, misaligned pagination artifacts are displayed 3. Apply this patch and reload => SUCCESS: Things are back to normal! 4. Sign off :-D [1] https://datatables.net/examples/basic_init/dom.html Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26262 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26262 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_11_target -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26262 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26262 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109189|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 109362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109362&action=edit Bug 26262: Remove wrong dom setting in course reserves (OPAC) The current setting required pagination to be displayed. This was hidden probably as a side effect of styling settings. But the docs are clear on the fact that p and l are intended for displaying pagination controls and table rows lenght information [1] As the course reserves datatable is not paginated, this needs to be fixed properly by removing those controls in the configuration. This patch does so. To test: 1. Have some course reserves 2. See them in the OPAC => FAIL: Some funky, misaligned pagination artifacts are displayed 3. Apply this patch and reload => SUCCESS: Things are back to normal! 4. Sign off :-D [1] https://datatables.net/examples/basic_init/dom.html Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26262 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 109363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109363&action=edit Bug 26262: (follow-up) Fix course details page, default configuration Bug 25287 changed the default DataTable configuration in the OPAC so that tables are paginated by default. This is inconsistent with the way we currently use DataTables in the OPAC, and the change was probably unintentional. This patch returns the default pagination configuration to what it was before: Off. The patch also updates opac-course-details.tt with the same DOM configuration as opac-course-reserves.tt. To test, apply the patch and view the list of course reserves and the list of titles attached to a course. In both cases there should be no pagination controls, and the tables should show all results. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26262 Alexis Ripetti <alexis.ripetti@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26262 Alexis Ripetti <alexis.ripetti@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109363|0 |1 is obsolete| | --- Comment #8 from Alexis Ripetti <alexis.ripetti@inLibro.com> --- Created attachment 109673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109673&action=edit Bug 26262: (follow-up) Fix course details page, default configuration Bug 25287 changed the default DataTable configuration in the OPAC so that tables are paginated by default. This is inconsistent with the way we currently use DataTables in the OPAC, and the change was probably unintentional. This patch returns the default pagination configuration to what it was before: Off. The patch also updates opac-course-details.tt with the same DOM configuration as opac-course-reserves.tt. To test, apply the patch and view the list of course reserves and the list of titles attached to a course. In both cases there should be no pagination controls, and the tables should show all results. Signed-off-by: Alexis Ripetti <alexis.ripetti@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26262 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109362|0 |1 is obsolete| | Attachment #109673|0 |1 is obsolete| | --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 109831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109831&action=edit Bug 26262: Remove wrong dom setting in course reserves (OPAC) The current setting required pagination to be displayed. This was hidden probably as a side effect of styling settings. But the docs are clear on the fact that p and l are intended for displaying pagination controls and table rows lenght information [1] As the course reserves datatable is not paginated, this needs to be fixed properly by removing those controls in the configuration. This patch does so. To test: 1. Have some course reserves 2. See them in the OPAC => FAIL: Some funky, misaligned pagination artifacts are displayed 3. Apply this patch and reload => SUCCESS: Things are back to normal! 4. Sign off :-D [1] https://datatables.net/examples/basic_init/dom.html Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26262 --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 109832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109832&action=edit Bug 26262: (follow-up) Fix course details page, default configuration Bug 25287 changed the default DataTable configuration in the OPAC so that tables are paginated by default. This is inconsistent with the way we currently use DataTables in the OPAC, and the change was probably unintentional. This patch returns the default pagination configuration to what it was before: Off. The patch also updates opac-course-details.tt with the same DOM configuration as opac-course-reserves.tt. To test, apply the patch and view the list of course reserves and the list of titles attached to a course. In both cases there should be no pagination controls, and the tables should show all results. Signed-off-by: Alexis Ripetti <alexis.ripetti@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26262 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25775 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25775 [Bug 25775] Add DataTables controls to user's checkouts table in OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26262 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26262 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109831|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 109989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109989&action=edit Bug 26262: Remove wrong dom setting in course reserves (OPAC) The current setting required pagination to be displayed. This was hidden probably as a side effect of styling settings. But the docs are clear on the fact that p and l are intended for displaying pagination controls and table rows lenght information [1] As the course reserves datatable is not paginated, this needs to be fixed properly by removing those controls in the configuration. This patch does so. To test: 1. Have some course reserves 2. See them in the OPAC => FAIL: Some funky, misaligned pagination artifacts are displayed 3. Apply this patch and reload => SUCCESS: Things are back to normal! 4. Sign off :-D [1] https://datatables.net/examples/basic_init/dom.html Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26262 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109832|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 109990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109990&action=edit Bug 26262: (follow-up) Fix course details page, default configuration Bug 25287 changed the default DataTable configuration in the OPAC so that tables are paginated by default. This is inconsistent with the way we currently use DataTables in the OPAC, and the change was probably unintentional. This patch returns the default pagination configuration to what it was before: Off. The patch also updates opac-course-details.tt with the same DOM configuration as opac-course-reserves.tt. To test, apply the patch and view the list of course reserves and the list of titles attached to a course. In both cases there should be no pagination controls, and the tables should show all results. Signed-off-by: Alexis Ripetti <alexis.ripetti@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26262 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26262 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26262 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_11_target | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26262 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #14 from Lucas Gass <lucas@bywatersolutions.com> --- missing dependencies for 20.05.x, no backport -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org