[Bug 26301] New: Self-checkout blocks renew for overdues even when OverduesBlockRenewing allows it in opac-user.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26301 Bug ID: 26301 Summary: Self-checkout blocks renew for overdues even when OverduesBlockRenewing allows it in opac-user.pl Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Self checkout Assignee: koha-bugs@lists.koha-community.org Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org You can renew overdues in opac-user.pl but you can't with the self-checkout. This doesn't make sense. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26301 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |dcook@prosentient.com.au |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26301 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18349 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26301 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- But "./opac/sco/sco-main.pl" is shockingly bad. It's running "CanBookBeIssued" instead of "CanBookBeRenewed" which means all the wrong rules are being applied for a renewal... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26301 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18251 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26301 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26301 --- Comment #2 from David Cook <dcook@prosentient.com.au> --- Created attachment 109137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109137&action=edit Bug 26301: Use CanBookBeRenewed when renewing via self-checkout Currently, if you have OverduesBlockCirc set to "Ask for confirmation" and OverduesBlockRenewing set to "allow renewing", you get caught in a loop where you can never renew an overdue material. This patch uses CanBookBeRenewed for renewals, rather than CanBookBeIssued, which means the correct rules are applied to the correct scenario. To test: a. Set OverduesBlockCirc to "Ask for confirmation" b. Ensure "OverduesBlockRenewing" set to "allow renewing" 0. Apply the patch 1. Checkin item barcode 3999900000001 2. Go to http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51 3. Checkout item barcode 3999900000001 to 1 year ago 4. Go to http://localhost:8080/cgi-bin/koha/sco/sco-main.pl 5. Login as the "koha" user 6. Click on "Renew item" 7. Note that the item is renewed 8. Checkin item barcode 3999900000001 9. Go to http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51 10. Checkout item barcode 3999900000001 to 1 year ago 11. Go to http://localhost:8080/cgi-bin/koha/sco/sco-main.pl 12. Login as the "koha" user 13. Type "3999900000001" into the box under "Scan a new item or enter its barcode" 14. Click "Submit" 15. Note the system says the item is already checked out and it prompts you to click "Renew item" in this screen 16. Click "Renew item" 17. Note the system says "Item renewed" near the top of the screen, and the "Due" date near the bottom of the screen is more recent than the original due date 18. Checkin item barcode 3999900000001 19. Go to http://localhost:8080/cgi-bin/koha/sco/sco-main.pl 20. Login as the "koha" user 21. Type "3999900000001" into the box under "Scan a new item or enter its barcode" 22. Click "Submit" 23. Note the system says "Item checked out" and the item appears in the checkouts at the bottom of the screen -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26301 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26301 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109137|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 109791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109791&action=edit Bug 26301: Use CanBookBeRenewed when renewing via self-checkout Currently, if you have OverduesBlockCirc set to "Ask for confirmation" and OverduesBlockRenewing set to "allow renewing", you get caught in a loop where you can never renew an overdue material. This patch uses CanBookBeRenewed for renewals, rather than CanBookBeIssued, which means the correct rules are applied to the correct scenario. To test: a. Set OverduesBlockCirc to "Ask for confirmation" b. Ensure "OverduesBlockRenewing" set to "allow renewing" 0. Apply the patch 1. Checkin item barcode 3999900000001 2. Go to http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51 3. Checkout item barcode 3999900000001 to 1 year ago 4. Go to http://localhost:8080/cgi-bin/koha/sco/sco-main.pl 5. Login as the "koha" user 6. Click on "Renew item" 7. Note that the item is renewed 8. Checkin item barcode 3999900000001 9. Go to http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51 10. Checkout item barcode 3999900000001 to 1 year ago 11. Go to http://localhost:8080/cgi-bin/koha/sco/sco-main.pl 12. Login as the "koha" user 13. Type "3999900000001" into the box under "Scan a new item or enter its barcode" 14. Click "Submit" 15. Note the system says the item is already checked out and it prompts you to click "Renew item" in this screen 16. Click "Renew item" 17. Note the system says "Item renewed" near the top of the screen, and the "Due" date near the bottom of the screen is more recent than the original due date 18. Checkin item barcode 3999900000001 19. Go to http://localhost:8080/cgi-bin/koha/sco/sco-main.pl 20. Login as the "koha" user 21. Type "3999900000001" into the box under "Scan a new item or enter its barcode" 22. Click "Submit" 23. Note the system says "Item checked out" and the item appears in the checkouts at the bottom of the screen Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26301 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Good catch, fix works as expected.. Signing off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26301 --- Comment #5 from David Cook <dcook@prosentient.com.au> --- (In reply to Martin Renvoize from comment #4)
Good catch, fix works as expected.. Signing off
Thanks, Martin. The credit goes to one of my very diligent librarians! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26301 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26301 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109791|0 |1 is obsolete| | --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 109941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109941&action=edit Bug 26301: Use CanBookBeRenewed when renewing via self-checkout Currently, if you have OverduesBlockCirc set to "Ask for confirmation" and OverduesBlockRenewing set to "allow renewing", you get caught in a loop where you can never renew an overdue material. This patch uses CanBookBeRenewed for renewals, rather than CanBookBeIssued, which means the correct rules are applied to the correct scenario. To test: a. Set OverduesBlockCirc to "Ask for confirmation" b. Ensure "OverduesBlockRenewing" set to "allow renewing" 0. Apply the patch 1. Checkin item barcode 3999900000001 2. Go to http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51 3. Checkout item barcode 3999900000001 to 1 year ago 4. Go to http://localhost:8080/cgi-bin/koha/sco/sco-main.pl 5. Login as the "koha" user 6. Click on "Renew item" 7. Note that the item is renewed 8. Checkin item barcode 3999900000001 9. Go to http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51 10. Checkout item barcode 3999900000001 to 1 year ago 11. Go to http://localhost:8080/cgi-bin/koha/sco/sco-main.pl 12. Login as the "koha" user 13. Type "3999900000001" into the box under "Scan a new item or enter its barcode" 14. Click "Submit" 15. Note the system says the item is already checked out and it prompts you to click "Renew item" in this screen 16. Click "Renew item" 17. Note the system says "Item renewed" near the top of the screen, and the "Due" date near the bottom of the screen is more recent than the original due date 18. Checkin item barcode 3999900000001 19. Go to http://localhost:8080/cgi-bin/koha/sco/sco-main.pl 20. Login as the "koha" user 21. Type "3999900000001" into the box under "Scan a new item or enter its barcode" 22. Click "Submit" 23. Note the system says "Item checked out" and the item appears in the checkouts at the bottom of the screen Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26301 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26301 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26301 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- doesn't apply clean to 20.05.x, if needed please rebase -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org