[Bug 42263] New: Missing import of JSON::encode_json in Koha::File::Transport::SFTP [25.11.x]
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42263 Bug ID: 42263 Summary: Missing import of JSON::encode_json in Koha::File::Transport::SFTP [25.11.x] Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Fixed in main by bug 40811 - we need that fix here too -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42263 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42263 --- Comment #1 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 196723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196723&action=edit Bug 42263: Missing import and scalar context Patch from commit b83d34d -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42263 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@openfifth.c |ity.org |o.uk --- Comment #2 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Pinging martin to add his tests from 40811 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42263 --- Comment #3 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 196827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196827&action=edit Bug 42263: Backport tests and fix from bug 40811: (follow-up) Fix list context bug and add comprehensive tests Patch from commit f6cb552 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42263 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|Main |25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42263 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42263 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196723|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42263 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196827|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42263 --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 197760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197760&action=edit Bug 42263: Missing import and scalar context Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42263 --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 197761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197761&action=edit Bug 42263: Backport tests and fix from bug 40811: (follow-up) Fix list context bug and add comprehensive tests Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42263 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #6 from David Nind <david@davidnind.com> --- Hop this is sufficient for testing. Testing notes (using KTD): 1. Start up with Koha 25.11 . Koha: git checkout 25.11.x . KTD: edit .env file and change IMAGE=main to IMAGE=25.11 2. Apply the patch - I had to use the full path in the 25.11 image: /kohadevbox/perl-git-bz/bin/git-bz apply 42263 3. yarn api:bundle (not sure if this is required) 4. Restart everything: restart_all 5. The tests pass: prove t/db_dependent/Koha/File/Transports.t prove t/db_dependent/Koha/File/Transport/SFTP.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42263 --- Comment #7 from David Nind <david@davidnind.com> --- (In reply to David Nind from comment #6) ..
. KTD: edit .env file and change IMAGE=main to IMAGE=25.11 ..
Should be KOHA_IMAGE=25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42263 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org