https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42263 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42263 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@openfifth.c |ity.org |o.uk --- Comment #2 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Pinging martin to add his tests from 40811 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42263 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|Main |25.11 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42263 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196723|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42263 --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 197760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197760&action=edit Bug 42263: Missing import and scalar context Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42263 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #6 from David Nind <david@davidnind.com> --- Hop this is sufficient for testing. Testing notes (using KTD): 1. Start up with Koha 25.11 . Koha: git checkout 25.11.x . KTD: edit .env file and change IMAGE=main to IMAGE=25.11 2. Apply the patch - I had to use the full path in the 25.11 image: /kohadevbox/perl-git-bz/bin/git-bz apply 42263 3. yarn api:bundle (not sure if this is required) 4. Restart everything: restart_all 5. The tests pass: prove t/db_dependent/Koha/File/Transports.t prove t/db_dependent/Koha/File/Transport/SFTP.t -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42263 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42263 --- Comment #8 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 208967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208967&action=edit Bug 42263: Missing import and scalar context Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42263 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #10 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Rebased on current 25.11.x (ecadc3e65a2, 25.11.09). Notes: - Trivial import conflicts with the 25.11.x changes to Koha::File::Transport::SFTP (Fcntl) and its test (Net::SFTP::Foreign::Attributes): both imports kept. - Test fix in the backport: t/db_dependent/Koha/File/Transport/FTP.t gains a subtest, so its plan has to go from 7 to 8 (the 7 on 25.11.x already counts Test::NoWarnings); without it the test dies with 'planned 7 tests but ran 8'. - The second patch had a placeholder author (John Doe <you@example.com>); it is now authored by Martin Renvoize, as is the original commit on main (Bug 40811 follow-up). - Tidied the use JSON line (perltidy aligns it with the Fcntl import). Tested on a 25.11 KTD: t/db_dependent/Koha/File/Transports.t, Transport/SFTP.t and Transport/FTP.t pass, and the new tests fail without the source changes. koha-qa passes. David's Signed-off-by lines are carried over on both patches. Restoring status to Signed Off. -- You are receiving this mail because: You are watching all bug changes.