[Bug 29566] New: Convert bundle contents modal to a notice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29566 Bug ID: 29566 Summary: Convert bundle contents modal to a notice Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com We add a simple way to display and print a contents list for bundle items in bug 28854. It would be useful to allow librarians to customise how this list displays and prints; We can achieve that by converting the contents to a notice list other print slips. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29566 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29566 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28854 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29566 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127983&action=edit Bug 29566: Add API route for fetching item slip content This patch adds an API endpoint to allow the generation and fetching of an item print slip. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29566 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127984&action=edit Bug 29566: Update modal to use slip api -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29566 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127985&action=edit Bug 29566: Add sample notices -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29566 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29566 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127983|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 135038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135038&action=edit Bug 29566: Add API route for fetching item slip content This patch adds an API endpoint to allow the generation and fetching of an item print slip. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29566 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127984|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 135039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135039&action=edit Bug 29566: Update modal to use slip api -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29566 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127985|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 135040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135040&action=edit Bug 29566: Add sample notices -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29566 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135038|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137511&action=edit Bug 29566: Add API route for fetching item slip content This patch adds an API endpoint to allow the generation and fetching of an item print slip. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29566 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135039|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137512&action=edit Bug 29566: Update modal to use slip api -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29566 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135040|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137513&action=edit Bug 29566: Add sample notices -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29566 Bug 29566 depends on bug 28854, which changed state. Bug 28854 Summary: Add ability to create bundles of items for circulation https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29566 Bug 29566 depends on bug 28854, which changed state. Bug 28854 Summary: Add ability to create bundles of items for circulation https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |Needs documenting Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29566 Bug 29566 depends on bug 28854, which changed state. Bug 28854 Summary: Add ability to create bundles of items for circulation https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29566 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED CC| |Laura.escamilla@bywatersolu | |tions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29566 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Patches, but still ASSIGNED? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29566 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29566 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette@bywatersolutions.co | |m Status|Needs Signoff |Patch doesn't apply --- Comment #11 from Lisette Scheer <lisette@bywatersolutions.com> --- Applying: Bug 29566: Add API route for fetching item slip content Using index info to reconstruct a base tree... M Koha/REST/V1/Items.pm M api/v1/swagger/paths/items.yaml M api/v1/swagger/swagger.yaml Falling back to patching base and 3-way merge... Auto-merging api/v1/swagger/swagger.yaml CONFLICT (content): Merge conflict in api/v1/swagger/swagger.yaml Auto-merging api/v1/swagger/paths/items.yaml CONFLICT (content): Merge conflict in api/v1/swagger/paths/items.yaml Auto-merging Koha/REST/V1/Items.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29566 --- Comment #12 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Whilst this was a nice, asked for addition, waiting 3 years for testing.. and given the re-base isn't especially trivial I don't see this as a priority. If someone wants to commit to testing and give a time window for their interest I may schedule it in. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29566 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137511|0 |1 is obsolete| | Attachment #137512|0 |1 is obsolete| | Attachment #137513|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29566 --- Comment #13 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 208970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208970&action=edit Bug 29566: Add API route for fetching item slip content This patch adds an API endpoint to allow the generation and fetching of an item print slip. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29566 --- Comment #14 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 208971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208971&action=edit Bug 29566: Update modal to use slip api -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29566 --- Comment #15 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 208972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208972&action=edit Bug 29566: Add sample notices -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29566 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #16 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Rebased on current main. The series was last rebased in 2022, so this was more than a mechanical rebase: - API: the OpenAPI changes had to be re-added in the current style (quoted $refs, documented 404, new slip definition and path entry) and the print_slip controller now follows the idioms of the neighbouring Items.pm methods ($c->param, render_resource_not_found; unused $lang dropped). - UI: the modal markup is now Bootstrap 5 (data-bs-*), and printing relies on the existing js/modal_printer.js rather than duplicating the print handlers in the new bundle_contents_modal.js. - Notice: the atomicupdate now follows the current db_rev conventions (say_success/say_failure), the table style attribute is fixed (width:100%), and the sample notice and the atomicupdate use the same name and title. Tested in KTD: applied the atomicupdate, yarn build + restart_all, created a bundle with two items, and GET /api/v1/items/{id}/print_slips/BUNDLE returns the rendered slip (200), 404 for an unknown item or slip, 401 unauthenticated. In the staff client, checking in the bundle, scanning its contents and clicking 'View contents list' on the 'Bundle verified' message opens the modal with the title and contents from the slip; the Print button is still there. koha-qa passes. Not included: REST tests for the new route (t/db_dependent/api/v1/items.t). Happy to add them as a follow-up if useful. Restoring status to Needs Signoff. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29566 --- Comment #17 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 208973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208973&action=edit Bug 29566: (follow-up) Add tests for the item print_slips route Cover GET /api/v1/items/{item_id}/print_slips/{slip_id}: - 401 when unauthenticated - 403 without the catalogue permission - 200 with the generated slip (slip_id, title, content and timestamp), using a slip that loops over the bundled items of the item - 404 for an unknown slip (and the warning C4::Letters raises for it) - 404 for an unknown item To test: 1. Apply the patches 2. Run $ prove t/db_dependent/api/v1/items.t 3. Confirm the tests pass Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org